synsbasen_api 1.0.13 → 1.0.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 565b3bfae169b625688bcb1bb70d1fc3c68abb88d2226b0e796139a25adab9bc
-  data.tar.gz: fdb44552e927ff505dca9d8a1778ee84fb99ea559d1362518176ebcdb913f1ed
+  metadata.gz: 44d24b52fdfe7d02d6ad3b0522c1ee9585ce00a1b492394e3935efc155a448a8
+  data.tar.gz: 2228cdd496ca320ac3ff47c6c75241027690dbd0b6e51afe880a5a20ea6b6f1f
 SHA512:
-  metadata.gz: 794d7cc6f66ddb9320e706810fd7aa6fcc262b81d1599ec7b92e8f265ea835e08568609ca23b5ae2be000a711a0ad07faadce0cdebd2b55ccf6289a526e48efb
-  data.tar.gz: e701b46e2c20799a2fd53a4be1baadf650179b5ca5ee4d01377aebe8a39c049a287d688595100e4bca0653edafb0bcfef4d868a94b0643edc44a45e29eb14066
+  metadata.gz: 302740a2be98c79359fc6f66edd36e6cb050174213c2ea18df4ccc5f9d76554aefa853e3794fb66f7fffdd037a7af49d3b542471d8b8c6c5316cc2b7800b8979
+  data.tar.gz: 691e0059b612ba71835f92d03ae9a88476110b395fe452c0c11c1b8015a6ceb460ef2daeccae2b0b9e43a59be75c46862c3ac60d96c7595ea5931868890d1638

data/lib/synsbasen_api/client.rb

@@ -22,7 +22,7 @@ module SynsbasenApi
       def get(path, params: {}, expand: [])
         request = build_request(path, method: Net::HTTP::Get, params: params, expand: expand)
 
-        response = connection.request(request)
+        response = perform_request(request)
 
         raise_errors(response)
 
@@ -42,7 +42,7 @@ module SynsbasenApi
       def post(path, params: {}, body: {}, expand: [])
         request = build_request(path, method: Net::HTTP::Post, params: params, body: body, expand: expand)
 
-        response = connection.request(request)
+        response = perform_request(request)
 
         raise_errors(response)
 
@@ -61,7 +61,7 @@ module SynsbasenApi
       def delete(path, params = {}, body = {})
         request = build_request(path, method: Net::HTTP::Delete, params: params, body: body)
 
-        response = connection.request(request)
+        response = perform_request(request)
 
         raise_errors(response)
 
@@ -79,6 +79,7 @@ module SynsbasenApi
         uri = URI.parse(SynsbasenApi.config[:base_url] || DEFAULT_BASE_URL)
         http = Net::HTTP.new(uri.host, uri.port)
         http.use_ssl = uri.scheme == "https"
+        http.max_retries = 0 # Consumers own the retry policy.
         http
       end
 
@@ -106,29 +107,44 @@ module SynsbasenApi
         request
       end
 
+      # Sends a request and translates transport-level timeouts into a public gem error.
+      #
+      # @param request [Net::HTTPRequest] The request to send.
+      # @return [Net::HTTPResponse] The response returned by the API.
+      # @raise [RequestTimeoutError] Raised when the request times out before a response is received.
+      def perform_request(request)
+        connection.request(request)
+      rescue Net::OpenTimeout, Net::ReadTimeout, Net::WriteTimeout => e
+        raise RequestTimeoutError.new(e.message)
+      end
+
       # Raises specific errors based on the type of Net::HTTP error encountered.
       #
-      # @param e [Exception] The exception to handle.
-      # @raise [ClientError, ServerError, BadRequestError, UnauthorizedError, ForbiddenError, NotFoundError, ConflictError, UnprocessableEntityError, InternalServerError] Raised for errors.
+      # @param response [Net::HTTPResponse] The response to handle.
+      # @raise [ClientError, ServerError, BadRequestError, UnauthorizedError, ForbiddenError, NotFoundError, ConflictError, UnprocessableEntityError, RequestTimeoutError, GatewayTimeoutError, InternalServerError] Raised for errors.
       def raise_errors(response)
         return unless response.is_a?(Net::HTTPClientError) || response.is_a?(Net::HTTPServerError)
 
-        case response
-        when Net::HTTPUnauthorized
-          raise ClientError.new(response.message, response.code, {})
-        else
-          error_class_name = "#{response.message.split.map(&:capitalize).join}Error"
-
-          error_class =
-            if SynsbasenApi.const_defined?(error_class_name, false) &&
-               SynsbasenApi.const_get(error_class_name).is_a?(Class)
-              SynsbasenApi.const_get(error_class_name)
-            else
-              response.is_a?(Net::HTTPClientError) ? ClientError : ServerError
-            end
+        error_class = {
+          "400" => BadRequestError,
+          "401" => UnauthorizedError,
+          "403" => ForbiddenError,
+          "404" => NotFoundError,
+          "408" => RequestTimeoutError,
+          "409" => ConflictError,
+          "422" => UnprocessableEntityError,
+          "500" => InternalServerError,
+          "504" => GatewayTimeoutError
+        }[response.code] || (response.is_a?(Net::HTTPClientError) ? ClientError : ServerError)
+
+        raise error_class.new(response.message, response.code, parse_error_body(response.body))
+      end
 
-          raise error_class.new(response.message, response.code, parse_json(response.body))
-        end
+      # An HTML/text error page must not hide the HTTP error behind a JSON parser error.
+      def parse_error_body(body)
+        parse_json(body)
+      rescue JSON::ParserError
+        {}
       end
 
       # Calls the after_request callback if configured in the SynsbasenApi.
@@ -146,7 +162,7 @@ module SynsbasenApi
       # @param data [String] The JSON string to parse.
       # @return [Hash] The parsed JSON string as a hash with symbolized keys.
       def parse_json(data)
-        data ||= "{}"
+        return {} if data.nil? || data.empty?
 
         deep_symbolize_keys(JSON.parse(data))
       end

data/lib/synsbasen_api/error.rb

@@ -30,6 +30,13 @@ module SynsbasenApi
   # The `ServerError` class represents errors that occur on the server side (5xx status codes).
   class ServerError < Error; end
 
+  # The `RequestTimeoutError` class represents requests that did not complete within the
+  # configured timeout, including HTTP 408 responses and transport-level timeouts.
+  class RequestTimeoutError < Error; end
+
+  # The `GatewayTimeoutError` class represents an HTTP 504 response from the API.
+  class GatewayTimeoutError < RequestTimeoutError; end
+
   %w[BadRequestError UnauthorizedError ForbiddenError NotFoundError
      ConflictError UnprocessableEntityError].each do |error|
     klass = Class.new(ClientError)

data/lib/synsbasen_api/version.rb

@@ -2,5 +2,5 @@
 
 module SynsbasenApi
   # The `VERSION` module specifies the version of the SynsbasenApi gem.
-  VERSION = "1.0.13"
+  VERSION = "1.0.15"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: synsbasen_api
 version: !ruby/object:Gem::Version
-  version: 1.0.13
+  version: 1.0.15
 platform: ruby
 authors:
 - Jimmy Poulsen
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-09-30 00:00:00.000000000 Z
+date: 2026-09-24 00:00:00.000000000 Z
 dependencies: []
 description: Synsbasen API is the easiest way to get access to the Danish vehicle
   registry. See https://api.synsbasen.dk for details.