synced 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f3293144a530b0b41b214912ec147152b207e4b2
-  data.tar.gz: a016b6c1cb3628884c5c465a2c84e9f167c83a36
+  metadata.gz: 4e12f68714c45cb3257ac0116c7412e34879bff8
+  data.tar.gz: 07828256826de59fcb3e8e0c8da913270bab003d
 SHA512:
-  metadata.gz: 9b42ca3a24e7d58cfd666a01de3c8c22e28bd67db53f74649a77c678e6212b5e689977d3158a96d202bc3167e0dd41d180ea858e01c9ea29639fd5e95ef2e9e4
-  data.tar.gz: e9da5291a6c4fbbb7a2e52078b6a4817e6b6cd631eb6acbaeefa519ace7db4ebc295af66235065561ac48c0766c8d5cb8a10b6144a1b81c565196b89d0338eba
+  metadata.gz: aad5845c643c3a8485db188837bf7f43307513c8cbf3092b0e190a4759ffb00dd879ba74cfa0f77798128c0b81ab7710db268eec8e14fed782d51d4389b53195
+  data.tar.gz: f000eb92f1ccb6d09b10a10995571240f8619612206129305faa8a7283809169ed02a656cf9a50e775fecb93e847a8c35e4cfd2f64ca98992b1f94c8942f716a

data/README.md

@@ -226,8 +226,29 @@ By default `Synced::Strategies::SyncedAllAtTimestampStrategy` strategy is used,
 overhead on updating the timestamps on all the records.
 
 There is also a `Synced::Strategies::SyncedPerScopeTimestampStrategy`, that uses another model,
-`Synced::Timestamp`, to store the synchronization timestamps. Migration can be copied from the synced dummy app
-`spec/dummy/db/migrate/20160126082137_create_synced_timestamps.rb`.
+`Synced::Timestamp`, to store the synchronization timestamps. You can generate the  migration the following way:
+
+```
+rails generate migration create_synced_timestamps
+```
+
+and copy the body from here:
+
+```
+class CreateSyncedTimestamps < ActiveRecord::Migration
+  def change
+    create_table :synced_timestamps do |t|
+      t.belongs_to :parent_scope, polymorphic: true
+      t.string :model_class, null: false
+      t.datetime :synced_at, null: false
+    end
+
+    add_index :synced_timestamps, [:parent_scope_id, :parent_scope_type, :synced_at], name: 'synced_timestamps_max_index', order: { synced_at: 'DESC' }
+  end
+end
+```
+
+
 This strategy is added to fix the problems with massive updates on `synced_all_at`. Proper cleanup of timestamp records
 is needed once in a while with `Synced::Timestamp.cleanup` (cleans records older than 1 week).
 

data/lib/synced/strategies/synced_per_scope_timestamp_strategy.rb

@@ -5,21 +5,36 @@ module Synced
     # This is a strategy for UpdatedSince defining how to store and update synced timestamps.
     # It uses a separate timestamps table to track when different models were synced in specific scopes.
     class SyncedPerScopeTimestampStrategy
-      def initialize(scope:, model_class:, **_options)
+      attr_reader :scope, :model_class
+      private     :scope, :model_class
+
+      def initialize(scope: nil, model_class:, **_options)
         @scope = scope
         @model_class = model_class
       end
 
       def last_synced_at
-        Synced::Timestamp.with_scope_and_model(@scope, @model_class).last_synced_at
+        timestamp_repository.last_synced_at
       end
 
       def update(timestamp)
-        Synced::Timestamp.with_scope_and_model(@scope, @model_class).create!(synced_at: timestamp)
+        timestamp_repository.create!(synced_at: timestamp)
       end
 
       def reset
-        Synced::Timestamp.with_scope_and_model(@scope, @model_class).delete_all
+        timestamp_repository.delete_all
+      end
+
+      private
+
+      def timestamp_repository
+        @timestamp_repository ||= begin
+          if scope
+            Synced::Timestamp.with_scope_and_model(scope, model_class)
+          else
+            Synced::Timestamp.with_model(model_class)
+          end
+        end
       end
     end
   end

data/lib/synced/timestamp.rb

@@ -1,9 +1,15 @@
 class Synced::Timestamp < ActiveRecord::Base
-  self.table_name = 'synced_timestamps'
+  self.table_name = "synced_timestamps"
+
   belongs_to :parent_scope, polymorphic: true
-  scope :with_scope_and_model, ->(parent_scope, model_class) { where(parent_scope: parent_scope, model_class: model_class.to_s) }
-  validates :parent_scope, :model_class, :synced_at, presence: true
-  scope :old, -> { where('synced_at < ?', 1.week.ago) }
+
+  validates :model_class, :synced_at, presence: true
+
+  scope :with_scope_and_model, -> (parent_scope, model_class) {
+    where(parent_scope: parent_scope, model_class: model_class.to_s)
+  }
+  scope :with_model, -> model_class { where(model_class: model_class.to_s) }
+  scope :old, -> { where("synced_at < ?", 1.week.ago) }
 
   def model_class=(value)
     write_attribute(:model_class, value.to_s)

data/lib/synced/version.rb

@@ -1,3 +1,3 @@
 module Synced
-  VERSION = "1.2.0"
+  VERSION = "1.3.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: synced
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Sebastien Grosjean
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-01 00:00:00.000000000 Z
+date: 2016-04-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -210,7 +210,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Keep your BookingSync Application synced with BookingSync.