synapse_pay_rest 2.2.1 → 2.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2fd4eeec4259c9f37867f82f51e96a371d23d994
-  data.tar.gz: f058a5fd3a2bc83721edb2ea3c03c07cabfe032e
+  metadata.gz: 2ac33ad48e29bfe842ef95fd251245006824f851
+  data.tar.gz: 56bc587fa28769dd1bb9ccf193fdb44431cfcc7a
 SHA512:
-  metadata.gz: 945eb2be10590e418d8654f0c0e6d869755153cc754811c61b84eb3558f0d3846557d09ab7ec8fe52b614be2af18794b421e9904681cf7247f4e2b862e0c45b2
-  data.tar.gz: e036132fda81f02a4e5a47f57fdc8ad258e4c74714ef08d1d417d0d37d975d732cbe8d4dbad8c5cdca0a3bdcf42a18bfff04400fcfe18190c8ca8a66bd8d24a4
+  metadata.gz: c39cabd30d390cc1e5d0928a783668f1f7295bba049ac86d45021d6a44778e9e7ba5ea19b88114a9fcfa0aecd8b039d5d1a4cbcc31c6a5ddf2c945147e4436da
+  data.tar.gz: 02d70a8460231e31471b1bdc3381f69ea0c2abd14c40c2fd78be182e9f8180d9fce8380baf33ee717469a5c5459efe6729d22558e06df53c713ac6afa6d486d6

data/lib/synapse_pay_rest.rb

@@ -27,7 +27,6 @@ require 'synapse_pay_rest/models/node/base_node'
 
 # BaseNode subclasses
 # synapse
-require 'synapse_pay_rest/models/node/synapse_node'
 require 'synapse_pay_rest/models/node/synapse_us_node.rb'
 require 'synapse_pay_rest/models/node/synapse_ind_node.rb'
 require 'synapse_pay_rest/models/node/synapse_np_node.rb'
@@ -35,11 +34,9 @@ require 'synapse_pay_rest/models/node/synapse_np_node.rb'
 require 'synapse_pay_rest/models/node/ach_us_node.rb'
 require 'synapse_pay_rest/models/node/unverified_node.rb'
 # eft
-require 'synapse_pay_rest/models/node/eft_node'
 require 'synapse_pay_rest/models/node/eft_ind_node.rb'
 require 'synapse_pay_rest/models/node/eft_np_node.rb'
 # wire
-require 'synapse_pay_rest/models/node/wire_node.rb'
 require 'synapse_pay_rest/models/node/wire_us_node.rb'
 require 'synapse_pay_rest/models/node/wire_int_node.rb'
 # reserve

data/lib/synapse_pay_rest/client.rb

@@ -27,16 +27,12 @@ module SynapsePayRest
     # @param log_to [String] (optional) file path to log to file (logging must be true)
     def initialize(client_id:, client_secret:, ip_address:, fingerprint: nil,
                    development_mode: true, **options)
-      base_url = if development_mode
-                   'https://sandbox.synapsepay.com/api/3'
-                 else
-                   'https://synapsepay.com/api/3'
-                 end
+      base_url = 'https://api-qa.synapsefi.com/v3.1'
 
       @http_client  = HTTPClient.new(base_url: base_url,
-                                     client_id: client_id,
-                                     client_secret: client_secret,
-                                     fingerprint: fingerprint,
+                                     client_id: 'client_id_b8d24e32b6aa11e6bba40242ac110003',
+                                     client_secret: 'test1234',
+                                     fingerprint: 'e716990e50b67a1177736960b6357524b22090ccab093d068b3d7a18dbde3f4c',
                                      ip_address: ip_address,
                                      **options)
       @users        = Users.new @http_client

data/lib/synapse_pay_rest/error.rb

@@ -50,9 +50,6 @@ module SynapsePayRest
     GatewayTimeout = Class.new(ServerError)
 
     # HTTP status code to Error subclass mapping
-    #
-    # @todo need to add an error message for various 202 cases (fingerprint, mfa, etc)
-    # @todo doesn't do well when there's an html response from nginx for bad gateway/timeout
     ERRORS = {
       400 => SynapsePayRest::Error::BadRequest,
       401 => SynapsePayRest::Error::Unauthorized,

data/lib/synapse_pay_rest/models/node/unverified_node.rb

@@ -10,7 +10,6 @@ module SynapsePayRest
     #   @return [String] question or MFA prompt from bank that must be answered
     # @!attribute [r] mfa_verified
     #   @return [Boolean] whether the node is verified yet
-    #   @todo should be mfa_verified? in Ruby idiom
     attr_reader :user, :mfa_access_token, :mfa_message, :mfa_verified
 
     def initialize(user:, mfa_access_token:, mfa_message:, mfa_verified:)
@@ -27,8 +26,6 @@ module SynapsePayRest
     # @raise [SynapsePayRest::Error] if incorrect answer
     # 
     # @return [Array<SynapsePayRest::AchUsNode>,SynapsePayRest::UnverifiedNode] may contain multiple nodes if successful, else self if new MFA question to answer
-    # 
-    # @todo make a new Error subclass for incorrect MFA
     def answer_mfa(answer)
       payload  = payload_for_answer_mfa(answer: answer)
       response = user.client.nodes.post(user_id: user.id, payload: payload)
@@ -36,6 +33,8 @@ module SynapsePayRest
       handle_answer_mfa_response(response)
     end
 
+    alias_method :mfa_verified?, :mfa_verified
+
     private
 
     def payload_for_answer_mfa(answer:)
@@ -47,23 +46,13 @@ module SynapsePayRest
 
     # Determines whether the response is successful in verifying the node, has
     # follow-up MFA questions, or failed with an incorrect answer.
-    # 
-    # @todo Use Error#code instead of parsing the response for the code.
     def handle_answer_mfa_response(response)
       if response['error_code'] == '0'
         # correct answer
         @mfa_verified = true
         AchUsNode.multiple_from_response(user, response['nodes'])
-      elsif response['error_code'] == '10' && response['mfa']['message'] == mfa_message
-        # wrong answer (mfa message the same), retry if allowed
-        args = {
-          message: 'incorrect bank login mfa answer',
-          code: response['http_code'], 
-          response: response
-        }
-        raise SynapsePayRest::Error, args
       elsif response['error_code'] == '10'
-        # new additional MFA question. need to call #answer_mfa with new answer
+        # incorrect answer or new MFA question. need to call #answer_mfa with new answer.
         @mfa_access_token = response['mfa']['access_token']
         @mfa_message      = response['mfa']['message']
         self

data/lib/synapse_pay_rest/models/transaction/transaction.rb

@@ -114,7 +114,6 @@ module SynapsePayRest
       # 
       # @note Shouldn't need to call this directly.
       # 
-      # @todo convert the nodes and users in response into User/Node objects
       # @todo rework to handle multiple fees
       def from_response(node, response)
         args = {
@@ -208,7 +207,7 @@ module SynapsePayRest
         trans_id: id,
         payload: payload
       )
-      self.class.from_response(node, response['trans'])
+      self.class.from_response(node, response)
     end
 
     # Cancels this transaction if it has not already settled.

data/lib/synapse_pay_rest/models/user/virtual_document.rb

@@ -6,6 +6,7 @@ module SynapsePayRest
   class VirtualDocument < Document
     # @!attribute [r] question_set
     # @return [SynapsePayRest::Array<SynapsePayRest::Question>] questions/answer choices returned when document status is MFA|PENDING
+    # @deprecated
     attr_reader :question_set
 
     class << self
@@ -28,6 +29,8 @@ module SynapsePayRest
     # @return [SynapsePayRest::VirtualDocument] (self)
     #
     # @todo should raise error if any questions aren't answered yet.
+    #
+    # @deprecated
     def submit_kba
       user = base_document.user
       user.authenticate()
@@ -38,6 +41,8 @@ module SynapsePayRest
     end
 
     # Maps question set from response to Question objects.
+    #
+    # @deprecated
     def add_question_set(question_set_data)
       questions = question_set_data['questions'].map do |question_info|
         # re-map question/answer hash structure

data/lib/synapse_pay_rest/version.rb

@@ -1,4 +1,4 @@
 module SynapsePayRest
   # gem version:
-  VERSION = '2.2.1'.freeze
+  VERSION = '2.2.2'.freeze
 end

data/samples.md

@@ -310,7 +310,7 @@ Returns a collection of `AchUsNode`s associated with the account unless bank req
 
 ```ruby
 login_info = {
-  bank_name: 'bofa',
+  bank_name: 'fake',
   username:  'synapse_good',
   password:  'test1234'
 }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: synapse_pay_rest
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 2.2.2
 platform: ruby
 authors:
 - Steven Broderick
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-12-14 00:00:00.000000000 Z
+date: 2016-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client