synapse_pay_rest 0.0.14 → 0.0.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9eb067fcbf87836159c1afdfeb9fdf13a0b64c6a
-  data.tar.gz: 8e41c3f89e3de30798a252645ec77310d4cc39e3
+  metadata.gz: 47dd33491a54e460f6d819149c967607c7a93aaa
+  data.tar.gz: 409fe90ce07bb9eb0c99546cdb5d7c5d48c0e5e1
 SHA512:
-  metadata.gz: 1b981fbc586dec4a9cfe4f08e973f8a333d7993a7aa5520124e330020cf0be64e8f421d9caa0b0b3f8e6e38288729edcc7209ebbca94eb8a171cf8c8e046d20a
-  data.tar.gz: 249ed0c41fad41c2ec69703df4eb17d5370981bd0fa8fb51f713436ffe958543cb2a54cff29383476e71e32711b8a7d05d8aac3897e5306486d3d592a8c8303d
+  metadata.gz: 5b63b1214ab80b3e6647e4d9dab8c83c8dfde99f4902532f556a84538842b8643ddc3cf511c58d22946fb9c1b10d31abbb8ec454908519c6b8f8656db0718fa3
+  data.tar.gz: a08d5a5e82b14cbd9bd3cfb6116284e04833a2d8a33025c7fd077367ee1f938376817f1cc3388069cf1209776148a46d736f8eeeabd50e9bbb34c8d9df6fbad1

data/lib/synapse_pay_rest/error.rb

@@ -87,7 +87,7 @@ module SynapsePayRest
         klass.new(message: message, code: error_code, response: body)
       end
 
-    private
+      private
 
       def parse_error(body)
         if body.nil? || body.empty?
@@ -96,7 +96,6 @@ module SynapsePayRest
           [body['error']['en'], body['error_code']]
         end
       end
-
     end
 
     # Initializes a new Error object

data/lib/synapse_pay_rest/http_client.rb

@@ -64,50 +64,9 @@ module SynapsePayRest
 
     def with_error_handling
       yield
-    rescue => e
-      # By the way, this is a really bad idea.
-      # See: https://www.relishapp.com/womply/ruby-style-guide/docs/exceptions
-      # The exceptions should be enumerated. Not all exceptions are going
-      # to be parsable by JSON. The only one that should be captured are the
-      # are the HTTP Client responses.
-      case e.response.code
-      when 400
-        return e.response
-      when 401
-        return e.response
-      when 409
-        return e.response
-      when 500
-        return e.response
-      when 405
-        return handle_method_not_allowed
-      when 502
-        #Raise a gateway error
-        return handle_gateway_error
-      when 504
-        #Raise a timeout error
-        return handle_timeout_error
-      else
-        #Raise a generic error
-        return handle_unknown_error
-      end
-    end
-
-    def handle_method_not_allowed
-      return {'success' => false, 'reason' => 'The method is not allowed. Check your id parameters.'}.to_json
-    end
-
-    def handle_gateway_error
-      return {'success' => false, 'reason' => 'The gateway appears to be down.  Check synapsepay.com or try again later.'}.to_json
-    end
-
-    def handle_timeout_error
-      return {'success' => false, 'reason' => 'A timeout has occurred.'}.to_json
-    end
-
-
-    def handle_unknown_error
-      return {'success' => false, 'reason' => 'Unknown error in library. Contact synapsepay.'}.to_json
+    rescue RestClient::Exception => e
+      body = JSON.parse(e.response.body)
+      raise Error.error_from_response(body, e.response.code)
     end
   end
 end

data/lib/synapse_pay_rest/version.rb

@@ -1,3 +1,3 @@
 module SynapsePayRest
-  VERSION = '0.0.14'
+  VERSION = '0.0.15'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: synapse_pay_rest
 version: !ruby/object:Gem::Version
-  version: 0.0.14
+  version: 0.0.15
 platform: ruby
 authors:
 - Thomas Hipps
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-09-26 00:00:00.000000000 Z
+date: 2016-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler