switch_user 1.5.0 → 1.5.1

data/spec/integration/switch_user_spec.rb

@@ -1,82 +1,143 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
-RSpec.describe "Using SwitchUser", type: :request do
-  let(:user) { User.create!(email: "foo@bar.com", admin: true) }
-  let(:other_user) { User.create!(email: "other@bar.com", admin: false) }
+RSpec.describe 'Using SwitchUser', type: :request do
+  let(:user) { User.create!(email: 'foo@bar.com', admin: true) }
+  let(:other_user) { User.create!(email: 'other@bar.com', admin: false) }
 
   before do
     SwitchUser.reset_config
     SwitchUser.provider = :session
-    SwitchUser.controller_guard = ->(current_user, request) { Rails.env.test? }
-    SwitchUser.redirect_path = ->(_, _) { "/dummy/open" }
+    SwitchUser.controller_guard = ->(_current_user, _request) { Rails.env.test? }
+    SwitchUser.redirect_path = ->(_, _) { '/dummy/open' }
   end
 
-  it "signs a user in using switch_user" do
+  it 'signs a user in using switch_user' do
     # can't access protected url
-    get "/dummy/protected"
+    get '/dummy/protected'
     expect(response).to be_redirect
 
     get "/switch_user?scope_identifier=user_#{other_user.id}"
     expect(response).to be_redirect
 
     # now that we are logged in via switch_user we can access
-    get "/dummy/protected"
+    get '/dummy/protected'
     expect(response).to be_success
   end
 
-  context "using switch_back" do
+  context 'using switch_back' do
     before do
       SwitchUser.switch_back = true
-      SwitchUser.controller_guard = ->(current_user, request, original_user) { current_user && current_user.admin? || original_user && original_user.admin? }
+      SwitchUser.controller_guard = ->(current_user, _request, original_user) { current_user && current_user.admin? || original_user && original_user.admin? }
     end
 
-    it "can switch back to a different user through remember_user endpoint" do
+    it 'can switch back to a different user through remember_user endpoint' do
       # login
-      post "/login", params: { id: user.id }
+      post '/login', params: { id: user.id }
       follow_redirect!
 
       # have SwitchUser remember us
-      get "/switch_user/remember_user", params: { remember: true }
-      expect(session["original_user_scope_identifier"]).to be_present
+      get '/switch_user/remember_user', params: { remember: true }
+      expect(session['original_user_scope_identifier']).to be_present
 
       # check that we can switch to another user
       get "/switch_user?scope_identifier=user_#{other_user.id}"
-      expect(session["user_id"]).to eq other_user.id
+      expect(session['user_id']).to eq other_user.id
 
       # logout
-      get "/logout"
-      expect(session["user_id"]).to be_nil
+      get '/logout'
+      expect(session['user_id']).to be_nil
 
       # check that we can still switch to another user
       get "/switch_user?scope_identifier=user_#{user.id}"
-      expect(session["user_id"]).to eq user.id
+      expect(session['user_id']).to eq user.id
 
       # check that we can be un-remembered
-      get "/switch_user/remember_user", params: { remember: false }
-      expect(session["original_user"]).to be_nil
+      get '/switch_user/remember_user', params: { remember: false }
+      expect(session['original_user']).to be_nil
     end
 
-    it "can switch back to a different user without hitting remember_user endpoint" do
+    it 'can switch back to a different user without hitting remember_user endpoint' do
       # login
-      post "/login", params: { :id => user.id }
+      post '/login', params: { id: user.id }
       follow_redirect!
 
       # check that we can switch to another user
-      get "/switch_user?scope_identifier=user_#{other_user.id}", params: { :remember => true }
-      expect(session["user_id"]).to eq other_user.id
-      expect(session["original_user_scope_identifier"]).to_not be_nil
+      get "/switch_user?scope_identifier=user_#{other_user.id}", params: { remember: true }
+      expect(session['user_id']).to eq other_user.id
+      expect(session['original_user_scope_identifier']).to_not be_nil
 
       # logout
-      get "/logout"
-      expect(session["user_id"]).to be_nil
+      get '/logout'
+      expect(session['user_id']).to be_nil
 
       # check that we can still switch to another user
       get "/switch_user?scope_identifier=user_#{user.id}"
-      expect(session["user_id"]).to eq user.id
+      expect(session['user_id']).to eq user.id
 
       # check that we can be un-remembered
-      get "/switch_user/remember_user", params: { :remember => false }
-      expect(session["original_user"]).to be_nil
+      get '/switch_user/remember_user', params: { remember: false }
+      expect(session['original_user']).to be_nil
+    end
+
+    context 'when non-default identifier' do
+      before do
+        SwitchUser.available_users_identifiers = { user: :email }
+      end
+
+      after do
+        SwitchUser.available_users_identifiers = { user: :id }
+      end
+
+      it 'can switch back to a different user through remember_user endpoint' do
+        # login
+        post '/login', params: { id: user.id }
+        follow_redirect!
+
+        # have SwitchUser remember us
+        get '/switch_user/remember_user', params: { remember: true }
+        expect(session['original_user_scope_identifier']).to be_present
+
+        # check that we can switch to another user
+        get "/switch_user?scope_identifier=user_#{other_user.email}"
+        expect(session['user_id']).to eq other_user.id
+
+        # logout
+        get '/logout'
+        expect(session['user_id']).to be_nil
+
+        # check that we can still switch to another user
+        get "/switch_user?scope_identifier=user_#{user.email}"
+        expect(session['user_id']).to eq user.id
+
+        # check that we can be un-remembered
+        get '/switch_user/remember_user', params: { remember: false }
+        expect(session['original_user']).to be_nil
+      end
+
+      it 'can switch back to a different user without hitting remember_user endpoint' do
+        # login
+        post '/login', params: { id: user.id }
+        follow_redirect!
+
+        # check that we can switch to another user
+        get "/switch_user?scope_identifier=user_#{other_user.email}", params: { remember: true }
+        expect(session['user_id']).to eq other_user.id
+        expect(session['original_user_scope_identifier']).to_not be_nil
+
+        # logout
+        get '/logout'
+        expect(session['user_id']).to be_nil
+
+        # check that we can still switch to another user
+        get "/switch_user?scope_identifier=user_#{user.email}"
+        expect(session['user_id']).to eq user.id
+
+        # check that we can be un-remembered
+        get '/switch_user/remember_user', params: { remember: false }
+        expect(session['original_user']).to be_nil
+      end
     end
   end
 end

data/spec/provider/authlogic_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'switch_user/provider/authlogic'
 
@@ -33,5 +35,5 @@ RSpec.describe SwitchUser::Provider::Authlogic do
   let(:controller) { AuthlogicController.new }
   let(:provider) { SwitchUser::Provider::Authlogic.new(controller) }
 
-  it_behaves_like "a provider"
+  it_behaves_like 'a provider'
 end

data/spec/provider/clearance_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'switch_user/provider/clearance'
 
@@ -19,5 +21,5 @@ RSpec.describe SwitchUser::Provider::Clearance do
   let(:controller) { ClearanceController.new }
   let(:provider) { SwitchUser::Provider::Clearance.new(controller) }
 
-  it_behaves_like "a provider"
+  it_behaves_like 'a provider'
 end

data/spec/provider/devise_spec.rb

@@ -1,15 +1,15 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'switch_user/provider/devise'
 
 class FakeWardenSessionSerializer
   attr_accessor :user_hash
 
-
   def store(user, scope)
     return unless user
     user_hash[scope] = user
   end
-
 end
 
 class FakeWarden
@@ -54,34 +54,34 @@ RSpec.describe SwitchUser::Provider::Devise do
   let(:provider) { SwitchUser::Provider::Devise.new(controller) }
   let(:user) { double(:user) }
 
-  it_behaves_like "a provider"
+  it_behaves_like 'a provider'
 
-  it "can use alternate scopes" do
+  it 'can use alternate scopes' do
     user = double(:user)
     provider.login(user, :admin)
 
     expect(provider.current_user(:admin)).to eq user
   end
 
-  describe "#login_exclusive" do
+  describe '#login_exclusive' do
     before do
-      allow(SwitchUser).to receive(:available_users).and_return({ user: nil, admin: nil })
+      allow(SwitchUser).to receive(:available_users).and_return(user: nil, admin: nil)
       provider.login(user, :admin)
-      provider.login_exclusive(user, scope: "user")
+      provider.login_exclusive(user, scope: 'user')
     end
 
-    it "logs the user in" do
+    it 'logs the user in' do
       expect(provider.current_user(:user)).to eq user
     end
 
-    it "logs out other scopes" do
+    it 'logs out other scopes' do
       expect(provider.current_user(:admin)).to be_nil
     end
   end
 
-  describe "#logout_all" do
-    it "logs out users under all scopes" do
-      allow(SwitchUser).to receive(:available_users).and_return({ user: nil, admin: nil })
+  describe '#logout_all' do
+    it 'logs out users under all scopes' do
+      allow(SwitchUser).to receive(:available_users).and_return(user: nil, admin: nil)
       provider.login(user, :admin)
       provider.login(user, :user)
 
@@ -92,17 +92,17 @@ RSpec.describe SwitchUser::Provider::Devise do
     end
   end
 
-  describe "#all_current_users" do
-    it "pulls users from an alternate scope" do
-      allow(SwitchUser).to receive(:available_users).and_return({ user: nil, admin: nil })
+  describe '#all_current_users' do
+    it 'pulls users from an alternate scope' do
+      allow(SwitchUser).to receive(:available_users).and_return(user: nil, admin: nil)
       provider.login(user, :admin)
 
       expect(provider.current_users_without_scope).to eq [user]
     end
   end
 
-  describe "#current_user?" do
-    it "logs the user in" do
+  describe '#current_user?' do
+    it 'logs the user in' do
       user = double(:user)
       provider.login(user, :user)
 

data/spec/provider/dummy_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'switch_user/provider/dummy'
 
@@ -8,5 +10,5 @@ RSpec.describe SwitchUser::Provider::Session do
   let(:controller) { SessionController.new }
   let(:provider) { SwitchUser::Provider::Dummy.new(controller) }
 
-  it_behaves_like "a provider"
+  it_behaves_like 'a provider'
 end

data/spec/provider/restful_authentication_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'switch_user/provider/restful_authentication'
 
@@ -13,5 +15,5 @@ RSpec.describe SwitchUser::Provider::RestfulAuthentication do
   let(:controller) { RestfulAuthenticationController.new }
   let(:provider) { SwitchUser::Provider::RestfulAuthentication.new(controller) }
 
-  it_behaves_like "a provider"
+  it_behaves_like 'a provider'
 end

data/spec/provider/session_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'switch_user/provider/session'
 
@@ -14,5 +16,5 @@ RSpec.describe SwitchUser::Provider::Session do
   let(:controller) { SessionController.new }
   let(:provider) { SwitchUser::Provider::Session.new(controller) }
 
-  it_behaves_like "a provider"
+  it_behaves_like 'a provider'
 end

data/spec/provider/sorcery_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'switch_user/provider/sorcery'
 
@@ -20,5 +22,5 @@ RSpec.describe SwitchUser::Provider::Sorcery do
   let(:controller) { SorceryController.new }
   let(:provider) { SwitchUser::Provider::Sorcery.new(controller) }
 
-  it_behaves_like "a provider"
+  it_behaves_like 'a provider'
 end

data/spec/provider_spec.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module SwitchUser
   RSpec.describe Provider do
-    it "initializes the provider" do
+    it 'initializes the provider' do
       SwitchUser.provider = :dummy
       expect(Provider.init(double(:controller))).to be_a(Provider::Dummy)
     end

data/spec/rspec/feature_helpers_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'capybara/rspec'
@@ -6,32 +8,32 @@ Capybara.app = MyApp::Application
 
 require 'switch_user/rspec'
 
-RSpec.feature "SwitchUser::RSpecFeatureHelpers", type: :feature do
+RSpec.feature 'SwitchUser::RSpecFeatureHelpers', type: :feature do
   background do
-    @user = User.create!(email: "foo@bar.com", admin: true)
-    @client = Client.create!(email: "foo@bar.com")
+    @user = User.create!(email: 'foo@bar.com', admin: true)
+    @client = Client.create!(email: 'foo@bar.com')
   end
 
   before(:example) do
-    allow(SwitchUser).to receive(:controller_guard).and_return(->(current_user, request) { true })
+    allow(SwitchUser).to receive(:controller_guard).and_return(->(_current_user, _request) { true })
 
-    allow(SwitchUser).to receive(:available_users).and_return({ user: -> { User.all } })
+    allow(SwitchUser).to receive(:available_users).and_return(user: -> { User.all })
 
-    allow(SwitchUser).to receive(:available_users_identifiers).and_return({ user: :id })
+    allow(SwitchUser).to receive(:available_users_identifiers).and_return(user: :id)
 
-    allow(SwitchUser).to receive(:available_users_names).and_return({ user: :email })
+    allow(SwitchUser).to receive(:available_users_names).and_return(user: :email)
   end
 
-  scenario "when controller_guard return false" do
-    allow(SwitchUser).to receive(:controller_guard).and_return(->(current_user, request) { false })
+  scenario 'when controller_guard return false' do
+    allow(SwitchUser).to receive(:controller_guard).and_return(->(_current_user, _request) { false })
 
     expect do
       switch_user @user
     end.not_to raise_error
   end
 
-  scenario "when controller_guard return false and controller call original available?" do
-    allow(SwitchUser).to receive(:controller_guard).and_return(->(current_user, request) { false })
+  scenario 'when controller_guard return false and controller call original available?' do
+    allow(SwitchUser).to receive(:controller_guard).and_return(->(_current_user, _request) { false })
 
     allow_any_instance_of(SwitchUserController).to receive(:available?).and_call_original
 
@@ -40,73 +42,73 @@ RSpec.feature "SwitchUser::RSpecFeatureHelpers", type: :feature do
     end.to raise_error ActionController::RoutingError, /Do not try to hack us/
   end
 
-  scenario "arg is @user, available_users is default, and available_users_identifiers is default" do
+  scenario 'arg is @user, available_users is default, and available_users_identifiers is default' do
     expect do
       switch_user @user
     end.not_to raise_error
   end
 
-  scenario "arg is @user, available_users is default, and available_users_identifiers is {user: id}" do
-    allow(SwitchUser).to receive(:available_users_identifiers).and_return({ user: :id })
+  scenario 'arg is @user, available_users is default, and available_users_identifiers is {user: id}' do
+    allow(SwitchUser).to receive(:available_users_identifiers).and_return(user: :id)
 
     expect do
       switch_user @user
     end.not_to raise_error
   end
 
-  scenario "arg is @user, available_users is default, and available_users_identifiers is {:client => :id}" do
-    allow(SwitchUser).to receive(:available_users_identifiers).and_return({ client: :id })
-    allow(SwitchUser).to receive(:available_users_names).and_return({ client: :email })
+  scenario 'arg is @user, available_users is default, and available_users_identifiers is {:client => :id}' do
+    allow(SwitchUser).to receive(:available_users_identifiers).and_return(client: :id)
+    allow(SwitchUser).to receive(:available_users_names).and_return(client: :email)
 
     expect do
       switch_user @user
     end.to raise_error SwitchUser::InvalidScope, /config.available_users_identifiers/
   end
 
-  scenario "arg is @client, available_users is default, and available_users_identifiers is default" do
+  scenario 'arg is @client, available_users is default, and available_users_identifiers is default' do
     expect do
       switch_user @client
     end.to raise_error SwitchUser::InvalidScope, /config.available_users/
   end
 
-  scenario "arg is @client, available_users is {:user => lambda { User.all }, :client => lambda {Client.all}}, and available_users_identifiers is default" do
-    allow(SwitchUser).to receive(:available_users).and_return({ user: -> { User.all }, client: -> { Client.all } })
+  scenario 'arg is @client, available_users is {:user => lambda { User.all }, :client => lambda {Client.all}}, and available_users_identifiers is default' do
+    allow(SwitchUser).to receive(:available_users).and_return(user: -> { User.all }, client: -> { Client.all })
 
     expect do
       switch_user @client
     end.to raise_error SwitchUser::InvalidScope, /config.available_users_identifiers/
   end
 
-  scenario "arg is @client, available_users is {:user => lambda { User.all }, :client => lambda {Client.all}}, and available_users_identifiers is {:user => id, :client => id}" do
-    allow(SwitchUser).to receive(:available_users).and_return({ user: -> { User.all }, client: -> { Client.all } })
+  scenario 'arg is @client, available_users is {:user => lambda { User.all }, :client => lambda {Client.all}}, and available_users_identifiers is {:user => id, :client => id}' do
+    allow(SwitchUser).to receive(:available_users).and_return(user: -> { User.all }, client: -> { Client.all })
 
-    allow(SwitchUser).to receive(:available_users_identifiers).and_return({ user: :id, client: :id })
-    allow(SwitchUser).to receive(:available_users_names).and_return({ user: :email, client: :email })
+    allow(SwitchUser).to receive(:available_users_identifiers).and_return(user: :id, client: :id)
+    allow(SwitchUser).to receive(:available_users_names).and_return(user: :email, client: :email)
 
     expect do
       switch_user @client
     end.not_to raise_error
   end
 
-  scenario "args is :user and @user.id, available_users is default, and available_users_identifiers is default" do
+  scenario 'args is :user and @user.id, available_users is default, and available_users_identifiers is default' do
     expect do
       switch_user :user, @user.id
     end.not_to raise_error
   end
 
-  scenario "arg is :client and @client.id, available_users is default, and available_users_identifiers is default" do
+  scenario 'arg is :client and @client.id, available_users is default, and available_users_identifiers is default' do
     expect do
       switch_user :client, @client.id
     end.to raise_error SwitchUser::InvalidScope, /config.available_users/
   end
 
-  scenario "args is :user, available_users is default, and available_users_identifiers is default" do
+  scenario 'args is :user, available_users is default, and available_users_identifiers is default' do
     expect do
       switch_user :user
     end.to raise_error SwitchUser::RSpecFeatureHelpers::InvalidArgument, /user_id is empty/
   end
 
-  scenario "args is :user and nil, available_users is default, and available_users_identifiers is default" do
+  scenario 'args is :user and nil, available_users is default, and available_users_identifiers is default' do
     expect do
       switch_user :user, nil
     end.to raise_error SwitchUser::RSpecFeatureHelpers::InvalidArgument, /user_id is empty/
@@ -118,10 +120,9 @@ RSpec.feature "SwitchUser::RSpecFeatureHelpers", type: :feature do
     end.to raise_error SwitchUser::RSpecFeatureHelpers::InvalidArgument, /user_id is empty/
   end
 
-  scenario "args is :user and 0, available_users is default, and available_users_identifiers is default" do
+  scenario 'args is :user and 0, available_users is default, and available_users_identifiers is default' do
     expect do
       switch_user :user, 0
     end.not_to raise_error
   end
-
 end