swift 0.5.0 → 0.5.1

data/VERSION

@@ -1 +1 @@
-0.5.0
+0.5.1

data/ext/result.cc

@@ -88,10 +88,10 @@ static VALUE result_finish(VALUE self) {
 }
 
 // Calculates local offset at a given time, including dst.
-size_t client_tzoffset(uint64_t local, int isdst) {
+int64_t client_tzoffset(int64_t local, int isdst) {
   struct tm tm;
   gmtime_r((const time_t*)&local, &tm);
-  return local + (isdst ? 3600 : 0) - mktime(&tm);
+  return (int64_t)(local + (isdst ? 3600 : 0) - mktime(&tm));
 }
 
 // pinched from do_postgres
@@ -108,7 +108,7 @@ static void reduce(uint64_t *numerator, uint64_t *denominator) {
 
 VALUE typecast_datetime(const char *data, uint64_t len) {
   struct tm tm;
-  uint64_t epoch, adjust, offset;
+  int64_t epoch, adjust, offset;
 
   double usec = 0;
   char tzsign = 0;
@@ -148,7 +148,7 @@ VALUE typecast_datetime(const char *data, uint64_t len) {
     reduce(&ajd_n, &ajd_d);
 
     VALUE ajd = rb_rational_new(SIZET2NUM(ajd_n), SIZET2NUM(ajd_d));
-    return rb_funcall(cDateTime, fNewBang, 3, ajd, rb_rational_new(INT2FIX(offset), daysecs), sg);
+    return rb_funcall(cDateTime, fNewBang, 3, ajd, rb_rational_new(INT2FIX(adjust), daysecs), sg);
   }
 
   // TODO: throw a warning ?

data/swift.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{swift}
-  s.version = "0.5.0"
+  s.version = "0.5.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Shane Hanna", "Bharanee 'Barney' Rathna"]

data/test/helper.rb

@@ -27,6 +27,4 @@ class MiniTest::Spec
   end
 end
 
-# All tests run in this timezone.
-ENV['TZ'] = ":Australia/Melbourne"
 MiniTest::Unit.autorun

data/test/test_timestamps.rb

@@ -3,37 +3,39 @@ require 'date'
 
 describe 'Adapter' do
   supported_by Swift::DB::Postgres do
-    describe 'time parsing and time zones' do
+    %w(Australia/Melboure America/Chicago).each do |timezone|
+      describe 'time parsing in %s' % timezone do
+        before do
+          @db = Swift.db
+          ENV['TZ'] = ":#{timezone}"
+        end
 
-      before do
-        @db = Swift.db.class.new Swift.db.options.merge(timezone: 'Asia/Kabul')
-      end
-
-      it 'should parse timestamps and do conversion accordingly' do
-        time  = DateTime.parse('2010-01-01 15:00:00+04:30')
-        assert_timestamp_like time, fetch_timestamp_at(time), 'parses correctly'
-      end
+        it 'should parse timestamps and do conversion accordingly' do
+          time  = DateTime.parse('2010-01-01 15:00:00+04:30')
+          assert_timestamp_like time, fetch_timestamp_at(time), 'parses correctly'
+        end
 
-      it 'should parse correctly when DST is on' do
-        time  = DateTime.parse('2010-10-02 20:31:00+04:30')
-        assert_timestamp_like time, fetch_timestamp_at(time), 'DST on'
-      end
+        it 'should parse correctly when DST is on' do
+          time  = DateTime.parse('2010-10-02 20:31:00+04:30')
+          assert_timestamp_like time, fetch_timestamp_at(time), 'DST on'
+        end
 
-      it 'should parse correctly when DST is off' do
-        time  = DateTime.parse('2010-04-04 20:31:00+04:30')
-        assert_timestamp_like time, fetch_timestamp_at(time), 'DST off'
-      end
+        it 'should parse correctly when DST is off' do
+          time  = DateTime.parse('2010-04-04 20:31:00+04:30')
+          assert_timestamp_like time, fetch_timestamp_at(time), 'DST off'
+        end
 
-      def fetch_timestamp_at value
-        sql = "select '%s'::timestamp with time zone as now" % value.strftime('%F %T%z')
-        @db.execute(sql)
-        @db.results.first.fetch(:now)
-      end
+        def fetch_timestamp_at value
+          sql = "select '%s'::timestamp with time zone as now" % value.strftime('%F %T%z')
+          @db.execute(sql)
+          @db.results.first.fetch(:now)
+        end
 
-      def assert_timestamp_like expect, given, comment
-        match = Regexp.new expect.to_time.strftime('%F %T')
-        assert_kind_of DateTime, given
-        assert_match match, given.strftime('%F %T'), comment
+        def assert_timestamp_like expect, given, comment
+          match = Regexp.new expect.to_time.strftime('%F %T')
+          assert_kind_of DateTime, given
+          assert_match match, given.strftime('%F %T'), comment
+        end
       end
     end
   end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 5
-  - 0
-  version: 0.5.0
+  - 1
+  version: 0.5.1
 platform: ruby
 authors: 
 - Shane Hanna