svgo_wrapper 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 76a70d96f217e4b058f67f606d9ba17ddef9f777
-  data.tar.gz: fe0c8f2ed99d09b63a53e445a9db99c373e19bf2
+  metadata.gz: 3a40cd66303349f126ac7403993e9e49c4d70c03
+  data.tar.gz: c7fd377d1a46ec6441dff7866efa36bb8c81d8eb
 SHA512:
-  metadata.gz: c5c86c5f59bd2e820d14a15e7bc4f2571ab604d6f2e987e070582dc8c1785b59854cd9f9d91c7589db44fea8b47ef23b6b5d8dd25aaf7406416d05f3d908c841
-  data.tar.gz: 4c8c053e552c484cb2d23c162288515c55f9ca1012ed0c5f39b4d1787f3761c29596eb77d3fcd0372ac2998c1d98517cec8e9c4678188be64ae13ccd20b52bb6
+  metadata.gz: 1e6a39d65c1646e5164aa09d54854a23e8173a60219030f145102aca2d4bc44b0d6aa9cda03f39edbbb553ecbe833753753899ea4eef5c8699434a8968512ca3
+  data.tar.gz: f43d1cfafc2ef8ed34f8002b81262ea27dd36011f1403e513c0e5bffe598af38e59580157bad744f1036efba44c2c570b7e6282369e90563c924dd56e3ebd4ef

data/.ruby-version

@@ -1 +1 @@
-2.1.2
+2.2.0

data/lib/svgo_wrapper.rb

@@ -28,7 +28,7 @@ class SvgoWrapper
       raise Error, "Unexpected error (#{e.exitstatus})\n"
     end
 
-    raise ParserError, output unless output =~ /<svg/
+    verify_output(output)
     output
   end
 
@@ -60,4 +60,11 @@ class SvgoWrapper
     (disabled.map {|v| "--disable=#{v}".freeze } +
      enabled.map {|v| "--enable=#{v}".freeze }).freeze
   end
+
+  def verify_output(output)
+    return if output =~ /<svg/
+
+    output = "There was a problem optimizing the SVG image with the selected plugins\n" if output.strip.empty?
+    raise ParserError, output
+  end
 end

data/lib/svgo_wrapper/version.rb

@@ -1,3 +1,3 @@
 class SvgoWrapper
-  VERSION = "0.0.3".freeze
+  VERSION = "0.0.4".freeze
 end

data/spec/lib/svgo_wrapper_spec.rb

@@ -152,25 +152,38 @@ describe SvgoWrapper do
       end
     end
 
-    context "`svgo` tool unexpectedly fails" do
-      let(:mocked_status) do
-        # A mock of Process::Status
-        Object.new.tap do |o|
-          o.instance_eval do
-            define_singleton_method :signaled?, proc { false }
-            define_singleton_method :exitstatus, proc { 123 }
-          end
+    describe "`svgo` tool" do
+      context "returns an empty string" do
+        let(:svg_image) { " <svg/>" }
+
+        subject { described_class.new(enable: :transformsWithOnePath).optimize_images_data svg_image }
+
+        it "raises a descriptive exception" do
+          expect { subject }.to raise_error(described_class::ParserError, "There was a problem optimizing the SVG " \
+                                                                          "image with the selected plugins\n")
         end
       end
 
-      subject { described_class.new.optimize_images_data svg_image }
+      context "unexpectedly fails" do
+        let(:mocked_status) do
+          # A mock of Process::Status
+          Object.new.tap do |o|
+            o.instance_eval do
+              define_singleton_method :signaled?, proc { false }
+              define_singleton_method :exitstatus, proc { 123 }
+            end
+          end
+        end
 
-      before(:each) do
-        allow(Open4).to receive(:spawn).and_raise(Open4::SpawnError.new("command example", mocked_status))
-      end
+        subject { described_class.new.optimize_images_data svg_image }
 
-      it "raises a general error" do
-        expect { subject }.to raise_error(described_class::Error, "Unexpected error (123)\n")
+        before(:each) do
+          allow(Open4).to receive(:spawn).and_raise(Open4::SpawnError.new("command example", mocked_status))
+        end
+
+        it "raises a general error" do
+          expect { subject }.to raise_error(described_class::Error, "Unexpected error (123)\n")
+        end
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: svgo_wrapper
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Gabriel de Oliveira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-12 00:00:00.000000000 Z
+date: 2015-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: open4