svg_sprite 1.0.1 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dad974718ab6a4417495499e8aa788e041663a5f11819611e651a2c05bd378da
-  data.tar.gz: e77c32dce5a61f03ddc881f9a3e01895ee79fa7447a3ad2dd770cb39be468a6f
+  metadata.gz: 102ffaf3f4314cb00bea8e473f8d82a20b598a727c522f36ea0443a9ff9ef089
+  data.tar.gz: cd212d62cb0a88314a1f111a6f56de52fbf84a9c5157c706694609fdd7ec8136
 SHA512:
-  metadata.gz: 37b27b2ab2af3ec6a728eee52e636e446eae3a38b1672e853bb72d70c631a6f52bccdf10c94a70a85f0bc6bb15a266a8c0818bcc240c2b6a56037d9443684c71
-  data.tar.gz: 44b8b4bc240067b9e5ee979ecd27f320c83bfbf9a3539e67c2ecee6d3593a6560bed125968118295a6f7cbd7d37762e302af180fe990d0fe7775ae686e65d0b7
+  metadata.gz: e8e0a194d46fd6dbe33ab04c0ea9552a2925d2019e4a62fd5a9f69b9dae07c29b9c7f9f5729dd3c7211664bf2a3b034d663bf6fdc34b33a06425c21bd6815229
+  data.tar.gz: c0a0f242c808e663e3a20f4a688116bb042b730de598ff8827efa80dea47770f79d631b07a809139b64f5cbe7d7163f9d6fb45eb4ba9bd8b6417e78faeb34632

data/.github/workflows/ruby-tests.yml

@@ -24,9 +24,9 @@ jobs:
           - Gemfile
 
     steps:
-      - uses: actions/checkout@v2.4.0
+      - uses: actions/checkout@v3
 
-      - uses: actions/cache@v2
+      - uses: actions/cache@v3
         with:
           path: vendor/bundle
           key: >

data/CHANGELOG.md

@@ -11,6 +11,19 @@ Prefix your message with one of the following:
 - [Security] in case of vulnerabilities.
 -->
 
+## v1.0.3
+
+- [Changed] SVG sprite won't include `display: none` anymore; instead, a class
+  `:name--sprite` is added. This eases the CSP setups, as it won't include a
+  inline style. Make sure you hide the sprite with something like
+  `.icon--sprite { display: none }`.
+
+## v1.0.2
+
+- [Changed] Remove `<symbol>`'s `width` and `height` property, otherwise Google
+  Chrome and Firefox won't be able to resize the SVG properly. The `viewBox`
+  will determine the svg's dimensions.
+
 ## v1.0.1
 
 - [Changed] SVG sprite now includes the sprite name as the id. It means you'll

data/README.md

@@ -1,7 +1,6 @@
 # svg_sprite
 
 [![Tests](https://github.com/fnando/svg_sprite/workflows/ruby-tests/badge.svg)](https://github.com/fnando/svg_sprite)
-[![Code Climate](https://codeclimate.com/github/fnando/svg_sprite/badges/gpa.svg)](https://codeclimate.com/github/fnando/svg_sprite)
 [![Gem](https://img.shields.io/gem/v/svg_sprite.svg)](https://rubygems.org/gems/svg_sprite)
 [![Gem](https://img.shields.io/gem/dt/svg_sprite.svg)](https://rubygems.org/gems/svg_sprite)
 
@@ -165,18 +164,18 @@ SvgSprite.call(
 
 ## Contributors
 
-- https://github.com/fnando/svg_sprite/contributors
+- <https://github.com/fnando/svg_sprite/contributors>
 
 ## Contributing
 
 For more details about how to contribute, please read
-https://github.com/fnando/svg_sprite/blob/main/CONTRIBUTING.md.
+<https://github.com/fnando/svg_sprite/blob/main/CONTRIBUTING.md>.
 
 ## License
 
 The gem is available as open source under the terms of the
 [MIT License](https://opensource.org/licenses/MIT). A copy of the license can be
-found at https://github.com/fnando/svg_sprite/blob/main/LICENSE.md.
+found at <https://github.com/fnando/svg_sprite/blob/main/LICENSE.md>.
 
 ## Code of Conduct
 

data/lib/svg_sprite/svg.rb

@@ -12,10 +12,16 @@ class SvgSprite
       @fill = fill
     end
 
+    def svg
+      @svg ||= xml.css("svg").first
+    end
+
     def symbol
-      @symbol ||= xml.css("svg").first.clone.tap do |node|
+      @symbol ||= svg.clone.tap do |node|
         node.name = "symbol"
         node.set_attribute :id, id
+        node.remove_attribute "width"
+        node.remove_attribute "height"
 
         process_stroke(node)
         process_fill(node)
@@ -23,11 +29,11 @@ class SvgSprite
     end
 
     def width
-      symbol[:width]
+      svg[:width]
     end
 
     def height
-      symbol[:height]
+      svg[:height]
     end
 
     def id

data/lib/svg_sprite/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class SvgSprite
-  VERSION = "1.0.1"
+  VERSION = "1.0.3"
 end

data/lib/svg_sprite.rb

@@ -134,7 +134,7 @@ class SvgSprite
     Nokogiri::XML::Builder.new(encoding: "UTF-8") do |xml|
       xml.svg(
         xmlns: "http://www.w3.org/2000/svg",
-        style: "display: none"
+        class: "#{name}--sprite"
       ) do |svg|
         svg.defs { } # rubocop:disable Lint/EmptyBlock
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: svg_sprite
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.3
 platform: ruby
 authors:
 - Nando Vieira
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-01-05 00:00:00.000000000 Z
+date: 2023-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -227,7 +227,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.3
+rubygems_version: 3.4.3
 signing_key:
 specification_version: 4
 summary: Create SVG sprites using SVG links.