svg_icon 0.2.0 → 0.4.0

data/lib/svg_icon/cli.rb

@@ -0,0 +1,68 @@
+# frozen_string_literal: true
+
+require_relative "fetcher"
+
+module SvgIcon
+  class CLI
+    def self.run(argv)
+      new(argv).run
+    end
+
+    def initialize(argv)
+      @argv = argv
+    end
+
+    def run
+      command = @argv.shift
+      case command
+      when "fetch"
+        fetch
+      when nil, "help", "--help", "-h"
+        puts usage
+      else
+        warn "Unknown command: #{command}"
+        warn usage
+        exit 1
+      end
+    end
+
+    private
+
+    def fetch
+      name = @argv.shift
+      unless valid_name?(name) && @argv.empty?
+        warn "Usage: svg_icon fetch <icon_set_name>"
+        exit 1
+      end
+
+      destination = File.join(SvgIcon.configuration.icons_path, "#{name}.json")
+      puts "Fetching #{name} from iconify/icon-sets"
+      SvgIcon::Fetcher.new.fetch(name, destination)
+      puts "Saved to #{relative_path(destination)}"
+    rescue SvgIcon::FetchError => e
+      warn e.message
+      exit 1
+    rescue StandardError => e
+      warn "Error: #{e.message}"
+      exit 1
+    end
+
+    def valid_name?(name)
+      !name.nil? && name =~ SvgIcon::Fetcher::NAME_PATTERN
+    end
+
+    def relative_path(path)
+      path.sub("#{Dir.pwd}/", "")
+    end
+
+    def usage
+      <<~TEXT
+        Usage: svg_icon COMMAND
+
+        Commands:
+          fetch NAME    Download icon set NAME (e.g. bi) from iconify/icon-sets into #{SvgIcon.configuration.icons_path}
+          help          Show this help
+      TEXT
+    end
+  end
+end

data/lib/svg_icon/configuration.rb

@@ -2,14 +2,16 @@
 
 module SvgIcon
   class Configuration
-    DEFAULT_ICON = "bi"
+    DEFAULT_ICON = "lucide"
 
     attr_accessor :icon
     attr_accessor :default_class
     attr_accessor :extra_icons_path
+    attr_accessor :icons_path
 
     def initialize
       @icon = DEFAULT_ICON
+      @icons_path = File.join(Dir.pwd, "config", "svg_icons")
     end
   end
 
@@ -23,5 +25,6 @@ module SvgIcon
 
   def self.configure
     yield configuration
+    SvgIcon.clear_cache!
   end
 end

data/lib/svg_icon/fetcher.rb

@@ -0,0 +1,73 @@
+# frozen_string_literal: true
+
+require "fileutils"
+require "net/http"
+require "openssl"
+require "tempfile"
+require "uri"
+
+module SvgIcon
+  class FetchError < Error; end
+
+  class Fetcher
+    DEFAULT_BASE_URL = "https://raw.githubusercontent.com/iconify/icon-sets/master/json"
+    NAME_PATTERN = /\A[a-z0-9\-_]+\z/
+
+    def initialize(base_url: DEFAULT_BASE_URL, http: Net::HTTP)
+      @base_url = base_url
+      @http = http
+    end
+
+    def fetch(name, destination)
+      validate_name!(name)
+      response = fetch_response(name)
+      raise FetchError, "Failed to fetch #{name}: HTTP #{response.code}#{not_found_hint(response.code)}" unless response.code == "200"
+
+      parse(response.body, name)
+      write(response.body, destination)
+      true
+    end
+
+    private
+
+    def validate_name!(name)
+      raise FetchError, "Invalid icon set name: #{name}" unless name.is_a?(String) && name =~ NAME_PATTERN
+    end
+
+    def fetch_response(name)
+      @http.get_response(uri_for(name))
+    rescue SocketError, SystemCallError, Timeout::Error, EOFError, IOError, OpenSSL::SSL::SSLError => e
+      raise FetchError, "Failed to fetch #{name}: #{e.message}"
+    end
+
+    def uri_for(name)
+      URI.join("#{@base_url}/", "#{name}.json")
+    end
+
+    def not_found_hint(code)
+      code == "404" ? " (icon set not found)" : ""
+    end
+
+    def parse(body, name)
+      data = MultiJson.load(body)
+      return if data.is_a?(Hash) && data["icons"].is_a?(Hash)
+
+      raise FetchError, "Invalid icon set '#{name}': JSON must contain an 'icons' object"
+    rescue MultiJson::ParseError => e
+      raise FetchError, "Invalid icon set '#{name}': invalid JSON (#{e.message})"
+    end
+
+    def write(body, destination)
+      dir = File.dirname(destination)
+      FileUtils.mkdir_p(dir)
+      temp = Tempfile.new([".#{File.basename(destination)}", ".tmp"], dir)
+      begin
+        temp.write(body)
+        temp.flush
+        File.rename(temp.path, destination)
+      ensure
+        temp.close!
+      end
+    end
+  end
+end

data/lib/svg_icon/helper.rb

@@ -1,31 +1,42 @@
+# frozen_string_literal: true
+
+require "cgi"
+
 module SvgIcon
   module Helper
     def svg_icon(name, options = {})
       options = options.dup
-
       icons = SvgIcon.icons_json
+
       height = icons["height"] || 24
       width = icons["width"] || 24
 
-      options[:viewBox] = "0 0 #{width} #{height}"
-      options[:version] = "1.1"
+      options[:viewBox] ||= "0 0 #{width} #{height}"
 
       default_class = SvgIcon.configuration.default_class
-
       options[:class] = "#{default_class} #{options[:class]}".strip if default_class.present?
 
-      begin
-        path = icons["icons"][name]["body"]
-        "<svg xmlns='http://www.w3.org/2000/svg' #{icon_html_attributes(options)}>#{path}</svg>".html_safe
-      rescue
-        "<svg xmlns='http://www.w3.org/2000/svg' #{icon_html_attributes(options)}><!-- SVG icon file not found: '#{name}' --></svg>".html_safe
+      body = icons.dig("icons", name.to_s, "body")
+
+      content = if body
+        body
+      else
+        "<!-- SVG icon file not found: '#{safe_comment_text(name.to_s)}' -->"
       end
+
+      "<svg xmlns='http://www.w3.org/2000/svg' #{icon_html_attributes(options)}>#{content}</svg>".html_safe
     end
 
+    private
+
     def icon_html_attributes(options)
-      attrs = ""
-      options.each { |attr, value| attrs += "#{attr}=\"#{value}\" " }
-      attrs.strip
+      options.map do |attr, value|
+        %(#{CGI.escapeHTML(attr.to_s)}="#{CGI.escapeHTML(value.to_s)}")
+      end.join(" ")
+    end
+
+    def safe_comment_text(value)
+      CGI.escapeHTML(value).gsub("-", "&#45;")
     end
   end
 end

data/lib/svg_icon/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SvgIcon
-  VERSION = "0.2.0"
+  VERSION = "0.4.0"
 end

data/lib/svg_icon.rb

@@ -5,50 +5,106 @@ require_relative "svg_icon/helper"
 require_relative "svg_icon/version"
 
 require "multi_json"
+require "active_support/core_ext/object/blank"
+require "active_support/core_ext/string/output_safety"
 
 module SvgIcon
   class Error < StandardError; end
 
+  require_relative "svg_icon/fetcher"
+  require_relative "svg_icon/cli"
+
   extend self
 
-  def extra_file_data
-    extra_data_path = SvgIcon.configuration.extra_icons_path
-    return nil if extra_data_path.nil?
-    @extra_file_data ||= File.read(extra_data_path)
+  def icons
+    @icons ||= {}
+    @icons[file_cache_key_for(resolve_icon_path)] ||= MultiJson.load(file_data)
   end
 
-  def extra_icons
-    return {} if extra_file_data.nil?
-    @extra_icons ||= MultiJson.load(extra_file_data)
+  def icons_json
+    @icons_json ||= {}
+    @icons_json[cache_key] ||= merge_extra_icons(icons)
   end
 
-  # def file_data
-  #   icons_data_path = SvgIcon.configuration.icons_data_path
+  def clear_cache!
+    @file_data = nil
+    @icons = nil
+    @icons_json = nil
+    @extra_file_data = nil
+    @extra_icons = nil
+  end
+
+  private
 
-  #   icons_path = if icons_data_path.present?
-  #     File.join(icons_data_path)
-  #   else
-  #     File.join(__dir__, "data/#{SvgIcon.configuration.icon}.json")
-  #   end
-  #   @file_data ||= File.read(icons_path)
-  # end
+  def icon
+    configuration.icon
+  end
+
+  def configuration
+    SvgIcon.configuration
+  end
 
   def file_data
-    icons_path = File.join(__dir__, "data/#{SvgIcon.configuration.icon}.json")
-    @file_data ||= File.read(icons_path)
+    @file_data ||= {}
+    @file_data[file_cache_key_for(resolve_icon_path)] ||= begin
+      path = resolve_icon_path
+      raise Error, "Icon data file not found: #{icon} (looked in #{configuration.icons_path} and bundled data)" unless File.exist?(path)
+
+      File.read(path)
+    end
   end
 
-  def icons
-    @icons ||= MultiJson.load(file_data)
+  def resolve_icon_path
+    external = File.join(configuration.icons_path, "#{icon}.json")
+    return external if File.exist?(external)
+
+    File.join(__dir__, "data", "#{icon}.json")
   end
 
-  def icons_json
-    @icons_json ||= if extra_icons
-      puts "icons_json"
-      icons["icons"] = icons["icons"].merge(extra_icons)
-      icons
-    else
-      icons
+  def file_cache_key_for(path)
+    return nil unless path
+
+    "#{path}:#{File.exist?(path) ? File.mtime(path).to_i : nil}"
+  end
+
+  def extra_icons
+    return {} unless configuration.extra_icons_path
+
+    @extra_icons ||= {}
+    @extra_icons[file_cache_key_for(extra_path)] ||= begin
+      data = MultiJson.load(extra_file_data)
+      raise Error, "Extra icons file must contain a JSON object: #{extra_path}" unless data.is_a?(Hash)
+
+      data
     end
   end
+
+  def extra_path
+    configuration.extra_icons_path
+  end
+
+  def extra_file_data
+    @extra_file_data ||= {}
+    @extra_file_data[file_cache_key_for(extra_path)] ||= begin
+      path = extra_path
+      raise Error, "Extra icons file not found: #{path}" unless File.exist?(path)
+
+      File.read(path)
+    end
+  end
+
+  def merge_extra_icons(base_icons)
+    icons_set = base_icons["icons"]
+    raise Error, "Icon data must contain an 'icons' object: #{resolve_icon_path}" unless icons_set.is_a?(Hash)
+
+    return base_icons if extra_icons.empty?
+
+    merged = base_icons.dup
+    merged["icons"] = icons_set.merge(extra_icons)
+    merged
+  end
+
+  def cache_key
+    "#{icon}:#{file_cache_key_for(resolve_icon_path)}:#{file_cache_key_for(extra_path)}"
+  end
 end

data/svg_icon.gemspec

@@ -26,6 +26,8 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  # Uncomment to register a new dependency of your gem
   spec.add_dependency "multi_json"
+  spec.add_dependency "activesupport", ">= 5.0"
+
+  spec.add_development_dependency "minitest"
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: svg_icon
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.4.0
 platform: ruby
 authors:
 - doabit
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-03-31 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -24,10 +23,39 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Svg icon render helper for rails.
 email:
 - doinsist@gmail.com
-executables: []
+executables:
+- svg_icon
 extensions: []
 extra_rdoc_files: []
 files:
@@ -38,11 +66,17 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
+- docs/superpowers/plans/2026-08-18-svg-icon-fetch-cli.md
+- docs/superpowers/specs/2026-08-18-svg-icon-fetch-design.md
+- exe/svg_icon
 - lib/data/bi.json
 - lib/data/bx.json
 - lib/data/heroicons.json
+- lib/data/lucide.json
 - lib/svg_icon.rb
+- lib/svg_icon/cli.rb
 - lib/svg_icon/configuration.rb
+- lib/svg_icon/fetcher.rb
 - lib/svg_icon/helper.rb
 - lib/svg_icon/version.rb
 - svg_icon.gemspec
@@ -52,7 +86,6 @@ metadata:
   homepage_uri: https://github.com/ruby-gems/svg_icon
   source_code_uri: https://github.com/ruby-gems/svg_icon
   changelog_uri: https://github.com/ruby-gems/svg_icon
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -67,8 +100,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Svg icon render helper for rails
 test_files: []