svg_conform 0.1.2 → 0.1.3

data/lib/svg_conform/requirements/allowed_elements_requirement.rb

@@ -121,6 +121,13 @@ module SvgConform
       end
 
       def validate_sax_element(element, context)
+        # Skip if parent is structurally invalid (matches DOM behavior)
+        if element.parent && context.node_structurally_invalid?(element.parent)
+          # Mark this element as invalid too since it won't be in final document
+          context.mark_node_structurally_invalid(element)
+          return
+        end
+
         # Skip foreign namespace elements if configured (let NamespaceRequirement handle them)
         if skip_foreign_namespaces && foreign_namespace_sax?(element)
           return
@@ -135,7 +142,7 @@ module SvgConform
             message: "Element '#{element_name}' is not allowed in this profile",
             node: element,
             severity: :error,
-            data: { element: element_name }
+            data: { element: element_name },
           )
           return
         end
@@ -149,7 +156,7 @@ module SvgConform
               message: "The element '#{element_name}' is not allowed as a child of '#{parent_name}'",
               node: element,
               severity: :error,
-              data: { element: element_name, parent: parent_name }
+              data: { element: element_name, parent: parent_name },
             )
             # Mark node as structurally invalid
             context.mark_node_structurally_invalid(element)
@@ -166,7 +173,7 @@ module SvgConform
               message: "Element '#{element_name}' is not allowed in this profile",
               node: element,
               severity: :error,
-              data: { element: element_name }
+              data: { element: element_name },
             )
             # Mark as structurally invalid
             context.mark_node_structurally_invalid(element)
@@ -184,7 +191,7 @@ module SvgConform
             requirement_id: id,
             message: error[:message],
             node: element,
-            severity: :error
+            severity: :error,
           )
         end
       end
@@ -339,7 +346,13 @@ module SvgConform
       def foreign_namespace_sax?(element)
         return false unless skip_foreign_namespaces
 
-        # Check if element has a namespace
+        # Check if element name has a namespace prefix (e.g., rdf:RDF, cc:Work)
+        if element.name.include?(":")
+          # Element has prefix, it's in a foreign namespace
+          return true
+        end
+
+        # Also check xmlns attribute
         element_namespace = element.namespace
 
         # No namespace or empty namespace means SVG namespace (default)
@@ -374,7 +387,9 @@ module SvgConform
 
         return errors unless element_configs&.any?
 
-        element_config = element_configs.find { |config| config.tag == element_name }
+        element_config = element_configs.find do |config|
+          config.tag == element_name
+        end
         return errors unless element_config&.attr
 
         allowed_attrs = []
@@ -414,6 +429,11 @@ module SvgConform
           attr_name = attr.name.downcase
           next if attr_name.start_with?("xmlns:")
           next if attr_name.start_with?("xml:")
+
+          # Skip namespaced attributes (those with colon prefix like inkscape:label)
+          # This matches DOM behavior where XPath skips attributes with namespaces
+          next if attr_name.include?(":") && !attr_name.start_with?("xmlns:")
+
           next if attr.namespace
           next if attr_name.start_with?("data-")
 
@@ -422,7 +442,7 @@ module SvgConform
             errors << {
               type: :explicitly_disallowed,
               attribute: attr_name,
-              message: "Attribute '#{attr_name}' is explicitly disallowed on element '#{element_name}'"
+              message: "Attribute '#{attr_name}' is explicitly disallowed on element '#{element_name}'",
             }
             next
           end
@@ -433,7 +453,7 @@ module SvgConform
           errors << {
             type: :not_allowed,
             attribute: attr_name,
-            message: "Attribute '#{attr_name}' is not allowed on element '#{element_name}'"
+            message: "Attribute '#{attr_name}' is not allowed on element '#{element_name}'",
           }
         end
 
@@ -462,7 +482,7 @@ module SvgConform
           errors << {
             type: :globally_disallowed,
             attribute: attr_name,
-            message: "Attribute '#{attr_name}' is globally disallowed in this profile"
+            message: "Attribute '#{attr_name}' is globally disallowed in this profile",
           }
         end
 

data/lib/svg_conform/requirements/color_restrictions_requirement.rb

@@ -85,7 +85,8 @@ module SvgConform
         return if context.node_structurally_invalid?(element)
 
         # Check color-related attributes
-        color_attributes = %w[fill stroke color stop-color flood-color lighting-color]
+        color_attributes = %w[fill stroke color stop-color flood-color
+                              lighting-color]
 
         color_attributes.each do |attr_name|
           value = element.raw_attributes[attr_name]
@@ -101,8 +102,8 @@ module SvgConform
             data: {
               attribute: attr_name,
               value: value,
-              element: element.name
-            }
+              element: element.name,
+            },
           )
         end
 
@@ -111,7 +112,8 @@ module SvgConform
         return unless style_value
 
         styles = parse_style(style_value)
-        color_properties = %w[fill stroke color stop-color flood-color lighting-color]
+        color_properties = %w[fill stroke color stop-color flood-color
+                              lighting-color]
 
         color_properties.each do |prop|
           value = styles[prop]
@@ -127,8 +129,8 @@ module SvgConform
             data: {
               attribute: prop,
               value: value,
-              element: element.name
-            }
+              element: element.name,
+            },
           )
         end
       end

data/lib/svg_conform/requirements/font_family_requirement.rb

@@ -47,19 +47,23 @@ module SvgConform
       end
 
       def validate_sax_element(element, context)
+        # Skip if parent is structurally invalid
+        return if element.parent && context.node_structurally_invalid?(element.parent)
+
         # Check font-family attribute only
         font_family = element.raw_attributes["font-family"]
         return unless font_family
 
         if svgcheck_compatibility
-          check_font_family_svgcheck_mode(element, context, font_family, "font-family")
+          check_font_family_svgcheck_mode(element, context, font_family,
+                                          "font-family")
         elsif !valid_font_family?(font_family)
           context.add_error(
             requirement_id: id,
             message: "Font family '#{font_family}' is not allowed in this profile",
             node: element,
             severity: :error,
-            data: { attribute: "font-family", value: font_family }
+            data: { attribute: "font-family", value: font_family },
           )
         end
       end

data/lib/svg_conform/requirements/forbidden_content_requirement.rb

@@ -63,7 +63,7 @@ module SvgConform
             requirement_id: id,
             message: "Forbidden element '#{element.name}' is not allowed",
             node: element,
-            severity: :error
+            severity: :error,
           )
         end
 
@@ -76,7 +76,7 @@ module SvgConform
               requirement_id: id,
               message: "Forbidden attribute '#{attr_name}' is not allowed",
               node: element,
-              severity: :error
+              severity: :error,
             )
           end
         end

data/lib/svg_conform/requirements/id_reference_requirement.rb

@@ -10,7 +10,7 @@ module SvgConform
         true
       end
 
-      def collect_sax_data(element, context)
+      def collect_sax_data(element, _context)
         # Initialize collections on first call
         @collected_ids ||= Set.new
         @collected_url_refs ||= []
@@ -22,7 +22,8 @@ module SvgConform
         @collected_ids.add(id_value) if id_value && !id_value.empty?
 
         # Collect url() references
-        url_attributes = %w[fill stroke marker-start marker-mid marker-end clip-path mask filter]
+        url_attributes = %w[fill stroke marker-start marker-mid marker-end
+                            clip-path mask filter]
         url_attributes.each do |attr_name|
           attr_value = element.raw_attributes[attr_name]
           next unless attr_value
@@ -45,12 +46,13 @@ module SvgConform
         # Collect href references
         href_value = element.raw_attributes["href"] || element.raw_attributes["xlink:href"]
         if href_value&.start_with?("#")
-          ref_id = href_value[1..]  # Remove #
+          ref_id = href_value[1..] # Remove #
           @collected_href_refs << [element, ref_id]
         end
 
         # Collect other ID references
-        id_ref_attributes = %w[for aria-labelledby aria-describedby aria-controls aria-owns]
+        id_ref_attributes = %w[for aria-labelledby aria-describedby
+                               aria-controls aria-owns]
         id_ref_attributes.each do |attr_name|
           attr_value = element.raw_attributes[attr_name]
           next unless attr_value
@@ -58,6 +60,7 @@ module SvgConform
           ref_ids = attr_value.split(/\s+/)
           ref_ids.each do |ref_id|
             next if ref_id.empty?
+
             @collected_other_refs << [element, ref_id, attr_name]
           end
         end
@@ -77,7 +80,7 @@ module SvgConform
           context.add_error(
             node: element,
             message: message,
-            requirement_id: id
+            requirement_id: id,
           )
         end
 
@@ -87,7 +90,7 @@ module SvgConform
           context.add_error(
             node: element,
             message: "Reference to undefined ID '#{ref_id}' in href attribute",
-            requirement_id: id
+            requirement_id: id,
           )
         end
 
@@ -97,7 +100,7 @@ module SvgConform
           context.add_error(
             node: element,
             message: "Reference to undefined ID '#{ref_id}' in #{attr_name} attribute",
-            requirement_id: id
+            requirement_id: id,
           )
         end
       end

data/lib/svg_conform/requirements/invalid_id_references_requirement.rb

@@ -24,15 +24,15 @@ module SvgConform
       def initialize(*args)
         super
         @collected_ids = Set.new
-        @use_element_refs = []  # [element, ref_id, href]
-        @other_refs = []  # [element, ref_id, attr_name, value]
+        @use_element_refs = [] # [element, ref_id, href]
+        @other_refs = [] # [element, ref_id, attr_name, value]
       end
 
       def needs_deferred_validation?
         true
       end
 
-      def collect_sax_data(element, context)
+      def collect_sax_data(element, _context)
         # Initialize collections on first call
         @collected_ids ||= Set.new
         @use_element_refs ||= []
@@ -53,7 +53,8 @@ module SvgConform
 
         # Collect other ID references if enabled
         if check_other_references
-          id_reference_attributes = %w[clip-path mask filter marker-start marker-mid marker-end fill stroke]
+          id_reference_attributes = %w[clip-path mask filter marker-start
+                                       marker-mid marker-end fill stroke]
 
           id_reference_attributes.each do |attr_name|
             attr_value = element.raw_attributes[attr_name]
@@ -87,7 +88,7 @@ module SvgConform
             node: element,
             message: "use element references non-existent ID: #{ref_id}",
             severity: :error,
-            data: { invalid_id: ref_id, href: href }
+            data: { invalid_id: ref_id, href: href },
           )
         end
 
@@ -107,7 +108,7 @@ module SvgConform
             node: element,
             message: message,
             severity: :error,
-            data: { invalid_id: ref_id, attribute: attr_name, value: value }
+            data: { invalid_id: ref_id, attribute: attr_name, value: value },
           )
         end
       end

data/lib/svg_conform/requirements/link_validation_requirement.rb

@@ -54,7 +54,7 @@ module SvgConform
             requirement_id: id,
             message: "Link href '#{href_value}' contains non-ASCII characters",
             node: element,
-            severity: :error
+            severity: :error,
           )
         end
 
@@ -70,7 +70,7 @@ module SvgConform
             requirement_id: id,
             message: "IRI attribute '#{attr_name}' value '#{iri_value}' contains non-ASCII characters",
             node: element,
-            severity: :error
+            severity: :error,
           )
         end
       end

data/lib/svg_conform/requirements/namespace_attributes_requirement.rb

@@ -42,8 +42,16 @@ module SvgConform
       end
 
       def validate_sax_element(element, context)
+        # Extract local name without prefix for exemption check
+        local_name = if element.name.include?(":")
+                       element.name.split(":",
+                                          2).last
+                     else
+                       element.name
+                     end
+
         # Skip validation for exempt elements (e.g., RDF metadata elements)
-        return if exempt_elements.include?(element.name)
+        return if exempt_elements.include?(local_name) || exempt_elements.include?(element.name)
 
         # Check all attributes for namespace violations
         element.attributes.each do |attr|
@@ -67,12 +75,12 @@ module SvgConform
 
         # Determine if this namespace is invalid based on configuration
         invalid_namespace = if allowed_namespaces.empty?
-                             # Blacklist mode: disallowed namespaces are forbidden
-                             disallowed_namespaces.include?(namespace_uri)
-                           else
-                             # Whitelist mode: only allowed namespaces are permitted
-                             !allowed_namespaces.include?(namespace_uri)
-                           end
+                              # Blacklist mode: disallowed namespaces are forbidden
+                              disallowed_namespaces.include?(namespace_uri)
+                            else
+                              # Whitelist mode: only allowed namespaces are permitted
+                              !allowed_namespaces.include?(namespace_uri)
+                            end
 
         return unless invalid_namespace
 
@@ -81,7 +89,7 @@ module SvgConform
           message: "Element '#{element.name}' does not allow attributes with namespace '#{namespace_uri}'",
           node: element,
           severity: :error,
-          data: { attribute: attr_name, namespace: namespace_uri }
+          data: { attribute: attr_name, namespace: namespace_uri },
         )
       end
 
@@ -100,8 +108,6 @@ module SvgConform
         nil
       end
 
-      private
-
       def check_attribute_nodes(node, context)
         node.attribute_nodes.each do |attr|
           # Check if attribute has a namespace

data/lib/svg_conform/requirements/namespace_requirement.rb

@@ -213,8 +213,8 @@ module SvgConform
             data: {
               element_name: element.name,
               namespace: element_namespace,
-              allowed_namespaces: effective_allowed_namespaces
-            }
+              allowed_namespaces: effective_allowed_namespaces,
+            },
           )
           return
         end
@@ -230,24 +230,25 @@ module SvgConform
           data: {
             element_name: element.name,
             namespace: element_namespace,
-            disallowed_namespaces: disallowed_namespaces
-          }
+            disallowed_namespaces: disallowed_namespaces,
+          },
         )
       end
 
       private
 
       def get_element_namespace_sax(element)
-        # Try to get namespace from the element
-        namespace = element.namespace
-        return namespace if namespace && !namespace.empty?
-
-        # If no namespace found, check if element has a prefix (indicating it's namespaced)
+        # Check if element name has a namespace prefix (e.g., rdf:RDF, cc:Work)
         if element.name.include?(":")
           prefix = element.name.split(":").first
-          return find_namespace_uri_for_prefix_sax(element, prefix)
+          namespace_uri = find_namespace_uri_for_prefix_sax(element, prefix)
+          return namespace_uri if namespace_uri
         end
 
+        # Try to get namespace from xmlns attribute
+        namespace = element.namespace
+        return namespace if namespace && !namespace.empty?
+
         nil
       end
 

data/lib/svg_conform/requirements/no_external_css_requirement.rb

@@ -131,7 +131,7 @@ module SvgConform
               requirement_id: id,
               message: "External CSS import not allowed: #{url}",
               node: element,
-              severity: :error
+              severity: :error,
             )
           end
         end
@@ -145,7 +145,7 @@ module SvgConform
           requirement_id: id,
           message: "External CSS import not allowed: #{url}",
           node: element,
-          severity: :error
+          severity: :error,
         )
       end
 
@@ -161,7 +161,7 @@ module SvgConform
           requirement_id: id,
           message: "External CSS link not allowed: #{href}",
           node: element,
-          severity: :error
+          severity: :error,
         )
       end
 
@@ -179,7 +179,7 @@ module SvgConform
           requirement_id: id,
           message: "External URL reference in style attribute not allowed: #{url}",
           node: element,
-          severity: :error
+          severity: :error,
         )
       end
 

data/lib/svg_conform/requirements/no_external_fonts_requirement.rb

@@ -127,7 +127,7 @@ module SvgConform
                 requirement_id: id,
                 message: "External font reference not allowed: #{url}. Fonts must be embedded as data URIs.",
                 node: element,
-                severity: :error
+                severity: :error,
               )
             end
           end
@@ -154,7 +154,7 @@ module SvgConform
           requirement_id: id,
           message: "External font URL in style attribute not allowed: #{url}. Fonts must be embedded as data URIs.",
           node: element,
-          severity: :error
+          severity: :error,
         )
       end
 

data/lib/svg_conform/requirements/no_external_images_requirement.rb

@@ -88,7 +88,7 @@ module SvgConform
           requirement_id: id,
           message: "External image reference not allowed: #{href}. Images must be embedded as data URIs.",
           node: element,
-          severity: :error
+          severity: :error,
         )
       end
 
@@ -105,7 +105,7 @@ module SvgConform
             requirement_id: id,
             message: "External image URL in style attribute not allowed: #{url}. Images must be embedded as data URIs.",
             node: element,
-            severity: :error
+            severity: :error,
           )
         end
       end

data/lib/svg_conform/requirements/style_promotion_requirement.rb

@@ -20,6 +20,13 @@ module SvgConform
         end
       end
 
+      def validate_sax_element(element, context)
+        style_attr = element.raw_attributes["style"]
+        return if style_attr.nil? || style_attr.strip.empty?
+
+        validate_style_properties(element, style_attr, context)
+      end
+
       private
 
       def validate_style_properties(element, style_attr, context)

data/lib/svg_conform/requirements/viewbox_required_requirement.rb

@@ -95,7 +95,7 @@ module SvgConform
             message: "SVG root element must have a viewBox attribute",
             node: element,
             severity: :error,
-            data: { missing_attribute: "viewBox" }
+            data: { missing_attribute: "viewBox" },
           )
 
           # Add informational message about calculated viewBox if width/height are present
@@ -112,8 +112,8 @@ module SvgConform
               data: {
                 calculated_viewbox: calculated_viewbox,
                 source_width: width,
-                source_height: height
-              }
+                source_height: height,
+              },
             )
           end
           return
@@ -130,8 +130,8 @@ module SvgConform
             severity: :error,
             data: {
               viewbox_value: viewbox,
-              parsed_parts: parts
-            }
+              parsed_parts: parts,
+            },
           )
           return
         end
@@ -150,8 +150,8 @@ module SvgConform
           data: {
             viewbox_value: viewbox,
             width: width,
-            height: height
-          }
+            height: height,
+          },
         )
       end
 

data/lib/svg_conform/sax_document.rb

@@ -27,14 +27,14 @@ module SvgConform
     def validate_with_profile(profile)
       handler = SaxValidationHandler.new(profile)
       parser = Nokogiri::XML::SAX::Parser.new(handler)
-      
+
       begin
         parser.parse(@content)
       rescue StandardError => e
         # Handle parse errors
         handler.add_parse_error(e)
       end
-      
+
       handler.result
     end
 

data/lib/svg_conform/sax_validation_handler.rb

@@ -13,11 +13,11 @@ module SvgConform
 
     def initialize(profile)
       @profile = profile
-      @element_stack = []  # Track parent-child hierarchy
-      @path_stack = []  # Current element path
-      @position_counters = []  # Stack of sibling counters per level
+      @element_stack = [] # Track parent-child hierarchy
+      @path_stack = [] # Current element path
+      @position_counters = [] # Stack of sibling counters per level
       @parse_errors = []
-      @result = nil  # Will be set in end_document
+      @result = nil # Will be set in end_document
 
       # Create validation context (without document reference for SAX)
       @context = create_sax_context
@@ -50,13 +50,13 @@ module SvgConform
         attributes: attrs,
         position: position,
         path: @path_stack.dup,
-        parent: @element_stack.last
+        parent: @element_stack.last,
       )
 
       # Push to stacks
       @element_stack.push(element)
       @path_stack.push("#{name}[#{position}]")
-      @position_counters.push({})  # New level for this element's children
+      @position_counters.push({}) # New level for this element's children
 
       # Validate with immediate requirements
       @immediate_requirements.each do |req|
@@ -65,12 +65,15 @@ module SvgConform
 
       # Deferred requirements may need to collect data
       @deferred_requirements.each do |req|
-        req.collect_sax_data(element, @context) if req.respond_to?(:collect_sax_data)
+        if req.respond_to?(:collect_sax_data)
+          req.collect_sax_data(element,
+                               @context)
+        end
       end
     end
 
     # SAX Event: Element end tag
-    def end_element(name)
+    def end_element(_name)
       @element_stack.pop
       @path_stack.pop
       @position_counters.pop
@@ -79,6 +82,7 @@ module SvgConform
     # SAX Event: Text content
     def characters(string)
       return if @element_stack.empty?
+
       @element_stack.last.text_content << string
     end
 
@@ -109,7 +113,7 @@ module SvgConform
         node: nil,
         message: "Parse error: #{error.message}",
         requirement_id: "parse_error",
-        severity: :error
+        severity: :error,
       )
     end
 
@@ -138,7 +142,7 @@ module SvgConform
       context.instance_variable_set(:@data, {})
       context.instance_variable_set(:@structurally_invalid_node_ids, Set.new)
       context.instance_variable_set(:@node_id_cache, {})
-      context.instance_variable_set(:@cache_populated, true)  # Skip population for SAX
+      context.instance_variable_set(:@cache_populated, true) # Skip population for SAX
       context
     end