svelte-on-rails 22.0.3 → 22.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 89170a8dfaf49bc474ff1edfd3ba74a78d64dd54af2913cd29cbfd754b06c394
-  data.tar.gz: adf0042767c8fd3449d5c1ffcc015e15de6f5240fb2af5a7c3245ec6f718e1cf
+  metadata.gz: 7f30afd891885bd5b9d03aacb948116be1d32838d08c9d29589b5d3d68d31317
+  data.tar.gz: cbd63f36144fac966013a5b6d9e1bcfca9070a56c8367eaff8ff2033ab628ff2
 SHA512:
-  metadata.gz: d81f67a3ece83223ba30d35cbda6f070179ec9f7dccc85d6957a410c781dac760e83fd72e3b93781135eb1a080ec6e2f19c6789cff11e2b10d223cc4ea843822
-  data.tar.gz: e2ab8b1d993c31c743fe35929e6a6efd5ffc364f684264c70e3d9a6b2a3a5304c584d2fe959b759f542396b5c0b76d07acc5af8e5a1883c07cba970b2cd014f0
+  metadata.gz: acfe1cb4a3c02e70f979097867ab426b46b98025c88326831d41c229a41b9e468d2a8a76ae4cb9c35be9e3ba3ed3ff750e3edb2f80d52587de207ffafc62c085
+  data.tar.gz: 1c5aa90cbc05f1eeef827957035a894eb721ec957223a9230fce24ae0db48ce2c500ad8d19b901a5836431fa70127d7925b01ffa88344c243eb614711c31b7f5

data/lib/svelte_on_rails/lib/utils.rb

@@ -153,25 +153,20 @@ module SvelteOnRails
         trace[0..last_match_index]
       end
 
-      # Log for debugging purposes
-      def self.secure_debug_log(line)
+      def self.ssr_server_logfile
+          Rails.root.join("log", "svelte-ssr-server.log")
+      end
 
-        puts "[SOR] #{line}"
+      def self.ssr_server_log(msg)
+        File.open(ssr_server_logfile, 'a') do |f|
+          f.sync = true
+          f.puts("[#{Time.now.utc.iso8601(3)} ppid:#{Process.ppid} pid:#{Process.pid}] #{msg}")
+        end
+        puts "[SOR] #{msg}"
         $stdout.flush
+      end
 
-        # base = Rails.root.join('tmp')
-
-        # FileUtils.mkdir_p(base) unless File.directory?(base)
-        # path = File.join(base.to_s, 'svelte-on-rails.log')
 
-        # File.open(path, 'a') do |f|
-        #   f.sync = true
-        #   f.puts("[#{Time.now.utc.iso8601(3)}] [pid=#{Process.pid}] #{line}")
-        # end
-      rescue => e
-        # Last resort: write the failure itself to stderr; never raise.
-        warn "[SOR] sor_debug_log failed: #{e.class}: #{e.message}"
-      end
     end
   end
 end

data/lib/svelte_on_rails/railtie.rb

@@ -18,12 +18,10 @@ module SvelteOnRails
       app.config.after_initialize do
 
         if defined?(Rake) && Rake.respond_to?(:application) && Rake.application.top_level_tasks.any?
-          puts "[Skipping svelte-on-rails SSR-Server because of top level task: #{Rake.application.top_level_tasks.join(', ')}]"
+          SvelteOnRails::Lib::Utils.ssr_server_log("Skipping svelte-on-rails SSR-Server because of top level task: #{Rake.application.top_level_tasks.join(', ')}")
           $stdout.flush
         elsif SvelteOnRails::Configuration.instance.configs[:ssr]
-          SvelteOnRails::Lib::Utils.secure_debug_log("Initializing SSR client")
           SvelteOnRails::SsrServer.instance
-          SvelteOnRails::Lib::Utils.secure_debug_log("Initializing SSR client finished")
         end
 
       end

data/lib/svelte_on_rails/ssr_server.rb

@@ -15,16 +15,14 @@ module SvelteOnRails
     # methods
 
     def self.instance
-      SvelteOnRails::Lib::Utils.secure_debug_log("SOR Server instance called")
       @instance ||= new
     end
 
     def initialize
 
-      SvelteOnRails::Lib::Utils.secure_debug_log("SOR Server initialize called")
+      SvelteOnRails::Lib::Utils.ssr_server_logfile.delete if SvelteOnRails::Lib::Utils.ssr_server_logfile.exist?
 
       @helpers = SsrServerHelpers.new
-      @helpers.logfile.delete if @helpers.logfile.exist?
 
       @logfile_path = Rails.root.join("log/svelte-ssr-server-#{Rails.env}.log")
       @logfile_max_lines = build_logfile_max_lines
@@ -35,21 +33,16 @@ module SvelteOnRails
       File.delete(restart_marker_file) if File.exist?(restart_marker_file)
 
       if @ssr_server
-        # if !defined?(Rails::Server)
-        #   SvelteOnRails::Lib::Utils.secure_debug_log("Rails Server is not yet defined, SSR Server cannot be started because of initializing too early")
-        # else
-
-        SvelteOnRails::Lib::Utils.secure_debug_log("SOR using svelte-ssr-server called, now starting node-server...")
 
         start_node_server!
-        # end
+
         at_exit do
           @helpers.shutdown
           File.delete(restart_marker_file) if File.exist?(restart_marker_file)
         end
       else
-        SvelteOnRails::Lib::Utils.secure_debug_log("SSR Server NOT used => @ssr_server #{@ssr_server}")
-        SvelteOnRails::Lib::Utils.secure_debug_log("SSR Server NOT used => @ssr_server #{defined?(Rails::Server)}")
+        SvelteOnRails::Lib::Utils.ssr_server_log("SSR Server NOT used => @ssr_server #{@ssr_server}")
+        SvelteOnRails::Lib::Utils.ssr_server_log("SSR Server NOT used => @ssr_server #{defined?(Rails::Server)}")
       end
 
     end
@@ -174,8 +167,7 @@ module SvelteOnRails
       restart_after_failure: false
     )
 
-      @helpers.secure_log("test log")
-      SvelteOnRails::Lib::Utils.secure_debug_log("SOR start_node_server! called") if restart_after_failure
+      SvelteOnRails::Lib::Utils.ssr_server_log("SOR start_node_server! called") if restart_after_failure
 
       # notice ppid
       FileUtils.mkdir_p(@helpers.ssr_server_ppid_file.dirname)
@@ -195,28 +187,28 @@ module SvelteOnRails
           status: status
         }
       end
-      @helpers.secure_log("Node Version: #{Configuration.instance.node_version_test}, package version: #{Configuration.instance.npm_package_version_test}")
-      @helpers.secure_log("Start running Svelte-SSR-Server... (#{started_by})")
+      SvelteOnRails::Lib::Utils.ssr_server_log("Node Version: #{Configuration.instance.node_version_test}, package version: #{Configuration.instance.npm_package_version_test}")
+      SvelteOnRails::Lib::Utils.ssr_server_log("Start running Svelte-SSR-Server... (#{started_by})")
 
       until node_server_pid do
         sleep 0.12
-        @helpers.secure_log("Waiting for node server process-id")
+        SvelteOnRails::Lib::Utils.ssr_server_log("Waiting for node server process-id")
         start_server_timeout!(start)
       end
 
       until File.exist?(socket_path) do
         sleep 0.1
-        @helpers.secure_log("Waiting for socket to be created")
+        SvelteOnRails::Lib::Utils.ssr_server_log("Waiting for socket to be created")
         start_server_timeout!(start)
       end
-      @helpers.secure_log("Socket created: #{socket_path}")
+      SvelteOnRails::Lib::Utils.ssr_server_log("Socket created: #{socket_path}")
 
       until ping? do
-        @helpers.secure_log("Waiting for successful server-response")
+        SvelteOnRails::Lib::Utils.ssr_server_log("Waiting for successful server-response")
         start_server_timeout!(start)
         sleep 0.1
       end
-      @helpers.secure_log("Server responded successfully")
+      SvelteOnRails::Lib::Utils.ssr_server_log("Server responded successfully")
 
       @helpers.cleanup_leftover_processes
     end
@@ -225,7 +217,7 @@ module SvelteOnRails
 
       marker = restart_marker_file
       if File.exist?(marker) && File.mtime(marker) > 10.seconds.ago
-        SvelteOnRails::Lib::Utils.secure_debug_log("[ERROR] Prevented Server Restart because server was restarted too recently: #{marker}")
+        SvelteOnRails::Lib::Utils.ssr_server_log("[ERROR] Prevented Server Restart because server was restarted too recently: #{marker}")
         return
       end
 
@@ -235,7 +227,7 @@ module SvelteOnRails
 
       msg = "Restarting SSR server (#{tag})"
       Rails.logger.error(msg)
-      SvelteOnRails::Lib::Utils.secure_debug_log("[ERROR] #{msg}")
+      SvelteOnRails::Lib::Utils.ssr_server_log("[ERROR] #{msg}")
 
       @helpers.shutdown
       begin
@@ -367,7 +359,7 @@ module SvelteOnRails
       FileUtils.mkdir_p(dir)
       FileUtils.chmod(0777, dir)
       fallback = Pathname.new("#{dir}/#{@socket_namespace}-#{ppid}.sock")
-      secure_log("sockets longer than 104 chars are risky, fallback to: #{fallback}")
+      SvelteOnRails::Lib::Utils.ssr_server_log("sockets longer than 104 chars are risky, fallback to: #{fallback}")
       fallback
     end
 
@@ -407,19 +399,6 @@ module SvelteOnRails
       File.delete(ssr_server_ppid_file) if File.exist?(ssr_server_ppid_file)
     end
 
-    def secure_log(msg)
-
-      File.open(logfile, 'a') do |f|
-        f.sync = true
-        f.puts("[#{Time.now.utc.iso8601(3)} ppid:#{Process.ppid} pid:#{Process.pid}] #{msg}")
-      end
-
-    end
-
-    def logfile
-      Rails.root.join("log", "svelte_ssr_server.log")
-    end
-
     private
 
     # Cluster mode: a primary + N workers share one socket path.
@@ -431,7 +410,7 @@ module SvelteOnRails
         Process.kill("SIGINT", p.pid) rescue Errno::ESRCH || Errno::EPERM
       end
 
-      secure_log("Killed #{processes.length} #{label} process#{'es' if processes.length != 1}")
+      SvelteOnRails::Lib::Utils.ssr_server_log("Killed #{processes.length} #{label} process#{'es' if processes.length != 1}")
     end
 
     def delete_sockets(socket_paths, label:)
@@ -443,7 +422,7 @@ module SvelteOnRails
         # raced with primary's own cleanup — fine
       end
 
-      secure_log("Deleted #{socket_paths.size} #{label} socket#{'s' if socket_paths.size != 1}")
+      SvelteOnRails::Lib::Utils.ssr_server_log("Deleted #{socket_paths.size} #{label} socket#{'s' if socket_paths.size != 1}")
     end
 
     # All running SSR processes matching our namespace (any ppid).

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: svelte-on-rails
 version: !ruby/object:Gem::Version
-  version: 22.0.3
+  version: 22.1.0
 platform: ruby
 authors:
 - Christian Sedlmair