svelte-on-rails 1.0.12 → 1.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 89b585de2264458769d479f27bcadc4080a8984b23e916cccd5d07876a30ea24
-  data.tar.gz: 7255f6af6ee943e809b24ba6551730e05dd21b8279555c677f7be2346d47a0f1
+  metadata.gz: bff57a06d326d5d82c6723869221aa21a47cb5d26e13c2d12100962610240b94
+  data.tar.gz: 589902ba14fd77b3c094a92ce2396a0edb0d5bfb8e81f23bf2250953f9d89da2
 SHA512:
-  metadata.gz: 3557343363ea9f1776a6766eadcb97a3d8e6376ac069b1daa764cd77aa87a2f04614c91f3ed0b9d16a549b4ca7651ad82716d4b2374fc222c6d649d1e1c538c3
-  data.tar.gz: 4f301fb16a422e682e75ca9ebf09a207474346ff973140191d8e92226bc9b284c04eaa3c3662f6745b83637b6db83752c8b5b4dcfa35deaec71eaa0d0ad1d973
+  metadata.gz: 35ee591f318848ca0918280f4c633f36896f530a443f97ff6e02444877e6b9b677aeb0a139503a8296f3f47fbb528dc5b60cb277721237d68c5100e1b048267d
+  data.tar.gz: c119240c35a8a0c74d9606a7cc651f37bb8c107fa9e96d18d8b20ce2b68018fa630d6f3749bd0ecb594834fc5cdf742fc4e1d2c1bfc0095e18d4074b38c9b105

data/README.md

@@ -4,7 +4,14 @@
 
 ---
 
-Svelte is the missing peace for ambitious Rails frontends.
+Do you want to combine DHH's [vision](https://rubyonrails.org/2021/12/15/Rails-7-fulfilling-a-vision) 
+with modern front-end requirements?
+
+Svelte.
+
+Vite.
+
+Nothing else.
 
 # Why Svelte? 
 
@@ -14,12 +21,12 @@ On every app there are parts where you want it to shine. This is where Svelte co
 - Perfect addition to Stimulus
 - Easy to learn
 - Powerful
+- Super fast
 - **Compared to Stimulus**
   - No more writing double logic of the initial HTML state
-  - Stimulus is good for parts where you have simple and little javascript and lots of html
-  - The more complexity, the more you will love svelte
+  - Stimulus is great for rails views with some javascript, but, complex parts: Svelte. Nothing else.
 - **Compared to React**
-  - No Shadow dom 
+  - No more shadow dom and all those packages that are supposed to improve performance (e.g. useCallback...)
   - Slimmer packages
   - Easier to learn
   - Faster
@@ -27,12 +34,15 @@ On every app there are parts where you want it to shine. This is where Svelte co
 Have a look at this entertaining video [rethinking reactivity](https://svelte.dev/blog/svelte-3-rethinking-reactivity)
 by Rich Harris, especially from 3:50 to 6:40 and his comparison to react.
 
-This all fits perfectly with the Rails way of minimalist javascript, but: Where we need it, we have it.
+This all fits in perfectly with the Rails way of minimalist javascript,
+but: Where needed, we want full power.
 
 # Features
 
-- 🤝 fully integrated with `assets:precompile`
-- 🚀 cero-config deployment
+- 🤝 Fully integrated with `assets:precompile`
+- 🚀 Cero-config deployment
+- ✍️ Sophisticated error messages
+- 😍 Contributor friendly
 
 # Known Issues
 
@@ -189,7 +199,7 @@ The most importand rule is to firstly check all npm packages installed and passi
 ## Check if it all works
 
 Server Side Rendering (SSR) is a parallel pipeline to client side rendering.
-Both should return the same html. And your global styles should be applied same way
+Both should return the same HTML. And your global styles should be applied same way
 for both cases. For normal use cases this is. 
 
 For check the **ssr pipeline** you can pass the options `ssr: true` and `hydrate: false`

data/lib/svelte_on_rails/lib/utils.rb

@@ -59,35 +59,50 @@ module SvelteOnRails
       def self.precompile(last_mtime = nil)
         config = SvelteOnRails::Configuration.instance
 
-        mtime = (File.exist?(config.ssr_dist_folder.join('last_mtime')) ? File.read(config.ssr_dist_folder.join('last_mtime')).to_f : 0.0)
-
         Dir.chdir(config.rails_root) do
 
           # run build
 
           cmd = "./node_modules/.bin/vite build --config vite-ssr.config.ts"
+
           stdout, stderr, status = Open3.capture3(cmd)
-          mtime2 = (File.exist?(config.ssr_dist_folder.join('last_mtime')) ? File.read(config.ssr_dist_folder.join('last_mtime')).to_f : 0.0)
+
+          warnings = stderr.to_s.split("\n")
+          errors_matcher = Regexp.new('(Could not resolve)')
+          error_lines = warnings.select { |e| e.match(errors_matcher) }
+          have_error = error_lines.present? || status.to_s.match(/exit 1/)
 
           # error handling
 
           if stderr.present?
 
-            nothing_done = mtime2 == mtime
-            color = (nothing_done ? "\033[97;41m" : "\033[30;106m")
-
-            msg = "  +++  #{nothing_done ? 'ERROR' : 'WARNING'} compiling Svelte components#{nothing_done ? ' failed' : ''} («#{cmd}»)  +++  "
-            puts "#{color}#{msg}\033[0m"
-            errs = stderr.split("\n")
-            errs.each { |e| puts "#{color}  \033[0m #{e}" }
-            puts "#{color}  +++  End of error message  +++  \033[0m"
-            puts "#{color}  +++  Run «npm run build:ssr» on the console to see the original error message  +++  \033[0m"
-
-            if nothing_done
-              critical_lines = errs.select { |e| e.match(/Could not resolve/i) }
-              cl_str = if critical_lines.present?
-                     "#{critical_lines.join("\n")}\n\n"
-                   end
+            red_background = "\033[97;41m"
+            light_blue_background = "\033[30;106m"
+            clear_colors = "\033[0m"
+
+            msg = "  +++  #{have_error ? 'ERROR' : 'WARNING'} compiling Svelte components#{have_error ? ' failed' : ''} («#{cmd}»)  +++  "
+            puts "#{have_error ? red_background : light_blue_background}#{msg}#{clear_colors}"
+
+            warnings.each do |e|
+              if e.match(errors_matcher)
+                red_font = "\033[31m"
+                puts "#{red_background}  #{clear_colors}#{red_font} #{e}#{clear_colors}"
+              else
+                puts "#{light_blue_background}  #{clear_colors}#{e}"
+              end
+            end
+
+            if have_error
+              puts "#{red_background}  +++  End of error message  +++  #{clear_colors}"
+            else
+              puts "#{light_blue_background}  +++  End of compiling warnings  +++  #{clear_colors}"
+            end
+            puts "#{have_error ? red_background : light_blue_background}  +++  Run «npm run build:ssr» on the console to see the original error message  +++  #{clear_colors}"
+
+            if have_error
+              cl_str = if error_lines.present?
+                         "#{error_lines.join("\n")}\n\n"
+                       end
               raise "Svelte components compilation failed\n\n#{cl_str}Full message:\n+++\n#{stderr}+++\n\nYou can run «npm run build:ssr» on the console to see the original error message\n"
             end
 
@@ -104,6 +119,7 @@ module SvelteOnRails
           mtime_path = config.ssr_dist_folder.join('last_mtime')
           File.write(mtime_path, last_mtime.to_s)
         end
+
       end
 
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: svelte-on-rails
 version: !ruby/object:Gem::Version
-  version: 1.0.12
+  version: 1.0.14
 platform: ruby
 authors:
 - Christian Sedlmair
@@ -95,6 +95,5 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 rubygems_version: 3.6.7
 specification_version: 4
-summary: Rock-solid and seamless integration of Svelte Components into Rails views,
-  based on vite_rails.
+summary: Solid and seamless integration of Svelte Components into Rails views.
 test_files: []