svelte-on-rails 1.0.11 → 1.0.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 11f044fdee86f5acc0dc592039acf158004a9f9849caaf12aaddbfaf16c7a086
-  data.tar.gz: '036408c99291e0a454726e0624a8492de97936e70550936fa5b49f670893bfcb'
+  metadata.gz: c2bddaae521fc71ed3c7975612b8b9109830fd25210eda2d30c00c6150265dca
+  data.tar.gz: 7adeb7e7181508d704ff98087f5b601a596159d1205cb0ffb08e98f5fca81272
 SHA512:
-  metadata.gz: 21235c147c880a84db9ad123aea60e5d9833e0451675754f9e6ac94c395fa445182e69fe1fbce6b1caf09c7e4e5c84fd7fa2a0460d5e9fe18d55fb9384287a58
-  data.tar.gz: 6673e550b9afc250663c81cdeca7837e4a8649875a4541cb83dabd773544fc528c52787b447d28c7d356ea664b3f1a8b911f6c864d1814e032830f73bc7c0305
+  metadata.gz: 77f1fd03901c9c73c8893c471b464db9e2e4fd212b9a36dad9a78f15b34f155865155b4796af3409e32b741dd4693a9756c369bcfb32caf05b1a1abdfa6e1af5
+  data.tar.gz: 7be8fd8640a3d7431dd6e8274a3bc3f3a9eca0c9c9e30f46d42f4eb00735f13a8e8421e8b0e6142c17ac0a0aab9bc9df5cc0914b17add50677498575401ac20b

data/README.md

@@ -4,7 +4,14 @@
 
 ---
 
-Svelte is the missing peace for ambitious Rails frontends.
+Do you want to combine DHH's [vision](https://rubyonrails.org/2021/12/15/Rails-7-fulfilling-a-vision) 
+with modern front-end requirements?
+
+Svelte.
+
+Vite.
+
+Nothing else.
 
 # Why Svelte? 
 
@@ -14,12 +21,12 @@ On every app there are parts where you want it to shine. This is where Svelte co
 - Perfect addition to Stimulus
 - Easy to learn
 - Powerful
+- Super fast
 - **Compared to Stimulus**
   - No more writing double logic of the initial HTML state
-  - Stimulus is good for parts where you have simple and little javascript and lots of html
-  - The more complexity, the more you will love svelte
+  - Stimulus is great for rails views with some javascript, but, complex parts: Svelte. Nothing else.
 - **Compared to React**
-  - No Shadow dom 
+  - No more shadow dom and all those packages that are supposed to improve performance (e.g. useCallback...)
   - Slimmer packages
   - Easier to learn
   - Faster
@@ -27,12 +34,15 @@ On every app there are parts where you want it to shine. This is where Svelte co
 Have a look at this entertaining video [rethinking reactivity](https://svelte.dev/blog/svelte-3-rethinking-reactivity)
 by Rich Harris, especially from 3:50 to 6:40 and his comparison to react.
 
-This all fits perfectly with the Rails way of minimalist javascript, but: Where we need it, we have it.
+This all fits in perfectly with the Rails way of minimalist javascript,
+but: Where needed, we want full power.
 
 # Features
 
-- 🤝 fully integrated with `assets:precompile`
-- 🚀 cero-config deployment
+- 🤝 Fully integrated with `assets:precompile`
+- 🚀 Cero-config deployment
+- ✍️ Sophisticated error messages
+- 😍 Contributor friendly
 
 # Known Issues
 
@@ -189,7 +199,7 @@ The most importand rule is to firstly check all npm packages installed and passi
 ## Check if it all works
 
 Server Side Rendering (SSR) is a parallel pipeline to client side rendering.
-Both should return the same html. And your global styles should be applied same way
+Both should return the same HTML. And your global styles should be applied same way
 for both cases. For normal use cases this is. 
 
 For check the **ssr pipeline** you can pass the options `ssr: true` and `hydrate: false`

data/lib/svelte_on_rails/lib/utils.rb

@@ -62,20 +62,37 @@ module SvelteOnRails
         mtime = (File.exist?(config.ssr_dist_folder.join('last_mtime')) ? File.read(config.ssr_dist_folder.join('last_mtime')).to_f : 0.0)
 
         Dir.chdir(config.rails_root) do
+
+          # run build
+
           cmd = "./node_modules/.bin/vite build --config vite-ssr.config.ts"
           stdout, stderr, status = Open3.capture3(cmd)
           mtime2 = (File.exist?(config.ssr_dist_folder.join('last_mtime')) ? File.read(config.ssr_dist_folder.join('last_mtime')).to_f : 0.0)
-          build_failed = mtime2 == mtime
-          color = (build_failed ? "\033[97;41m" : "\033[30;106m")
+
+          # error handling
 
           if stderr.present?
-            msg = "  +++  #{build_failed ? 'ERROR' : 'WARNING'} compiling Svelte components#{build_failed ? ' failed' : ''} («#{cmd}»)  +++  "
+
+            nothing_done = mtime2 == mtime
+            color = (nothing_done ? "\033[97;41m" : "\033[30;106m")
+
+            msg = "  +++  #{nothing_done ? 'ERROR' : 'WARNING'} compiling Svelte components#{nothing_done ? ' failed' : ''} («#{cmd}»)  +++  "
             puts "#{color}#{msg}\033[0m"
             errs = stderr.split("\n")
-            errs.each {|e|puts "#{color}  \033[0m #{e}"}
+            errs.each { |e| puts "#{color}  \033[0m #{e}" }
             puts "#{color}  +++  End of error message  +++  \033[0m"
             puts "#{color}  +++  Run «npm run build:ssr» on the console to see the original error message  +++  \033[0m"
+
+            if nothing_done
+              critical_lines = errs.select { |e| e.match(/Could not resolve/i) }
+              cl_str = if critical_lines.present?
+                     "#{critical_lines.join("\n")}\n\n"
+                   end
+              raise "Svelte components compilation failed\n\n#{cl_str}Full message:\n+++\n#{stderr}+++\n\nYou can run «npm run build:ssr» on the console to see the original error message\n"
+            end
+
           end
+
           puts stdout
 
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: svelte-on-rails
 version: !ruby/object:Gem::Version
-  version: 1.0.11
+  version: 1.0.13
 platform: ruby
 authors:
 - Christian Sedlmair
@@ -95,6 +95,5 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 rubygems_version: 3.6.7
 specification_version: 4
-summary: Rock-solid and seamless integration of Svelte Components into Rails views,
-  based on vite_rails.
+summary: Solid and seamless integration of Svelte Components into Rails views.
 test_files: []