suspiciouss 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5e351f0df749a63d636445a4d46a097904ed575f
-  data.tar.gz: 700601a65138cbabb863036b1d6e64e47687b269
+  metadata.gz: 2cec60795a5d43b153226bdbd7a07f145bf9e943
+  data.tar.gz: 04c7f1e38dd8befc36c7bd8df2e672f8e6452977
 SHA512:
-  metadata.gz: d3fb9ed22350534bf844d65a48f5dc1bbac3babb0e1387193d1a651db6207303d9d8170218e8154d21f42bddae15e8c38863430fcbcd5e1a62d234417725ba73
-  data.tar.gz: 85cbca6c9b26aaefb114fc0ab16a16d1c4d7918cda9d680889a4cfa1c5d1ac5783b86269a601af778076349a17c67dd2022521e0e76b027b68d8d8ce9f3416cf
+  metadata.gz: d38bb88b4b85053b01bd940e2882fe7e6085600c399c1a32ab988fb415337d712a05cdc1de760da7fe50363e061f8b2baf477e7d8c5f7a2e2067c2c525803b81
+  data.tar.gz: 7f34108c06f126c456f267adb7a67426eb84e3690846ffcf1b5610e80a1736ddfce5961ad5ea2970c7431b782a3bda19a121b911c4922e3f55e9026089aea189

data/.gitignore

@@ -6,3 +6,4 @@ nbproject
 pkg/
 tmp/
 Gemfile.lock
+*gem

data/lib/suspiciouss/linter.rb

@@ -1,4 +1,5 @@
 require 'suspiciouss/suggestions/camel_case'
+require 'suspiciouss/suggestions/element'
 require 'suspiciouss/suggestions/indentation'
 require 'suspiciouss/suggestions/overqualifying'
 require 'suspiciouss/suggestions/styling_ids'
@@ -58,13 +59,13 @@ module Suspiciouss
     # Parses a line with each of the known suggestions and adds the result
     # to the final output.
     def parse(full_line)
-      @line = strip_diff_syntax full_line
+      line = strip_diff_syntax full_line
 
       return unless full_line =~ /^\+ /
 
       known_suggestions.each do |suggestion|
-        if result = suggestion.parse(@line)
-          @result[@filename] << "#{result}: #{@line}"
+        if result = suggestion.parse(line)
+          @result[@filename] << "#{result}: #{line}"
         end
       end
     end

data/lib/suspiciouss/suggestions/element.rb

@@ -0,0 +1,11 @@
+module Suspiciouss
+  module Suggestions
+    class Element
+
+      def parse(line)
+        return if line.include?(':')
+        'Rightmost selector might be very common. Use a class instead' if line =~ /\s+(div|a|p|span)/
+      end
+    end
+  end
+end

data/lib/suspiciouss/version.rb

@@ -1,3 +1,3 @@
 module Suspiciouss
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

data/spec/linter_spec.rb

@@ -1,5 +1,6 @@
 require 'spec_helper'
 require 'fakefs/spec_helpers'
+require 'yaml'
 
 describe Suspiciouss::Linter do
 
@@ -35,6 +36,7 @@ describe Suspiciouss::Linter do
     it 'is a list of Linters' do
       expect(suggestions_to_use).to match_array(%w(
         CamelCase
+        Element
         Indentation
         Overqualifying
         StylingIds
@@ -77,6 +79,7 @@ describe Suspiciouss::Linter do
       it 'excludes those suggestions' do
         expect(suggestions_to_use).to match_array(%w(
           CamelCase
+          Element
           Overqualifying
           StylingJsPrefix
           Underscores

data/spec/spec_helper.rb

@@ -1,6 +1,6 @@
 require 'rubygems'
 require 'bundler/setup'
-require 'pry-debugger'
+require 'pry-byebug'
 
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))

data/spec/suggestions/element_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe Suspiciouss::Suggestions::Element do
+
+  describe '#parse' do
+
+    context 'invalid' do
+      let(:result) { 'Rightmost selector might be very common. Use a class instead' }
+
+      it { expect(subject.parse('  div {}')).to eq result }
+      it { expect(subject.parse('  .selector div {}')).to eq result }
+    end
+
+    context 'valid' do
+      let(:line) { 'div {}' }
+
+      it { expect(subject.parse(line)).to be_nil }
+    end
+  end
+end

data/suspiciouss.gemspec

@@ -16,9 +16,9 @@ Gem::Specification.new do |gem|
   gem.require_paths = ['lib']
 
   gem.add_development_dependency 'rspec', '~> 2.12'
-  gem.add_development_dependency 'pry'
-  gem.add_development_dependency 'pry-debugger'
-  gem.add_development_dependency 'guard'
-  gem.add_development_dependency 'guard-rspec'
-  gem.add_development_dependency 'fakefs'
+  gem.add_development_dependency 'pry', '~> 0.9'
+  gem.add_development_dependency 'pry-byebug', '~> 1.3'
+  gem.add_development_dependency 'guard', '~> 2.5'
+  gem.add_development_dependency 'guard-rspec', '~> 3.0'
+  gem.add_development_dependency 'fakefs', '~> 0.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: suspiciouss
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Daniel Cruz Horts
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-09 00:00:00.000000000 Z
+date: 2014-08-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -28,72 +28,72 @@ dependencies:
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
 - !ruby/object:Gem::Dependency
-  name: pry-debugger
+  name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.5'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: fakefs
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.5'
 description: 
 email: 
 executables:
@@ -115,6 +115,7 @@ files:
 - lib/suspiciouss/result/markdown.rb
 - lib/suspiciouss/result/plain_text.rb
 - lib/suspiciouss/suggestions/camel_case.rb
+- lib/suspiciouss/suggestions/element.rb
 - lib/suspiciouss/suggestions/indentation.rb
 - lib/suspiciouss/suggestions/overqualifying.rb
 - lib/suspiciouss/suggestions/styling_ids.rb
@@ -130,6 +131,7 @@ files:
 - spec/result/plain_text_spec.rb
 - spec/spec_helper.rb
 - spec/suggestions/camel_case_spec.rb
+- spec/suggestions/element_spec.rb
 - spec/suggestions/indentation_spec.rb
 - spec/suggestions/overqualifying_spec.rb
 - spec/suggestions/styling_ids_spec.rb
@@ -170,6 +172,7 @@ test_files:
 - spec/result/plain_text_spec.rb
 - spec/spec_helper.rb
 - spec/suggestions/camel_case_spec.rb
+- spec/suggestions/element_spec.rb
 - spec/suggestions/indentation_spec.rb
 - spec/suggestions/overqualifying_spec.rb
 - spec/suggestions/styling_ids_spec.rb