suspiciouss 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5ad99a1a9bb97808032ac33af846bd48457d6549
-  data.tar.gz: cd365d13b993fc2a46b8390e9e50badc4bca8d13
+  metadata.gz: 5e351f0df749a63d636445a4d46a097904ed575f
+  data.tar.gz: 700601a65138cbabb863036b1d6e64e47687b269
 SHA512:
-  metadata.gz: d07bb76a495bdcac3fd23dbf657331796991066415e76b5062a84150dcc35144093a7aacc42d2ff8da89bdbd96eee280e7753a8b19704221ffc14e2914f7b87a
-  data.tar.gz: 90ae255ceb47d362d6cbbc611a34d50e1d9f036fdc0f22575869a659919ffc0803be60b0d93b7c48a4e7d8723c403f47018ba935b4c0346fac0a3dc0466b0f4e
+  metadata.gz: d3fb9ed22350534bf844d65a48f5dc1bbac3babb0e1387193d1a651db6207303d9d8170218e8154d21f42bddae15e8c38863430fcbcd5e1a62d234417725ba73
+  data.tar.gz: 85cbca6c9b26aaefb114fc0ab16a16d1c4d7918cda9d680889a4cfa1c5d1ac5783b86269a601af778076349a17c67dd2022521e0e76b027b68d8d8ce9f3416cf

data/lib/suspiciouss/linter.rb

@@ -37,6 +37,10 @@ module Suspiciouss
       end
     end
 
+    def suggestions_to_use
+      included_suggestions.reject { |s| excluded_suggestions.include?(s) }
+    end
+
     private
 
     # Detects if the diff block references a known file type
@@ -70,16 +74,39 @@ module Suspiciouss
       formatter.new(@result).format
     end
 
-    # Memoizes available suggestions in an array
+    # Returns a line without the "+ " added by diff
+    def strip_diff_syntax(line)
+      line[2..-1]
+    end
+
     def known_suggestions
-      @known_suggestions ||= SUGGESTIONS.constants.map do |suggestion_class|
+      @known_suggestions ||= suggestions_to_use.map do |suggestion_class|
         SUGGESTIONS.const_get(suggestion_class).new
       end
     end
 
-    # Returns a line without the "+ " added by diff
-    def strip_diff_syntax(line)
-      line[2..-1]
+    def included_suggestions
+      return SUGGESTIONS.constants unless config.has_key?(:include)
+      SUGGESTIONS.constants.select { |s| config[:include].include?(s.to_s) }
+    end
+
+    def excluded_suggestions
+      return [] unless config.has_key?(:exclude)
+      SUGGESTIONS.constants.select { |s| config[:exclude].include?(s.to_s) }
+    end
+
+    def config
+      return {} unless has_config?
+
+      @config ||= YAML::load(File.open(config_file))
+    end
+
+    def has_config?
+      File.exists?(config_file)
+    end
+
+    def config_file
+      '.suspiciouss.yml'
     end
   end
 end

data/lib/suspiciouss/version.rb

@@ -1,3 +1,3 @@
 module Suspiciouss
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

data/spec/linter_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'fakefs/spec_helpers'
 
 describe Suspiciouss::Linter do
 
@@ -25,4 +26,86 @@ describe Suspiciouss::Linter do
       it { expect(subject).to eq output }
     end
   end
+
+  describe '#suggestions_to_use' do
+    include FakeFS::SpecHelpers
+
+    let(:suggestions_to_use) { subject.suggestions_to_use.map(&:to_s) }
+
+    it 'is a list of Linters' do
+      expect(suggestions_to_use).to match_array(%w(
+        CamelCase
+        Indentation
+        Overqualifying
+        StylingIds
+        StylingJsPrefix
+        Underscores
+        ZeroUnits
+      ))
+    end
+
+    context 'when we have a config file that specifies what to include' do
+      before do
+        File.open(".suspiciouss.yml", "w") do |f|
+          f.write({
+            :include => [
+              'CamelCase'
+            ]
+          }.to_yaml)
+        end
+      end
+
+      it 'only includes those suggestions' do
+        expect(suggestions_to_use).to match_array(%w(
+          CamelCase
+        ))
+      end
+    end
+
+    context 'when we have a config file that specifies what to exclude' do
+      before do
+        File.open(".suspiciouss.yml", "w") do |f|
+          f.write({
+            :exclude => [
+              'StylingIds',
+              'Indentation'
+            ]
+          }.to_yaml)
+        end
+      end
+
+      it 'excludes those suggestions' do
+        expect(suggestions_to_use).to match_array(%w(
+          CamelCase
+          Overqualifying
+          StylingJsPrefix
+          Underscores
+          ZeroUnits
+        ))
+      end
+    end
+
+    context 'when we have a config file that specifies what to include _and_ exclude' do
+      before do
+        File.open(".suspiciouss.yml", "w") do |f|
+          f.write({
+            :include => [
+              'CamelCase',
+              'StylingIds'
+            ],
+            :exclude => [
+              'StylingIds',
+              'Indentation'
+            ]
+          }.to_yaml)
+        end
+      end
+
+      it 'the includes overrides the excludes' do
+        expect(suggestions_to_use).to match_array(%w(
+          CamelCase
+        ))
+      end
+    end
+  end
 end

data/suspiciouss.gemspec

@@ -20,4 +20,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'pry-debugger'
   gem.add_development_dependency 'guard'
   gem.add_development_dependency 'guard-rspec'
+  gem.add_development_dependency 'fakefs'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: suspiciouss
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Daniel Cruz Horts
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-01 00:00:00.000000000 Z
+date: 2014-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -80,6 +80,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: fakefs
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email: 
 executables:
@@ -143,7 +157,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.2
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Reports common CSS/Sass/Less errors
@@ -162,3 +176,4 @@ test_files:
 - spec/suggestions/styling_js_prefix_spec.rb
 - spec/suggestions/underscores_spec.rb
 - spec/suggestions/zero_units_spec.rb
+has_rdoc: