suspenders 1.54.1 → 1.56.1

data/spec/features/new_project_spec.rb

@@ -1,319 +0,0 @@
-require "spec_helper"
-
-RSpec.describe "Suspend a new project with default configuration" do
-  before(:all) do
-    drop_dummy_database
-    remove_project_directory
-    run_suspenders
-    setup_app_dependencies
-  end
-
-  it "uses custom Gemfile" do
-    gemfile_file = IO.read("#{project_path}/Gemfile")
-    expect(gemfile_file).to match(
-      /^ruby "#{Suspenders::RUBY_VERSION}"$/,
-    )
-    expect(gemfile_file).to match(
-      /^gem "autoprefixer-rails"$/,
-    )
-    expect(gemfile_file).to match(
-      /^gem "rails", "#{Suspenders::RAILS_VERSION}"$/,
-    )
-  end
-
-  it "ensures project specs pass" do
-    Dir.chdir(project_path) do
-      Bundler.with_unbundled_env do
-        expect(`rake`).to include('0 failures')
-      end
-    end
-  end
-
-  it "includes the bundle:audit task" do
-    Dir.chdir(project_path) do
-      Bundler.with_unbundled_env do
-        expect(`rails -T`).to include("rails bundle:audit")
-      end
-    end
-  end
-
-  it "creates .ruby-version from Suspenders .ruby-version" do
-    ruby_version_file = IO.read("#{project_path}/.ruby-version")
-
-    expect(ruby_version_file).to eq "#{RUBY_VERSION}\n"
-  end
-
-  it "copies dotfiles" do
-    expect(File).to exist("#{project_path}/.env")
-  end
-
-  it "doesn't generate test directory" do
-    expect(File).not_to exist("#{project_path}/test")
-  end
-
-  it "loads secret_key_base from env" do
-    secrets_file = IO.read("#{project_path}/config/secrets.yml")
-
-    expect(secrets_file).
-      to match(/secret_key_base: <%= ENV\["SECRET_KEY_BASE"\] %>/)
-  end
-
-  it "adds bin/setup file" do
-    expect(File).to exist("#{project_path}/bin/setup")
-  end
-
-  it "makes bin/setup executable" do
-    expect("bin/setup").to be_executable
-  end
-
-  it "adds support file for action mailer" do
-    expect(File).to exist("#{project_path}/spec/support/action_mailer.rb")
-  end
-
-  it "configures capybara-chromedriver" do
-    expect(File).to exist("#{project_path}/spec/support/chromedriver.rb")
-  end
-
-  it "adds support file for i18n" do
-    expect(File).to exist("#{project_path}/spec/support/i18n.rb")
-  end
-
-  it "creates good default .hound.yml" do
-    hound_config_file = IO.read("#{project_path}/.hound.yml")
-
-    expect(hound_config_file).to include "enabled: true"
-  end
-
-  it "initializes ActiveJob to avoid memory bloat" do
-    expect(File).
-      to exist("#{project_path}/config/initializers/active_job.rb")
-  end
-
-  it "records pageviews through Segment if ENV variable set" do
-    expect(analytics_partial).
-      to include(%{<% if ENV["SEGMENT_KEY"] %>})
-    expect(analytics_partial).
-      to include(%{analytics.load("<%= ENV["SEGMENT_KEY"] %>");})
-  end
-
-  it "raises on unpermitted parameters in all environments" do
-    result = IO.read("#{project_path}/config/application.rb")
-
-    expect(result).to match(
-      /^ +config.action_controller.action_on_unpermitted_parameters = :raise$/
-    )
-  end
-
-  it "adds explicit quiet_assets configuration" do
-    result = IO.read("#{project_path}/config/application.rb")
-
-    expect(result).to match(/^ +config.assets.quiet = true$/)
-  end
-
-  it "configures public_file_server.headers in production" do
-    expect(production_config).to match(
-      /^ +config.public_file_server.headers = {\n +"Cache-Control" => "public,/,
-    )
-  end
-
-  it "configures production environment to enforce SSL" do
-    expect(production_config).to match(
-      /^ +config.force_ssl = true/,
-    )
-  end
-
-  it "raises on missing translations in development and test" do
-    [development_config, test_config].each do |environment_file|
-      expect(environment_file).to match(
-        /^ +config.action_view.raise_on_missing_translations = true$/
-      )
-    end
-  end
-
-  it "evaluates en.yml.erb" do
-    locales_en_file = IO.read("#{project_path}/config/locales/en.yml")
-
-    expect(locales_en_file).to match(/application: #{app_name.humanize}/)
-  end
-
-  it "configs simple_form" do
-    expect(File).to exist("#{project_path}/config/initializers/simple_form.rb")
-  end
-
-  it "configs :test email delivery method for development" do
-    expect(development_config).
-      to match(/^ +config.action_mailer.delivery_method = :file$/)
-  end
-
-  it "sets action mailer default host and asset host" do
-    config_key = 'config\.action_mailer\.asset_host'
-    config_value =
-      %q{ENV\.fetch\("ASSET_HOST", ENV\.fetch\("APPLICATION_HOST"\)\)}
-    expect(production_config).to match(/#{config_key} = #{config_value}/)
-  end
-
-  it "uses APPLICATION_HOST, not HOST in the production config" do
-    expect(production_config).to match(/"APPLICATION_HOST"/)
-    expect(production_config).not_to match(/"HOST"/)
-  end
-
-  it "configures email interceptor" do
-    email_file = File.join(project_path, "config", "initializers", "email.rb")
-    email_config = IO.read(email_file)
-
-    expect(email_config).
-      to include(%{RecipientInterceptor.new(ENV["EMAIL_RECIPIENTS"])})
-  end
-
-  it "configures language in html element" do
-    layout_path = "/app/views/layouts/application.html.erb"
-    layout_file = IO.read("#{project_path}#{layout_path}")
-    expect(layout_file).to match(/<html lang="en">/)
-  end
-
-  it "configs active job queue adapter" do
-    application_config = IO.read("#{project_path}/config/application.rb")
-
-    expect(application_config).to match(
-      /^ +config.active_job.queue_adapter = :delayed_job$/
-    )
-    expect(test_config).to match(
-      /^ +config.active_job.queue_adapter = :inline$/
-    )
-  end
-
-  it "configs background jobs for rspec" do
-    delayed_job = IO.read("#{project_path}/bin/delayed_job")
-
-    expect(delayed_job).to match(
-      /^require 'delayed\/command'$/,
-    )
-  end
-
-  it "configs bullet gem in development" do
-    expect(development_config).to match /^ +Bullet.enable = true$/
-    expect(development_config).to match /^ +Bullet.bullet_logger = true$/
-    expect(development_config).to match /^ +Bullet.rails_logger = true$/
-  end
-
-  it "configs missing assets to raise in test" do
-    expect(test_config).to match(
-      /^ +config.assets.raise_runtime_errors = true$/,
-    )
-  end
-
-  it "adds spring to binstubs" do
-    expect(File).to exist("#{project_path}/bin/spring")
-
-    bin_stubs = %w(rake rails rspec)
-    bin_stubs.each do |bin_stub|
-      expect(IO.read("#{project_path}/bin/#{bin_stub}")).to match(/spring/)
-    end
-  end
-
-  it "removes comments and extra newlines from config files" do
-    config_files = [
-      IO.read("#{project_path}/config/application.rb"),
-      IO.read("#{project_path}/config/environment.rb"),
-      development_config,
-      test_config,
-      production_config,
-    ]
-
-    config_files.each do |file|
-      expect(file).not_to match(%r{.*#.*})
-      expect(file).not_to eq(file.strip)
-      expect(file).not_to match(%r{^$\n\n})
-    end
-  end
-
-  it "copies factories.rb" do
-    expect(File).to exist("#{project_path}/spec/factories.rb")
-  end
-
-  it "creates review apps setup script" do
-    bin_setup_path = "#{project_path}/bin/setup_review_app"
-    bin_setup = IO.read(bin_setup_path)
-
-    expect(bin_setup).to include("PARENT_APP_NAME=#{app_name.dasherize}-staging")
-    expect(bin_setup).to include("APP_NAME=#{app_name.dasherize}-staging-pr-$1")
-    expect(bin_setup).to include("heroku ps:scale worker=1 --app $APP_NAME")
-    expect(bin_setup).to include("heroku restart --app $APP_NAME")
-
-    expect("bin/setup_review_app").to be_executable
-  end
-
-  it "creates deploy script" do
-    bin_deploy_path = "#{project_path}/bin/deploy"
-    bin_deploy = IO.read(bin_deploy_path)
-
-    expect(bin_deploy).to include("git push")
-    expect("bin/deploy").to be_executable
-  end
-
-  it "creates heroku application manifest file with application name in it" do
-    app_json_file = IO.read("#{project_path}/app.json")
-
-    expect(app_json_file).to match(/"name":\s*"#{app_name.dasherize}"/)
-  end
-
-  def app_name
-    SuspendersTestHelpers::APP_NAME
-  end
-
-  it "adds high_voltage" do
-    gemfile = IO.read("#{project_path}/Gemfile")
-    expect(gemfile).to match(/high_voltage/)
-  end
-
-  it "adds sassc-rails" do
-    gemfile = read_project_file("Gemfile")
-
-    expect(gemfile).to match(/sassc-rails/)
-  end
-
-  it "adds and configures bourbon" do
-    gemfile = read_project_file("Gemfile")
-
-    expect(gemfile).to match(/bourbon/)
-  end
-
-  it "configures bourbon, and bitters" do
-    app_css = read_project_file(%w(app assets stylesheets application.scss))
-    expect(app_css).to match(
-      /normalize\.css\/normalize.*bourbon.*base/m,
-    )
-  end
-
-  it "doesn't use turbolinks" do
-    app_js = read_project_file(%w(app javascript packs application.js))
-    expect(app_js).not_to match(/turbolinks/)
-  end
-
-  it "configures Timecop safe mode" do
-    spec_helper = read_project_file(%w(spec spec_helper.rb))
-    expect(spec_helper).to match(/Timecop.safe_mode = true/)
-  end
-
-  def development_config
-    @_development_config ||=
-      read_project_file %w(config environments development.rb)
-  end
-
-  def test_config
-    @_test_config ||= read_project_file %w(config environments test.rb)
-  end
-
-  def production_config
-    @_production_config ||=
-      read_project_file %w(config environments production.rb)
-  end
-
-  def analytics_partial
-    IO.read("#{project_path}/app/views/application/_analytics.html.erb")
-  end
-
-  def read_project_file(path)
-    IO.read(File.join(project_path, *path))
-  end
-end

data/spec/features/preloader_spec.rb

@@ -1,25 +0,0 @@
-require "spec_helper"
-
-RSpec.describe "suspenders:preloader", type: :generator do
-  it "adds binstubs for Spring" do
-    with_app { generate("suspenders:preloader") }
-
-    expect("bin/rails").to match_contents(/spring/)
-    expect("config/spring.rb").to exist_as_a_file
-    expect("config/environments/test.rb").to \
-      match_contents(/config.cache_classes = false/)
-    expect("Gemfile").to match_contents(/spring/)
-    expect("Gemfile").to match_contents(/spring-watcher-listen/)
-  end
-
-  it "removes Spring binstubs" do
-    with_app { destroy("suspenders:preloader") }
-
-    expect("config/environments/test.rb").to \
-      match_contents(/config.cache_classes = true/)
-    expect("config/spring.rb").not_to exist_as_a_file
-    expect("bin/rails").not_to match_contents(/spring/)
-    expect("Gemfile").not_to match_contents(/spring-watcher-listen/)
-    expect("Gemfile").not_to match_contents(/spring/)
-  end
-end

data/spec/features/production/compression_spec.rb

@@ -1,23 +0,0 @@
-require "spec_helper"
-
-RSpec.describe "suspenders:production:compression", type: :generator do
-  context "generate" do
-    it "adds Rack::Deflater to the middleware" do
-      with_app { generate("suspenders:production:compression") }
-
-      expect("config/environments/production.rb").to match_contents(
-        %r{config.middleware.use Rack::Deflater},
-      )
-    end
-  end
-
-  context "destroy" do
-    it "removes Rack::Deflater to the middleware" do
-      with_app { destroy("suspenders:production:compression") }
-
-      expect("config/environments/production.rb").not_to match_contents(
-        %r{Rack::Deflater},
-      )
-    end
-  end
-end

data/spec/features/production/deployment_spec.rb

@@ -1,22 +0,0 @@
-require "spec_helper"
-
-RSpec.describe "suspenders:production:deployment", type: :generator do
-  it "generates the configuration for a production deployment" do
-    rm "bin/deploy"
-
-    with_app { generate("suspenders:production:deployment") }
-
-    expect("bin/deploy").to exist_as_a_file
-    expect("bin/deploy").to be_executable
-    expect("README.md").to match_contents(%r{bin/deploy})
-  end
-
-  it "destroys the configuration for a production deployment" do
-    touch "bin/deploy"
-
-    with_app { destroy("suspenders:production:deployment") }
-
-    expect("bin/deploy").not_to exist_as_a_file
-    expect("README.md").not_to match_contents(%r{bin/deploy})
-  end
-end

data/spec/features/production/email_spec.rb

@@ -1,47 +0,0 @@
-require "spec_helper"
-
-RSpec.describe "suspenders:production:email", type: :generator do
-  it "generates the configuration for a production email deployment" do
-    with_app { generate("suspenders:production:email") }
-
-    expect("config/smtp.rb").to match_contents(%r{SMTP_SETTINGS\s*=})
-
-    expect("config/environments/production.rb").to \
-      match_contents(%r{require.+config/smtp})
-    expect("config/environments/production.rb").to \
-      match_contents(%r{action_mailer.delivery_method\s*=\s*:smtp})
-    expect("config/environments/production.rb").to \
-      match_contents(%r{action_mailer.smtp_settings\s*=\s*SMTP_SETTINGS})
-
-    expect("app.json").to contain_json(
-      env: {
-        SMTP_ADDRESS: { required: true },
-        SMTP_DOMAIN: { required: true },
-        SMTP_PASSWORD: { required: true },
-        SMTP_USERNAME: { required: true },
-      },
-    )
-  end
-
-  it "destroys the configuration for a production email deployment" do
-    with_app { destroy("suspenders:production:email") }
-
-    expect("config/smtp.rb").not_to exist_as_a_file
-
-    expect("config/environments/production.rb").not_to \
-      match_contents(%r{require.+config/smtp})
-    expect("config/environments/production.rb").not_to \
-      match_contents(%r{action_mailer.delivery_method\s*=\s*:smtp})
-    expect("config/environments/production.rb").not_to \
-      match_contents(%r{action_mailer.smtp_settings\s*=\s*SMTP_SETTINGS})
-
-    expect("app.json").not_to contain_json(
-      env: {
-        SMTP_ADDRESS: { required: true },
-        SMTP_DOMAIN: { required: true },
-        SMTP_PASSWORD: { required: true },
-        SMTP_USERNAME: { required: true },
-      },
-    )
-  end
-end

data/spec/features/production/manifest_spec.rb

@@ -1,37 +0,0 @@
-require "spec_helper"
-
-RSpec.describe "suspenders:production:manifest", type: :generator do
-  it "generates the manifest for a production build" do
-    with_app { generate("suspenders:production:manifest") }
-
-    expect("app.json").to contain_json(
-      name: SuspendersTestHelpers::APP_NAME.dasherize,
-      env: {
-        APPLICATION_HOST: { required: true },
-        AUTO_MIGRATE_DB: { value: true },
-        EMAIL_RECIPIENTS: { required: true },
-        HEROKU_APP_NAME: { required: true },
-        HEROKU_PARENT_APP_NAME: { required: true },
-        RACK_ENV: { required: true },
-        SECRET_KEY_BASE: { generator: "secret" },
-      },
-    )
-  end
-
-  it "destroys the manifest for a production build" do
-    with_app { destroy("suspenders:production:manifest") }
-
-    expect("app.json").not_to contain_json(
-      name: SuspendersTestHelpers::APP_NAME.dasherize,
-      env: {
-        APPLICATION_HOST: { required: true },
-        AUTO_MIGRATE_DB: { value: true },
-        EMAIL_RECIPIENTS: { required: true },
-        HEROKU_APP_NAME: { required: true },
-        HEROKU_PARENT_APP_NAME: { required: true },
-        RACK_ENV: { required: true },
-        SECRET_KEY_BASE: { generator: "secret" },
-      },
-    )
-  end
-end

data/spec/features/production/single_redirect_spec.rb

@@ -1,25 +0,0 @@
-require "spec_helper"
-
-RSpec.describe "suspenders:production:single_redirect", type: :generator do
-  context "generate" do
-    it "adds Rack::CanonicalHost to the production middleware" do
-      with_app { generate("suspenders:production:single_redirect") }
-      middleware_canonical_host = %r{config.middleware.use Rack::CanonicalHost, ENV.fetch\("APPLICATION_HOST"\)}
-
-      expect("config/environments/production.rb").to match_contents(
-        middleware_canonical_host,
-      )
-    end
-  end
-
-  context "destroy" do
-    it "removes Rack::CanonicalHost from the production middleware" do
-      with_app { destroy("suspenders:production:single_redirect") }
-      middleware_canonical_host = %r{config.middleware.use Rack::CanonicalHost, ENV.fetch\("APPLICATION_HOST"\)}
-
-      expect("config/environments/production.rb").not_to match_contents(
-        middleware_canonical_host,
-      )
-    end
-  end
-end

data/spec/features/profiler_spec.rb

@@ -1,20 +0,0 @@
-require "spec_helper"
-
-RSpec.describe "suspenders:profiler", type: :generator do
-  it "sets up rack-min-profiler" do
-    with_app { generate("suspenders:profiler") }
-
-    expect("config/initializers/rack_mini_profiler.rb").to \
-      match_contents(/Rack::MiniProfilerRails.initialize/)
-    expect("Gemfile").to match_contents(/rack-mini-profiler/)
-    expect(".env").to match_contents(/RACK_MINI_PROFILER=0/)
-  end
-
-  it "removes rack-min-profiler" do
-    with_app { destroy("suspenders:profiler") }
-
-    expect("config/initializers/rack_mini_profiler.rb").not_to exist_as_a_file
-    expect("Gemfile").not_to match_contents(/rack-mini-profiler/)
-    expect(".env").not_to exist_as_a_file
-  end
-end

data/spec/features/runner_spec.rb

@@ -1,30 +0,0 @@
-require "spec_helper"
-
-RSpec.describe "suspenders:runner", type: :generator do
-  it "configures the app for running" do
-    with_app { generate("suspenders:runner") }
-
-    expect("Procfile").to exist_as_a_file
-    expect(".sample.env").to exist_as_a_file
-    expect("bin/setup").to match_contents(/\.sample\.env/)
-    expect("README.md").to match_contents(/\.sample\.env/)
-  end
-
-  it "removes custom app running configuration" do
-    with_app { destroy("suspenders:runner") }
-
-    expect("README.md").not_to match_contents(/\.sample\.env/)
-    expect("bin/setup").not_to match_contents(/\.sample\.env/)
-    expect(".sample.env").not_to exist_as_a_file
-    expect("Procfile").not_to exist_as_a_file
-  end
-
-  it "configures the app with a shell script bin/setup" do
-    with_app do
-      copy_file "bin_setup", "bin/setup"
-      generate("suspenders:runner")
-    end
-
-    expect("bin/setup").to match_contents(/\.sample\.env/)
-  end
-end

data/spec/features/staging/pull_requests_spec.rb

@@ -1,22 +0,0 @@
-require "spec_helper"
-
-RSpec.describe "suspenders:staging:pull_requests", type: :generator do
-  it "generates the configuration for Heroku pipeline review apps" do
-    with_app { generate("suspenders:staging:pull_requests") }
-
-    expect("config/environments/production.rb").to \
-      match_contents(%r{HEROKU_APP_NAME})
-
-    expect("bin/setup_review_app").to \
-      match_contents(%r{APP_NAME=dummy-app-staging-pr-\$1})
-  end
-
-  it "destroys the configuration for Heroku pipeline review apps" do
-    with_app { destroy("suspenders:staging:pull_requests") }
-
-    expect("config/environments/production.rb").not_to \
-      match_contents(%r{APP_NAME=dummy-app-staging-pr-\$1})
-
-    expect("bin/setup_review_app").not_to exist_as_a_file
-  end
-end

data/spec/features/static_spec.rb

@@ -1,17 +0,0 @@
-require "spec_helper"
-
-RSpec.describe "suspenders:static", type: :generator do
-  it "adds the gem and pages directory" do
-    with_app { generate("suspenders:static") }
-
-    expect("Gemfile").to match_contents(/high_voltage/)
-    expect("app/views/pages/.keep").to exist_as_a_file
-  end
-
-  it "removes the gem and pages directory" do
-    with_app { destroy("suspenders:static") }
-
-    expect("app/views/pages/.keep").not_to exist_as_a_file
-    expect("Gemfile").not_to match_contents(/high_voltage/)
-  end
-end

data/spec/features/stylelint_spec.rb

@@ -1,60 +0,0 @@
-require "spec_helper"
-
-RSpec.describe "suspenders:stylelint", type: :generator do
-  context "generate" do
-    it "creates .stylelintrc.json" do
-      with_app { generate("suspenders:stylelint") }
-
-      expect(".stylelintrc.json").
-        to match_contents(%r{"extends": "@thoughtbot/stylelint-config"})
-    end
-
-    it "adds stylelint and @thoughtbot/stylelint-config to the package.json" do
-      with_app { generate("suspenders:stylelint") }
-
-      expect("package.json").to match_contents(/devDependencies/)
-      expect("package.json").to match_contents(/stylelint/)
-      expect("package.json").to match_contents(%r{@thoughtbot/stylelint-config})
-    end
-
-    it "uncomments the hound config_file option" do
-      with_app { generate("suspenders:stylelint") }
-
-      expect(".hound.yml").to(
-        match_contents(/^  config_file: \.stylelintrc\.json/),
-      )
-    end
-  end
-
-  context "destroy" do
-    it "removes .stylelintrc.json" do
-      with_app do
-        generate("suspenders:stylelint")
-        destroy("suspenders:stylelint")
-      end
-
-      expect(".stylelintrc.json").not_to exist_as_a_file
-    end
-
-    it "removes stylelint and @thoughtbot/stylelint-config from package.json" do
-      with_app do
-        generate("suspenders:stylelint")
-        destroy("suspenders:stylelint")
-      end
-
-      expect("package.json").not_to match_contents(/stylelint/)
-      expect("package.json").
-        not_to match_contents(%r{@thoughtbot/stylelint-config})
-    end
-
-    it "comments in the hound config_file option" do
-      with_app do
-        generate("suspenders:stylelint")
-        destroy("suspenders:stylelint")
-      end
-
-      expect(".hound.yml").
-        to match_contents(/^  # config_file: \.stylelintrc\.json/)
-    end
-  end
-end

data/spec/spec_helper.rb

@@ -1,21 +0,0 @@
-require 'bundler/setup'
-
-Bundler.require(:default, :test)
-
-require (Pathname.new(__FILE__).dirname + '../lib/suspenders').expand_path
-
-Dir['./spec/support/**/*.rb'].each { |file| require file }
-
-RSpec.configure do |config|
-  config.include SuspendersTestHelpers
-  config.include ProjectFiles
-
-  config.before(:all) do
-    add_fakes_to_path
-    create_tmp_directory
-  end
-
-  config.before(:each) do
-    FakeGithub.clear!
-  end
-end

data/spec/support/be_executable_matcher.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-
-RSpec::Matchers.define :be_executable do
-  match do |filename|
-    File.stat(File.join(project_path, filename)).executable?
-  end
-end