suspenders 1.52.0 → 1.55.1

data/spec/features/advisories_spec.rb

@@ -0,0 +1,24 @@
+require "spec_helper"
+
+RSpec.describe "suspenders:advisories", type: :generator do
+  it "configures bundler-audit" do
+    with_app { generate("suspenders:advisories") }
+
+    run_in_project do
+      expect(`rake -T`).to include("rake bundle:audit")
+    end
+    expect("lib/tasks/bundler_audit.rake").to \
+      match_contents(/Bundler::Audit::Task.new/)
+    expect("Gemfile").to match_contents(/bundler-audit/)
+  end
+
+  it "removes bundler-audit" do
+    with_app { destroy("suspenders:advisories") }
+
+    expect("Gemfile").not_to match_contents(/bundler-audit/)
+    expect("lib/tasks/bundler_audit.rake").not_to exist_as_a_file
+    run_in_project do
+      expect(`rake -T`).not_to include("rake bundle:audit")
+    end
+  end
+end

data/spec/features/api_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe "Suspend a new project with --api flag" do
     run_suspenders("--api")
 
     Dir.chdir(project_path) do
-      Bundler.with_clean_env do
+      Bundler.with_unbundled_env do
         expect(`rake`).to include("0 failures")
       end
     end

data/spec/features/ci_spec.rb

@@ -0,0 +1,31 @@
+require "spec_helper"
+
+RSpec.describe "suspenders:ci", type: :generator do
+  it "configures Circle with SimpleCov" do
+    with_app { generate("suspenders:ci") }
+
+    expect("Gemfile").to match_contents(/simplecov/)
+    expect("test/test_helper.rb").to match_contents(/SimpleCov.coverage_dir/)
+    expect("test/test_helper.rb").to match_contents(/SimpleCov.start/)
+    expect("circle.yml").to exist_as_a_file
+  end
+
+  it "removes Circle and SimpleCov" do
+    with_app { destroy("suspenders:ci") }
+
+    expect("circle.yml").not_to exist_as_a_file
+    expect("test/test_helper.rb").not_to match_contents(/SimpleCov/)
+    expect("Gemfile").not_to match_contents(/simplecov/)
+  end
+
+  it "configures RSpec" do
+    with_app do
+      copy_file "spec_helper.rb", "spec/spec_helper.rb"
+
+      generate("suspenders:ci")
+    end
+
+    expect("spec/spec_helper.rb").to match_contents(/SimpleCov.coverage_dir/)
+    expect("spec/spec_helper.rb").to match_contents(/SimpleCov.start/)
+  end
+end

data/spec/features/cli_help_spec.rb

@@ -20,10 +20,10 @@ RSpec.describe "Command line help output" do
 
   it "provides help and version usage within the suspenders group" do
     expect(help_text).to include <<~EOH
-Suspenders options:
-  -h, [--help], [--no-help]        # Show this help message and quit
-  -v, [--version], [--no-version]  # Show Suspenders version number and quit
-EOH
+      Suspenders options:
+        -h, [--help], [--no-help]        # Show this help message and quit
+        -v, [--version], [--no-version]  # Show Suspenders version number and quit
+    EOH
   end
 
   it "does not show the default extended rails help section" do

data/spec/features/db_optimizations_spec.rb

@@ -0,0 +1,19 @@
+require "spec_helper"
+
+RSpec.describe "suspenders:db_optimizations", type: :generator do
+  it "configures bullet" do
+    with_app { generate("suspenders:db_optimizations") }
+
+    expect("Gemfile").to match_contents(/bullet/)
+    expect("config/environments/development.rb").to \
+      match_contents(/Bullet.enable/)
+  end
+
+  it "removes bullet" do
+    with_app { destroy("suspenders:db_optimizations") }
+
+    expect("Gemfile").not_to match_contents(/bullet/)
+    expect("config/environments/development.rb").not_to \
+      match_contents(/Bullet.enable/)
+  end
+end

data/spec/features/heroku_spec.rb

@@ -16,9 +16,9 @@ RSpec.describe "Heroku" do
       expect(FakeHeroku).to have_configured_vars("staging", "SECRET_KEY_BASE")
       expect(FakeHeroku).to have_configured_vars(
         "production",
-        "SECRET_KEY_BASE",
+        "SECRET_KEY_BASE"
       )
-      %w(staging production).each do |env|
+      %w[staging production].each do |env|
         expect(FakeHeroku).to have_configured_vars(env, "APPLICATION_HOST")
         expect(FakeHeroku).to have_configured_vars(env, "HONEYBADGER_ENV")
       end
@@ -27,8 +27,8 @@ RSpec.describe "Heroku" do
       bin_setup_path = "#{project_path}/bin/setup"
       bin_setup = IO.read(bin_setup_path)
 
-      expect(bin_setup).to match(/^if heroku join --app #{app_name}-production/)
-      expect(bin_setup).to match(/^if heroku join --app #{app_name}-staging/)
+      expect(bin_setup).to assert_access_to_heroku_app("#{app_name}-production")
+      expect(bin_setup).to assert_access_to_heroku_app("#{app_name}-staging")
       expect(bin_setup).to match(/^git config heroku.remote staging/)
       expect("bin/setup").to be_executable
 
@@ -36,24 +36,13 @@ RSpec.describe "Heroku" do
 
       expect(readme).to include("./bin/deploy staging")
       expect(readme).to include("./bin/deploy production")
-
-      circle_yml_path = "#{project_path}/circle.yml"
-      circle_yml = IO.read(circle_yml_path)
-
-      expect(circle_yml).to include <<-YML.strip_heredoc
-      deployment:
-        staging:
-          branch: master
-          commands:
-            - bin/deploy staging
-      YML
     end
   end
 
   context "--heroku with region flag" do
     before(:all) do
       clean_up
-      run_suspenders(%{--heroku=true --heroku-flags="--region eu"})
+      run_suspenders(%(--heroku=true --heroku-flags="--region eu"))
       setup_app_dependencies
     end
 
@@ -63,6 +52,10 @@ RSpec.describe "Heroku" do
     end
   end
 
+  def assert_access_to_heroku_app(app_name)
+    match(/^if heroku apps:info --app #{app_name}/)
+  end
+
   def clean_up
     drop_dummy_database
     remove_project_directory

data/spec/features/inline_svg_spec.rb

@@ -0,0 +1,10 @@
+require "spec_helper"
+
+RSpec.describe "suspenders:inline_svg", type: :generator do
+  it "generates the configuration for inline_svg" do
+    with_app { generate("suspenders:inline_svg") }
+
+    expect("config/initializers/inline_svg.rb").to match_contents(/InlineSvg/)
+    expect("Gemfile").to match_contents(/inline_svg/)
+  end
+end

data/spec/features/lint_spec.rb

@@ -0,0 +1,26 @@
+require "spec_helper"
+
+RSpec.describe "suspenders:lint", type: :generator do
+  it "sets up standard" do
+    with_app { generate("suspenders:lint") }
+
+    expect("Gemfile").to match_contents(/standard/)
+
+    run_in_project do
+      expect(`rake -T`).to include("rake standard")
+    end
+  end
+
+  it "removes standard" do
+    with_app do
+      generate("suspenders:lint")
+      destroy("suspenders:lint")
+    end
+
+    expect("Gemfile").not_to match_contents(/standard/)
+
+    run_in_project do
+      expect(`rake -T`).not_to include("rake standard")
+    end
+  end
+end

data/spec/features/new_project_spec.rb

@@ -11,27 +11,27 @@ RSpec.describe "Suspend a new project with default configuration" do
   it "uses custom Gemfile" do
     gemfile_file = IO.read("#{project_path}/Gemfile")
     expect(gemfile_file).to match(
-      /^ruby "#{Suspenders::RUBY_VERSION}"$/,
+      /^ruby "#{Suspenders::RUBY_VERSION}"$/
     )
     expect(gemfile_file).to match(
-      /^gem "autoprefixer-rails"$/,
+      /^gem "autoprefixer-rails"$/
     )
     expect(gemfile_file).to match(
-      /^gem "rails", "#{Suspenders::RAILS_VERSION}"$/,
+      /^gem "rails", "#{Suspenders::RAILS_VERSION}"$/
     )
   end
 
   it "ensures project specs pass" do
     Dir.chdir(project_path) do
-      Bundler.with_clean_env do
-        expect(`rake`).to include('0 failures')
+      Bundler.with_unbundled_env do
+        expect(`rake`).to include("0 failures")
       end
     end
   end
 
   it "includes the bundle:audit task" do
     Dir.chdir(project_path) do
-      Bundler.with_clean_env do
+      Bundler.with_unbundled_env do
         expect(`rails -T`).to include("rails bundle:audit")
       end
     end
@@ -44,9 +44,7 @@ RSpec.describe "Suspend a new project with default configuration" do
   end
 
   it "copies dotfiles" do
-    %w[.ctags .env].each do |dotfile|
-      expect(File).to exist("#{project_path}/#{dotfile}")
-    end
+    expect(File).to exist("#{project_path}/.sample.env")
   end
 
   it "doesn't generate test directory" do
@@ -56,8 +54,8 @@ RSpec.describe "Suspend a new project with default configuration" do
   it "loads secret_key_base from env" do
     secrets_file = IO.read("#{project_path}/config/secrets.yml")
 
-    expect(secrets_file).
-      to match(/secret_key_base: <%= ENV\["SECRET_KEY_BASE"\] %>/)
+    expect(secrets_file)
+      .to match(/secret_key_base: <%= ENV\["SECRET_KEY_BASE"\] %>/)
   end
 
   it "adds bin/setup file" do
@@ -86,33 +84,16 @@ RSpec.describe "Suspend a new project with default configuration" do
     expect(hound_config_file).to include "enabled: true"
   end
 
-  it "ensures Gemfile contains `rack-mini-profiler`" do
-    gemfile = IO.read("#{project_path}/Gemfile")
-
-    expect(gemfile).to include %{gem "rack-mini-profiler", require: false}
-  end
-
-  it "ensures .sample.env defaults to RACK_MINI_PROFILER=0" do
-    env = IO.read("#{project_path}/.env")
-
-    expect(env).to include "RACK_MINI_PROFILER=0"
-  end
-
   it "initializes ActiveJob to avoid memory bloat" do
-    expect(File).
-      to exist("#{project_path}/config/initializers/active_job.rb")
-  end
-
-  it "creates a rack-mini-profiler initializer" do
-    expect(File).
-      to exist("#{project_path}/config/initializers/rack_mini_profiler.rb")
+    expect(File)
+      .to exist("#{project_path}/config/initializers/active_job.rb")
   end
 
   it "records pageviews through Segment if ENV variable set" do
-    expect(analytics_partial).
-      to include(%{<% if ENV["SEGMENT_KEY"] %>})
-    expect(analytics_partial).
-      to include(%{analytics.load("<%= ENV["SEGMENT_KEY"] %>");})
+    expect(analytics_partial)
+      .to include(%(<% if ENV["SEGMENT_KEY"] %>))
+    expect(analytics_partial)
+      .to include(%{analytics.load("<%= ENV["SEGMENT_KEY"] %>");})
   end
 
   it "raises on unpermitted parameters in all environments" do
@@ -131,13 +112,13 @@ RSpec.describe "Suspend a new project with default configuration" do
 
   it "configures public_file_server.headers in production" do
     expect(production_config).to match(
-      /^ +config.public_file_server.headers = {\n +"Cache-Control" => "public,/,
+      /^ +config.public_file_server.headers = {\n +"Cache-Control" => "public,/
     )
   end
 
   it "configures production environment to enforce SSL" do
     expect(production_config).to match(
-      /^ +config.force_ssl = true/,
+      /^ +config.force_ssl = true/
     )
   end
 
@@ -160,8 +141,8 @@ RSpec.describe "Suspend a new project with default configuration" do
   end
 
   it "configs :test email delivery method for development" do
-    expect(development_config).
-      to match(/^ +config.action_mailer.delivery_method = :file$/)
+    expect(development_config)
+      .to match(/^ +config.action_mailer.delivery_method = :file$/)
   end
 
   it "sets action mailer default host and asset host" do
@@ -180,8 +161,8 @@ RSpec.describe "Suspend a new project with default configuration" do
     email_file = File.join(project_path, "config", "initializers", "email.rb")
     email_config = IO.read(email_file)
 
-    expect(email_config).
-      to include(%{RecipientInterceptor.new(ENV["EMAIL_RECIPIENTS"])})
+    expect(email_config)
+      .to include(%{RecipientInterceptor.new(ENV["EMAIL_RECIPIENTS"])})
   end
 
   it "configures language in html element" do
@@ -205,26 +186,28 @@ RSpec.describe "Suspend a new project with default configuration" do
     delayed_job = IO.read("#{project_path}/bin/delayed_job")
 
     expect(delayed_job).to match(
-      /^require 'delayed\/command'$/,
+      /^require 'delayed\/command'$/
     )
   end
 
   it "configs bullet gem in development" do
-    expect(development_config).to match /^ +Bullet.enable = true$/
-    expect(development_config).to match /^ +Bullet.bullet_logger = true$/
-    expect(development_config).to match /^ +Bullet.rails_logger = true$/
+    expect(development_config).to match(/^ +Bullet.enable = true$/)
+    expect(development_config).to match(/^ +Bullet.bullet_logger = true$/)
+    expect(development_config).to match(/^ +Bullet.rails_logger = true$/)
+    # prevent broken result of standard removing whitespaces
+    expect(development_config).to_not match(/trueconfig/)
   end
 
   it "configs missing assets to raise in test" do
     expect(test_config).to match(
-      /^ +config.assets.raise_runtime_errors = true$/,
+      /^ +config.assets.raise_runtime_errors = true$/
     )
   end
 
   it "adds spring to binstubs" do
     expect(File).to exist("#{project_path}/bin/spring")
 
-    bin_stubs = %w(rake rails rspec)
+    bin_stubs = %w[rake rails rspec]
     bin_stubs.each do |bin_stub|
       expect(IO.read("#{project_path}/bin/#{bin_stub}")).to match(/spring/)
     end
@@ -236,7 +219,7 @@ RSpec.describe "Suspend a new project with default configuration" do
       IO.read("#{project_path}/config/environment.rb"),
       development_config,
       test_config,
-      production_config,
+      production_config
     ]
 
     config_files.each do |file|
@@ -256,8 +239,6 @@ RSpec.describe "Suspend a new project with default configuration" do
 
     expect(bin_setup).to include("PARENT_APP_NAME=#{app_name.dasherize}-staging")
     expect(bin_setup).to include("APP_NAME=#{app_name.dasherize}-staging-pr-$1")
-    expect(bin_setup).
-      to include("heroku run rails db:migrate --exit-code --app $APP_NAME")
     expect(bin_setup).to include("heroku ps:scale worker=1 --app $APP_NAME")
     expect(bin_setup).to include("heroku restart --app $APP_NAME")
 
@@ -268,7 +249,7 @@ RSpec.describe "Suspend a new project with default configuration" do
     bin_deploy_path = "#{project_path}/bin/deploy"
     bin_deploy = IO.read(bin_deploy_path)
 
-    expect(bin_deploy).to include("heroku run rails db:migrate --exit-code")
+    expect(bin_deploy).to include("git push")
     expect("bin/deploy").to be_executable
   end
 
@@ -293,42 +274,41 @@ RSpec.describe "Suspend a new project with default configuration" do
     expect(gemfile).to match(/sassc-rails/)
   end
 
-  it "adds and configures bourbon and neat" do
+  it "adds and configures bourbon" do
     gemfile = read_project_file("Gemfile")
 
     expect(gemfile).to match(/bourbon/)
-    expect(gemfile).to match(/neat/)
   end
 
-  it "configures bourbon, neat, and bitters" do
-    app_css = read_project_file(%w(app assets stylesheets application.scss))
+  it "configures bourbon, and bitters" do
+    app_css = read_project_file(%w[app assets stylesheets application.scss])
     expect(app_css).to match(
-      /normalize\.css\/normalize.*bourbon.*neat.*base/m,
+      /normalize\.css\/normalize.*bourbon.*base/m
     )
   end
 
   it "doesn't use turbolinks" do
-    app_js = read_project_file(%w(app assets javascripts application.js))
+    app_js = read_project_file(%w[app javascript packs application.js])
     expect(app_js).not_to match(/turbolinks/)
   end
 
   it "configures Timecop safe mode" do
-    spec_helper = read_project_file(%w(spec spec_helper.rb))
+    spec_helper = read_project_file(%w[spec spec_helper.rb])
     expect(spec_helper).to match(/Timecop.safe_mode = true/)
   end
 
   def development_config
     @_development_config ||=
-      read_project_file %w(config environments development.rb)
+      read_project_file %w[config environments development.rb]
   end
 
   def test_config
-    @_test_config ||= read_project_file %w(config environments test.rb)
+    @_test_config ||= read_project_file %w[config environments test.rb]
   end
 
   def production_config
     @_production_config ||=
-      read_project_file %w(config environments production.rb)
+      read_project_file %w[config environments production.rb]
   end
 
   def analytics_partial

data/spec/features/preloader_spec.rb

@@ -0,0 +1,25 @@
+require "spec_helper"
+
+RSpec.describe "suspenders:preloader", type: :generator do
+  it "adds binstubs for Spring" do
+    with_app { generate("suspenders:preloader") }
+
+    expect("bin/rails").to match_contents(/spring/)
+    expect("config/spring.rb").to exist_as_a_file
+    expect("config/environments/test.rb").to \
+      match_contents(/config.cache_classes = false/)
+    expect("Gemfile").to match_contents(/spring/)
+    expect("Gemfile").to match_contents(/spring-watcher-listen/)
+  end
+
+  it "removes Spring binstubs" do
+    with_app { destroy("suspenders:preloader") }
+
+    expect("config/environments/test.rb").to \
+      match_contents(/config.cache_classes = true/)
+    expect("config/spring.rb").not_to exist_as_a_file
+    expect("bin/rails").not_to match_contents(/spring/)
+    expect("Gemfile").not_to match_contents(/spring-watcher-listen/)
+    expect("Gemfile").not_to match_contents(/spring/)
+  end
+end