suspenders 1.51.0 → 1.55.0

data/spec/features/new_project_spec.rb

@@ -11,27 +11,27 @@ RSpec.describe "Suspend a new project with default configuration" do
   it "uses custom Gemfile" do
     gemfile_file = IO.read("#{project_path}/Gemfile")
     expect(gemfile_file).to match(
-      /^ruby "#{Suspenders::RUBY_VERSION}"$/,
+      /^ruby "#{Suspenders::RUBY_VERSION}"$/
     )
     expect(gemfile_file).to match(
-      /^gem "autoprefixer-rails"$/,
+      /^gem "autoprefixer-rails"$/
     )
     expect(gemfile_file).to match(
-      /^gem "rails", "#{Suspenders::RAILS_VERSION}"$/,
+      /^gem "rails", "#{Suspenders::RAILS_VERSION}"$/
     )
   end
 
   it "ensures project specs pass" do
     Dir.chdir(project_path) do
-      Bundler.with_clean_env do
-        expect(`rake`).to include('0 failures')
+      Bundler.with_unbundled_env do
+        expect(`rake`).to include("0 failures")
       end
     end
   end
 
   it "includes the bundle:audit task" do
     Dir.chdir(project_path) do
-      Bundler.with_clean_env do
+      Bundler.with_unbundled_env do
         expect(`rails -T`).to include("rails bundle:audit")
       end
     end
@@ -44,9 +44,7 @@ RSpec.describe "Suspend a new project with default configuration" do
   end
 
   it "copies dotfiles" do
-    %w[.ctags .env].each do |dotfile|
-      expect(File).to exist("#{project_path}/#{dotfile}")
-    end
+    expect(File).to exist("#{project_path}/.sample.env")
   end
 
   it "doesn't generate test directory" do
@@ -56,8 +54,8 @@ RSpec.describe "Suspend a new project with default configuration" do
   it "loads secret_key_base from env" do
     secrets_file = IO.read("#{project_path}/config/secrets.yml")
 
-    expect(secrets_file).
-      to match(/secret_key_base: <%= ENV\["SECRET_KEY_BASE"\] %>/)
+    expect(secrets_file)
+      .to match(/secret_key_base: <%= ENV\["SECRET_KEY_BASE"\] %>/)
   end
 
   it "adds bin/setup file" do
@@ -86,33 +84,16 @@ RSpec.describe "Suspend a new project with default configuration" do
     expect(hound_config_file).to include "enabled: true"
   end
 
-  it "ensures Gemfile contains `rack-mini-profiler`" do
-    gemfile = IO.read("#{project_path}/Gemfile")
-
-    expect(gemfile).to include %{gem "rack-mini-profiler", require: false}
-  end
-
-  it "ensures .sample.env defaults to RACK_MINI_PROFILER=0" do
-    env = IO.read("#{project_path}/.env")
-
-    expect(env).to include "RACK_MINI_PROFILER=0"
-  end
-
   it "initializes ActiveJob to avoid memory bloat" do
-    expect(File).
-      to exist("#{project_path}/config/initializers/active_job.rb")
-  end
-
-  it "creates a rack-mini-profiler initializer" do
-    expect(File).
-      to exist("#{project_path}/config/initializers/rack_mini_profiler.rb")
+    expect(File)
+      .to exist("#{project_path}/config/initializers/active_job.rb")
   end
 
   it "records pageviews through Segment if ENV variable set" do
-    expect(analytics_partial).
-      to include(%{<% if ENV["SEGMENT_KEY"] %>})
-    expect(analytics_partial).
-      to include(%{analytics.load("<%= ENV["SEGMENT_KEY"] %>");})
+    expect(analytics_partial)
+      .to include(%(<% if ENV["SEGMENT_KEY"] %>))
+    expect(analytics_partial)
+      .to include(%{analytics.load("<%= ENV["SEGMENT_KEY"] %>");})
   end
 
   it "raises on unpermitted parameters in all environments" do
@@ -131,13 +112,13 @@ RSpec.describe "Suspend a new project with default configuration" do
 
   it "configures public_file_server.headers in production" do
     expect(production_config).to match(
-      /^ +config.public_file_server.headers = {\n +"Cache-Control" => "public,/,
+      /^ +config.public_file_server.headers = {\n +"Cache-Control" => "public,/
     )
   end
 
   it "configures production environment to enforce SSL" do
     expect(production_config).to match(
-      /^ +config.force_ssl = true/,
+      /^ +config.force_ssl = true/
     )
   end
 
@@ -160,8 +141,8 @@ RSpec.describe "Suspend a new project with default configuration" do
   end
 
   it "configs :test email delivery method for development" do
-    expect(development_config).
-      to match(/^ +config.action_mailer.delivery_method = :file$/)
+    expect(development_config)
+      .to match(/^ +config.action_mailer.delivery_method = :file$/)
   end
 
   it "sets action mailer default host and asset host" do
@@ -180,8 +161,8 @@ RSpec.describe "Suspend a new project with default configuration" do
     email_file = File.join(project_path, "config", "initializers", "email.rb")
     email_config = IO.read(email_file)
 
-    expect(email_config).
-      to include(%{RecipientInterceptor.new(ENV["EMAIL_RECIPIENTS"])})
+    expect(email_config)
+      .to include(%{RecipientInterceptor.new(ENV["EMAIL_RECIPIENTS"])})
   end
 
   it "configures language in html element" do
@@ -205,26 +186,26 @@ RSpec.describe "Suspend a new project with default configuration" do
     delayed_job = IO.read("#{project_path}/bin/delayed_job")
 
     expect(delayed_job).to match(
-      /^require 'delayed\/command'$/,
+      /^require 'delayed\/command'$/
     )
   end
 
   it "configs bullet gem in development" do
-    expect(development_config).to match /^ +Bullet.enable = true$/
-    expect(development_config).to match /^ +Bullet.bullet_logger = true$/
-    expect(development_config).to match /^ +Bullet.rails_logger = true$/
+    expect(development_config).to match(/^ +Bullet.enable = true$/)
+    expect(development_config).to match(/^ +Bullet.bullet_logger = true$/)
+    expect(development_config).to match(/^ +Bullet.rails_logger = true$/)
   end
 
   it "configs missing assets to raise in test" do
     expect(test_config).to match(
-      /^ +config.assets.raise_runtime_errors = true$/,
+      /^ +config.assets.raise_runtime_errors = true$/
     )
   end
 
   it "adds spring to binstubs" do
     expect(File).to exist("#{project_path}/bin/spring")
 
-    bin_stubs = %w(rake rails rspec)
+    bin_stubs = %w[rake rails rspec]
     bin_stubs.each do |bin_stub|
       expect(IO.read("#{project_path}/bin/#{bin_stub}")).to match(/spring/)
     end
@@ -236,7 +217,7 @@ RSpec.describe "Suspend a new project with default configuration" do
       IO.read("#{project_path}/config/environment.rb"),
       development_config,
       test_config,
-      production_config,
+      production_config
     ]
 
     config_files.each do |file|
@@ -256,8 +237,6 @@ RSpec.describe "Suspend a new project with default configuration" do
 
     expect(bin_setup).to include("PARENT_APP_NAME=#{app_name.dasherize}-staging")
     expect(bin_setup).to include("APP_NAME=#{app_name.dasherize}-staging-pr-$1")
-    expect(bin_setup).
-      to include("heroku run rails db:migrate --exit-code --app $APP_NAME")
     expect(bin_setup).to include("heroku ps:scale worker=1 --app $APP_NAME")
     expect(bin_setup).to include("heroku restart --app $APP_NAME")
 
@@ -268,7 +247,7 @@ RSpec.describe "Suspend a new project with default configuration" do
     bin_deploy_path = "#{project_path}/bin/deploy"
     bin_deploy = IO.read(bin_deploy_path)
 
-    expect(bin_deploy).to include("heroku run rails db:migrate --exit-code")
+    expect(bin_deploy).to include("git push")
     expect("bin/deploy").to be_executable
   end
 
@@ -293,42 +272,41 @@ RSpec.describe "Suspend a new project with default configuration" do
     expect(gemfile).to match(/sassc-rails/)
   end
 
-  it "adds and configures bourbon and neat" do
+  it "adds and configures bourbon" do
     gemfile = read_project_file("Gemfile")
 
     expect(gemfile).to match(/bourbon/)
-    expect(gemfile).to match(/neat/)
   end
 
-  it "configures bourbon, neat, and bitters" do
-    app_css = read_project_file(%w(app assets stylesheets application.scss))
+  it "configures bourbon, and bitters" do
+    app_css = read_project_file(%w[app assets stylesheets application.scss])
     expect(app_css).to match(
-      /normalize\.css\/normalize.*bourbon.*neat.*base/m,
+      /normalize\.css\/normalize.*bourbon.*base/m
     )
   end
 
   it "doesn't use turbolinks" do
-    app_js = read_project_file(%w(app assets javascripts application.js))
+    app_js = read_project_file(%w[app javascript packs application.js])
     expect(app_js).not_to match(/turbolinks/)
   end
 
   it "configures Timecop safe mode" do
-    spec_helper = read_project_file(%w(spec spec_helper.rb))
+    spec_helper = read_project_file(%w[spec spec_helper.rb])
     expect(spec_helper).to match(/Timecop.safe_mode = true/)
   end
 
   def development_config
     @_development_config ||=
-      read_project_file %w(config environments development.rb)
+      read_project_file %w[config environments development.rb]
   end
 
   def test_config
-    @_test_config ||= read_project_file %w(config environments test.rb)
+    @_test_config ||= read_project_file %w[config environments test.rb]
   end
 
   def production_config
     @_production_config ||=
-      read_project_file %w(config environments production.rb)
+      read_project_file %w[config environments production.rb]
   end
 
   def analytics_partial

data/spec/features/preloader_spec.rb

@@ -0,0 +1,25 @@
+require "spec_helper"
+
+RSpec.describe "suspenders:preloader", type: :generator do
+  it "adds binstubs for Spring" do
+    with_app { generate("suspenders:preloader") }
+
+    expect("bin/rails").to match_contents(/spring/)
+    expect("config/spring.rb").to exist_as_a_file
+    expect("config/environments/test.rb").to \
+      match_contents(/config.cache_classes = false/)
+    expect("Gemfile").to match_contents(/spring/)
+    expect("Gemfile").to match_contents(/spring-watcher-listen/)
+  end
+
+  it "removes Spring binstubs" do
+    with_app { destroy("suspenders:preloader") }
+
+    expect("config/environments/test.rb").to \
+      match_contents(/config.cache_classes = true/)
+    expect("config/spring.rb").not_to exist_as_a_file
+    expect("bin/rails").not_to match_contents(/spring/)
+    expect("Gemfile").not_to match_contents(/spring-watcher-listen/)
+    expect("Gemfile").not_to match_contents(/spring/)
+  end
+end

data/spec/features/production/compression_spec.rb

@@ -0,0 +1,23 @@
+require "spec_helper"
+
+RSpec.describe "suspenders:production:compression", type: :generator do
+  context "generate" do
+    it "adds Rack::Deflater to the middleware" do
+      with_app { generate("suspenders:production:compression") }
+
+      expect("config/environments/production.rb").to match_contents(
+        %r{config.middleware.use Rack::Deflater}
+      )
+    end
+  end
+
+  context "destroy" do
+    it "removes Rack::Deflater to the middleware" do
+      with_app { destroy("suspenders:production:compression") }
+
+      expect("config/environments/production.rb").not_to match_contents(
+        %r{Rack::Deflater}
+      )
+    end
+  end
+end

data/spec/features/production/email_spec.rb

@@ -15,11 +15,11 @@ RSpec.describe "suspenders:production:email", type: :generator do
 
     expect("app.json").to contain_json(
       env: {
-        SMTP_ADDRESS: { required: true },
-        SMTP_DOMAIN: { required: true },
-        SMTP_PASSWORD: { required: true },
-        SMTP_USERNAME: { required: true },
-      },
+        SMTP_ADDRESS: {required: true},
+        SMTP_DOMAIN: {required: true},
+        SMTP_PASSWORD: {required: true},
+        SMTP_USERNAME: {required: true}
+      }
     )
   end
 
@@ -37,11 +37,11 @@ RSpec.describe "suspenders:production:email", type: :generator do
 
     expect("app.json").not_to contain_json(
       env: {
-        SMTP_ADDRESS: { required: true },
-        SMTP_DOMAIN: { required: true },
-        SMTP_PASSWORD: { required: true },
-        SMTP_USERNAME: { required: true },
-      },
+        SMTP_ADDRESS: {required: true},
+        SMTP_DOMAIN: {required: true},
+        SMTP_PASSWORD: {required: true},
+        SMTP_USERNAME: {required: true}
+      }
     )
   end
 end

data/spec/features/production/manifest_spec.rb

@@ -7,13 +7,14 @@ RSpec.describe "suspenders:production:manifest", type: :generator do
     expect("app.json").to contain_json(
       name: SuspendersTestHelpers::APP_NAME.dasherize,
       env: {
-        APPLICATION_HOST: { required: true },
-        EMAIL_RECIPIENTS: { required: true },
-        HEROKU_APP_NAME: { required: true },
-        HEROKU_PARENT_APP_NAME: { required: true },
-        RACK_ENV: { required: true },
-        SECRET_KEY_BASE: { generator: "secret" },
-      },
+        APPLICATION_HOST: {required: true},
+        AUTO_MIGRATE_DB: {value: true},
+        EMAIL_RECIPIENTS: {required: true},
+        HEROKU_APP_NAME: {required: true},
+        HEROKU_PARENT_APP_NAME: {required: true},
+        RACK_ENV: {required: true},
+        SECRET_KEY_BASE: {generator: "secret"}
+      }
     )
   end
 
@@ -23,13 +24,14 @@ RSpec.describe "suspenders:production:manifest", type: :generator do
     expect("app.json").not_to contain_json(
       name: SuspendersTestHelpers::APP_NAME.dasherize,
       env: {
-        APPLICATION_HOST: { required: true },
-        EMAIL_RECIPIENTS: { required: true },
-        HEROKU_APP_NAME: { required: true },
-        HEROKU_PARENT_APP_NAME: { required: true },
-        RACK_ENV: { required: true },
-        SECRET_KEY_BASE: { generator: "secret" },
-      },
+        APPLICATION_HOST: {required: true},
+        AUTO_MIGRATE_DB: {value: true},
+        EMAIL_RECIPIENTS: {required: true},
+        HEROKU_APP_NAME: {required: true},
+        HEROKU_PARENT_APP_NAME: {required: true},
+        RACK_ENV: {required: true},
+        SECRET_KEY_BASE: {generator: "secret"}
+      }
     )
   end
 end

data/spec/features/production/single_redirect_spec.rb

@@ -0,0 +1,25 @@
+require "spec_helper"
+
+RSpec.describe "suspenders:production:single_redirect", type: :generator do
+  context "generate" do
+    it "adds Rack::CanonicalHost to the production middleware" do
+      with_app { generate("suspenders:production:single_redirect") }
+      middleware_canonical_host = %r{config.middleware.use Rack::CanonicalHost, ENV.fetch\("APPLICATION_HOST"\)}
+
+      expect("config/environments/production.rb").to match_contents(
+        middleware_canonical_host
+      )
+    end
+  end
+
+  context "destroy" do
+    it "removes Rack::CanonicalHost from the production middleware" do
+      with_app { destroy("suspenders:production:single_redirect") }
+      middleware_canonical_host = %r{config.middleware.use Rack::CanonicalHost, ENV.fetch\("APPLICATION_HOST"\)}
+
+      expect("config/environments/production.rb").not_to match_contents(
+        middleware_canonical_host
+      )
+    end
+  end
+end

data/spec/features/profiler_spec.rb

@@ -0,0 +1,20 @@
+require "spec_helper"
+
+RSpec.describe "suspenders:profiler", type: :generator do
+  it "sets up rack-min-profiler" do
+    with_app { generate("suspenders:profiler") }
+
+    expect("config/initializers/rack_mini_profiler.rb").to \
+      match_contents(/Rack::MiniProfilerRails.initialize/)
+    expect("Gemfile").to match_contents(/rack-mini-profiler/)
+    expect(".sample.env").to match_contents(/RACK_MINI_PROFILER=0/)
+  end
+
+  it "removes rack-min-profiler" do
+    with_app { destroy("suspenders:profiler") }
+
+    expect("config/initializers/rack_mini_profiler.rb").not_to exist_as_a_file
+    expect("Gemfile").not_to match_contents(/rack-mini-profiler/)
+    expect(".sample.env").not_to exist_as_a_file
+  end
+end

data/spec/features/runner_spec.rb

@@ -0,0 +1,30 @@
+require "spec_helper"
+
+RSpec.describe "suspenders:runner", type: :generator do
+  it "configures the app for running" do
+    with_app { generate("suspenders:runner") }
+
+    expect("Procfile").to exist_as_a_file
+    expect(".sample.env").to exist_as_a_file
+    expect("bin/setup").to match_contents(/\.sample\.env/)
+    expect("README.md").to match_contents(/\.sample\.env/)
+  end
+
+  it "removes custom app running configuration" do
+    with_app { destroy("suspenders:runner") }
+
+    expect("README.md").not_to match_contents(/\.sample\.env/)
+    expect("bin/setup").not_to match_contents(/\.sample\.env/)
+    expect(".sample.env").not_to exist_as_a_file
+    expect("Procfile").not_to exist_as_a_file
+  end
+
+  it "configures the app with a shell script bin/setup" do
+    with_app do
+      copy_file "bin_setup", "bin/setup"
+      generate("suspenders:runner")
+    end
+
+    expect("bin/setup").to match_contents(/\.sample\.env/)
+  end
+end