suspenders 1.43.0 → 1.44.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d1ebe4a4d98a7ed7b267b94ef68fda1bc2d95d21
-  data.tar.gz: c2a35b12c6f1d5a9bbf73d0a7848de38ea50b6bd
+  metadata.gz: c484e3bcdd101a9754109743b48f4bd1365667af
+  data.tar.gz: 8172832bc1d310452d31368dd98b32c5563932d5
 SHA512:
-  metadata.gz: 8612cbfb63b2363a2292785bb91410d51183b1e3c6e365ceffcd8dbeab8185a583bd732502817af1235189512c641d0f31891d447b4dc391a11d3c1d6dc765c1
-  data.tar.gz: 0b3c04d117d56a3149bed409f8427ea9eae743d5e1085dfc47dd99dcfccf864b66a29e003f0dce994399c14f508bf77cce469ec6884371a9097d8b9293056c75
+  metadata.gz: 21e949d9c811b1264ee995b4fd5238f3690f294e41adbad8ac59ee1d8d0d720f32aae3b42eb8be074f2b7ad410068179b8ee8fa196c40ca54c077af075df2e0a
+  data.tar.gz: ee9e71d1473f0bd77f30192dfcfd462454c0cec67fabfedf794f1fec331fa0e75d6b4e328eb062d141cb6e93e5dae00c09c64832c74eb800af66bf67917551fe

data/.ruby-version

@@ -1 +1 @@
-2.3.1
+2.4.0

data/.travis.yml

@@ -1,5 +1,5 @@
 language: ruby
-rvm: 2.3.1
+rvm: 2.4.0
 cache: bundler
 sudo: false
 before_install:

data/NEWS.md

@@ -1,3 +1,11 @@
+1.44.0 (January 25, 2017)
+
+* Improve readability of `bin/setup-review-app` (#819)
+* Update scripts to be `sh`-compatible (#820)
+* Remove `rails_stdout_logging` gem (#818)
+* Remove `12factor` gem (#817)
+* Update Ruby to 2.4.0 (#814)
+
 1.43.0 (November 8, 2016)
 
 * Update Bourbon to 5.0.0.beta.7

data/README.md

@@ -129,13 +129,8 @@ This:
 * Sets them as `staging` and `production` Git remotes
 * Configures staging with `RACK_ENV` environment variable set
   to `staging`
-* Adds the [Rails Stdout Logging][logging-gem] gem
-  to configure the app to log to standard out,
-  which is how [Heroku's logging][heroku-logging] works.
 * Creates a [Heroku Pipeline] for review apps
 
-[logging-gem]: https://github.com/heroku/rails_stdout_logging
-[heroku-logging]: https://devcenter.heroku.com/articles/logging#writing-to-your-log
 [Heroku Pipeline]: https://devcenter.heroku.com/articles/pipelines
 
 You can optionally specify alternate Heroku flags:

data/lib/suspenders/adapters/heroku.rb

@@ -87,7 +87,7 @@ module Suspenders
         heroku_app_name = heroku_app_name_for(environment)
         <<~SHELL
 
-          if heroku join --app #{heroku_app_name} &> /dev/null; then
+          if heroku join --app #{heroku_app_name} > /dev/null 2>&1; then
             git remote add #{environment} git@heroku.com:#{heroku_app_name}.git || true
             printf 'You are a collaborator on the "#{heroku_app_name}" Heroku app\n'
           else

data/lib/suspenders/app_builder.rb

@@ -106,7 +106,7 @@ module Suspenders
 
     config.generators do |generate|
       generate.helper false
-      generate.javascript_engine false
+      generate.javascripts false
       generate.request_specs false
       generate.routing_specs false
       generate.stylesheets false

data/lib/suspenders/version.rb

@@ -4,5 +4,5 @@ module Suspenders
     read("#{File.dirname(__FILE__)}/../../.ruby-version").
     strip.
     freeze
-  VERSION = "1.43.0".freeze
+  VERSION = "1.44.0".freeze
 end

data/spec/features/new_project_spec.rb

@@ -119,7 +119,6 @@ RSpec.describe "Suspend a new project with default configuration" do
   end
 
   it "configures public_file_server.headers in production" do
-    IO.write("production_config.rb", production_config)
     expect(production_config).to match(
       /^ +config.public_file_server.headers = {\n +"Cache-Control" => "public,/,
     )
@@ -220,12 +219,12 @@ RSpec.describe "Suspend a new project with default configuration" do
     bin_setup_path = "#{project_path}/bin/setup_review_app"
     bin_setup = IO.read(bin_setup_path)
 
-    expect(bin_setup).to include("heroku run rake db:migrate --exit-code "\
-                                 "--app #{app_name.dasherize}-staging-pr-$1")
-    expect(bin_setup).to include("heroku ps:scale worker=1 "\
-                                 "--app #{app_name.dasherize}-staging-pr-$1")
-    expect(bin_setup).to include("heroku restart "\
-                                 "--app #{app_name.dasherize}-staging-pr-$1")
+    expect(bin_setup).to include("PARENT_APP_NAME=#{app_name.dasherize}-staging")
+    expect(bin_setup).to include("APP_NAME=#{app_name.dasherize}-staging-pr-$1")
+    expect(bin_setup).to include("heroku run rake db:migrate --exit-code --app $APP_NAME")
+    expect(bin_setup).to include("heroku ps:scale worker=1 --app $APP_NAME")
+    expect(bin_setup).to include("heroku restart --app $APP_NAME")
+
     expect(File.stat(bin_setup_path)).to be_executable
   end
 
@@ -243,12 +242,6 @@ RSpec.describe "Suspend a new project with default configuration" do
     expect(app_json_file).to match(/"name":"#{app_name.dasherize}"/)
   end
 
-  it "sets up heroku specific gems" do
-    gemfile_file = IO.read("#{project_path}/Gemfile")
-
-    expect(gemfile_file).to include %{gem "rails_stdout_logging"}
-  end
-
   def app_name
     SuspendersTestHelpers::APP_NAME
   end

data/templates/Gemfile.erb

@@ -36,7 +36,7 @@ group :development, :test do
   gem "factory_girl_rails"
   gem "pry-byebug"
   gem "pry-rails"
-  gem "rspec-rails", "~> 3.5.0.beta4"
+  gem "rspec-rails", "~> 3.5"
 end
 
 group :development, :staging do
@@ -56,5 +56,4 @@ end
 
 group :staging, :production do
   gem "rack-timeout"
-  gem "rails_stdout_logging"
 end

data/templates/bin_setup_review_app.erb

@@ -9,11 +9,11 @@ if [ -z "$1" ]; then
   exit 64
 fi
 
-heroku pg:backups restore \
-  `heroku pg:backups public-url -a <%= app_name.dasherize %>-staging` \
-  DATABASE_URL \
-  --confirm <%= app_name.dasherize %>-staging-pr-$1 \
-  --app <%= app_name.dasherize %>-staging-pr-$1
-heroku run rake db:migrate --exit-code --app <%= app_name.dasherize %>-staging-pr-$1
-heroku ps:scale worker=1 --app <%= app_name.dasherize %>-staging-pr-$1
-heroku restart --app <%= app_name.dasherize %>-staging-pr-$1
+PARENT_APP_NAME=<%= app_name.dasherize %>-staging
+APP_NAME=<%= app_name.dasherize %>-staging-pr-$1
+URL=`heroku pg:backups public-url -a $PARENT_APP_NAME`
+
+heroku pg:backups restore $URL DATABASE_URL --confirm $APP_NAME --app $APP_NAME
+heroku run rake db:migrate --exit-code --app $APP_NAME
+heroku ps:scale worker=1 --app $APP_NAME
+heroku restart --app $APP_NAME

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: suspenders
 version: !ruby/object:Gem::Version
-  version: 1.43.0
+  version: 1.44.0
 platform: ruby
 authors:
 - thoughtbot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-08 00:00:00.000000000 Z
+date: 2017-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bitters
@@ -165,7 +165,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.1
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -173,7 +173,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Generate a Rails app using thoughtbot's best practices.