surveyor 0.7.1 → 0.8.0

data/spec/models/dependency_condition_spec.rb

@@ -58,36 +58,19 @@ describe DependencyCondition, "instance" do
   it "should evaluate within the context of a response set object" do
     @response = Response.new(:question_id => 45, :response_set_id => 40, :answer_id => 23)
     @response.answer = Answer.new(:question_id => 45, :response_class => "answer")
-    @response_set = ResponseSet.new()
-    @response_set.stub!(:find_response).and_return(@response)
-    @dependency_condition.evaluation_of(@response_set).should be_true
+    @dependency_condition.is_met?(@response).should be_true
     # inversion
     @alt_response = Response.new(:question_id => 45, :response_set_id => 40, :answer_id => 55)
     @alt_response.answer = Answer.new(:question_id => 45, :response_class => "answer")
-    @alt_resp_set = ResponseSet.new()
 
-    @alt_resp_set.stub!(:find_response).and_return(@alt_response)
-    @dependency_condition.evaluation_of(@alt_resp_set).should be_false
-
-  end
-  
-  it "should return false if there is no response set value that corresponds to the dependency condition" do
-    @empty_rs = mock(ResponseSet, :find_response => nil)
-    @dependency_condition.evaluation_of(@empty_rs).should be_false
+    @dependency_condition.is_met?(@alt_response).should be_false
   end
   
-  describe "when helping the dependency object determine state" do
-    
-    it "returns its key as a symbol" do
-      @dependency_condition.symbol_key.should == @dependency_condition.rule_key.to_sym 
-    end
-    
-    it "converts to a hash for evaluation by the depedency object" do
-      @rs = mock(ResponseSet)
-      @dependency_condition.stub!(:evaluation_of).with(@rs)
-      @dependency_condition.to_evaluation_hash(@rs)
-    end
-    
+  it "converts to a hash for evaluation by the depedency object" do
+    @response = Response.new(:question_id => 45, :response_set_id => 40, :answer_id => 23)
+    @rs = mock(ResponseSet, :responses => [@response])
+    @dependency_condition.stub!(:is_met?).and_return(true)
+    @dependency_condition.to_hash(@rs)
   end
 end
 
@@ -106,45 +89,45 @@ describe DependencyCondition, "evaluting the resonse_set state" do
     end
 
     it "knows checkbox/radio type response" do
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
       @dep_c.answer_id = 12
-      @dep_c.is_satisfied_by?(@response).should be_false
+      @dep_c.is_met?(@response).should be_false
     end
 
     it "knows string value response" do
       @select_answer.response_class = "string"
       @response.string_value = "hello123"
       @dep_c.string_value = "hello123"
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
       @response.string_value = "foo_abc"
-      @dep_c.is_satisfied_by?(@response).should be_false
+      @dep_c.is_met?(@response).should be_false
     end
 
     it "knows a text value response" do
       @select_answer.response_class = "text"
       @response.text_value = "hello this is some text for comparison"
       @dep_c.text_value = "hello this is some text for comparison"
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
       @response.text_value = "Not the same text"
-      @dep_c.is_satisfied_by?(@response).should be_false 
+      @dep_c.is_met?(@response).should be_false 
     end
 
     it "knows an integer value response" do
       @select_answer.response_class = "integer"
       @response.integer_value = 10045
       @dep_c.integer_value = 10045
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
       @response.integer_value = 421
-      @dep_c.is_satisfied_by?(@response).should be_false
+      @dep_c.is_met?(@response).should be_false
     end
 
     it "knows a float value response" do
       @select_answer.response_class = "float"
       @response.float_value = 121.1
       @dep_c.float_value = 121.1
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
       @response.float_value = 130.123
-      @dep_c.is_satisfied_by?(@response).should be_false
+      @dep_c.is_met?(@response).should be_false
     end
 
   end
@@ -162,45 +145,45 @@ describe DependencyCondition, "evaluting the resonse_set state" do
     end
 
     it "knows checkbox/radio type response" do
-      @dep_c.is_satisfied_by?(@response).should be_false
+      @dep_c.is_met?(@response).should be_false
       @dep_c.answer_id = 12
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
     end
 
     it "knows string value response" do
       @select_answer.response_class = "string"
       @response.string_value = "hello123"
       @dep_c.string_value = "hello123"
-      @dep_c.is_satisfied_by?(@response).should be_false
+      @dep_c.is_met?(@response).should be_false
       @response.string_value = "foo_abc"
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
     end
 
     it "knows a text value response" do
       @select_answer.response_class = "text"
       @response.text_value = "hello this is some text for comparison"
       @dep_c.text_value = "hello this is some text for comparison"
-      @dep_c.is_satisfied_by?(@response).should be_false
+      @dep_c.is_met?(@response).should be_false
       @response.text_value = "Not the same text"
-      @dep_c.is_satisfied_by?(@response).should be_true 
+      @dep_c.is_met?(@response).should be_true 
     end
 
     it "knows an integer value response" do
       @select_answer.response_class = "integer"
       @response.integer_value = 10045
       @dep_c.integer_value = 10045
-      @dep_c.is_satisfied_by?(@response).should be_false
+      @dep_c.is_met?(@response).should be_false
       @response.integer_value = 421
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
     end
 
     it "knows a float value response" do
       @select_answer.response_class = "float"
       @response.float_value = 121.1
       @dep_c.float_value = 121.1
-      @dep_c.is_satisfied_by?(@response).should be_false
+      @dep_c.is_met?(@response).should be_false
       @response.float_value = 130.123
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
     end
 
   end
@@ -219,18 +202,18 @@ describe DependencyCondition, "evaluting the resonse_set state" do
       @select_answer.response_class = "integer"
       @response.integer_value = 50
       @dep_c.integer_value = 100
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
       @response.integer_value = 421
-      @dep_c.is_satisfied_by?(@response).should be_false
+      @dep_c.is_met?(@response).should be_false
     end
 
     it "knows operator on float value response" do
       @select_answer.response_class = "float"
       @response.float_value = 5.1
       @dep_c.float_value = 121.1
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
       @response.float_value = 130.123
-      @dep_c.is_satisfied_by?(@response).should be_false
+      @dep_c.is_met?(@response).should be_false
     end
 
   end
@@ -249,22 +232,22 @@ describe DependencyCondition, "evaluting the resonse_set state" do
       @select_answer.response_class = "integer"
       @response.integer_value = 50
       @dep_c.integer_value = 100
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
       @response.integer_value = 100
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
       @response.integer_value = 421
-      @dep_c.is_satisfied_by?(@response).should be_false
+      @dep_c.is_met?(@response).should be_false
     end
 
     it "knows operator on float value response" do
       @select_answer.response_class = "float"
       @response.float_value = 5.1
       @dep_c.float_value = 121.1
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
       @response.float_value = 121.1
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
       @response.float_value = 130.123
-      @dep_c.is_satisfied_by?(@response).should be_false
+      @dep_c.is_met?(@response).should be_false
     end
 
   end
@@ -283,18 +266,18 @@ describe DependencyCondition, "evaluting the resonse_set state" do
       @select_answer.response_class = "integer"
       @response.integer_value = 50
       @dep_c.integer_value = 100
-      @dep_c.is_satisfied_by?(@response).should be_false
+      @dep_c.is_met?(@response).should be_false
       @response.integer_value = 421
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
     end
 
     it "knows operator on float value response" do
       @select_answer.response_class = "float"
       @response.float_value = 5.1
       @dep_c.float_value = 121.1
-      @dep_c.is_satisfied_by?(@response).should be_false
+      @dep_c.is_met?(@response).should be_false
       @response.float_value = 130.123
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
     end
 
   end
@@ -313,22 +296,22 @@ describe DependencyCondition, "evaluting the resonse_set state" do
       @select_answer.response_class = "integer"
       @response.integer_value = 50
       @dep_c.integer_value = 100
-      @dep_c.is_satisfied_by?(@response).should be_false
+      @dep_c.is_met?(@response).should be_false
       @response.integer_value = 100
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
       @response.integer_value = 421
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
     end
 
     it "knows operator on float value response" do
       @select_answer.response_class = "float"
       @response.float_value = 5.1
       @dep_c.float_value = 121.1
-      @dep_c.is_satisfied_by?(@response).should be_false
+      @dep_c.is_met?(@response).should be_false
       @response.float_value = 121.1
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
       @response.float_value = 130.123
-      @dep_c.is_satisfied_by?(@response).should be_true
+      @dep_c.is_met?(@response).should be_true
     end
   end
   

data/spec/models/dependency_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe Dependency do
   before(:each) do
-    @dependency = Dependency.new(:rule => "1 and 2 or 3", :question_id => 23)
+    @dependency = Factory(:dependency)
   end
 
   it "should be valid" do
@@ -19,6 +19,13 @@ describe Dependency do
   it "should be invalid without a question_id" do
     @dependency.question_id = nil
     @dependency.should have(1).error_on(:question_id)
+
+    @dependency.question_group_id = 1
+    @dependency.should be_valid
+
+    @dependency.question_id.should be_nil
+    @dependency.question_group_id = nil
+    @dependency.should have(1).error_on(:question_group_id)
   end
 
   it "should alias question_id as dependent_question_id" do
@@ -47,9 +54,9 @@ describe Dependency, "when evaluating dependency conditions of a question in a r
     @dep3 = Dependency.new(:rule => "A or B", :question_id => 1)
     @dep4 = Dependency.new(:rule => "!(A and B) and C", :question_id => 1)
     
-    @dep_c = mock_model(DependencyCondition, :id => 1, :rule_key => "A", :to_evaluation_hash => {:A => true})
-    @dep_c2 = mock_model(DependencyCondition, :id => 2, :rule_key => "B", :to_evaluation_hash => {:B => false})
-    @dep_c3 = mock_model(DependencyCondition, :id => 3, :rule_key => "C", :to_evaluation_hash => {:C => true})
+    @dep_c = mock_model(DependencyCondition, :id => 1, :rule_key => "A", :to_hash => {:A => true})
+    @dep_c2 = mock_model(DependencyCondition, :id => 2, :rule_key => "B", :to_hash => {:B => false})
+    @dep_c3 = mock_model(DependencyCondition, :id => 3, :rule_key => "C", :to_hash => {:C => true})
 
     @dep.stub!(:dependency_conditions).and_return([@dep_c])
     @dep2.stub!(:dependency_conditions).and_return([@dep_c, @dep_c2])
@@ -78,5 +85,4 @@ describe Dependency, "when evaluating dependency conditions of a question in a r
     @dep4.rule_evaluation(@dep4.keyed_conditions(@response_set)).should be_true
   end
   
-  
 end

data/spec/models/question_group_spec.rb

@@ -2,10 +2,34 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe QuestionGroup do
   before(:each) do
-    @question_group = QuestionGroup.new
+    @question_group = Factory(:question_group)
   end
 
   it "should be valid" do
     @question_group.should be_valid
   end
+  it "should have defaults" do
+    @question_group = QuestionGroup.new
+    @question_group.display_type.should == "inline"
+    @question_group.renderer.should == :inline
+    @question_group.display_type = nil
+    @question_group.renderer.should == :default
+  end
+  it "should return its custom css class" do
+    @question_group.custom_class = "foo bar"
+    @question_group.css_class(Factory(:response_set)).should == "foo bar"
+  end
+  it "should return its dependency class" do
+    @dependency = Factory(:dependency)
+    @question_group.dependency = @dependency
+    @dependency.should_receive(:met?).and_return(true)
+    @question_group.css_class(Factory(:response_set)).should == "dependent"
+
+    @dependency.should_receive(:met?).and_return(false)
+    @question_group.css_class(Factory(:response_set)).should == "dependent hidden"
+
+    @question_group.custom_class = "foo bar"
+    @dependency.should_receive(:met?).and_return(false)
+    @question_group.css_class(Factory(:response_set)).should == "dependent hidden foo bar"
+  end
 end

data/spec/models/question_spec.rb

@@ -53,7 +53,7 @@ describe Question, "when interacting with an instance" do
 
   it "should return 'default' for nil display type" do
     @question.display_type = nil
-    @question.display_type.should == "default"
+    @question.renderer.should == :default
   end
   
 end
@@ -69,7 +69,7 @@ describe Question, "with dependencies" do
     @dependency = mock_model(Dependency)
     @dependency.stub!(:met?).with(@rs).and_return(true)
     @question.stub!(:dependency).and_return(@dependency)
-    @question.dependency_is_satisfied?(@rs).should == true
+    @question.triggered?(@rs).should == true
   end
   
 end

data/spec/models/response_set_spec.rb

@@ -75,10 +75,6 @@ describe ResponseSet, "Updating the response set" do
     })
   end
 
-  it "should delete existing responses corresponding to every question key that comes in" do
-    Response.should_receive(:delete_all).exactly(3).times
-    @response_set.update_attributes(:response_attributes => @radio_response_attributes)
-  end
   it "should save new responses from radio buttons, ignoring blanks" do
     @response_set.update_attributes(:response_attributes => @radio_response_attributes)
     @response_set.responses.should have(2).items
@@ -108,37 +104,26 @@ describe ResponseSet, "Updating the response set" do
   end
 end
 
-describe ResponseSet, "knowing internal status" do
-  before(:each) do
-    @response_set = Factory(:response_set)
-  end
-  it "knows when it is empty"  do
-    @response_set.empty?.should be_true
-  end
-
-  it "knows when it is not empty" do
-    @response_set.responses.build({:question_id => 1, :answer_id => 8})
-    @response_set.empty?.should be_false
-  end
-end
 describe ResponseSet, "with dependencies" do
   before(:each) do
+    @section = Factory(:survey_section)
     # Questions
-    @do_you_like_pie = Factory(:question, :text => "Do you like pie?")
-    @what_flavor = Factory(:question, :text => "What flavor?")
-    @what_bakery = Factory(:question, :text => "What bakery?")
+    @do_you_like_pie = Factory(:question, :text => "Do you like pie?", :survey_section => @section)
+    @what_flavor = Factory(:question, :text => "What flavor?", :survey_section => @section)
+    @what_bakery = Factory(:question, :text => "What bakery?", :survey_section => @section)
     # Answers
     @do_you_like_pie.answers << Factory(:answer, :text => "yes", :question_id => @do_you_like_pie.id)
     @do_you_like_pie.answers << Factory(:answer, :text => "no", :question_id => @do_you_like_pie.id)
     @what_flavor.answers << Factory(:answer, :response_class => :string, :question_id => @what_flavor.id)
     @what_bakery.answers << Factory(:answer, :response_class => :string, :question_id => @what_bakery.id)
     # Dependency
-    @what_flavor_dep = Factory(:dependency, :rule => "1", :question_id => @what_flavor.id)
-    @what_flavor_dep.dependency_conditions << Factory(:dependency_condition, :rule_key => "1", :question_id => @do_you_like_pie.id, :operator => "==", :answer_id => @do_you_like_pie.answers.first.id, :dependency_id => @what_flavor_dep.id)
-    @what_bakery_dep = Factory(:dependency, :rule => "2", :question_id => @what_bakery.id)
-    @what_bakery_dep.dependency_conditions << Factory(:dependency_condition, :rule_key => "2", :question_id => @do_you_like_pie.id, :operator => "==", :answer_id => @do_you_like_pie.answers.first.id, :dependency_id => @what_bakery_dep.id)
+    @what_flavor_dep = Factory(:dependency, :rule => "A", :question_id => @what_flavor.id)
+    Factory(:dependency_condition, :rule_key => "A", :question_id => @do_you_like_pie.id, :operator => "==", :answer_id => @do_you_like_pie.answers.first.id, :dependency_id => @what_flavor_dep.id)
+    @what_bakery_dep = Factory(:dependency, :rule => "B", :question_id => @what_bakery.id)
+    Factory(:dependency_condition, :rule_key => "B", :question_id => @do_you_like_pie.id, :operator => "==", :answer_id => @do_you_like_pie.answers.first.id, :dependency_id => @what_bakery_dep.id)
     # Responses
     @response_set = Factory(:response_set)
+    @response_set.current_section_id = @section.id
     @response_set.responses << Factory(:response, :question_id => @do_you_like_pie.id, :answer_id => @do_you_like_pie.answers.first.id, :response_set_id => @response_set.id)
     @response_set.responses << Factory(:response, :string_value => "pecan pie", :question_id => @what_flavor.id, :answer_id => @what_flavor.answers.first.id, :response_set_id => @response_set.id)
   end
@@ -147,7 +132,7 @@ describe ResponseSet, "with dependencies" do
     @response_set.unanswered_dependencies.should == [@what_bakery]
   end
   it "should list answered and unanswered dependencies to show inline (javascript turned on)" do
-    @response_set.all_dependencies[:show].should == [@what_flavor, @what_bakery]
+    @response_set.all_dependencies[:show].should == ["question_#{@what_flavor.id}", "question_#{@what_bakery.id}"]
   end
   
 end

data/spec/models/response_spec.rb

@@ -4,47 +4,47 @@ describe Response, "when saving a response" do
   before(:each) do
     @response = Response.new(:question_id => 314, :response_set_id => 159, :answer_id => 1)
   end
-  
+
   it "should be valid" do
     @response.should be_valid
   end
-  
+
   it "should be invalid without a parent response set and question" do
     @response.response_set_id = nil
     @response.should have(1).error_on(:response_set_id)
-    
+
     @response.question_id = nil
     @response.should have(1).error_on(:question_id)
   end
 
   describe "returns the response as the type requested" do
-    
+
     it "returns 'string'" do
       @response.string_value = "blah"
       @response.as("string").should == "blah"
       @response.as(:string).should == "blah"
     end
-    
+
     it "returns 'integer'" do
       @response.integer_value = 1001
       @response.as(:integer).should == 1001
     end
-    
-    it "returns 'float'"do
+
+    it "returns 'float'" do
       @response.float_value = 3.14
       @response.as(:float).should == 3.14
     end
-    
+
     it "returns 'answer'" do
       @response.answer_id = 14
       @response.as(:answer).should == 14
     end
-    
+
     it "default returns answer type if not specified" do
       @response.answer_id =18
       @response.as(:stuff).should == 18
     end
-    
+
     it "returns empty elements if the response is cast as a type that is not present" do
       resp = Response.new(:question_id => 314, :response_set_id => 156)
       resp.as(:string).should == nil
@@ -53,42 +53,7 @@ describe Response, "when saving a response" do
       resp.as(:answer).should == nil
       resp.as(:stuff).should == nil
     end
-        
-  end
-  
-  describe "model validation defined in the answer class attributes" do
-    
-    before(:each) do
-      # faking out all the basic validations on the model
-      @response = Response.new(:question_id => 123, :response_set_id => 421, :answer_id => 213)
-    end
-    
-    describe "Integer response_type validations" do
-      
-      before(:each) do
-        @response.stub!(:answer).and_return(mock(Answer, {:response_class => :integer}))
-      end
-      
-      it "validates an upper limit on responses" do
-        @response.answer.stub!(:max_value).and_return(10)
-        @response.integer_value = 100
-        @response.save.should be_false
-        @response.should have(1).error_on(:integer_value)
-      end
-    
-    end
-    
-    describe "Float response_type validations" do
 
-        before(:each) do
-          @response.stub!(:answer).and_return(mock(Answer, {:response_class => :float}))
-        end
-
-        it "validates an upper limit on responses" do
-          pending
-        end
-
-      end
-    
   end
+
 end

data/spec/models/survey_spec.rb

@@ -3,8 +3,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 # Validations
 describe Survey, "when saving a new one" do
   before(:each) do
-    @survey = Survey.new
-    @survey.title = "Foo"
+    @survey = Factory(:survey, :title => "Foo")
   end
   
   it "should be invalid without a title" do
@@ -16,14 +15,14 @@ end
 # Associations
 describe Survey, "that has sections" do
   before(:each) do
-    @survey = Survey.create(:title => "foo")
-    @s1 = @survey.sections.create(:title => "wise", :display_order => 2)
-    @s2 = @survey.sections.create(:title => "er", :display_order => 3)
-    @s3 = @survey.sections.create(:title => "bud", :display_order => 1)
-    @q1 = @s1.questions.create(:text => "what is wise?")
-    @q2 = @s2.questions.create(:text => "what is er?", :display_order => 2)
-    @q3 = @s2.questions.create(:text => "what is mill?", :display_order => 1)
-    @q4 = @s3.questions.create(:text => "what is bud?")
+    @survey = Factory(:survey, :title => "Foo")
+    @s1 = Factory(:survey_section, :survey => @survey, :title => "wise", :display_order => 2)
+    @s2 = Factory(:survey_section, :survey => @survey, :title => "er", :display_order => 3)
+    @s3 = Factory(:survey_section, :survey => @survey, :title => "bud", :display_order => 1)
+    @q1 = Factory(:question, :survey_section => @s1, :text => "what is wise?", :display_order => 2)
+    @q2 = Factory(:question, :survey_section => @s2, :text => "what is er?", :display_order => 4)
+    @q3 = Factory(:question, :survey_section => @s2, :text => "what is mill?", :display_order => 3)
+    @q4 = Factory(:question, :survey_section => @s3, :text => "what is bud?", :display_order => 1)
   end
 
   it "should return survey_sections in display order" do

data/spec/models/validation_condition_spec.rb

@@ -0,0 +1,53 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe ValidationCondition, "Class methods" do
+  it "should have a list of operators" do
+    %w(== != < > <= >= =~).each{|operator| ValidationCondition.operators.include?(operator).should be_true }
+  end
+end
+
+describe ValidationCondition do
+  before(:each) do
+    @validation_condition = Factory(:validation_condition)
+  end
+  
+  it "should be valid" do
+     @validation_condition.should be_valid
+  end
+  
+  it "should be invalid without a parent validation_id" do
+    @validation_condition.validation_id = nil
+    @validation_condition.should have(1).errors_on(:validation_id)
+  end
+
+  it "should be invalid without an operator" do
+    @validation_condition.operator = nil
+    @validation_condition.should have(2).errors_on(:operator)
+  end
+  
+  it "should be invalid without a rule_key" do
+    @validation_condition.should be_valid
+    @validation_condition.rule_key = nil
+    @validation_condition.should_not be_valid
+    @validation_condition.should have(1).errors_on(:rule_key)
+  end
+
+  it "should have unique rule_key within the context of a validation" do
+   @validation_condition.should be_valid
+   Factory(:validation_condition, :validation_id => 2, :rule_key => "2")
+   @validation_condition.rule_key = "2" #rule key uniquness is scoped by validation_id
+   @validation_condition.validation_id = 2
+   @validation_condition.should_not be_valid
+   @validation_condition.should have(1).errors_on(:rule_key)
+  end
+
+  it "should have an operator in ValidationCondition.operators" do
+    ValidationCondition.operators.each do |o|
+      @validation_condition.operator = o
+      @validation_condition.should have(0).errors_on(:operator)
+    end
+    @validation_condition.operator = "#"
+    @validation_condition.should have(1).error_on(:operator)
+  end
+  
+end

data/spec/models/validation_spec.rb

@@ -0,0 +1,32 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe Validation do
+  before(:each) do
+    @validation = Factory(:validation)
+  end
+  
+  it "should be valid" do
+    @validation.should be_valid
+  end
+  
+  it "should be invalid without a rule" do
+    @validation.rule = nil
+    @validation.should have(2).errors_on(:rule)
+    @validation.rule = " "
+    @validation.should have(1).errors_on(:rule)
+  end
+
+  it "should be invalid without a answer_id" do
+    @validation.answer_id = nil
+    @validation.should have(1).error_on(:answer_id)
+  end
+
+  it "should be invalid unless rule composed of only references and operators" do
+    @validation.rule = "foo"
+    @validation.should have(1).error_on(:rule)
+    @validation.rule = "1 to 2"
+    @validation.should have(1).error_on(:rule)
+    @validation.rule = "a and b"
+    @validation.should have(1).error_on(:rule)
+  end
+end