surveyor 0.20.0 → 0.21.0

data/lib/surveyor/version.rb

@@ -0,0 +1,3 @@
+module Surveyor
+  VERSION = '0.21.0'
+end

data/lib/tasks/surveyor_tasks.rake

@@ -4,7 +4,7 @@ task :surveyor => :"surveyor:parse"
 namespace :surveyor do
   task :parse => :environment do
     raise "USAGE: file name required e.g. 'FILE=surveys/kitchen_sink_survey.rb'" if ENV["FILE"].blank?
-    file = File.join(RAILS_ROOT, ENV["FILE"])
+    file = File.join(Rails.root, ENV["FILE"])
     raise "File does not exist: #{file}" unless FileTest.exists?(file)
     puts "--- Parsing #{file} ---"
     Surveyor::Parser.parse File.read(file)
@@ -13,7 +13,7 @@ namespace :surveyor do
   desc "generate and load survey from REDCap Data Dictionary (specify FILE=surveys/redcap.csv)"
   task :redcap => :environment do
     raise "USAGE: file name required e.g. 'FILE=surveys/redcap_demo_survey.csv'" if ENV["FILE"].blank?
-    file = File.join(RAILS_ROOT, ENV["FILE"])
+    file = File.join(Rails.root, ENV["FILE"])
     raise "File does not exist: #{file}" unless FileTest.exists?(file)
     puts "--- Parsing #{file} ---"
     Surveyor::RedcapParser.parse File.read(file), File.basename(file, ".csv")

data/rails/init.rb

@@ -1,2 +1 @@
-# For Rails 2.3 gem engine to work
 require 'surveyor'

data/spec/controllers/surveyor_controller_spec.rb

@@ -1,26 +1,25 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe SurveyorController do
-  
+
   # map.with_options :controller => 'surveyor' do |s|
   #   s.available_surveys "#{root}",                                       :conditions => {:method => :get}, :action => "new"      # GET survey list
   #   s.take_survey       "#{root}:survey_code",                           :conditions => {:method => :post}, :action => "create"  # Only POST of survey to create
   #   s.view_my_survey    "#{root}:survey_code/:response_set_code",        :conditions => {:method => :get}, :action => "show"     # GET viewable/printable? survey
-  #   s.edit_my_survey    "#{root}:survey_code/:response_set_code/take",   :conditions => {:method => :get}, :action => "edit"     # GET editable survey 
-  #   s.update_my_survey  "#{root}:survey_code/:response_set_code",        :conditions => {:method => :put}, :action => "update"   # PUT edited survey 
-  # end   
-  
-  describe "available surveys: GET /surveys" do
+  #   s.edit_my_survey    "#{root}:survey_code/:response_set_code/take",   :conditions => {:method => :get}, :action => "edit"     # GET editable survey
+  #   s.update_my_survey  "#{root}:survey_code/:response_set_code",        :conditions => {:method => :put}, :action => "update"   # PUT edited survey
+  # end
 
+  describe "available surveys: GET /surveys" do
     before(:each) do
       @survey = Factory(:survey)
       Survey.stub!(:find).and_return([@survey])
     end
-  
+
     def do_get
       get :new
     end
-  
+
     it "should render index template" do
       do_get
       response.should be_success
@@ -31,7 +30,7 @@ describe SurveyorController do
       Survey.should_receive(:find).with(:all).and_return([@survey])
       do_get
     end
-    
+
     it "should assign the found surveys for the view" do
       do_get
       assigns[:surveys].should == [@survey]
@@ -39,14 +38,13 @@ describe SurveyorController do
   end
 
   describe "take survey: POST /surveys/xyz" do
-
     before(:each) do
       @survey = Factory(:survey, :title => "xyz", :access_code => "xyz")
       @response_set = Factory(:response_set, :access_code => "pdq")
       ResponseSet.stub!(:create).and_return(@response_set)
       Survey.stub!(:find_by_access_code).and_return(@survey)
     end
-    
+
     describe "with success" do
       def do_post
         post :create, :survey_code => "xyz"
@@ -61,10 +59,11 @@ describe SurveyorController do
       end
       it "should redirect to the new response_set" do
         do_post
-        response.should redirect_to(edit_my_survey_url(:survey_code => "xyz", :response_set_code  => "pdq"))
+        response.should redirect_to(
+          edit_my_survey_url(:survey_code => "xyz", :response_set_code  => "pdq"))
       end
     end
-    
+
     describe "with failures" do
       it "should re-redirect to 'new' if ResponseSet failed create" do
         ResponseSet.should_receive(:create).and_return(false)
@@ -77,15 +76,31 @@ describe SurveyorController do
         response.should redirect_to(available_surveys_url)
       end
     end
+
+    describe "determining if javascript is enabled" do
+      it "sets the user session to know that javascript is enabled" do
+        post :create, :survey_code => "xyz", :surveyor_javascript_enabled => "true"
+        session[:surveyor_javascript].should_not be_nil
+        session[:surveyor_javascript].should == "enabled"
+      end
+
+      it "sets the user session to know that javascript is not enabled" do
+        post :create, :survey_code => "xyz", :surveyor_javascript_enabled => "not_true"
+        session[:surveyor_javascript].should_not be_nil
+        session[:surveyor_javascript].should == "not_enabled"
+      end
+
+    end
+
   end
 
   describe "view my survey: GET /surveys/xyz/pdq" do
-   #integrate_views
     before(:each) do
-      @survey = Factory(:survey, :title => "xyz", :access_code => "xyz", :sections => [Factory(:survey_section)])  
+      @survey = Factory(:survey,
+        :title => "xyz", :access_code => "xyz", :sections => [Factory(:survey_section)])
       @response_set = Factory(:response_set, :access_code => "pdq", :survey => @survey)
     end
-  
+
     def do_get
       get :show, :survey_code => "xyz", :response_set_code => "pdq"
     end
@@ -94,29 +109,28 @@ describe SurveyorController do
       do_get
       response.should be_success
     end
-    
+
     it "should render show template" do
       do_get
       response.should render_template('show')
     end
-   
+
     it "should find the response_set requested" do
-      ResponseSet.should_receive(:find_by_access_code).with("pdq",{:include=>{:responses=>[:question, :answer]}}).and_return(@response_set)
+      ResponseSet.should_receive(:find_by_access_code).
+        with("pdq",{:include=>{:responses=>[:question, :answer]}}).and_return(@response_set)
       do_get
     end
 
     it "should redirect if :response_code not found" do
       get :show, :survey_code => "xyz", :response_set_code => "DIFFERENT"
-      response.should redirect_to(available_surveys_url)      
+      response.should redirect_to(available_surveys_url)
     end
-
   end
 
   describe "edit my survey: GET /surveys/XYZ/PDQ/take" do
-
     before(:each) do
       @survey = Factory(:survey, :title => "XYZ", :access_code => "XYZ")
-      @section = Factory(:survey_section, :survey => @survey)      
+      @section = Factory(:survey_section, :survey => @survey)
       @response_set = Factory(:response_set, :access_code => "PDQ", :survey => @survey)
     end
 
@@ -128,27 +142,49 @@ describe SurveyorController do
       assigns[:response_set].should == @response_set
       assigns[:survey].should == @survey
     end
+
     it "should redirect if :response_code not found" do
       get :edit, :survey_code => "XYZ", :response_set_code => "DIFFERENT"
-      response.should redirect_to(available_surveys_url)      
+      response.should redirect_to(available_surveys_url)
     end
 
+    it "should only set dependents if javascript is not enabled" do
+      ResponseSet.should_receive(:find_by_access_code).and_return(@response_set)
+      controller.stub!(:get_unanswered_dependencies_minus_section_questions).
+        and_return([Question.new])
+
+      get :edit, :survey_code => "XYZ", :response_set_code => "PDQ"
+      assigns[:dependents].should_not be_empty
+      session[:surveyor_javascript].should be_nil
+    end
+
+    it "should not set dependents if javascript is enabled" do
+      ResponseSet.should_receive(:find_by_access_code).and_return(@response_set)
+      controller.stub!(:get_unanswered_dependencies_minus_section_questions).
+        and_return([Question.new])
+
+      session[:surveyor_javascript] = "enabled"
+
+      get :edit, :survey_code => "XYZ", :response_set_code => "PDQ"
+      assigns[:dependents].should be_empty
+      session[:surveyor_javascript].should == "enabled"
+    end
   end
 
   describe "update my survey: PUT /surveys/XYZ/PDQ" do
-
     before(:each) do
       @survey = Factory(:survey, :title => "XYZ", :access_code => "XYZ")
-      @section = Factory(:survey_section, :survey => @survey)      
+      @section = Factory(:survey_section, :survey => @survey)
       @response_set = Factory(:response_set, :access_code => "PDQ", :survey => @survey)
       # @response_set.stub!(:update_attributes).and_return(true)
       # @response_set.stub!(:complete!).and_return(Time.now)
       # @response_set.stub!(:save).and_return(true)
     end
-    
+
     def do_put
       put :update, :survey_code => "XYZ", :response_set_code => "PDQ"
     end
+
     def do_put_with_finish
       responses = {
          "6"=>{"question_id"=>"6", "answer_id" => "6", "string_value"=>"saf"}, #string
@@ -161,27 +197,29 @@ describe SurveyorController do
       }
       put :update, :survey_code => "XYZ", :response_set_code => "PDQ", :finish => "finish", :r => responses
     end
-    
+
     it "should find the response set requested" do
       ResponseSet.should_receive(:find_by_access_code).and_return(@response_set)
       do_put
     end
+
     it "should redirect to 'edit' without params" do
       do_put
       response.should redirect_to(:action => :edit)
     end
-    it "should complete the found response set on finish" do      
+
+    it "should complete the found response set on finish" do
       do_put_with_finish
       flash[:notice].should == "Completed survey"
     end
+
     it "should redirect to available surveys if :response_code not found" do
       put :update, :survey_code => "XYZ", :response_set_code => "DIFFERENT"
       response.should redirect_to(available_surveys_url)
       flash[:notice].should == "Unable to find your responses to the survey"
     end
-
   end
-  
+
   describe "update my survey with ajax" do
     before(:each) do
       @survey = Factory(:survey, :title => "XYZ", :access_code => "XYZ")
@@ -189,29 +227,37 @@ describe SurveyorController do
       @response_set = Factory(:response_set, :access_code => "PDQ", :survey => @survey)
       ResponseSet.stub!(:find_by_access_code).and_return(@response_set)
     end
+
     def do_ajax_put(r)
       xhr :put, :update, :survey_code => "XYZ", :response_set_code => "PDQ", :r => r
     end
+
     it "should return an id for new responses" do
       do_ajax_put({
          "2"=>{"question_id"=>"4", "answer_id"=>"14"}, #check
          "4"=>{"question_id"=>"4", "answer_id"=>"15"} #check
       })
-      JSON.parse(response.body).should == {"ids" => {"2" => 1, "4" => 2}, "remove" => {}, "show" => [], "hide" => []}
+      JSON.parse(response.body).
+        should == {"ids" => {"2" => 1, "4" => 2}, "remove" => {}, "show" => [], "hide" => []}
     end
+
     it "should return a delete for when responses are removed" do
       r = @response_set.responses.create(:question_id => 4, :answer_id => 14)
       do_ajax_put({
          "2"=>{"question_id"=>"4", "answer_id"=>"", "id" => r.id} # uncheck
       })
-      JSON.parse(response.body).should == {"ids" => {}, "remove" => {"2" => r.id}, "show" => [], "hide" => []}
+      # r.id is a String with AR 3.0 and an int with AR 3.1
+      JSON.parse(response.body)['remove']['2'].to_s.should == r.id.to_s
     end
+
     it "should return dependencies" do
-      @response_set.should_receive(:all_dependencies).and_return({"show" => ['q_1'], "hide" => ['q_2']})
+      @response_set.should_receive(:all_dependencies).
+        and_return({"show" => ['q_1'], "hide" => ['q_2']})
       do_ajax_put({
         "4"=>{"question_id"=>"9", "answer_id"=>"12"} #check
       })
-      JSON.parse(response.body).should == {"ids" => {"4" => 1}, "remove" => {}, "show" => ['q_1'], "hide" => ["q_2"]}
+      JSON.parse(response.body).
+        should == {"ids" => {"4" => 1}, "remove" => {}, "show" => ['q_1'], "hide" => ["q_2"]}
     end
   end
 end

data/spec/helpers/surveyor_helper_spec.rb

@@ -13,7 +13,13 @@ describe SurveyorHelper do
     helper.q_text(q1).should == "1) #{q1.text}"
     helper.q_text(q2).should == q2.text
     helper.q_text(q3).should == q3.text
-    helper.q_text(q4).should == '<img alt="Something" src="/images/something.jpg" />'
+    
+    dir = "images"
+    if Rails.application.config.respond_to?(:assets) && Rails.application.config.assets
+      dir = "assets"
+    end
+    
+    helper.q_text(q4).should == %Q(<img alt="Something" src="/#{dir}/something.jpg" />)
     helper.q_text(q5).should == q5.text
   end
   it "should return the group text with number" do

data/spec/models/dependency_condition_spec.rb

@@ -6,10 +6,13 @@ describe DependencyCondition do
     %w(== != < > <= >=).each do |operator|
       DependencyCondition.operators.include?(operator).should be_true
     end
-  end  
+  end
+
   describe "instance" do
     before(:each) do
-      @dependency_condition = DependencyCondition.new(:dependency_id => 1, :question_id => 45, :operator => "==", :answer_id => 23, :rule_key => "1")
+      @dependency_condition = DependencyCondition.new(
+        :dependency_id => 1, :question_id => 45, :operator => "==",
+        :answer_id => 23, :rule_key => "1")
     end
 
     it "should be valid" do
@@ -28,7 +31,7 @@ describe DependencyCondition do
       @dependency_condition.operator = nil
       @dependency_condition.should have(2).errors_on(:operator)
     end
-  
+
     it "should be invalid without a rule_key" do
       @dependency_condition.should be_valid
       @dependency_condition.rule_key = nil
@@ -37,12 +40,14 @@ describe DependencyCondition do
     end
 
     it "should have unique rule_key within the context of a dependency" do
-     @dependency_condition.should be_valid
-     DependencyCondition.create(:dependency_id => 2, :question_id => 46, :operator => "==", :answer_id => 14, :rule_key => "2")
-     @dependency_condition.rule_key = "2" #rule key uniquness is scoped by dependency_id
-     @dependency_condition.dependency_id = 2
-     @dependency_condition.should_not be_valid
-     @dependency_condition.should have(1).errors_on(:rule_key)
+      @dependency_condition.should be_valid
+      DependencyCondition.create(
+        :dependency_id => 2, :question_id => 46, :operator => "==",
+        :answer_id => 14, :rule_key => "2")
+      @dependency_condition.rule_key = "2" # rule key uniquness is scoped by dependency_id
+      @dependency_condition.dependency_id = 2
+      @dependency_condition.should_not be_valid
+      @dependency_condition.should have(1).errors_on(:rule_key)
     end
 
     it "should have an operator in DependencyCondition.operators" do
@@ -56,15 +61,17 @@ describe DependencyCondition do
 
     it "should evaluate within the context of a response set object" do
       @response = Response.new(:question_id => 45, :response_set_id => 40, :answer_id => 23)
-      @response.answer = Answer.new(:question_id => 45, :response_class => "answer")
+      @response.answer = Answer.new(:question_id => 45, :response_class => "answer").
+        tap { |a| a.id = 23 }
       @dependency_condition.is_met?([@response]).should be_true
       # inversion
-      @alt_response = Response.new(:question_id => 45, :response_set_id => 40, :answer_id => 55)
-      @alt_response.answer = Answer.new(:question_id => 45, :response_class => "answer")
+      @alt_response = Response.new(:question_id => 45, :response_set_id => 40)
+      @alt_response.answer = Answer.new(:question_id => 45, :response_class => "answer").
+        tap { |a| a.id = 55 }
 
       @dependency_condition.is_met?([@alt_response]).should be_false
     end
-  
+
     it "converts to a hash for evaluation by the dependency object" do
       @response = Response.new(:question_id => 45, :response_set_id => 40, :answer_id => 23)
       @rs = mock(ResponseSet, :responses => [@response])
@@ -72,40 +79,45 @@ describe DependencyCondition do
       @dependency_condition.to_hash(@rs)
     end
   end
+
   describe "to_hash" do
     before do
-      @response = mock(Response)
-      @question = mock(Question)
-      @dependency_condition = DependencyCondition.new(:rule_key => "A")
-      @answer = mock(Answer)
-      @question.stub!(:answers).and_return([@answer])
-      @response.stub!(:answer).and_return(@answer)
-      @rs = mock(ResponseSet, :responses => [@response])
-      @dependency_condition.stub!(:question).and_return(@question)
+      @question = Factory(:question)
+      @answer = Factory(:answer, :question => @question)
+      @dependency_condition =
+        Factory(:dependency_condition, :rule_key => "A", :question => @question)
+      @rs = Factory(:response_set)
+      @response =
+        Factory(:response, :question => @question, :answer => @answer, :response_set => @rs)
+      @rs.responses << @response
+      @rs.save!
     end
-    
+
     it "converts unmet condition to {:A => false}" do
       @dependency_condition.stub!(:is_met?).and_return(false)
       @dependency_condition.to_hash(@rs).should == {:A => false}
     end
-    
+
     it "converts met condition to {:A => true}" do
       @dependency_condition.stub!(:is_met?).and_return(true)
       @dependency_condition.to_hash(@rs).should == {:A => true}
     end
-    
+
     it "converts unanswered condition to {:A => false}" do
-      @question.stub!(:answers).and_return([])
-      @response.stub!(:answer).and_return(nil)
-      @rs.stub!(:responses).and_return([])
-      @dependency_condition.to_hash(@rs).should == {:A => false}
-    end 
+      question = Factory(:question)
+      dependency_condition =
+        Factory(:dependency_condition, :rule_key => "A", :question => @question)
+      rs = Factory(:response_set)
+      dependency_condition.to_hash(rs).should == {:A => false}
+    end
   end
+
   describe "when if given a response object whether the dependency is satisfied using '=='" do
     before(:each) do
-      @dep_c = DependencyCondition.new(:answer_id => 2, :operator => "==")
-      @select_answer = Answer.new(:question_id => 1, :response_class => "answer")
-      @response = Response.new(:question_id => 314, :response_set_id => 159, :answer_id => 2)
+      @select_answer = Answer.new(:question_id => 1, :response_class => "answer").
+        tap { |a| a.id = 2 }
+      @dep_c = DependencyCondition.new(:operator => "==", :answer_id => @select_answer.id)
+      @response = Response.new(:question_id => 314, :response_set_id => 159, :answer_id => @select_answer.id)
       @response.answer = @select_answer
       @dep_c.answer = @select_answer
       @dep_c.as(:answer).should == 2
@@ -134,7 +146,7 @@ describe DependencyCondition do
       @dep_c.text_value = "hello this is some text for comparison"
       @dep_c.is_met?([@response]).should be_true
       @response.text_value = "Not the same text"
-      @dep_c.is_met?([@response]).should be_false 
+      @dep_c.is_met?([@response]).should be_false
     end
 
     it "knows an integer value response" do
@@ -154,14 +166,14 @@ describe DependencyCondition do
       @response.float_value = 130.123
       @dep_c.is_met?([@response]).should be_false
     end
-
   end
 
   describe "when if given a response object whether the dependency is satisfied using '!='" do
     before(:each) do
-      @dep_c = DependencyCondition.new(:answer_id => 2, :operator => "!=")
-      @select_answer = Answer.new(:question_id => 1, :response_class => "answer")
-      @response = Response.new(:question_id => 314, :response_set_id => 159, :answer_id => 2)
+      @select_answer = Answer.new(:question_id => 1, :response_class => "answer").
+        tap { |a| a.id = 2 }
+      @response = Response.new(:question_id => 314, :response_set_id => 159, :answer_id => @select_answer.id)
+      @dep_c = DependencyCondition.new(:operator => "!=", :answer_id => @select_answer.id)
       @response.answer = @select_answer
       @dep_c.answer = @select_answer
       @dep_c.as(:answer).should == 2
@@ -190,7 +202,7 @@ describe DependencyCondition do
       @dep_c.text_value = "hello this is some text for comparison"
       @dep_c.is_met?([@response]).should be_false
       @response.text_value = "Not the same text"
-      @dep_c.is_met?([@response]).should be_true 
+      @dep_c.is_met?([@response]).should be_true
     end
 
     it "knows an integer value response" do
@@ -210,7 +222,6 @@ describe DependencyCondition do
       @response.float_value = 130.123
       @dep_c.is_met?([@response]).should be_true
     end
-
   end
 
   describe "when if given a response object whether the dependency is satisfied using '<'" do
@@ -220,7 +231,6 @@ describe DependencyCondition do
       @response = Response.new(:question_id => 314, :response_set_id => 159, :answer_id => 2)
       @response.answer = @select_answer
       @dep_c.answer = @select_answer
-
     end
 
     it "knows operator on integer value response" do
@@ -240,7 +250,6 @@ describe DependencyCondition do
       @response.float_value = 130.123
       @dep_c.is_met?([@response]).should be_false
     end
-
   end
 
   describe "when if given a response object whether the dependency is satisfied using '<='" do
@@ -250,7 +259,6 @@ describe DependencyCondition do
       @response = Response.new(:question_id => 314, :response_set_id => 159, :answer_id => 2)
       @response.answer = @select_answer
       @dep_c.answer = @select_answer
-
     end
 
     it "knows operator on integer value response" do
@@ -284,7 +292,6 @@ describe DependencyCondition do
       @response = Response.new(:question_id => 314, :response_set_id => 159, :answer_id => 2)
       @response.answer = @select_answer
       @dep_c.answer = @select_answer
-
     end
 
     it "knows operator on integer value response" do
@@ -304,7 +311,6 @@ describe DependencyCondition do
       @response.float_value = 130.123
       @dep_c.is_met?([@response]).should be_true
     end
-
   end
 
   describe "when if given a response object whether the dependency is satisfied using '>='" do
@@ -314,7 +320,6 @@ describe DependencyCondition do
       @response = Response.new(:question_id => 314, :response_set_id => 159, :answer_id => 2)
       @response.answer = @select_answer
       @dep_c.answer = @select_answer
-
     end
 
     it "knows operator on integer value response" do
@@ -343,46 +348,54 @@ describe DependencyCondition do
   describe "when evaluating a pick one/many with response_class e.g. string" do
     it "should compare answer ids when the string_value is nil" do
       a = Factory(:answer, :response_class => "string")
-      dc = Factory(:dependency_condition, :question_id => a.question.id, :answer_id => a.id, :operator => "==")
+      dc = Factory(:dependency_condition,
+        :question_id => a.question.id, :answer_id => a.id, :operator => "==")
       r = Factory(:response, :question_id => a.question.id, :answer_id => a.id, :string_value => "")
       r.should_receive(:as).with("answer").and_return(a.id)
       dc.is_met?([r]).should be_true
     end
+
     it "should compare strings when the string_value is not nil, even if it is blank" do
       a = Factory(:answer, :response_class => "string")
-      dc = Factory(:dependency_condition, :question_id => a.question.id, :answer_id => a.id, :operator => "==", :string_value => "foo")
-      r = Factory(:response, :question_id => a.question.id, :answer_id => a.id, :string_value => "foo")
+      dc = Factory(:dependency_condition,
+        :question_id => a.question.id, :answer_id => a.id,
+        :operator => "==", :string_value => "foo")
+      r = Factory(:response,
+        :question_id => a.question.id, :answer_id => a.id, :string_value => "foo")
       r.should_receive(:as).with("string").and_return("foo")
-      dc.is_met?([r]).should be_true      
+      dc.is_met?([r]).should be_true
 
-      dc2 = Factory(:dependency_condition, :question_id => a.question.id, :answer_id => a.id, :operator => "==", :string_value => "")
-      r2 = Factory(:response, :question_id => a.question.id, :answer_id => a.id, :string_value => "")
+      dc2 = Factory(:dependency_condition,
+        :question_id => a.question.id, :answer_id => a.id, :operator => "==", :string_value => "")
+      r2 = Factory(:response,
+        :question_id => a.question.id, :answer_id => a.id, :string_value => "")
       r2.should_receive(:as).with("string").and_return("")
-      dc2.is_met?([r2]).should be_true      
+      dc2.is_met?([r2]).should be_true
     end
   end
+
   describe "when given responses whether the dependency is satisfied using 'count'" do
     before(:each) do
-      @dep_c = DependencyCondition.new(:answer_id => nil, 
-                                       :operator => "count>2")
+      @dep_c = DependencyCondition.new(:answer_id => nil,
+        :operator => "count>2")
       @question = Question.new
       @select_answers = []
-      3.times do 
-        @select_answers << Answer.new(:question => @question, 
-                                      :response_class => "answer")
+      3.times do
+        @select_answers << Answer.new(:question => @question,
+          :response_class => "answer")
       end
       @responses = []
       @select_answers.slice(0,2).each do |a|
-        @responses << Response.new(:question => @question, :answer => a, 
-                                   :response_set_id => 159)
+        @responses << Response.new(:question => @question, :answer => a,
+          :response_set_id => 159)
       end
-     end
+    end
 
     it "knows operator with >" do
       @dep_c.is_met?(@responses).should be_false
-      @responses << Response.new(:question => @question, 
-                                 :answer => @select_answers.last, 
-                                 :response_set_id => 159)
+      @responses << Response.new(:question => @question,
+        :answer => @select_answers.last,
+        :response_set_id => 159)
       @dep_c.is_met?(@responses).should be_true
     end