survey-gizmo-ruby 6.2.6 → 6.2.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bec70065e63bfbce5fbe051b24b1287c3b48da77
-  data.tar.gz: d045b945faac6833471a7e9e2cdc55523eefe50f
+  metadata.gz: 20a04949f16c25819c1023e91c871fa7db8aab13
+  data.tar.gz: 99f4d0a5c17a0f7a83a67c3ecb8039ec5643b0d6
 SHA512:
-  metadata.gz: 1244fe6fbacc861a11cab40e4b256d5352e6b212fd28c32bfc099ce362f68976dd365e60bb4478de16c3699b810d6a0cf768d4bbb786083beaef99f535621880
-  data.tar.gz: bec1a6537c50205d9a246cc31dec8e56e6012c609e1bbdff14910524db9190edf6d8fe5c451bf89da43d3d2e0f5874b98e74c441153bfd1d310732fe828499ad
+  metadata.gz: 7ffdb74e5fa62bd8e37744d8ecae7a18357110d3842b0a531af0ea0e1a92afb2f6b44ccc832bbb7523144129c13257881fff496b4e32c58ffb887942804e6323
+  data.tar.gz: dca6e6c8ff26776d48df6e66ad9850faf165773d91e4bb5968c83e733293895d684984cccd396f0cd154d3e11dd621382eb129ebe5ffddf3d1f7bcdaecc1f13e

data/README.md

@@ -58,7 +58,7 @@ And then your ruby code just has to make sure to call
 SurveyGizmo.configure
 ````
 
-once at some point.
+once at some point to load the tokens out of the `ENV` and into the configuration.
 
 ## Usage
 
@@ -68,7 +68,7 @@ once at some point.
 
 `SurveyGizmo::API::Klass.all` returns an `Enumerator` you can use to loop through your results/questions/surveys etc.  It will actually iterate through ALL your results (pagination will be handled for you) if you pass `all_pages: true`.
 
-Because `.all` returns an `Enumerator`, you have to call `.to_a` or some other enumerable method to trigger actual API data retrieval.
+Because `.all` returns an `Enumerator`, you have to call `.each` or `.to_a` or some other enumerable method to trigger actual API data retrieval.
 ```ruby
 SurveyGizmo::API::Survey.all(all_pages: true)      # => #<Enumerator: #<Enumerator::Generator>:each>
 SurveyGizmo::API::Survey.all(all_pages: true).to_a # => [Survey, Survey, Survey, ...]
@@ -107,8 +107,9 @@ question.destroy
 # Iterate over all your Responses
 survey.responses.each { |response| do_something_with(response) }
 # Use filters to limit results - this example will iterate over page 3 of completed, non test data
-# SurveyResponses submitted within the past 3 days for contact 999. It demonstrates how to use some of
-# the gem's built in filters/generators as well as how to construct a filter.
+# SurveyResponses submitted within the past 3 days for contact 999. The example `filters` array
+# demonstrates how to use some of the gem's built in filters/generators as well as how to construct
+# an ad hoc filter hash.
 # See: http://apihelp.surveygizmo.com/help/article/link/filters for more info on filters
 filters = [
   SurveyGizmo::API::Response::NO_TEST_DATA,

data/lib/survey_gizmo/connection.rb

@@ -54,13 +54,15 @@ module SurveyGizmo
           interval: SurveyGizmo.configuration.retry_interval,
           tries: SurveyGizmo.configuration.retry_attempts + 1,
           on: [
-            SurveyGizmo::BadResponseError,
-            SurveyGizmo::RateLimitExceededError,
             Errno::ETIMEDOUT,
+            Faraday::Error::ClientError,
             Net::ReadTimeout,
-            Faraday::Error::ParsingError,
-            Faraday::Error::TimeoutError
-          ]
+            SurveyGizmo::BadResponseError,
+            SurveyGizmo::RateLimitExceededError
+          ],
+          on_retry: Proc.new do |exception, tries|
+            SurveyGizmo.configuration.logger.warn("Retrying after #{exception.class}: #{tries} attempts.")
+          end
         }
       end
     end

data/lib/survey_gizmo/resource.rb

@@ -35,7 +35,7 @@ module SurveyGizmo
       # Properties from the conditions hash (e.g. survey_id) will be added to the returned objects
       def all(conditions = {})
         fail ':all_pages and :page are mutually exclusive' if conditions[:page] && conditions[:all_pages]
-        logger.warn('WARNING: Only retrieving first page of results!') unless conditions[:page] || conditions[:all_pages]
+        logger.warn('Only retrieving first page of results!') unless conditions[:page] || conditions[:all_pages]
 
         all_pages = conditions.delete(:all_pages)
         conditions[:resultsperpage] ||= SurveyGizmo.configuration.results_per_page
@@ -44,7 +44,9 @@ module SurveyGizmo
           response = nil
 
           while !response || (all_pages && response['page'] < response['total_pages'])
-            conditions[:page] = response ? response['page'] + 1 : conditions.fetch(:page, 1) 
+            conditions[:page] = response ? response['page'] + 1 : conditions.fetch(:page, 1)
+
+            start_fetch_time = Time.now
             logger.debug("Fetching #{name} page #{conditions} - #{conditions[:page]}#{response ? "/#{response['total_pages']}" : ''}...")
             response = Connection.get(create_route(:create, conditions)).body
             collection = response['data'].map { |datum| datum.is_a?(Hash) ? new(conditions.merge(datum)) : datum }
@@ -55,6 +57,7 @@ module SurveyGizmo
               collection += collection.flat_map { |question| question.sub_questions }
             end
 
+            logger.debug("  Fetched #{conditions[:resultsperpage]} of #{name} in #{(Time.now - start_fetch_time).to_i}s...")
             collection.each { |e| yielder.yield(e) }
           end
         end

data/lib/survey_gizmo/version.rb

@@ -1,3 +1,3 @@
 module SurveyGizmo
-  VERSION = '6.2.6'
+  VERSION = '6.2.9'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: survey-gizmo-ruby
 version: !ruby/object:Gem::Version
-  version: 6.2.6
+  version: 6.2.9
 platform: ruby
 authors:
 - Kabari Hendrick
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-03 00:00:00.000000000 Z
+date: 2016-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport