survey-gizmo-ruby 6.2.11 → 6.2.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 80f9cff758eafb0dc9a52c9d48c06d83094c3e6b
-  data.tar.gz: 2715840cd27fdf996c2f72b1cd53542e32ec9913
+  metadata.gz: 844b6e6671c728ff6f42dc5b1ed5c73c2379540c
+  data.tar.gz: b3df39f6c5c5e78c55084895b6f67faf1986fe91
 SHA512:
-  metadata.gz: 551e3c4f4a93af34edc7d06ca47576f7355453dd3625c5631e9b7a4befd957970da1d14ac2bf38296055c0d4222e3f95de41e984b9a8839c7c55cbe68ebcd4cd
-  data.tar.gz: effefb9bda5c5d1975eaa8056b7fe4a096ea81512e046029420c5fb18eef70e7e7da7c1f72eef12a3e177c37ddd182ea73b9e8ae6ac965a5747e2cd81f742633
+  metadata.gz: 7a08e99da36784b02497f799b5dc81af4e2b567c9bf69e0391de39f2da6dca68fcca8efa612e8d079fc9d66e989d5e733a345de9db95ce2fdcbbd8af068579b9
+  data.tar.gz: 7a340eaabb357007102dc28965eb539cd3f348b7923f45e147f5c9ff45808d36e9bf00e1742ac8d2f3fa11a69bb8e7afcd72a26009cd91ed5b816e5b07853f6d

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Versions
 
+## 6.2.12
+* Bugfix: Don't allow option_ids of 0
+
 ## 6.2.11
 * Bugfix: Mask CGI escaped (percent encoded) api tokens in logs
 

data/lib/survey_gizmo/api/answer.rb

@@ -23,6 +23,9 @@ module SurveyGizmo::API
         if option_id =~ /-other/
           option_id.delete!('-other"')
           self.other_text = value
+        elsif option_id == 0
+          # Option IDs of 0 seem to happen for hidden questions, even when there is answer_text
+          self.option_id = nil
         end
       when /\[question\((\d+)\),\s*question_pipe\("?([^"]*)"?\)\]/
         self.question_id, self.question_pipe = $1, $2
@@ -33,8 +36,9 @@ module SurveyGizmo::API
       end
 
       self.question_id = question_id.to_i
-      if option_id
-        fail "Bad option_id #{option_id} (class: #{option_id.class}) for #{attrs}!" if option_id.to_i == 0 && option_id != '0' && option_id != 0
+
+      if option_id && !option_id.is_a?(Fixnum)
+        fail "Bad option_id #{option_id} (class: #{option_id.class}) for #{attrs}!" if option_id.to_i == 0
         self.option_id = option_id.to_i
       end
     end

data/lib/survey_gizmo/version.rb

@@ -1,3 +1,3 @@
 module SurveyGizmo
-  VERSION = '6.2.11'
+  VERSION = '6.2.12'
 end

data/spec/resource_spec.rb

@@ -262,7 +262,8 @@ describe 'Survey Gizmo Resource' do
           '[question(11), question_pipe(10527)]' => 'This product was too expensive',
           # Sometimes surveygizmo only includes the option with the "other" answer.  =(
           '[question(12)]' => 'Other - Please explain',
-          '[question(12), option("10017-other")]' => 'I understood...'
+          '[question(12), option("10017-other")]' => 'I understood...',
+          '[question(13), option(0)]' => '12345'
         }
       end
 
@@ -284,7 +285,8 @@ describe 'Survey Gizmo Resource' do
           { survey_id: 1, question_id: 9, option_id: 10002 },
           { survey_id: 1, question_id: 10, question_pipe: 'Que aplicación', answer_text: '5 = Extremely important' },
           { survey_id: 1, question_id: 11, question_pipe: '10527', answer_text: 'This product was too expensive' },
-          { survey_id: 1, question_id: 12, option_id: 10017, other_text: 'I understood...' }
+          { survey_id: 1, question_id: 12, option_id: 10017, other_text: 'I understood...' },
+          { survey_id: 1, question_id: 13, answer_text: '12345' }
         ])
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: survey-gizmo-ruby
 version: !ruby/object:Gem::Version
-  version: 6.2.11
+  version: 6.2.12
 platform: ruby
 authors:
 - Kabari Hendrick
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-10 00:00:00.000000000 Z
+date: 2016-12-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport