surrounded 0.9.3 → 0.9.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 03f2358dca677e952ee8a0fd5887d309f7156ac2
-  data.tar.gz: eb183b1de9c4e2226a4c4228f78b6a692fe80810
+  metadata.gz: 63bac757a4c7f7b9cb953a51123e31dc3612fa22
+  data.tar.gz: 1afa12d700b0756ce4e22becf4555169d8e4fa10
 SHA512:
-  metadata.gz: f875e9a9bad6f5a24a199e2b04ad32be237affa9500bc3cc870ad2206cc5191658c8bdfb92b08cc044b84d2e1fd9ada1392003e0ed90a6f316d3b9ab82d6bf33
-  data.tar.gz: b7118a9f177ab1b0e6a1c609c412bc3de832b312d97a6c2054f08fe758b5f1864f6f2cf332e63160f490baee89fdedf90a2b7eb537753387ec4279f20b3ef51f
+  metadata.gz: 4d508948a224105b736246b96f0a0a8dec5d9bccd9f2000429071135481fe09a3ecac7963e37e684940411a1d02bf89f5697810593469acbc47b7013e4a95820
+  data.tar.gz: 1f68568474713853a086aef3c3e09ce292fbd66dca77c00c68f32afe11a30af593d159ba76c56f31765dd049063646b214f0bf556a302f9fd07be242274f4db1

data/.codeclimate.yml

@@ -0,0 +1,4 @@
+languages:
+  Ruby: true
+exclude_paths:
+- "examples"

data/.travis.yml

@@ -2,8 +2,8 @@ language: ruby
 cache: bundler
 rvm:
   - 2.0.0
-  - 2.1.1
-  - 2.2.0
+  - 2.1.5
+  - 2.2.2
   - ruby-head
   - jruby-head
   - rbx
@@ -11,6 +11,7 @@ env:
 - COVERALLS=true
 matrix:
   allow_failures:
+    - rvm: 2.0.0
     - rvm: ruby-head
     - rvm: jruby-head
     - rvm: rbx

data/README.md

@@ -53,6 +53,24 @@ There are 2 things left to do:
 1. define behaviors for each role and
 2. define how you can trigger their actions
 
+Currently initializing contexts does not require the use of keyword arguments, _but it will in the future_.
+
+You should consider using explicit names when initialize now by using `keyword_initialize`:
+
+```ruby
+class Employment
+  extend Surrounded::Context
+
+  keyword_initialize :employee, :boss
+end
+
+user1 = User.find(1)
+user2 = User.find(2)
+context = Employment.new(employee: user1, boss: user2)
+```
+
+This will allow you to prepare your accessing code to use keywords.
+
 ## Defining behaviors for roles
 
 Behaviors for your roles are easily defined just like you define a method. Provide your role a block and define methods there.

data/lib/surrounded/access_control.rb

@@ -30,7 +30,7 @@ module Surrounded
     
     def define_access_method(name, &block)
       mod = Module.new
-      num = __LINE__; mod.class_eval {
+      mod.class_eval {
         define_method "disallow_#{name}?" do
           begin
             apply_behaviors

data/lib/surrounded/context/forwarding.rb

@@ -3,8 +3,8 @@ module Surrounded
     module Forwarding
       def forward_trigger(receiver, message, alternate=message)
         raise(ArgumentError, %{you may not forward '%{m}`} % {m: message}) if ['__id__','__send__'].include?(message.to_s)
-        trigger alternate do
-          self.send(receiver).public_send(message)
+        trigger alternate do |*args, &block|
+          self.send(receiver).public_send(message,*args, &block)
         end
       end
       

data/lib/surrounded/context/initializing.rb

@@ -3,7 +3,7 @@ module Surrounded
     module Initializing
       # Shorthand for creating an instance level initialize method which
       # handles the mapping of the given arguments to their named role.
-      def initialize(*setup_args)
+      def initialize_without_keywords(*setup_args)
         private_attr_reader(*setup_args)
       
         mod = Module.new
@@ -17,6 +17,11 @@ module Surrounded
         const_set("ContextInitializer", mod)
         include mod
       end
+      def initialize(*setup_args)
+        warn "Deprecated: The behavior of 'initialize' will require keywords in the future
+            Consider using keyword arguments or switching to 'initialize_without_keywords'\n\n"
+        initialize_without_keywords(*setup_args)
+      end
 
       def keyword_initialize(*setup_args)
         private_attr_reader(*setup_args)

data/lib/surrounded/version.rb

@@ -1,5 +1,5 @@
 module Surrounded
-  VERSION = "0.9.3"
+  VERSION = "0.9.4"
   
   def self.version
     VERSION

data/test/context_forwarding_test.rb

@@ -7,6 +7,8 @@ class Sending
   
   forwarding [:hello, :goodbye] => :one
   forward_trigger :two, :ping
+  forward_trigger :two, :argumentative
+  forwards :two, :blockhead
   
   role :one do
     def hello
@@ -22,6 +24,14 @@ class Sending
     def ping
       one.hello
     end
+
+    def argumentative(yes, no)
+      [yes, no].join(' and ')
+    end
+
+    def blockhead
+      yield
+    end
   end
 end
 
@@ -56,4 +66,15 @@ describe Surrounded::Context, 'forwarding triggers' do
     }
     assert_match(/you may not forward '__send__/i, error.message)
   end
+
+  it 'passes arguments' do
+    assert_equal 'YES and NO', context.argumentative('YES','NO')
+  end
+
+  it 'passes blocks' do
+    result = context.blockhead do
+      "Put them in the iron maiden. Excellent!"
+    end
+    assert_equal "Put them in the iron maiden. Excellent!", result
+  end
 end

data/test/example_proxy_test.rb

@@ -65,7 +65,7 @@ describe ProxyContext do
   it 'passes missing methods up the ancestry of the object' do
     err = ->{ context.admin_missing_method }.must_raise(NoMethodError)
 
-    assert_match /ProxyUser.*name="Jim"/, err.message
+    assert_match(/ProxyUser.*name="Jim"/, err.message)
   end
 
   it 'allows access to other objects in the context' do

data/test/surrounded_context_test.rb

@@ -259,21 +259,25 @@ describe Surrounded::Context, 'auto-assigning roles for collections' do
   end
 end
 
-class Keyworder
-  extend Surrounded::Context
-
-  keyword_initialize :this, :that
-end
+begin
+  class Keyworder
+    extend Surrounded::Context
 
-describe Surrounded::Context, 'keyword initializers' do
-  it 'works with keyword arguments' do
-    assert context = Keyworder.new(this: User.new('Jim'), that: User.new('Guille'))
+    keyword_initialize :this, :that
   end
 
-  it 'raises errors with missing keywords' do
-    err = assert_raises(ArgumentError){
-      Keyworder.new(this: User.new('Amy'))
-    }
-    assert_match /missing keyword: that/, err.message
+  describe Surrounded::Context, 'keyword initializers' do
+    it 'works with keyword arguments' do
+      assert Keyworder.new(this: User.new('Jim'), that: User.new('Guille'))
+    end
+
+    it 'raises errors with missing keywords' do
+      err = assert_raises(ArgumentError){
+        Keyworder.new(this: User.new('Amy'))
+      }
+      assert_match(/missing keyword: that/, err.message)
+    end
   end
+rescue SyntaxError
+  STDOUT.puts "No support for keywords"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: surrounded
 version: !ruby/object:Gem::Version
-  version: 0.9.3
+  version: 0.9.4
 platform: ruby
 authors:
 - "'Jim Gay'"
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-14 00:00:00.000000000 Z
+date: 2015-05-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: triad
@@ -59,6 +59,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
 - ".simplecov"
 - ".travis.yml"