surrogate 0.3.1 → 0.3.2

data/Readme.md

@@ -251,17 +251,6 @@ user.id.should == 12
 user.should have_been_initialized_with 12
 ```
 
-Initialization is **always recorded**, so that you don't have to override it just to be able to query.
-
-```ruby
-class MockUser < Struct.new(:id)
-  Surrogate.endow self
-end
-user = MockUser.new 12
-user.id.should == 12
-user.should have_been_initialized_with 12
-```
-
 
 Substitutability
 ----------------
@@ -356,7 +345,9 @@ Need to put an explanation here soon. In the meantime, I wrote a [blog](http://b
 Special Thanks
 ==============
 
-* [Corey Haines](http://coreyhaines.com/) for pairing on it with me
+* [Kyle Hargraves](https://github.com/pd) for changing the name of his internal gem so that I could take Surrogate
+* [Corey Haines](http://coreyhaines.com/) for pairing on substitutability with me
+* [Enova](http://www.enovafinancial.com/) for giving me time and motivation to work on this during Enova Labs.
 * [8th Light](http://8thlight.com/) for giving me time to work on this during our weekly Wazas, and the general encouragement and interest
 
 
@@ -377,3 +368,7 @@ Future Features
 * Ability to disassociate the method name from the test (e.g. you shouldn't need to change a test just because you change a name)
 * declare normal methods as being part of the API (e.g. for inheritance)
 * assertions for order of invocations & methods
+* class generator? (supports a top-down style of development for when you write your mocks before you write your implementations)
+* extract surrogate/rspec into its own gem?
+* deal with hard dependency on rspec-mocks
+* support subset-substitutabilty not being able to touch real methods (e.g. #respond_to?)

data/lib/surrogate/endower.rb

@@ -3,6 +3,7 @@ class Surrogate
   # Adds surrogate behaviour to your class / singleton class / instances
   #
   # please refactor me! ...may not be possible :(
+  # Can we move all method definitions into this class?
   class Endower
     def self.endow(klass, &block)
       new(klass, &block).endow
@@ -22,12 +23,11 @@ class Surrogate
   private
 
     def endow_klass
-      add_hatchery_to                        klass
       klass.extend ClassMethods
+      add_hatchery_to                        klass
       enable_defining_methods                klass
       record_initialization_for_instances_of klass
       remember_invocations_for_instances_of  klass
-      remember_invocations_for_instances_of  klass.singleton_class
     end
 
     def endow_singleton_class
@@ -35,6 +35,7 @@ class Surrogate
       enable_defining_methods singleton
       singleton.module_eval &block if block
       klass.instance_variable_set :@hatchling, Hatchling.new(klass, hatchery)
+      remember_invocations_for_instances_of  singleton
       klass
     end
 
@@ -87,6 +88,9 @@ class Surrogate
 
   # use a module so that the method is inherited (important for substitutability)
   module ClassMethods
+
+    # Should this be dup? (dup seems to copy singleton methods) and may be able to use #initialize_copy to reset ivars
+    # Can we just remove this feature an instead provide a reset feature which could be hooked into in before/after blocks (e.g. https://github.com/rspec/rspec-core/blob/622505d616d950ed53d12c6e82dbb953ba6241b4/lib/rspec/core/mocking/with_rspec.rb)
     def clone
       hatchling, hatchery = @hatchling, @hatchery
       Class.new self do
@@ -97,7 +101,8 @@ class Surrogate
       end
     end
 
-    # Custom new, because user can define initialize, and ivars should be set before it
+    # Custom new, because user can define initialize, and we need to record it
+    # Can we move this into the redefinition of initialize and have it explicitly record itself?
     def new(*args)
       instance = allocate
       instance.instance_variable_set :@hatchling, Hatchling.new(instance, @hatchery)

data/lib/surrogate/values.rb

@@ -12,7 +12,7 @@ class Surrogate
       elsif arg.kind_of? Exception
         Raisable.new arg
       elsif arg.kind_of? Value
-        Recursive.new arg
+        arg
       else
         Value.new arg
       end
@@ -45,13 +45,6 @@ class Surrogate
     end
 
 
-    class Recursive < Value
-      def value(hatchling, method_name)
-        @value.value hatchling, method_name
-      end
-    end
-
-
     class MethodQueue < Value
       QueueEmpty = Class.new StandardError
 

data/lib/surrogate/version.rb

@@ -1,3 +1,3 @@
 class Surrogate
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

data/surrogate.gemspec

@@ -7,7 +7,7 @@ Gem::Specification.new do |s|
   s.version     = Surrogate::VERSION
   s.authors     = ["Josh Cheek"]
   s.email       = ["josh.cheek@gmail.com"]
-  s.homepage    = ""
+  s.homepage    = "https://github.com/JoshCheek/surrogate"
   s.summary     = %q{Framework to aid in handrolling mock/spy objects.}
   s.description = %q{Framework to aid in handrolling mock/spy objects.}
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: surrogate
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-01 00:00:00.000000000 Z
+date: 2012-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70186184231320 !ruby/object:Gem::Requirement
+  requirement: &70198239716160 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,7 +21,7 @@ dependencies:
         version: 2.8.0
   type: :development
   prerelease: false
-  version_requirements: *70186184231320
+  version_requirements: *70198239716160
 description: Framework to aid in handrolling mock/spy objects.
 email:
 - josh.cheek@gmail.com
@@ -55,7 +55,7 @@ files:
 - spec/spec_helper.rb
 - spec/unit/api_comparer_spec.rb
 - surrogate.gemspec
-homepage: ''
+homepage: https://github.com/JoshCheek/surrogate
 licenses: []
 post_install_message: 
 rdoc_options: []