supplejack_client 1.0.4 → 1.0.5

data/spec/supplejack/concept_spec.rb

@@ -0,0 +1,130 @@
+# The Supplejack Client code is Crown copyright (C) 2014, New Zealand Government,
+# and is licensed under the GNU General Public License, version 3.
+# See https://github.com/DigitalNZ/supplejack_client for details.
+#
+# Supplejack was created by DigitalNZ at the National Library of NZ
+# and the Department of Internal Affairs. http://digitalnz.org/supplejack
+
+require 'spec_helper'
+
+class SupplejackConcept
+  include Supplejack::Concept
+end
+
+class Search < Supplejack::Search
+  def initialize(params={})
+    super
+    self.or = {:type => ['Person']}
+  end
+end
+
+class SpecialSearch < Supplejack::Search
+  def initialize(params={})
+    super(params)
+    if self.api_params && self.api_params[:and]
+      self.api_params[:and].delete(:format)
+    end
+  end
+end
+
+module Supplejack
+  describe Concept do
+    it 'initializes its attributes from a JSON string' do
+      concept = SupplejackConcept.new(%{{"name": "Name", "prefLabel": "Label"}})
+      concept.attributes.should eq({name: 'Name', prefLabel: 'Label'})
+    end
+
+    it 'handles nil params' do
+      concept = SupplejackConcept.new(nil)
+      concept.attributes.should eq({})
+    end
+
+    it 'handles a string as params' do
+      concept = SupplejackConcept.new('')
+      concept.attributes.should eq({})
+    end
+
+    it 'handles a array as params' do
+      concept = SupplejackConcept.new([])
+      concept.attributes.should eq({})
+    end
+
+    it 'raises a NoMethodError for every method call that doesn\'t have a key in the attributes' do
+      concept = SupplejackConcept.new
+      expect { concept.something }.to raise_error(NoMethodError)
+    end
+
+    it 'should return the value when is present in the attributes' do
+      concept = SupplejackConcept.new(:weird_method => 'Something')
+      concept.weird_method.should eq 'Something'
+    end
+
+    describe 'id' do
+      it 'returns the concept_id' do
+        concept = SupplejackConcept.new({'concept_id' => '95'})
+        concept.id.should eq 95
+      end
+
+      it 'returns the id' do
+        concept = SupplejackConcept.new({'id' => '96'})
+        concept.id.should eq 96
+      end
+    end
+
+    describe '#name' do
+      it 'returns the title attribute value' do
+        SupplejackConcept.new(name: 'Name').name.should eq 'Name'
+      end
+
+      it 'returns "Unknown" for concepts without a title' do
+        SupplejackConcept.new(name: nil).name.should eq 'Unknown'
+      end
+    end
+
+    [:next_concept, :previous_concept, :next_page, :previous_page].each do |attr|
+      describe "#{attr}" do
+        it "returns the #{attr}" do
+          concept = SupplejackConcept.new({attr => 1})
+          concept.send(attr).should eq 1
+        end
+
+        it "returns the nil" do
+          concept = SupplejackConcept.new({})
+          concept.send(attr).should be_nil
+        end
+      end
+    end
+
+    describe '#find' do
+      context 'single concept' do
+        it 'raises a Supplejack::ConceptNotFound' do
+          SupplejackConcept.stub(:get).and_raise(RestClient::ResourceNotFound)
+          expect { SupplejackConcept.find(1) }.to raise_error(Supplejack::ConceptNotFound)
+        end
+
+        it 'raises a Supplejack::MalformedRequest' do
+          expect { SupplejackConcept.find('replace_this') }.to raise_error(Supplejack::MalformedRequest)
+        end
+
+        it 'requests the concept from the API' do
+          SupplejackConcept.should_receive(:get).with('/concepts/1', {}).and_return({'concept' => {}})
+          SupplejackConcept.find(1)
+        end
+
+        it 'initializes a new SupplejackConcept object' do
+          SupplejackConcept.stub(:get).and_return({'concept_id' => '1', 'name' => 'Wellington'})
+          concept = SupplejackConcept.find(1)
+          concept.class.should eq SupplejackConcept
+          concept.id.should eq 1
+          concept.name.should eq 'Wellington'
+        end
+
+        it 'send the fields defined in the configuration' do
+          Supplejack.stub(:fields) { [:verbose,:default] }
+          SupplejackConcept.should_receive(:get).with('/concepts/1', {}).and_return({'concept' => {}})
+          SupplejackConcept.find(1)
+        end
+      end
+    end
+  end
+end

data/spec/supplejack/user_set_spec.rb

@@ -21,7 +21,7 @@ module Supplejack
     end
 
     describe '#initialize' do
-      [:id, :name, :description, :privacy, :url, :priority, :count, :tag_list, :homepage, :approved].each do |attribute|
+      [:id, :name, :description, :privacy, :url, :priority, :count, :tag_list, :featured, :approved].each do |attribute|
         it "initializes the #{attribute}" do
           Supplejack::UserSet.new({attribute => 'value'}).send(attribute).should eq 'value'
         end
@@ -69,9 +69,9 @@ module Supplejack
         supplejack_set.api_attributes
       end
 
-      it 'should send the homepage value' do
-        supplejack_set.homepage = true
-        supplejack_set.api_attributes.should include(homepage: true)
+      it 'should send the featured value' do
+        supplejack_set.featured = true
+        supplejack_set.api_attributes.should include(featured: true)
       end
 
       it 'returns a array of records with only id and position' do
@@ -443,20 +443,20 @@ module Supplejack
       end
     end
 
-    describe '#homepage_sets' do
+    describe '#featured_sets' do
       before :each do
         Supplejack::UserSet.stub(:get) { {'sets' => [{'id' => '123', 'name' => 'Dog'}]} }
       end
 
       it 'fetches the public sets from the api' do
-        Supplejack::UserSet.should_receive(:get).with('/sets/home')
-        Supplejack::UserSet.homepage_sets
+        Supplejack::UserSet.should_receive(:get).with('/sets/featured')
+        Supplejack::UserSet.featured_sets
       end
 
       it 'returns an array of user set objects' do
         @set = supplejack_set
         Supplejack::UserSet.should_receive(:new).once.with({'id' => '123', 'name' => 'Dog'}) { @set }
-        sets = Supplejack::UserSet.homepage_sets
+        sets = Supplejack::UserSet.featured_sets
         sets.should be_a Array
         sets.size.should eq 1
       end

data/supplejack_client.gemspec

@@ -22,9 +22,10 @@ Gem::Specification.new do |gem|
   gem.require_paths = ['lib']
   gem.version       = Supplejack::VERSION
 
-  gem.add_dependency 'rails', '~> 3.2.12'
+  gem.add_dependency 'rails', '>= 3.2.12', '< 5.0'
   gem.add_dependency 'rest-client', '~> 1.6'
   gem.add_dependency 'rails_autolink', '~> 1.0'
   
   gem.add_development_dependency 'rspec', '~> 2.8'
+  gem.add_development_dependency 'codeclimate-test-reporter'
 end

metadata

@@ -1,29 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: supplejack_client
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors:
 - Supplejack
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-16 00:00:00.000000000 Z
+date: 2016-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.12
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.12
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: rest-client
   requirement: !ruby/object:Gem::Requirement
@@ -66,6 +72,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.8'
+- !ruby/object:Gem::Dependency
+  name: codeclimate-test-reporter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: " Library to abstract the interaction with the Supplejack API "
 email:
 - info@digitalnz.org
@@ -75,6 +95,9 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
+- ".travis.yml"
 - Gemfile
 - Guardfile
 - LICENSE.txt
@@ -84,6 +107,7 @@ files:
 - lib/generators/supplejack/install_generator.rb
 - lib/generators/templates/README
 - lib/generators/templates/supplejack_client.rb
+- lib/supplejack/concept.rb
 - lib/supplejack/config.rb
 - lib/supplejack/controllers/helpers.rb
 - lib/supplejack/engine.rb
@@ -104,6 +128,7 @@ files:
 - lib/supplejack/version.rb
 - lib/supplejack_client.rb
 - spec/spec_helper.rb
+- spec/supplejack/concept_spec.rb
 - spec/supplejack/controllers/helpers_spec.rb
 - spec/supplejack/facet_spec.rb
 - spec/supplejack/item_relation_spec.rb
@@ -137,13 +162,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Connects to the API, and allows you to treat models as if they were in a
   local database
 test_files:
 - spec/spec_helper.rb
+- spec/supplejack/concept_spec.rb
 - spec/supplejack/controllers/helpers_spec.rb
 - spec/supplejack/facet_spec.rb
 - spec/supplejack/item_relation_spec.rb