supervision 0.1.0 → 0.2.0

data/spec/unit/circuit_monitor_spec.rb

@@ -3,4 +3,25 @@
 require "spec_helper"
 
 describe Supervision::CircuitMonitor do
+  let(:object) { described_class }
+
+  subject(:monitor) { object.new }
+
+  describe "#record_success" do
+    it "records success" do
+      monitor.record_success
+      expect(monitor.total_success_calls).to eq(1)
+      expect(monitor.total_failed_calls).to eq(0)
+      expect(monitor.total_calls).to eq(1)
+    end
+  end
+
+  describe "#record_failure" do
+    it "records failure" do
+      monitor.record_failure
+      expect(monitor.total_success_calls).to eq(0)
+      expect(monitor.total_failed_calls).to eq(1)
+      expect(monitor.total_calls).to eq(1)
+    end
+  end
 end

data/spec/unit/circuit_system_spec.rb

@@ -0,0 +1,42 @@
+# encoding: utf-8
+
+require "spec_helper"
+
+describe Supervision::CircuitSystem do
+  let(:object) { described_class }
+
+  let(:circuit) { Supervision.supervise { } }
+
+  subject(:system) { object.new }
+
+  it { expect(system).to respond_to(:register) }
+
+  it { expect(system).to respond_to(:delete) }
+
+  it { expect(system).to respond_to(:registered?) }
+
+  it { expect(system).to respond_to(:empty?) }
+
+  it { expect(system).to respond_to(:names) }
+
+  describe "#shutdown" do
+    it "shuts down system" do
+      expect(system.registry).to receive(:clear)
+      system.shutdown
+    end
+  end
+
+  describe "#to_s" do
+    it 'prints object info' do
+      system.register(:danger, circuit)
+      expect(system.to_s).to include("@names=[:danger]")
+    end
+  end
+
+  describe "#inspect" do
+    it 'prints object info' do
+      system.register(:danger, circuit)
+      expect(system.inspect).to include("@names=[:danger]")
+    end
+  end
+end

data/spec/unit/configuration_spec.rb

@@ -3,12 +3,38 @@
 require 'spec_helper'
 
 describe Supervision::Configuration do
+  let(:object) { described_class }
 
   subject(:config) { described_class.new }
 
-  it { expect(config.max_failures).to eql(5) }
+  it "fails fast with unknown config option" do
+    expect {
+      object.new max_fail: 2
+    }.to raise_error(Supervision::InvalidParameterError)
+  end
 
-  it { expect(config.call_timeout).to eql(0.01) }
+  context 'when default' do
+    it { expect(config.max_failures).to eql(5) }
 
-  it { expect(config.reset_timeout).to eql(0.1) }
+    it { expect(config.call_timeout).to eql(0.01) }
+
+    it { expect(config.reset_timeout).to eql(0.1) }
+  end
+
+  context 'when setting' do
+    it "sets maximum failures" do
+      config.max_failures(3)
+      expect(config.max_failures).to eq(3)
+    end
+
+    it "sets call timeout" do
+      config.call_timeout(1.sec)
+      expect(config.call_timeout).to eq(1.sec)
+    end
+
+    it "sets reset timeout" do
+      config.reset_timeout(10.sec)
+      expect(config.reset_timeout).to eq(10.sec)
+    end
+  end
 end

data/spec/unit/counter_spec.rb

@@ -0,0 +1,34 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Supervision::Counter do
+
+  let(:object) { described_class }
+
+  subject(:counter) { object.new }
+
+  it "initializes to 0" do
+    expect(counter.value).to eq(0)
+  end
+
+  it "increments default value" do
+    counter.increment
+    expect(counter.value).to eq(1)
+  end
+
+  it "increments by value" do
+    counter.increment(10)
+    expect(counter.value).to eq(10)
+  end
+
+  it "increments in threads" do
+    spawn(10) { counter.increment }
+    expect(counter.value).to eq(10)
+  end
+
+  it "increments in threads by value" do
+    spawn(10) { counter.increment(10) }
+    expect(counter.value).to eq(100)
+  end
+end

data/spec/unit/initialize_spec.rb

@@ -5,6 +5,8 @@ require 'spec_helper'
 describe Supervision do
 
   context "when used as instance" do
+    before { Supervision.circuit_system.shutdown }
+
     it "permits options configuration" do
       supervision = Supervision.new { }
       supervision.configure do
@@ -15,23 +17,78 @@ describe Supervision do
       expect(supervision.control.call_timeout).to eql(1.sec)
     end
 
-    it "allows to supervise call" do
-      called = []
-      supervision = Supervision.supervise { called << 'method_call'}
-      supervision.call
-      expect(called).to eql(['method_call'])
+    describe "#supervise" do
+      it "supervises call" do
+        called = []
+        supervision = Supervision.supervise { |arg| called << "method_call_#{arg}"}
+        supervision.call(:foo)
+        expect(called).to match_array(['method_call_foo'])
+      end
+
+      it "accepts circuit options and exposes them" do
+        supervision = Supervision.supervise(max_failures: 4,
+                                            call_timeout: 0.1.sec,
+                                            reset_timeout: 0.4.sec) { }
+        expect(supervision.max_failures).to eq(4)
+        expect(supervision.call_timeout).to eq(0.1.sec)
+        expect(supervision.reset_timeout).to eq(0.4.sec)
+      end
+    end
+
+    describe "#supervise_as" do
+      it "registers named supervision" do
+        called = []
+        expect(Supervision[:danger]).to be_nil
+        supervision = Supervision.supervise_as(:danger) { |arg|
+          called << "method_call_#{arg}"
+        }
+        supervision.call(:foo)
+        expect(Supervision[:danger]).to eql(supervision)
+        expect(called).to match_array(['method_call_foo'])
+      end
+
+      it "accepts circuit options and exposes them" do
+        Supervision.supervise_as(:danger, max_failures: 4,
+                                          call_timeout: 0.1.sec,
+                                          reset_timeout: 0.4.sec) { }
+        expect(Supervision[:danger].max_failures).to eq(4)
+        expect(Supervision[:danger].call_timeout).to eq(0.1.sec)
+        expect(Supervision[:danger].reset_timeout).to eq(0.4.sec)
+      end
+
+      it "calls registered circuit by name" do
+        called = []
+        expect(Supervision[:danger]).to be_nil
+        Supervision.supervise_as(:danger) { |arg| called << "method_call_#{arg}" }
+        Supervision.danger(:foo)
+        expect(called).to match_array(['method_call_foo'])
+      end
+
+      it "saves the name on circuit" do
+        Supervision.supervise_as(:danger) { }
+        circuit = Supervision[:danger]
+        expect(circuit.name).to eql(:danger)
+      end
+    end
+
+    describe "#circuit_system" do
+      it "caches system circuits" do
+        system = Supervision.circuit_system
+        2.times { expect(Supervision.circuit_system).to eq(system) }
+      end
     end
 
-    it "registers named supervision" do
-      called = []
-      supervision = Supervision.supervise_as(:danger) { called << 'method_call'}
-      supervision.call
-      expect(called).to eql(['method_call'])
-      expect(Supervision.circuit_system[:danger]).to eql(supervision)
+    describe "#configuration" do
+      it "caches configuration" do
+        config = Supervision.configuration
+        2.times { expect(Supervision.configuration).to eq(config) }
+      end
     end
   end
 
   context "when included as module" do
+    before { Supervision.circuit_system.shutdown }
+
     class RemoteApi
       include Supervision
 

data/spec/unit/registry_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Supervision::Registry do
@@ -6,7 +8,7 @@ describe Supervision::Registry do
 
   subject(:registry) { described_class.new }
 
-  it "registers" do
+  it "registers a circuit" do
     registry[:danger] = circuit
     expect(registry[:danger]).to eql(circuit)
   end
@@ -17,14 +19,43 @@ describe Supervision::Registry do
     }.to raise_error(Supervision::TypeError)
   end
 
-  it "" do
+  it "refuses to add duplicate entry" do
     registry[:danger] = circuit
-    expect(registry.names).to eql([:danger])
+    expect {
+      registry[:danger] = circuit
+    }.to raise_error(Supervision::DuplicateEntryError)
   end
 
-  it "" do
-    registry[:danger] = circuit
-    registry.delete(:danger)
-    expect(registry.names).to be_empty
+  it "returns nil for unregistered circuit" do
+    expect(registry[:danger]).to be_nil
+  end
+
+  it "gets a circuit by name" do
+    registry.register :danger, circuit
+    expect(registry[:danger]).to eq(circuit)
+  end
+
+  it "retrieves registered circuit names" do
+    registry.register :danger, circuit
+    registry.register :fragile, circuit
+    expect(registry.names).to match_array([:danger, :fragile])
+  end
+
+  it "deletes circuit from registry" do
+    registry.register :danger, circuit
+    registry.delete :danger
+    expect(registry.empty?).to be_true
+  end
+
+  it "checks if circuit is registered" do
+    registry.register :danger, circuit
+    expect(registry.registered?(:danger)).to be_true
+  end
+
+  it "clears all circuits" do
+    registry.register :danger, circuit
+    expect(registry.empty?).to be_false
+    registry.clear
+    expect(registry.empty?).to be_true
   end
 end

data/supervision.gemspec

@@ -18,6 +18,6 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "finite_machine", "~> 0.4"
+  spec.add_dependency "finite_machine", "~> 0.6.1"
   spec.add_development_dependency "bundler", "~> 1.6"
 end

data/tasks/console.rake

@@ -4,7 +4,7 @@ desc 'Load gem inside irb console'
 task :console do
   require 'irb'
   require 'irb/completion'
-  require File.join(__FILE__, '../lib/finite_machine')
+  require File.join(__FILE__, '../../lib/supervision')
   ARGV.clear
   IRB.start
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: supervision
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Piotr Murach
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-13 00:00:00.000000000 Z
+date: 2014-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: finite_machine
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: 0.6.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: 0.6.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -52,6 +52,7 @@ files:
 - .ruby-gemset
 - .ruby-version
 - .travis.yml
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -63,6 +64,7 @@ files:
 - lib/supervision/circuit_monitor.rb
 - lib/supervision/circuit_system.rb
 - lib/supervision/configuration.rb
+- lib/supervision/counter.rb
 - lib/supervision/factory.rb
 - lib/supervision/registry.rb
 - lib/supervision/time_dsl.rb
@@ -72,7 +74,9 @@ files:
 - spec/unit/circuit_breaker_spec.rb
 - spec/unit/circuit_control_spec.rb
 - spec/unit/circuit_monitor_spec.rb
+- spec/unit/circuit_system_spec.rb
 - spec/unit/configuration_spec.rb
+- spec/unit/counter_spec.rb
 - spec/unit/initialize_spec.rb
 - spec/unit/registry_spec.rb
 - spec/unit/time_dsl_spec.rb
@@ -110,7 +114,9 @@ test_files:
 - spec/unit/circuit_breaker_spec.rb
 - spec/unit/circuit_control_spec.rb
 - spec/unit/circuit_monitor_spec.rb
+- spec/unit/circuit_system_spec.rb
 - spec/unit/configuration_spec.rb
+- spec/unit/counter_spec.rb
 - spec/unit/initialize_spec.rb
 - spec/unit/registry_spec.rb
 - spec/unit/time_dsl_spec.rb