superstore 2.4.4 → 2.5.0

data/lib/superstore/types/json_type.rb

@@ -1,6 +1,6 @@
 module Superstore
   module Types
-    class JsonType < BaseType
+    class JsonType < ActiveModel::Type::Value
     end
   end
 end

data/lib/superstore/types/range_type.rb

@@ -0,0 +1,51 @@
+module Superstore
+  module Types
+    class RangeType < ActiveModel::Type::Value
+      class_attribute :subtype
+
+      def serialize(range)
+        if range
+          [
+            serialize_for_open_ended(range.begin),
+            serialize_for_open_ended(range.end)
+          ]
+        end
+      end
+
+      def deserialize(range_tuple)
+        if range_tuple.is_a? Range
+          range_tuple
+        elsif range_tuple.is_a?(Array)
+          range = convert_min(:deserialize, range_tuple[0]) .. convert_max(:deserialize, range_tuple[1])
+          cast_value(range)
+        end
+      end
+
+      def cast_value(value)
+        if value.is_a?(Range) && value.begin < value.end
+          value
+        elsif value.is_a?(Array) && value.size == 2
+          begin
+            array = convert_min(:cast_value, value[0])..convert_max(:cast_value, value[1])
+            cast_value(array)
+          rescue ArgumentError
+          end
+        end
+      end
+
+      private
+
+      def serialize_for_open_ended(value)
+        subtype.serialize(value)
+      end
+
+      def convert_min(method, value)
+        subtype.send(method, value)
+      end
+
+      def convert_max(method, value)
+        subtype.send(method, value)
+      end
+    end
+  end
+end

data/lib/superstore/types/string_type.rb

@@ -1,8 +1,8 @@
 module Superstore
   module Types
-    class StringType < BaseType
-      def encode(str)
-        raise ArgumentError.new("#{str.inspect} is not a String") unless str.kind_of?(String)
+    class StringType < ActiveModel::Type::Value
+      def serialize(str)
+        return if str.nil?
 
         unless str.encoding == Encoding::UTF_8
           (str.frozen? ? str.dup : str).force_encoding('UTF-8')
@@ -11,7 +11,7 @@ module Superstore
         end
       end
 
-      def typecast(value)
+      def cast_value(value)
         value.to_s
       end
     end

data/lib/superstore/types/time_type.rb

@@ -1,16 +1,18 @@
 module Superstore
   module Types
-    class TimeType < BaseType
-      def encode(time)
-        raise ArgumentError.new("#{time.inspect} does not respond to #to_time") unless time.is_a?(Time) || time.respond_to?(:to_time)
-        time = time.to_time unless time.is_a?(Time)
-        time.utc.xmlschema(6)
+    class TimeType < ActiveModel::Type::Value
+      def serialize(time)
+        time.utc.xmlschema(6) if time
       end
 
-      def decode(str)
-        Time.parse(str).in_time_zone if str
-      rescue
+      def deserialize(str)
+        Time.rfc3339(str).in_time_zone if str
+      rescue ArgumentError
+        Time.parse(str).in_time_zone rescue nil
+      end
 
+      def cast_value(value)
+        value.to_time.in_time_zone rescue nil
       end
     end
   end

data/superstore.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = 'superstore'
-  s.version = '2.4.4'
+  s.version = '2.5.0'
   s.description = 'ActiveModel-based JSONB document store'
   s.summary = 'ActiveModel for JSONB documents'
   s.authors = ['Michael Koziarski', 'Infogroup']
@@ -18,9 +18,10 @@ Gem::Specification.new do |s|
   s.test_files  = `git ls-files -- {test}/*`.split("\n")
   s.require_paths = ['lib']
 
-  s.add_runtime_dependency('activemodel', '>= 3.0')
+  s.add_runtime_dependency('activemodel', '>= 5.2')
+  s.add_runtime_dependency('activerecord', '>= 5.2')
   s.add_runtime_dependency('globalid')
-  s.add_runtime_dependency('oj')
 
   s.add_development_dependency('bundler')
+  s.add_development_dependency('rails')
 end

data/test/support/jsonb.rb

@@ -1,6 +1,8 @@
 class JsonbInitializer
   def self.initialize!
-    Superstore::Base.adapter.create_table('issues')
+    ActiveRecord::Migration.create_table :issues, id: :string do |t|
+      t.jsonb :document, null: false
+    end
   end
 end
 

data/test/support/models.rb

@@ -2,19 +2,22 @@ class User < ActiveRecord::Base
 end
 
 class Label < ActiveRecord::Base
+  belongs_to :issue
 end
 
 class Issue < Superstore::Base
-  string :description
-  string :title
-  json :comments
+  attribute :description, type: :string
+  attribute :title, type: :string
+  attribute :parent_issue_id, type: :string
+  attribute :comments, type: :json
 
   before_create { self.description ||= 'funny' }
 
-  has_many :labels
+  has_many :labels, inverse_of: :issue
+  has_many :children_issues, class_name: 'Issue', foreign_key: :parent_issue_id, inverse_of: :parent_issue, superstore: true
+  belongs_to :parent_issue, class_name: 'Issue', superstore: true
 
   def self.for_key key
     where_ids(key)
   end
 end
-

data/test/test_helper.rb

@@ -13,12 +13,16 @@ require 'support/pg'
 require 'support/jsonb'
 require 'support/models'
 
+def MiniTest.filter_backtrace(bt)
+  bt
+end
+
 module Superstore
   class TestCase < ActiveSupport::TestCase
     def temp_object(&block)
       Class.new(Superstore::Base) do
         self.table_name = 'issues'
-        string :force_save
+        attribute :force_save, type: :string
         before_save { self.force_save = 'junk' }
 
         def self.name
@@ -34,7 +38,7 @@ module Superstore
     class TestCase < Superstore::TestCase
       attr_accessor :type
       setup do
-        @type = self.class.name.sub(/Test$/, '').constantize.new(Issue)
+        @type = self.class.name.sub(/Test$/, '').constantize.new
       end
     end
   end

data/test/unit/adapters/adapter_test.rb

@@ -1,6 +1,4 @@
 require 'test_helper'
 
 class Superstore::Adapters::AdapterTest < Superstore::TestCase
-  test 'create_table' do
-  end
-end
+end

data/test/unit/associations/belongs_to_test.rb

@@ -3,7 +3,7 @@ require 'test_helper'
 class Superstore::Associations::BelongsTest < Superstore::TestCase
   class TestObject < Superstore::Base
     self.table_name = 'issues'
-    string :user_id
+    attribute :user_id, type: :string
     belongs_to :user, primary_key: :special_id
   end
 

data/test/unit/associations/has_many_test.rb

@@ -4,7 +4,7 @@ class Superstore::Associations::HasManyTest < Superstore::TestCase
   class TestObject < Issue
   end
 
-  test 'has_many' do
+  test 'has_many active_record association' do
     issue = TestObject.create!
     label = Label.create! name: 'important', issue_id: issue.id
 
@@ -13,10 +13,18 @@ class Superstore::Associations::HasManyTest < Superstore::TestCase
 
   test 'create supports preloaded records' do
     issue = TestObject.create!
-    issue.labels = Label.all.to_a
+    issue.labels = Label.all
 
     issue.labels.create! name: 'blue'
 
     assert_equal 1, issue.labels.size
   end
+
+  test 'has_many superstore association' do
+    parent_issue = Issue.create!
+    child_issue = Issue.create! parent_issue: parent_issue
+
+    assert_equal [child_issue], parent_issue.children_issues
+    assert_equal parent_issue.object_id, parent_issue.children_issues.first.parent_issue.object_id
+  end
 end

data/test/unit/attribute_methods/dirty_test.rb

@@ -3,7 +3,7 @@ require 'test_helper'
 class Superstore::AttributeMethods::DirtyTest < Superstore::TestCase
   test 'save clears dirty' do
     record = temp_object do
-      string :name
+      attribute :name, type: :string
     end.new name: 'foo'
 
     assert record.changed?
@@ -16,7 +16,7 @@ class Superstore::AttributeMethods::DirtyTest < Superstore::TestCase
 
   test 'reload clears dirty' do
     record = temp_object do
-      string :name
+      attribute :name, type: :string
     end.create! name: 'foo'
 
     record.name = 'bar'
@@ -27,9 +27,9 @@ class Superstore::AttributeMethods::DirtyTest < Superstore::TestCase
     assert !record.changed?
   end
 
-  test 'typecast float before dirty check' do
+  test 'cast_value float before dirty check' do
     record = temp_object do
-      float :price
+      attribute :price, type: :float
     end.create(price: 5.01)
 
     record.price = '5.01'
@@ -39,9 +39,9 @@ class Superstore::AttributeMethods::DirtyTest < Superstore::TestCase
     assert record.changed?
   end
 
-  test 'typecast boolean before dirty check' do
+  test 'cast_value boolean before dirty check' do
     record = temp_object do
-      boolean :awesome
+      attribute :awesome, type: :boolean
     end.create(awesome: false)
 
     record.awesome = false
@@ -51,20 +51,9 @@ class Superstore::AttributeMethods::DirtyTest < Superstore::TestCase
     assert record.changed?
   end
 
-  test 'unapplied_changes' do
-    record = temp_object do
-      float :price
-      string :color
-    end.create(price: 5.01, color: 'green')
-
-    record.color = 'blue'
-
-    assert_equal({'color' => 'blue'}, record.unapplied_changes)
-  end
-
   test 'write_attribute' do
     object = temp_object do
-      string :name
+      attribute :name, type: :string
     end
 
     expected = {"name"=>[nil, "foo"]}
@@ -83,7 +72,7 @@ class Superstore::AttributeMethods::DirtyTest < Superstore::TestCase
 
   test 'dirty and restore to original value' do
     object = temp_object do
-      string :name
+      attribute :name, type: :string
     end
 
     record = object.create(name: 'foo')

data/test/unit/attribute_methods/primary_key_test.rb

@@ -19,7 +19,7 @@ class Superstore::AttributeMethods::PrimaryKeyTest < Superstore::TestCase
   end
 
   test 'attributes' do
-    issue = Issue.new
+    issue = Issue.new(id: 'lol')
 
     assert_not_nil issue.attributes['id']
   end

data/test/unit/attribute_methods_test.rb

@@ -12,10 +12,6 @@ class Superstore::AttributeMethodsTest < Superstore::TestCase
     assert_equal 'foo', issue.read_attribute(:description)
   end
 
-  test 'read primary_key' do
-    refute_nil Issue.new[:id]
-  end
-
   test 'hash accessor aliases' do
     issue = Issue.new
 
@@ -34,32 +30,24 @@ class Superstore::AttributeMethodsTest < Superstore::TestCase
     assert_equal 'foo', issue.description
   end
 
-  class ChildIssue < Issue
-    def title=(val)
-      self[:title] = val + ' lol'
-    end
-  end
+  class ModelWithOverride < Superstore::Base
+    attribute :title, type: :string
 
-  test 'override' do
-    issue = ChildIssue.new(title: 'hey')
-
-    assert_equal 'hey lol', issue.title
+    def title=(v)
+      super "#{v} lol"
+    end
   end
 
-  class ReservedWord < Superstore::Base
-    self.table_name = 'issues'
-    string :system
-  end
+   test 'override' do
+    issue = ModelWithOverride.new(title: 'hey')
 
-  test 'reserved words' do
-    r = ReservedWord.new(system: 'hello')
-    assert_equal 'hello', r.system
+     assert_equal 'hey lol', issue.title
   end
 
   test 'has_attribute?' do
-    refute Issue.new.attribute_exists?(:description)
+    refute Issue.new.has_attribute?(:unknown)
+    assert Issue.new.has_attribute?(:description)
     assert Issue.new(description: nil).has_attribute?(:description)
-    assert Issue.new(description: false).has_attribute?(:description)
     assert Issue.new(description: 'hey').has_attribute?(:description)
   end
 end

data/test/unit/{attribute_methods/typecasting_test.rb → attributes_test.rb}

@@ -1,18 +1,19 @@
 require 'test_helper'
 
-class Superstore::AttributeMethods::TypecastingTest < Superstore::TestCase
+class Superstore::AttributesTest < Superstore::TestCase
   class TestIssue < Superstore::Base
     self.table_name = 'issues'
 
-    boolean :enabled
-    float   :rating
-    integer :price
-    json    :orders
-    string  :name
+    attribute :enabled, type: :boolean
+    attribute :rating, type: :float
+    attribute :price, type: :integer
+    attribute :orders, type: :json
+    attribute :name, type: :string
+    attribute :age_range, type: :integer_range
   end
 
   class TestChildIssue < TestIssue
-    string :description
+    attribute :description, type: :string
   end
 
   test 'attributes not shared' do
@@ -21,15 +22,6 @@ class Superstore::AttributeMethods::TypecastingTest < Superstore::TestCase
     assert_nothing_raised { TestChildIssue.new.description }
   end
 
-  test 'typecast_attribute' do
-    assert_equal 1, TestIssue.typecast_attribute('price', 1)
-    assert_equal 1, TestIssue.typecast_attribute(:price, 1)
-
-    assert_raise NoMethodError do
-      TestIssue.typecast_attribute('wtf', 1)
-    end
-  end
-
   test 'boolean attribute' do
     issue = TestIssue.create! enabled: '1'
     assert_equal true, issue.enabled
@@ -76,29 +68,11 @@ class Superstore::AttributeMethods::TypecastingTest < Superstore::TestCase
     assert_equal '42', issue.name
   end
 
-  test 'multiple attributes definition' do
-    class MultipleAttributesIssue < Superstore::Base
-      self.table_name = 'issues'
-    end
+  test 'integer_range' do
+    issue = TestIssue.create! age_range: ['70', nil]
+    assert_equal 70..Float::INFINITY, issue.age_range
 
-    assert_nothing_raised {
-      MultipleAttributesIssue.string :hello, :greetings, :bye
-    }
-    issue = MultipleAttributesIssue.new :hello => 'hey', :greetings => 'how r u', :bye => 'see ya'
-
-    assert_equal 'how r u', issue.greetings
-  end
-
-  test 'multiple attributes with options' do
-    class MultipleAttributesIssue < Superstore::Base
-      self.table_name = 'issues'
-    end
-
-    MultipleAttributesIssue.expects(:attribute).with(:hello, { :unique => :true, :type => :string })
-    MultipleAttributesIssue.expects(:attribute).with(:world, { :unique => :true, :type => :string })
-
-    class MultipleAttributesIssue < Superstore::Base
-      string :hello, :world, :unique => :true
-    end
+    issue = TestIssue.find issue.id
+    assert_equal 70..Float::INFINITY, issue.age_range
   end
 end