superstore 2.3.0 → 2.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: efa28ad8771bdcf6a918cf33a4d81f3e6945581a
-  data.tar.gz: 732be1d35bf085bc141c1772d7beef1e1655f397
+  metadata.gz: 5684a72108f25316fd6cfc5b187f1f637cf86ed6
+  data.tar.gz: 8ec22cebf483751984796e2b5ab9f6f4ca312ffe
 SHA512:
-  metadata.gz: c8f18bbcabe090e89e0ff5a19058689b7e2002488be9332c666e62cc556e78a58573918e27081c48f13eb9ed30c26a60cab90d6c39abe0f0e2522f6e90770786
-  data.tar.gz: bfc9b5f6637f4955ad45753f0a2996be1f5892aba8ac15646ee9deb4194237b2300c1d57ef42c22e310f8e6e261aedc7c75bcdca58fc40a5fad36395a0f2c0da
+  metadata.gz: 5c6e4a89c79f90fa7c79eba4fdf42fbf10fba8c85a92a23643dd6bbb717ff30d90983a399202fb7889a6399bf393a426fe01a87dde9d9a64404269e21b860f46
+  data.tar.gz: 0cd0147c2951aae69c0e340c91d91da881a5c19ce2402fbaefb460316b946f735d2a0765c63780d72d5d77bf02bb9e20c287220709fbc956a09964da8ad8189e

data/.gitignore

@@ -1,2 +1,2 @@
-Gemfile.lock
+Gemfile*.lock
 *.gem

data/.travis.yml

@@ -1,23 +1,13 @@
 language: ruby
 rvm:
-- 2.1.10
-- 2.2.5
 - 2.3.1
 sudo: required
 dist: trusty
 cache: bundler
-before_install:
-# https://github.com/travis-ci/travis-ci/issues/4264
-- sudo cp /etc/postgresql/9.4/main/pg_hba.conf /tmp
-- sudo add-apt-repository "deb http://apt.postgresql.org/pub/repos/apt/ $(lsb_release -cs)-pgdg 9.5"
-- sudo apt-key adv --keyserver keys.gnupg.net --recv-keys 7FCC7D46ACCC4CF8
-- sudo apt-get update
-- sudo service postgresql stop
-- for version in 9.1 9.2 9.3 9.4; do sudo pg_dropcluster --stop $version main; done
-- sudo apt-get remove --purge --yes postgresql-9.[1234]
-- sudo apt-get install --no-install-recommends --yes postgresql-client-9.5 postgresql-9.5
-- sudo apt-get autoremove --yes
-- sudo cp /tmp/pg_hba.conf /etc/postgresql/9.5/main/
-- sudo service postgresql restart
-- sudo -u postgres createuser -s travis
-- sudo -u postgres createdb -O travis travis
+gemfile:
+- Gemfile
+- Gemfile-rails4.2
+addons:
+  postgresql: 9.5
+services:
+- postgresql

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+# 2.3.0
+
+Released 2016-06-29.
+
+## Changed
+
+* Superstore requires PostgreSQL 9.5, since it uses the JSONB operators introduced in that version.
+
 # 2.2.0
 
 Released 2016-06-02.

data/Gemfile

@@ -6,6 +6,6 @@ gem 'rake'
 group :test do
   gem 'rails'
   gem 'pg'
-  gem 'activerecord', '~> 4.2.0'
+  gem 'activerecord', '~> 5.0.0'
   gem 'mocha', require: false
 end

data/Gemfile-rails4.2

@@ -0,0 +1,11 @@
+source "http://rubygems.org"
+gemspec
+
+gem 'rake'
+
+group :test do
+  gem 'rails'
+  gem 'pg'
+  gem 'activerecord', '~> 4.2.0'
+  gem 'mocha', require: false
+end

data/README.md

@@ -1,15 +1,33 @@
 # Superstore
-[![Build Status](https://secure.travis-ci.org/data-axle/superstore.png?rvm=2.0.0)](http://travis-ci.org/data-axle/superstore) [![Code Climate](https://codeclimate.com/github/data-axle/superstore/badges/gpa.svg)](https://codeclimate.com/github/data-axle/superstore)
+[![Build Status](https://secure.travis-ci.org/data-axle/superstore.png?rvm=2.0.0)](http://travis-ci.org/data-axle/superstore)
+[![Code Climate](https://codeclimate.com/github/data-axle/superstore/badges/gpa.svg)](https://codeclimate.com/github/data-axle/superstore)
+[![Gem](https://img.shields.io/gem/v/superstore.svg?maxAge=2592000)](https://rubygems.org/gems/superstore)
 
-Superstore uses ActiveModel to mimic much of the behavior in ActiveRecord.
+Superstore is a PostgreSQL JSONB document store which uses ActiveModel to mimic much of the behavior
+in ActiveRecord.
+
+## Requirements
+
+Superstore requires PostgreSQL 9.5 or above.
 
 ## Installation
 
 Add the following to the `Gemfile`:
+
 ```ruby
+gem 'pg'
 gem 'superstore'
 ```
 
+Add a `config/superstore.yml`:
+
+```yaml
+development:
+  adapter: jsonb
+```
+
+Superstore will share the existing ActiveRecord database connection.
+
 ## Defining Models
 
 ```ruby
@@ -36,23 +54,6 @@ class MyWidget < Superstore::Base
 end
 ```
 
-## Using the PostgreSQL JSONB adapter
-
-Add the `pg` gem to the `Gemfile`:
-
-```ruby
-gem 'pg'
-```
-
-Add a `config/superstore.yml`:
-
-```yaml
-development:
-  adapter: jsonb
-```
-
-Superstore will share the existing ActiveRecord database connection.
-
 ## Creating and updating records
 
 Superstore has equivalent methods to ActiveRecord:

data/lib/superstore/adapters/abstract_adapter.rb

@@ -4,6 +4,7 @@ module Superstore
       attr_reader :config
       def initialize(config)
         @config = config
+        @batch_statements = nil
       end
 
       # Read records from a instance of Superstore::Scope

data/lib/superstore/associations.rb

@@ -36,6 +36,10 @@ module Superstore
           super
         end
       end
+
+      def belongs_to_required_by_default
+        false
+      end
     end
 
   end

data/lib/superstore/attribute_methods.rb

@@ -37,6 +37,10 @@ module Superstore
       def dangerous_attribute_method?(name)
         false
       end
+
+      def has_attribute?(attr_name)
+        attribute_definitions.key?(attr_name.to_s)
+      end
     end
 
     def write_attribute(name, value)
@@ -59,9 +63,10 @@ module Superstore
       !value.nil? && !(value.respond_to?(:empty?) && value.empty?)
     end
 
-    def attribute_exists?(name)
+    def has_attribute?(name)
       @attributes.key?(name.to_s)
     end
+    alias_method :attribute_exists?, :has_attribute?
 
     def attributes
       results = {}
@@ -80,7 +85,13 @@ module Superstore
     def method_missing(method_id, *args, &block)
       self.class.define_attribute_methods unless self.class.attribute_methods_generated?
 
-      match = match_attribute_method?(method_id.to_s)
+      match = if ActiveRecord.version >= Gem::Version.new('5.0')
+        # Active Record 5.0
+        matched_attribute_method(method_id.to_s)
+      else
+        # Active Record 4.2
+        match_attribute_method?(method_id.to_s)
+      end
       match ? attribute_missing(match, *args, &block) : super
     end
 

data/lib/superstore/scope/query_methods.rb

@@ -9,7 +9,7 @@ module Superstore
       if block_given?
         to_a.select(&block)
       else
-        clone.select! *values
+        clone.select!(*values)
       end
     end
 

data/superstore.gemspec

@@ -2,17 +2,17 @@
 
 Gem::Specification.new do |s|
   s.name = 'superstore'
-  s.version = '2.3.0'
-  s.description = 'ActiveModel for many attributes'
-  s.summary = 'JSONB ActiveModel'
-  s.authors = ["Michael Koziarski", "Infogroup"]
+  s.version = '2.4.0'
+  s.description = 'ActiveModel-based JSONB document store'
+  s.summary = 'ActiveModel for JSONB documents'
+  s.authors = ['Michael Koziarski', 'Infogroup']
   s.email = 'developer@matthewhiggins.com'
   s.homepage = 'http://github.com/data-axle/superstore'
 
   s.required_ruby_version     = '>= 2.0.0'
   s.required_rubygems_version = '>= 1.3.5'
 
-  s.extra_rdoc_files = ["README.md"]
+  s.extra_rdoc_files = ['README.md']
   s.files       = `git ls-files`.split("\n")
   s.test_files  = `git ls-files -- {test}/*`.split("\n")
   s.require_paths = ['lib']

data/test/test_helper.rb

@@ -1,22 +1,18 @@
-require 'bundler/setup'
-Bundler.require(:default, :test)
+require 'rails'
 
 I18n.config.enforce_available_locales = false
+ActiveSupport::TestCase.test_order = :random
 
 require 'active_record'
 require 'rails/test_help'
 require 'mocha/setup'
 
-ActiveSupport::TestCase.test_order = :random
+require 'superstore'
 
 require 'support/pg'
 require 'support/jsonb'
 require 'support/models'
 
-def MiniTest.filter_backtrace(bt)
-  bt
-end
-
 module Superstore
   class TestCase < ActiveSupport::TestCase
     def temp_object(&block)

data/test/unit/attribute_methods/dirty_test.rb

@@ -91,7 +91,6 @@ class Superstore::AttributeMethods::DirtyTest < Superstore::TestCase
     assert_equal({}, record.changes)
 
     record.name = 'bar'
-    expected = {'name'=>[nil, 'foo']}
     assert_equal({'name' => ['foo', 'bar']}, record.changes)
 
     record.name = 'foo'

data/test/unit/attribute_methods_test.rb

@@ -56,10 +56,10 @@ class Superstore::AttributeMethodsTest < Superstore::TestCase
     assert_equal 'hello', r.system
   end
 
-  # test 'attribute_exists' do
-  #   assert !Issue.new.attribute_exists?(:description)
-  #   assert Issue.new(description: nil).attribute_exists?(:description)
-  #   assert Issue.new(description: false).attribute_exists?(:description)
-  #   assert Issue.new(description: 'hey').attribute_exists?(:description)
-  # end
+  test 'has_attribute?' do
+    refute Issue.new.attribute_exists?(:description)
+    assert Issue.new(description: nil).has_attribute?(:description)
+    assert Issue.new(description: false).has_attribute?(:description)
+    assert Issue.new(description: 'hey').has_attribute?(:description)
+  end
 end

data/test/unit/inspect_test.rb

@@ -19,8 +19,8 @@ class Superstore::InspectTest < Superstore::TestCase
       integer :price
     end.new(description: "yeah buddy", price: nil)
 
-    assert_match /id/, object.inspect
-    assert_match /description/, object.inspect
-    assert_no_match /price/, object.inspect
+    assert_match(/id/, object.inspect)
+    assert_match(/description/, object.inspect)
+    assert_no_match(/price/, object.inspect)
   end
 end

data/test/unit/persistence_test.rb

@@ -43,8 +43,8 @@ class Superstore::PersistenceTest < Superstore::TestCase
     end
 
     assert !Issue.batching?
-    assert_nothing_raised(Superstore::RecordNotFound) { Issue.find(first_issue.id) }
-    assert_nothing_raised(Superstore::RecordNotFound) { Issue.find(second_issue.id) }
+    assert_nothing_raised { Issue.find(first_issue.id) }
+    assert_nothing_raised { Issue.find(second_issue.id) }
   end
 
   test 'persistence inquiries' do

data/test/unit/scope/finder_methods_test.rb

@@ -21,7 +21,7 @@ class Superstore::FinderMethodsTest < Superstore::TestCase
   test 'find with ids' do
     first_issue = Issue.create
     second_issue = Issue.create
-    third_issue = Issue.create
+    Issue.create
 
     assert_equal [], Issue.find([])
     assert_equal [first_issue, second_issue], Issue.find([first_issue.id, second_issue.id])

data/test/unit/scope/query_methods_test.rb

@@ -22,7 +22,7 @@ class Superstore::Scope::QueryMethodsTest < Superstore::TestCase
 
   test "select with block" do
     foo_issue = Issue.create title: 'foo'
-    bar_issue = Issue.create title: 'bar'
+    Issue.create title: 'bar'
 
     assert_equal [foo_issue], Issue.select { |issue| issue.title == 'foo' }
   end

data/test/unit/types/integer_type_test.rb

@@ -14,8 +14,8 @@ class Superstore::Types::IntegerTypeTest < Superstore::Types::TestCase
 
   test 'decode' do
     assert_nil type.decode('')
-    assert_equal 0, type.decode('abc')
-    assert_equal 3, type.decode('3')
-    assert_equal -3, type.decode('-3')
+    assert_equal(0, type.decode('abc'))
+    assert_equal(3, type.decode('3'))
+    assert_equal(-3, type.decode('-3'))
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: superstore
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.4.0
 platform: ruby
 authors:
 - Michael Koziarski
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-29 00:00:00.000000000 Z
+date: 2016-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -67,7 +67,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: ActiveModel for many attributes
+description: ActiveModel-based JSONB document store
 email: developer@matthewhiggins.com
 executables: []
 extensions: []
@@ -78,6 +78,7 @@ files:
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
+- Gemfile-rails4.2
 - LICENSE
 - MIT-LICENSE
 - README.md
@@ -193,5 +194,5 @@ rubyforge_project:
 rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
-summary: JSONB ActiveModel
+summary: ActiveModel for JSONB documents
 test_files: []