super_settings 2.2.1 → 2.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f2db5de763e2b71a248913369bf05dda818d328fdee379a703054164ecdb9f51
-  data.tar.gz: 5ca7f24e706c33d4b79363144eb98e41c8772e046709f6fc2bc7f21ba91ea592
+  metadata.gz: a8062539b6606b9cd5d043cfe7ec52abfe7a49a13edb59fbd8a9660831282c89
+  data.tar.gz: 5bd8d1a568fc9828f0a3c1d57d2efda2109ffebf7ecbe5ba55d8ba1c01e1f57c
 SHA512:
-  metadata.gz: c3c45f9701cf13c981de225ea0fbe157709aab31cea37e967b33deeb0a9e382d2d0fe8e1a4afae889d572743f4bd40ad21e206ec6db34f74cff493c1a2560130
-  data.tar.gz: 5923794e1704cabf9885e6e7ff90420302158c77911efa9b47441a0d14c0e1326c0f0ca6699dc523898a08f0eb9375ceada0bf6414367eb5fa0995166ea2b1d5
+  metadata.gz: e0a64b3993479ec0f0e94ba362e9dba51dd2ca44d2da8ec09c29f2e0a67bbcae4393352846de727cd21c31eab244304edf8847d2d922acd583cc6f4dc9ebc482
+  data.tar.gz: 65952c3cecf4ef4c97ff4d84e0a6d49ee4515260551c6941dbe8eeaf894bf3a0d21c922ed8d6afb8431680556c39771de93656de31f1f7c8fa2ef4dd5b84f3ef

data/CHANGELOG.md

@@ -4,6 +4,19 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 2.3.1
+
+### Fixed
+
+- Add check if database connection is valid for ActiveRecord storage engine to avoid race conditions where settings were not available until an application model was used.
+
+## 2.3.0
+
+### Changed
+
+- Calling `SuperSettings.get` on a setting stored as an array now returns the array as a multiline string rather than simply calling `to_s` on the array. So an array setting stored as `["foo", "bar"]` will now be returned as `"foo\nbar"` rather than `'["foo", "bar"]'`.
+- Calling `SuperSettings.get` on a setting stored as a datetime will now return the value as an ISO-8601 formatted string rather than simply calling `to_s` on the `Time` object.
+
 ## 2.2.1
 
 ### Added

data/VERSION

@@ -1 +1 @@
-2.2.1
+2.3.1

data/lib/super_settings/coerce.rb

@@ -34,7 +34,7 @@ module SuperSettings
       # @param value [Object]
       # @return [Time]
       def time(value)
-        value = nil if value.nil? || value.to_s.empty?
+        value = nil if blank?(value)
         return nil if value.nil?
 
         time = if value.is_a?(Numeric)
@@ -50,6 +50,25 @@ module SuperSettings
         time
       end
 
+      # Cast a value to a string.
+      #
+      # @param value [Object]
+      # @return [String]
+      def string(value)
+        value = nil if blank?(value)
+        return nil if value.nil?
+
+        if value.is_a?(String)
+          value
+        elsif value.is_a?(Array)
+          value.join("\n")
+        elsif value.respond_to?(:iso8601)
+          value.iso8601
+        else
+          value.to_s
+        end
+      end
+
       # @return [Boolean] true if the value is nil or empty.
       def blank?(value)
         return true if value.nil?

data/lib/super_settings/storage/active_record_storage/models.rb

@@ -16,8 +16,29 @@ module SuperSettings
         class << self
           # ActiveRecord storage is only available if the connection pool is connected and the table exists.
           def available?
+            attempt_connection!
             connection_pool&.connected? && table_exists?
           end
+
+          private
+
+          @connection_attempted = false
+
+          def attempt_connection!
+            return if @connection_attempted
+
+            @connection_attempted = true
+            return if connection_pool.nil? || connection_pool.connected?
+
+            begin
+              connection_pool.with_connection do
+                # Do nothing, just ensure that the connection is established.
+              end
+            rescue ActiveRecord::ConnectionNotEstablished
+              # Ignore errors so the application doesn't break if the database is not available.
+              # Otherwise things like build processes can fail.
+            end
+          end
         end
       end
 

data/lib/super_settings.rb

@@ -35,7 +35,10 @@ module SuperSettings
     # @return [String]
     def get(key, default = nil)
       val = context_setting(key)
-      val.nil? ? default : val.to_s
+      return val if val.is_a?(String)
+      return default if val.nil?
+
+      Coerce.string(val)
     end
 
     # Alias for {#get} to allow using the [] operator to get a setting value.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: super_settings
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 2.3.1
 platform: ruby
 authors:
 - Brian Durand
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-05 00:00:00.000000000 Z
+date: 2025-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler