super_settings 2.0.3 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: deffd163ccbba074051f5e7df4138216f24da7c8fa068c5a25fdaa7c83326799
-  data.tar.gz: af00d68c45251327f0e73867c16bdb4171110929f02290db374178c88718f0ec
+  metadata.gz: c245924ff453f5cd0bde098003e6dc05d54b21aba4a42ddaf7c614c63233a542
+  data.tar.gz: fb8672624d5c688794f8492be263534ed4e46ac49684f76d9bbf3bd120b62579
 SHA512:
-  metadata.gz: d496dfbfeaba9952c624f15680323d83fe055a03f48f17c660a5dee8e3512a4692bbe249212bfdf1830026ec0e726cb312acc0134a8c8260e95433b6c325abc8
-  data.tar.gz: de6887cbbe6ec06ba1cb20e75769377008a5d7fa4eb1a55bcbb6be87e3cdff508890209a0984dc3cdf4ae293d895ce946eb807582097c65e052a9f0b0fcef081
+  metadata.gz: 605db9f00bbd1865203caaf7515c3d5f1ad83911653dd9410c69344dda0b21b8e58167806186969a6d2b27d4867a61d97b29333715c3f139741f16a3d3b0a635
+  data.tar.gz: b1565e3ace970a26a8d126ec27e3bee6786b5da85e33e25bbde5a947af12e8067a23d143870b7012dd449b86ab5658fbeb99fb365bc8f738276cf8672ffc318d

data/CHANGELOG.md

@@ -4,6 +4,26 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 2.1.1
+
+### Fixed
+
+- Added check to ensure that ActiveRecord has a connection to the database to avoid error when settings are checked before the database is connected or when the database doesn't yet exist.
+
+### Added
+
+- Added `:null` storage engine that doesn't store settings at all. This is useful for testing or when the storage engine is no available in your continuous integration environment.
+
+## 2.1.0
+
+## Fixed
+
+- More robust handling of history tracking when keys are deleted and then reused. Previously, the history was not fully recorded when a key was reused. Now the history on the old key is recorded as a delete and the history on the new key is recorded as being an update.
+
+## Changed
+
+- Times are now consistently encoded in UTC in ISO-8601 format with microseconds whenever they are serialized to JSON.
+
 ## 2.0.3
 
 ### Fixed

data/README.md

@@ -154,6 +154,8 @@ This gem abstracts out the storage engine and can support multiple storage mecha
 * `SuperSettings::Storage::RedisStorage` - Stores the settings in a Redis database using the [redis](https://github.com/redis/redis-rb) gem.
 * `SuperSettings::Storage::HttpStorage` - Uses the SuperSettings REST API running on another server. This is useful in a microservices architecture so you can have a central settings server used by all the services.
 * `SuperSettings::Storage::S3Storage` - Stores the settings in JSON in an S3 object. This is useful for applications running on AWS that want to store settings in a central location since it does not require a dedicated database. It is possible to read the settings directly from S3 from another application.
+* `SuperSettings::Storage::MongoDBStorage` - Stores the settings in a MongoDB database using the [mongo](https://github.com/mongodb/mongo-ruby-driver) gem.
+* `SuperSettings::Storage::NullStorage` - Does not store settings at all. This is useful for testing or when the storage engine is not available in your continuous integration environment.
 
 Additional storage engines can be built by creating a class that includes `SuperSettings::Storage` and implements the unimplemented methods in that module.
 
@@ -391,10 +393,12 @@ bundle exec rackup
 
 By default this will use Redis for storage using the default Redis URL. You can change the storage engine with the `STORAGE` environment variable.
 
+- `active_record` - Use the ActiveRecord storage engine.
 - `redis` - Use the Redis storage engine. The Redis URL can be set with the `REDIS_URL` environment variable.
 - `http` - Use the HTTP storage engine. The URL for the REST API can be set with the `REST_API_URL` environment variable.
 - `s3` - Use the S3 storage engine. The S3 URL can be set with the `S3_URL` environment variable.
 - `mongodb` - Use the MongoDB storage engine. The MongoDB URL can be set with the `MONGODB_URL` environment variable.
+- `null` - Use the null storage engine. This storage engine does not store settings at all.
 
 You can bring up all of these storage engines locally with the included docker-compose configuration.
 

data/VERSION

@@ -1 +1 @@
-2.0.3
+2.1.1

data/lib/super_settings/application/scripts.js

@@ -384,7 +384,7 @@
     payload.histories.forEach(function(history) {
       const date = new Date(Date.parse(history.created_at));
       const dateString = dateFormatter().format(date);
-      const value = (payload.encrypted ? "<em>n/a</em>" : escapeHTML(history.value));
+      const value = (history.deleted ? '<em class="super-settings-text-danger">deleted</em>' : escapeHTML(history.value));
       rowsHTML += `<tr><td class="super-settings-text-nowrap">${escapeHTML(dateString)}</td><td>${escapeHTML(history.changed_by)}</td><td>${value}</td></tr>`;
     });
     tbody.insertAdjacentHTML("beforeend", rowsHTML);

data/lib/super_settings/coerce.rb

@@ -36,6 +36,7 @@ module SuperSettings
       def time(value)
         value = nil if value.nil? || value.to_s.empty?
         return nil if value.nil?
+
         time = if value.is_a?(Numeric)
           Time.at(value)
         elsif value.respond_to?(:to_time)
@@ -52,6 +53,7 @@ module SuperSettings
       # @return [Boolean] true if the value is nil or empty.
       def blank?(value)
         return true if value.nil?
+
         if value.respond_to?(:empty?)
           value.empty?
         else

data/lib/super_settings/configuration.rb

@@ -27,6 +27,10 @@ module SuperSettings
         @web_ui_enabled = true
         @color_scheme = false
         @changed_by_block = nil
+        @enhancement = nil
+        @application_name = nil
+        @application_logo = nil
+        @application_link = nil
       end
 
       def superclass
@@ -119,6 +123,7 @@ module SuperSettings
         @storage = :active_record
         @after_save_blocks = []
         @changed_by_display = nil
+        @cache = nil
       end
 
       # Specify the storage engine to use for persisting settings. The value can either be specified

data/lib/super_settings/history_item.rb

@@ -34,5 +34,14 @@ module SuperSettings
         changed_by
       end
     end
+
+    def as_json
+      {
+        value: value,
+        changed_by: changed_by,
+        created_at: created_at&.utc&.iso8601(6),
+        deleted: deleted?
+      }
+    end
   end
 end

data/lib/super_settings/rest_api.rb

@@ -145,7 +145,7 @@ module SuperSettings
         end
 
         payload[:histories] = histories.collect do |history|
-          history_values = {value: history.value, changed_by: history.changed_by_display, created_at: history.created_at}
+          history_values = {value: history.value, changed_by: history.changed_by_display, created_at: history.created_at.utc.iso8601(6)}
           history_values[:deleted] = true if history.deleted?
           history_values
         end
@@ -163,7 +163,7 @@ module SuperSettings
       #     last_updated_at: iso8601 string
       #   }
       def last_updated_at
-        {last_updated_at: Setting.last_updated_at.utc.iso8601}
+        {last_updated_at: Setting.last_updated_at.utc.iso8601(6)}
       end
 
       # Return settings that have been updated since a specified timestamp.

data/lib/super_settings/setting.rb

@@ -446,18 +446,17 @@ module SuperSettings
     #
     # @return [void]
     def save!
-      record_value_change
-
       unless valid?
         raise InvalidRecordError.new(errors.values.join("; "))
       end
 
       timestamp = Time.now
       self.created_at ||= timestamp
-      self.updated_at = timestamp unless updated_at && changed?(:updated_at)
+      self.updated_at = timestamp if updated_at.nil? || !changed?(:updated_at)
 
       self.class.storage.with_connection do
         self.class.storage.transaction do
+          record_value_change
           @record.save!
         end
 
@@ -525,8 +524,8 @@ module SuperSettings
         value: value,
         value_type: value_type,
         description: description,
-        created_at: created_at,
-        updated_at: updated_at
+        created_at: created_at&.utc&.iso8601(6),
+        updated_at: updated_at&.utc&.iso8601(6)
       }
       attributes[:deleted] = true if deleted?
       attributes
@@ -592,8 +591,16 @@ module SuperSettings
     # Update the histories association whenever the value or key is changed.
     def record_value_change
       return unless changed?(:raw_value) || changed?(:deleted) || changed?(:key)
+
       recorded_value = (deleted? ? nil : raw_value)
-      @record.create_history(value: recorded_value, deleted: deleted?, changed_by: changed_by, created_at: Time.now)
+      @record.class.create_history(key: key, value: recorded_value, deleted: deleted?, changed_by: changed_by, created_at: updated_at)
+
+      if changed?(:key)
+        key_was = @changes["key"][0]
+        if key_was
+          @record.class.create_history(key: key_was, changed_by: changed_by, created_at: updated_at, deleted: true)
+        end
+      end
     end
 
     def clear_changes

data/lib/super_settings/storage/active_record_storage/models.rb

@@ -12,6 +12,13 @@ module SuperSettings
         self.table_name = "super_settings"
 
         has_many :history_items, class_name: "SuperSettings::Storage::ActiveRecordStorage::HistoryModel", foreign_key: :key, primary_key: :key
+
+        class << self
+          # ActiveRecord storage is only available if the connection pool is connected and the table exists.
+          def available?
+            connection_pool&.connected? && table_exists?
+          end
+        end
       end
 
       class HistoryModel < ApplicationRecord

data/lib/super_settings/storage/active_record_storage.rb

@@ -18,7 +18,7 @@ module SuperSettings
 
       class << self
         def all
-          if Model.table_exists?
+          if Model.available?
             Model.all.collect { |model| new(model) }
           else
             []
@@ -26,7 +26,7 @@ module SuperSettings
         end
 
         def active
-          if Model.table_exists?
+          if Model.available?
             Model.where(deleted: false).collect { |model| new(model) }
           else
             []
@@ -34,7 +34,7 @@ module SuperSettings
         end
 
         def updated_since(time)
-          if Model.table_exists?
+          if Model.available?
             Model.where("updated_at > ?", time).collect { |model| new(model) }
           else
             []
@@ -42,16 +42,20 @@ module SuperSettings
         end
 
         def find_by_key(key)
-          model = Model.where(deleted: false).find_by(key: key) if Model.table_exists?
+          model = Model.where(deleted: false).find_by(key: key) if Model.available?
           new(model) if model
         end
 
         def last_updated_at
-          if Model.table_exists?
+          if Model.available?
             Model.maximum(:updated_at)
           end
         end
 
+        def create_history(key:, changed_by:, created_at:, value: nil, deleted: false)
+          HistoryModel.create!(key: key, value: value, deleted: deleted, changed_by: changed_by, created_at: created_at)
+        end
+
         def with_connection(&block)
           Model.connection_pool.with_connection(&block)
         end
@@ -117,15 +121,6 @@ module SuperSettings
           HistoryItem.new(key: key, value: record.value, changed_by: record.changed_by, created_at: record.created_at, deleted: record.deleted?)
         end
       end
-
-      def create_history(changed_by:, created_at:, value: nil, deleted: false)
-        history_attributes = {value: value, deleted: deleted, changed_by: changed_by, created_at: created_at}
-        if @model.persisted?
-          @model.history_items.create!(history_attributes)
-        else
-          @model.history_items.build(history_attributes)
-        end
-      end
     end
   end
 end

data/lib/super_settings/storage/http_storage.rb

@@ -71,6 +71,10 @@ module SuperSettings
           SuperSettings::Coerce.time(value)
         end
 
+        def create_history(key:, changed_by:, created_at:, value: nil, deleted: false)
+          # No-op since history is maintained by the source system.
+        end
+
         def save_all(changes)
           payload = []
           changes.each do |setting|
@@ -132,10 +136,6 @@ module SuperSettings
         end
       end
 
-      def create_history(changed_by:, created_at:, value: nil, deleted: false)
-        # No-op since history is maintained by the source system.
-      end
-
       def reload
         self.class.find_by_key(key)
         self.attributes = self.class.find_by_key(key).attributes

data/lib/super_settings/storage/json_storage.rb

@@ -19,9 +19,32 @@ module SuperSettings
       include Transaction
 
       class HistoryStorage < HistoryAttributes
+        class << self
+          def create!(attributes)
+            record = new(attributes)
+            record.save!
+            record
+          end
+        end
+
+        def initialize(*)
+          @storage = nil
+          super
+        end
+
+        attr_writer :storage
+
         def created_at=(val)
           super(TimePrecision.new(val).time)
         end
+
+        def save!
+          raise ArgumentError.new("Missing key") if Coerce.blank?(key)
+
+          @storage.transaction do |changes|
+            changes << self
+          end
+        end
       end
 
       class << self
@@ -37,36 +60,54 @@ module SuperSettings
           active.detect { |setting| setting.key == key }
         end
 
+        def create_history(key:, changed_by:, created_at:, value: nil, deleted: false)
+          HistoryStorage.create!(key: key, value: value, changed_by: changed_by, created_at: created_at, deleted: deleted, storage: self)
+        end
+
         def save_all(changes)
           existing = {}
           parse_settings(settings_json_payload).each do |setting|
             existing[setting.key] = setting
           end
 
-          changes.each do |setting|
-            existing[setting.key] = setting
+          history_items = []
+          changes.each do |record|
+            if record.is_a?(HistoryStorage)
+              history_items << record
+            else
+              existing[record.key] = record
+            end
           end
 
           settings = existing.values.sort_by(&:key)
+
           changed_histories = {}
-          changes.collect do |setting|
-            history = (setting.new_history + setting.history).sort_by(&:created_at).reverse
-            changed_histories[setting.key] = history.collect do |history_item|
-              {
-                value: history_item.value,
-                changed_by: history_item.changed_by,
-                created_at: history_item.created_at&.iso8601(6),
-                deleted: history_item.deleted?
-              }
+          history_items.each do |history_item|
+            setting = existing[history_item.key]
+            next unless setting
+
+            history = changed_histories[history_item.key]
+            unless history
+              history = setting.history.dup
+              changed_histories[history_item.key] = history
             end
-            setting.new_history.clear
+            history.unshift(history_item)
           end
 
           settings_json = JSON.dump(settings.collect(&:as_json))
           save_settings_json(settings_json)
 
           changed_histories.each do |setting_key, setting_history|
-            history_json = JSON.dump(setting_history)
+            ordered_history = setting_history.sort_by { |history_item| history_item.created_at }.reverse
+            payload = ordered_history.collect do |history_item|
+              {
+                value: history_item.value,
+                changed_by: history_item.changed_by,
+                created_at: history_item.created_at.iso8601(6),
+                deleted: history_item.deleted?
+              }
+            end
+            history_json = JSON.dump(payload)
             save_history_json(setting_key, history_json)
           end
         end
@@ -128,11 +169,6 @@ module SuperSettings
         end
       end
 
-      def initialize(*)
-        @new_history = []
-        super
-      end
-
       def created_at=(val)
         super(TimePrecision.new(val).time)
       end
@@ -149,14 +185,6 @@ module SuperSettings
         end
       end
 
-      def create_history(changed_by:, created_at:, value: nil, deleted: false)
-        history = HistoryStorage.new(key: key, value: value, changed_by: changed_by, created_at: created_at, deleted: deleted)
-        @new_history.unshift(history)
-        history
-      end
-
-      attr_reader :new_history
-
       def as_json
         {
           key: key,

data/lib/super_settings/storage/mongodb_storage.rb

@@ -26,6 +26,26 @@ module SuperSettings
       @mutex = Mutex.new
 
       class HistoryStorage < HistoryAttributes
+        class << self
+          def create!(attributes)
+            record = new(attributes)
+            record.save!
+            record
+          end
+        end
+
+        def created_at=(value)
+          super(TimePrecision.new(value, :millisecond).time)
+        end
+
+        def save!
+          raise ArgumentError.new("Missing key") if Coerce.blank?(key)
+
+          MongoDBStorage.transaction do |changes|
+            changes << self
+          end
+        end
+
         def as_bson
           attributes = {
             value: value,
@@ -89,13 +109,16 @@ module SuperSettings
           last_updated_setting["updated_at"] if last_updated_setting
         end
 
+        def create_history(key:, changed_by:, created_at:, value: nil, deleted: false)
+          HistoryStorage.create!(key: key, value: value, changed_by: changed_by, created_at: created_at, deleted: deleted)
+        end
+
         def destroy_all
           settings_collection.delete_many({})
         end
 
         def save_all(changes)
           upserts = changes.collect { |setting| upsert(setting) }
-          changes.each { |setting| setting.new_history.clear }
           settings_collection.bulk_write(upserts)
           true
         end
@@ -108,17 +131,18 @@ module SuperSettings
 
         private
 
-        def upsert(setting)
-          doc = setting.as_bson
-          history = setting.new_history.collect(&:as_bson)
+        def upsert(record)
+          update = {"$setOnInsert": {key: record.key}}
+          if record.is_a?(MongoDBStorage::HistoryStorage)
+            update["$push"] = {history: record.as_bson}
+          else
+            update["$set"] = record.as_bson.except(:key)
+          end
+
           {
             update_one: {
-              filter: {key: setting.key},
-              update: {
-                "$set": doc.except(:key, :history),
-                "$setOnInsert": {key: setting.key},
-                "$push": {history: {"$each": history}}
-              },
+              filter: {key: record.key},
+              update: update,
               upsert: true
             }
           }
@@ -146,13 +170,6 @@ module SuperSettings
         end
       end
 
-      attr_reader :new_history
-
-      def initialize(*)
-        @new_history = []
-        super
-      end
-
       def history(limit: nil, offset: 0)
         pipeline = [
           {
@@ -195,13 +212,6 @@ module SuperSettings
         end
       end
 
-      def create_history(changed_by:, created_at:, value: nil, deleted: false)
-        created_at = TimePrecision.new(created_at, :millisecond).time
-        history = HistoryStorage.new(key: key, value: value, changed_by: changed_by, created_at: created_at, deleted: deleted)
-        @new_history.unshift(history)
-        history
-      end
-
       def created_at=(val)
         super(TimePrecision.new(val, :millisecond).time)
       end

data/lib/super_settings/storage/null_storage.rb

@@ -0,0 +1,72 @@
+# frozen_string_literal: true
+
+module SuperSettings
+  module Storage
+    # No-op implementation of the SuperSettings::Storage model. You can use this model if there
+    # is no other storage engine available. It can be useful for situations where the normal
+    # storage engine is not available, such as in a continious integration environment.
+    class NullStorage
+      # :nocov:
+
+      include Storage
+
+      attr_accessor :key, :raw_value, :description, :value_type, :updated_at, :created_at, :changed_by
+
+      class << self
+        attr_reader :settings
+
+        def history(key)
+          []
+        end
+
+        def destroy_all
+        end
+
+        def all
+          []
+        end
+
+        def updated_since(time)
+          []
+        end
+
+        def find_by_key(key)
+          nil
+        end
+
+        def last_updated_at
+          nil
+        end
+
+        def create_history(key:, changed_by:, created_at:, value: nil, deleted: false)
+          nil
+        end
+
+        def load_asynchronous?
+          false
+        end
+      end
+
+      def history(limit: nil, offset: 0)
+        []
+      end
+
+      def save!
+        true
+      end
+
+      def deleted=(value)
+      end
+
+      def deleted?
+        false
+      end
+
+      def persisted?
+        false
+      end
+
+      # :nocov:
+    end
+  end
+end

data/lib/super_settings/storage/redis_storage.rb

@@ -116,6 +116,10 @@ module SuperSettings
           record unless record.deleted?
         end
 
+        def create_history(key:, changed_by:, created_at:, value: nil, deleted: false)
+          HistoryStorage.create!(key: key, value: value, deleted: deleted, changed_by: changed_by, created_at: created_at)
+        end
+
         def last_updated_at
           result = with_redis { |redis| redis.zrevrange(UPDATED_KEY, 0, 1, withscores: true).first }
           return nil unless result
@@ -184,10 +188,6 @@ module SuperSettings
         end
       end
 
-      def create_history(changed_by:, created_at:, value: nil, deleted: false)
-        HistoryStorage.create!(key: key, value: value, deleted: deleted, changed_by: changed_by, created_at: created_at)
-      end
-
       def save_to_redis(redis)
         redis.hset(SETTINGS_KEY, key, payload_json)
         redis.zadd(UPDATED_KEY, self.class.microseconds(updated_at), key)

data/lib/super_settings/storage/test_storage.rb

@@ -59,6 +59,20 @@ module SuperSettings
           settings.values.collect { |attributes| attributes[:updated_at] }.max
         end
 
+        def create_history(key:, changed_by:, created_at:, value: nil, deleted: false)
+          history = @history[key]
+          unless history
+            history = []
+            @history[key] = history
+          end
+
+          created_at = SuperSettings::TimePrecision.new(created_at).time if created_at
+          item = {key: key, value: value, deleted: deleted, changed_by: changed_by, created_at: created_at}
+          history.unshift(item)
+
+          item
+        end
+
         protected
 
         def default_load_asynchronous?
@@ -85,11 +99,6 @@ module SuperSettings
         end
       end
 
-      def create_history(changed_by:, created_at:, value: nil, deleted: false)
-        item = {key: key, value: value, deleted: deleted, changed_by: changed_by, created_at: created_at}
-        self.class.history(key).unshift(item)
-      end
-
       def save!
         self.updated_at ||= Time.now
         self.created_at ||= updated_at
@@ -123,11 +132,15 @@ module SuperSettings
       end
 
       def created_at=(value)
-        @created_at = SuperSettings::Coerce.time(value)
+        time = SuperSettings::Coerce.time(value)
+        time = SuperSettings::TimePrecision.new(time).time if time
+        @created_at = time
       end
 
       def updated_at=(value)
-        @updated_at = SuperSettings::Coerce.time(value)
+        time = SuperSettings::Coerce.time(value)
+        time = SuperSettings::TimePrecision.new(time).time if time
+        @updated_at = time
       end
 
       def deleted?

data/lib/super_settings/storage/transaction.rb

@@ -53,8 +53,9 @@ module SuperSettings
       end
 
       def save!
-        self.updated_at ||= Time.now
-        self.created_at ||= updated_at
+        timestamp = Time.now
+        self.updated_at ||= timestamp if respond_to?(:updated_at)
+        self.created_at ||= (respond_to?(:updated_at) ? updated_at : timestamp)
 
         self.class.transaction do |changes|
           changes << self

data/lib/super_settings/storage.rb

@@ -13,6 +13,7 @@ module SuperSettings
     autoload :JSONStorage, File.join(__dir__, "storage/json_storage")
     autoload :S3Storage, File.join(__dir__, "storage/s3_storage")
     autoload :MongoDBStorage, File.join(__dir__, "storage/mongodb_storage")
+    autoload :NullStorage, File.join(__dir__, "storage/null_storage")
 
     def self.included(base)
       base.extend(ClassMethods)
@@ -67,6 +68,15 @@ module SuperSettings
         # :nocov:
       end
 
+      # Create a history item for the setting.
+      #
+      # @return [void]
+      def create_history(key:, changed_by:, created_at:, value: nil, deleted: false)
+        # :nocov:
+        raise NotImplementedError
+        # :nocov:
+      end
+
       # Implementing classes can override this method to setup a thread safe connection within a block.
       #
       # @return [void]
@@ -253,9 +263,7 @@ module SuperSettings
     #
     # @return [void]
     def create_history(changed_by:, created_at:, value: nil, deleted: false)
-      # :nocov:
-      raise NotImplementedError
-      # :nocov:
+      self.class.create_history(key: key, changed_by: changed_by, created_at: created_at, value: value, deleted: deleted)
     end
 
     # Persist the record to storage.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: super_settings
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.1.1
 platform: ruby
 authors:
 - Brian Durand
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-11-22 00:00:00.000000000 Z
+date: 2024-12-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -79,6 +79,7 @@ files:
 - lib/super_settings/storage/http_storage.rb
 - lib/super_settings/storage/json_storage.rb
 - lib/super_settings/storage/mongodb_storage.rb
+- lib/super_settings/storage/null_storage.rb
 - lib/super_settings/storage/redis_storage.rb
 - lib/super_settings/storage/s3_storage.rb
 - lib/super_settings/storage/storage_attributes.rb