super_settings 2.0.1 → 2.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a7e5362ee5262805e4178be0485c0a3fba4d3f5468a793b8819abd1bb0322399
-  data.tar.gz: 1051e29b721ffb12a431b14ad660b13b25673abd766f7f987838030f665807cc
+  metadata.gz: deffd163ccbba074051f5e7df4138216f24da7c8fa068c5a25fdaa7c83326799
+  data.tar.gz: af00d68c45251327f0e73867c16bdb4171110929f02290db374178c88718f0ec
 SHA512:
-  metadata.gz: f29c06dc13802640cb1b7edd51b2fc8d8f2ed01f1e354fc6fe1eb50f58c32baa331ebb21fed9c42858c86a4d0a8a1b5a220aa1ca6bd1fe1c7a17fe2217cbcdf5
-  data.tar.gz: e5f5d481458271761744533629e504c93b8c4a3b4b70da048881ac1b272de1f8266e1da10444a55d5af7c60415c2de11eba9ba33fdf8f9d637ff3e33adc7b616
+  metadata.gz: d496dfbfeaba9952c624f15680323d83fe055a03f48f17c660a5dee8e3512a4692bbe249212bfdf1830026ec0e726cb312acc0134a8c8260e95433b6c325abc8
+  data.tar.gz: de6887cbbe6ec06ba1cb20e75769377008a5d7fa4eb1a55bcbb6be87e3cdff508890209a0984dc3cdf4ae293d895ce946eb807582097c65e052a9f0b0fcef081

data/CHANGELOG.md

@@ -4,6 +4,18 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 2.0.3
+
+### Fixed
+
+- Fixed ActiveRecord code handling changing a setting key to one that had previously been used. The previous code relied on a unique key constraint error to detect this condition, but Postgres does not handle this well since it invalidates the entire transaction. Now the code checks for the uniqueness of the key before attempting to save the setting.
+
+## 2.0.2
+
+### Fixed
+
+- Coercing a string to a boolean is now case insensitive (i.e. "True" is interpreted as `true` and "False" is interpreted as `false`).
+
 ## 2.0.1
 
 ### Added

data/VERSION

@@ -1 +1 @@
-2.0.1
+2.0.3

data/lib/super_settings/coerce.rb

@@ -7,14 +7,10 @@ module SuperSettings
   class Coerce
     # rubocop:disable Lint/BooleanSymbol
     FALSE_VALUES = Set.new([
-      false, 0,
       "0", :"0",
       "f", :f,
-      "F", :F,
       "false", :false,
-      "FALSE", :FALSE,
-      "off", :off,
-      "OFF", :OFF
+      "off", :off
     ]).freeze
     # rubocop:enable Lint/BooleanSymbol
 
@@ -29,7 +25,7 @@ module SuperSettings
         elsif blank?(value)
           nil
         else
-          !FALSE_VALUES.include?(value)
+          !FALSE_VALUES.include?(value.to_s.downcase)
         end
       end
 

data/lib/super_settings/storage/active_record_storage.rb

@@ -89,17 +89,17 @@ module SuperSettings
       end
 
       def save!
-        begin
+        # Check if another record with the same key exists. If it does, then we need to update
+        # that record instead and delete the current one.
+        duplicate = @model.class.find_by(key: @model.key)
+        if duplicate.nil? || duplicate == @model
           @model.save!
-        rescue ActiveRecord::RecordNotUnique => e
-          # Gracefully handle duplicate key constraint on the database; in this case the existing
-          # record should be updated.
-          duplicate = @model.class.find_by(key: @model.key)
-          raise e if duplicate == @model
+        else
           duplicate.raw_value = @model.raw_value
           duplicate.value_type = @model.value_type
           duplicate.description = @model.description
-          duplicate.deleted = false
+          duplicate.deleted = @model.deleted
+
           @model.transaction do
             if @model.persisted?
               @model.reload.update!(deleted: true)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: super_settings
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.3
 platform: ruby
 authors:
 - Brian Durand
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-10-28 00:00:00.000000000 Z
+date: 2024-11-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler