super_good-solidus_taxjar 0.6.1 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6563c176335daae605e2b63add3f10d670509486f31de788687b3fadfce537c0
-  data.tar.gz: 391562433aaa5a9a91be498f91c7b9dbaec899dc793ad37c942b4a7d809ead59
+  metadata.gz: 3bd45137c03f2ef0e98fc82b6c1e3e9685fa42b22560caf432ed428ae5ce9a3d
+  data.tar.gz: f7686d33b2d6f34d50a5f5e3307192ee7dbe1bb31c4276886fea695662d1e244
 SHA512:
-  metadata.gz: 6de73f35b8304608e370039d5e5c9d4f62ee21f756cee5ef68df8ed17b48b5c612b74e88014bcdc36ebe8eaee02670e27f118b2ab8b2e78f8e2b85a3f10a524a
-  data.tar.gz: ec6978c44dfc0cd05a9d4683ef66c50b773bc4599f173776dca589833a6da6c5c76816d1b486fa620597c785d5734c63f9337ea58a713d3b8f78de7d6a2f630f
+  metadata.gz: 844f20af4104c36eefc4c95dd4771a5b73a770ad41cfa23b08e9765e8d3dd362b8690caeb96fdab7689bccd42000067bc920ef996964cec477220db225f98fd6
+  data.tar.gz: 2a39bf8402ebba2397ff0a9467754fdfc94b23d7e9b443021ab36eda7ccc6531f0fc6d3a5ff5582e2d012ca1a3db229e7dccd1caca540bb3c31bca89cf35ec6d

data/CHANGELOG.md

@@ -1,7 +1,15 @@
 # Changelog
 
+## v0.6.2
+
+- Fixed issued where orders without tax address would cause errors because `Spree::Order#tax_address` will return a `Spree::Tax::TaxLocation` when called on an order without a tax address. `Spree::Tax::TaxLocation` isn't enough like a real address and this was causing exceptions.
+
+  To fix this `SuperGood::SolidusTaxJar#incomplete_address?` was updated to treat `Spree::Tax::TaxLocation`s as "incomplete". (Thanks to [@JuanCrg90](https://github.com/JuanCrg90)!)
+
 ## v0.6.1
 
+**Warning**: v0.6.1 has a critical bug and should not be used.
+
 - Stopped using the deprecated method `Spree::Address#empty?` in favour of simply checking that we have all of the fields on the address required for doing a TaxJar lookup.
 
 ## v0.6.0

data/lib/super_good/solidus_taxjar/tax_calculator.rb

@@ -152,6 +152,8 @@ module SuperGood
       end
 
       def incomplete_address?(tax_address)
+        return true if tax_address.is_a?(Spree::Tax::TaxLocation)
+
         [
           tax_address.address1,
           tax_address.city,

data/lib/super_good/solidus_taxjar/version.rb

@@ -1,5 +1,5 @@
 module SuperGood
   module SolidusTaxJar
-    VERSION = "0.6.1"
+    VERSION = "0.6.2"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: super_good-solidus_taxjar
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors:
 - Jared Norman
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-03-12 00:00:00.000000000 Z
+date: 2019-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: solidus_core
@@ -194,8 +194,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: Support for using TaxJar to handle tax calculations in Solidus