super_good-solidus_taxjar 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 4fabc8235afd3cc52046d35cf5d88ec0cd17d8e7
-  data.tar.gz: 52067151ebe53c704c9e9afb168919a2438f064c
+SHA256:
+  metadata.gz: 6563c176335daae605e2b63add3f10d670509486f31de788687b3fadfce537c0
+  data.tar.gz: 391562433aaa5a9a91be498f91c7b9dbaec899dc793ad37c942b4a7d809ead59
 SHA512:
-  metadata.gz: 9df52cfcec3b89302cf1b652172a7fa9f3545554d6ddb448f4a901dd681cdc0a15b8a710027e620078a9c2620ffe6bfee52b059a5cdb719b85e8a53579e3750d
-  data.tar.gz: 7d33b0dd569cde3c71e8b0bc390d406a6ba7c04200f206b45ab531f6ed5fae8a6e825c2cf0876887243197ca3b9b39589efa7d684721b9d5136f47362326c4ba
+  metadata.gz: 6de73f35b8304608e370039d5e5c9d4f62ee21f756cee5ef68df8ed17b48b5c612b74e88014bcdc36ebe8eaee02670e27f118b2ab8b2e78f8e2b85a3f10a524a
+  data.tar.gz: ec6978c44dfc0cd05a9d4683ef66c50b773bc4599f173776dca589833a6da6c5c76816d1b486fa620597c785d5734c63f9337ea58a713d3b8f78de7d6a2f630f

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## v0.6.1
+
+- Stopped using the deprecated method `Spree::Address#empty?` in favour of simply checking that we have all of the fields on the address required for doing a TaxJar lookup.
+
 ## v0.6.0
 
 - Added `SuperGood::SolidusTaxJar.shipping_tax_label_maker` for customizing the labels on the tax adjustments on shipments.

data/lib/super_good/solidus_taxjar/tax_calculator.rb

@@ -12,7 +12,7 @@ module SuperGood
 
       def calculate
         return no_tax if SuperGood::SolidusTaxJar.test_mode
-        return no_tax if order.tax_address.empty? || order.line_items.none?
+        return no_tax if incomplete_address?(order.tax_address) || order.line_items.none?
         return no_tax unless taxable_address? order.tax_address
 
         cache do
@@ -150,6 +150,16 @@ module SuperGood
       def line_item_tax_label(taxjar_line_item, spree_line_item)
         SuperGood::SolidusTaxJar.line_item_tax_label_maker.(taxjar_line_item, spree_line_item)
       end
+
+      def incomplete_address?(tax_address)
+        [
+          tax_address.address1,
+          tax_address.city,
+          tax_address&.state&.abbr || tax_address.state_name,
+          tax_address.zipcode,
+          tax_address.country.iso
+        ].any?(&:blank?)
+      end
     end
   end
 end

data/lib/super_good/solidus_taxjar/version.rb

@@ -1,5 +1,5 @@
 module SuperGood
   module SolidusTaxJar
-    VERSION = "0.6.0"
+    VERSION = "0.6.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: super_good-solidus_taxjar
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Jared Norman
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-02-07 00:00:00.000000000 Z
+date: 2019-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: solidus_core
@@ -195,7 +195,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2.3
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Support for using TaxJar to handle tax calculations in Solidus