super_good-solidus_taxjar 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 15e315fd76cef9f6fddba1b3202cda57b2e04d39
-  data.tar.gz: 64708cb635e934536fdb2dcb37cb0f60a23c8df1
+  metadata.gz: 76b48f5239948da1f17684991f5c22f66f2f4326
+  data.tar.gz: 3ea032a3d4659ed75142bf9eb338da2985309164
 SHA512:
-  metadata.gz: 1ad10edb29f0a302a1f3e2f9d4100814bbb0573895b1ff4ca10217283f24f2c6fa835711bd691d3719861f24a3c21376870364bbf99334d661ba8af62ef15f93
-  data.tar.gz: 6c925bf6f337c91c294a5846a7afb7b43a17cc0c25a661e51cbdee66275de1e08cb0f9bcec772699b19676e4325d2a282ad6927716a438388cfb834cc6cc3dbf
+  metadata.gz: 554d571ac1eaf53f17cbb903ae3fd25efa2942dc23d77e9f6d07cdf18f637249732d73e0d5c859d614408eefd820a1d2f6bbd7aaebc4c4e99772ce612ce9ef8b
+  data.tar.gz: 6b72b4a99f1c7f68955ff07c8c45f1061209dd11e0300e322bd8101162a5fa240074a0e0f292824c68ce665f51e39da664d43cdc2c9544ca60540bc6c34b1b43

data/CHANGELOG.md

@@ -0,0 +1,9 @@
+# Changelog
+
+## v0.5.0
+
+- Moved exception handler configuration to `SuperGood::SolidusTaxJar.exception_handler` from `SuperGood::SolidusTaxJar::TaxCalculator.exception_handler`. Now all the configuration options are in the same place.
+- Added `SuperGood::SolidusTaxJar.taxable_address_check` option which can be set to a block that receives the address and will prevent actual tax calculator from occurring if it returns false. If your app has introduced a method like `Spree::Address#us?`, you could avoid trying to compute taxes on non-US orders by doing the following in an initializer:
+  ```ruby
+  SuperGood::SolidusTaxJar.taxable_address_check = ->(address) { address.us? }
+  ```

data/lib/super_good/solidus_taxjar.rb

@@ -13,9 +13,15 @@ module SuperGood
     class << self
       attr_accessor :discount_calculator
       attr_accessor :test_mode
+      attr_accessor :exception_handler
+      attr_accessor :taxable_address_check
     end
 
     self.discount_calculator = ::SuperGood::SolidusTaxJar::DiscountCalculator
     self.test_mode = false
+    self.exception_handler = ->(e) {
+      Rails.logger.error "An error occurred while fetching TaxJar tax rates - #{e}: #{e.message}"
+    }
+    self.taxable_address_check = ->(address) { true }
   end
 end

data/lib/super_good/solidus_taxjar/tax_calculator.rb

@@ -1,11 +1,6 @@
 module SuperGood
   module SolidusTaxJar
     class TaxCalculator
-      class_attribute :exception_handler
-      self.exception_handler = ->(e) {
-        Rails.logger.error "An error occurred while fetching TaxJar tax rates - #{e}: #{e.message}"
-      }
-
       def self.default_api
         ::SuperGood::SolidusTaxJar::API.new
       end
@@ -18,6 +13,7 @@ module SuperGood
       def calculate
         return no_tax if SuperGood::SolidusTaxJar.test_mode
         return no_tax if order.tax_address.empty? || order.line_items.none?
+        return no_tax unless taxable_address? order.tax_address
 
         cache do
           next no_tax unless taxjar_breakdown
@@ -129,6 +125,14 @@ module SuperGood
           end
         end
       end
+
+      def exception_handler
+        SuperGood::SolidusTaxJar.exception_handler
+      end
+
+      def taxable_address?(address)
+        SuperGood::SolidusTaxJar.taxable_address_check.(address)
+      end
     end
   end
 end

data/lib/super_good/solidus_taxjar/version.rb

@@ -1,5 +1,5 @@
 module SuperGood
   module SolidusTaxJar
-    VERSION = "0.4.0"
+    VERSION = "0.5.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: super_good-solidus_taxjar
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Jared Norman
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-02-01 00:00:00.000000000 Z
+date: 2019-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: solidus_core
@@ -160,6 +160,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt