super_good-solidus_taxjar 0.17.1 → 0.18.1

data/spec/super_good/solidus_taxjar/tax_rate_calculator_spec.rb

@@ -0,0 +1,116 @@
+require "spec_helper"
+
+RSpec.describe ::SuperGood::SolidusTaxjar::TaxRateCalculator do
+  describe "#calculate" do
+    subject { calculator.calculate }
+
+    let(:calculator) { described_class.new(address, api: dummy_api) }
+
+    let(:dummy_api) do
+      instance_double ::SuperGood::SolidusTaxjar::Api
+    end
+
+    let(:dummy_tax_rate) { BigDecimal(0) }
+
+    let(:empty_address) do
+      ::Spree::Address.new
+    end
+
+    let(:incomplete_address) do
+      ::Spree::Address.new(
+        first_name: "Ronnie James",
+        zipcode: nil,
+        address1: nil,
+        city: "Beverly Hills",
+        state_name: "California",
+        country: ::Spree::Country.new(iso: "US")
+      )
+    end
+
+    let(:complete_address) do
+      incomplete_address.tap do |address|
+        address.zipcode = "90210"
+        address.address1 = "9900 Wilshire Blvd"
+      end
+    end
+
+    shared_examples "returns the dummy tax rate" do
+      it { expect(subject).to eq dummy_tax_rate }
+    end
+
+    context "when the address is an empty address" do
+      let(:address) { empty_address }
+
+      context "when we're not rescuing from errors" do
+        around do |example|
+          handler = SuperGood::SolidusTaxjar.exception_handler
+          SuperGood::SolidusTaxjar.exception_handler = ->(error) { raise error }
+          example.run
+          SuperGood::SolidusTaxjar.exception_handler = handler
+        end
+
+        it_behaves_like "returns the dummy tax rate"
+      end
+    end
+
+    context "when the address is not complete" do
+      let(:address) { incomplete_address }
+
+      it_behaves_like "returns the dummy tax rate"
+    end
+
+    context "when the address is complete" do
+      let(:address) { complete_address }
+
+      context "when the address is not taxable" do
+        before do
+          allow(SuperGood::SolidusTaxjar.taxable_address_check)
+            .to receive(:call).with(address)
+            .and_return(false)
+        end
+
+        it_behaves_like "returns the dummy tax rate"
+      end
+
+      context "when the address is taxable" do
+        let(:tax_rate) { 0.03 }
+
+        before do
+          allow(dummy_api).to receive(:tax_rate_for) { tax_rate }
+        end
+
+        it "returns the expected tax rate" do
+          expect(subject).to eq tax_rate
+        end
+      end
+    end
+
+    context "when the API encounters an error" do
+      let(:address) { complete_address }
+
+      before do
+        allow(dummy_api).to receive(:tax_rate_for).and_raise("A bad thing happened.")
+      end
+
+      it "calls the configured error handler" do
+        expect(SuperGood::SolidusTaxjar.exception_handler).to receive(:call) do |e|
+          expect(e).to be_a StandardError
+          expect(e.message).to eq "A bad thing happened."
+        end
+
+        subject
+      end
+
+      it_behaves_like "returns the dummy tax rate"
+    end
+
+    context "when test_mode is set" do
+      let(:address) { complete_address }
+
+      before { SuperGood::SolidusTaxjar.test_mode = true }
+      after { SuperGood::SolidusTaxjar.test_mode = false }
+
+      it_behaves_like "returns the dummy tax rate"
+    end
+  end
+end

data/spec/super_good/solidus_taxjar_spec.rb

@@ -0,0 +1,77 @@
+require "spec_helper"
+
+RSpec.describe SuperGood::SolidusTaxjar do
+  it "has a version number" do
+    expect(SuperGood::SolidusTaxjar::VERSION).not_to be nil
+  end
+
+  describe "configuration" do
+    describe ".cache_key" do
+      subject { described_class.cache_key.call(order) }
+
+      let(:order) { Spree::Order.new }
+
+      it "returns the API params converted to JSON" do
+        allow(SuperGood::SolidusTaxjar::ApiParams)
+          .to receive(:order_params)
+          .with(order)
+          .and_return({some: "hash", with: "stuff", in: "it"})
+
+        expect(subject).to eq '{"some":"hash","with":"stuff","in":"it"}'
+      end
+    end
+
+    describe ".discount_calculator" do
+      subject { described_class.discount_calculator }
+      it { is_expected.to eq SuperGood::SolidusTaxjar::DiscountCalculator }
+    end
+
+    describe ".test_mode" do
+      subject { described_class.test_mode }
+      it { is_expected.to eq false }
+    end
+
+    describe ".exception_handler" do
+      subject { described_class.exception_handler.call(exception) }
+
+      let(:exception) { StandardError.new("Something happened") }
+
+      it "reports the exception using the Rails logger" do
+        expect(Rails.logger).to receive(:error).with(
+          "An error occurred while fetching TaxJar tax rates - Something happened: Something happened"
+        )
+        subject
+      end
+    end
+
+    describe ".taxable_address_check" do
+      subject { described_class.taxable_address_check.call(address) }
+
+      let(:address) { Spree::Address.new }
+
+      it { is_expected.to eq true }
+    end
+
+    describe ".taxable_order_check" do
+      subject { described_class.taxable_order_check.call(order) }
+
+      let(:order) { Spree::Order.new }
+
+      it { is_expected.to eq true }
+    end
+
+    describe ".shipping_tax_label_maker" do
+      subject { described_class.shipping_tax_label_maker.call(shipment, shipping_tax) }
+      let(:shipment) { Spree::Shipment.new }
+      let(:shipping_tax) { BigDecimal("3.25") }
+      it { is_expected.to eq "Sales Tax" }
+    end
+
+    describe ".line_item_tax_label_maker" do
+      subject { described_class.line_item_tax_label_maker.call(taxjar_line_item, spree_line_item) }
+      let(:taxjar_line_item) { instance_double Taxjar::BreakdownLineItem }
+      let(:spree_line_item) { Spree::LineItem.new }
+      it { is_expected.to eq "Sales Tax" }
+    end
+  end
+end

data/super_good-solidus_taxjar.gemspec

@@ -3,31 +3,34 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "super_good/solidus_taxjar/version"
 
 Gem::Specification.new do |spec|
-  spec.name          = "super_good-solidus_taxjar"
-  spec.version       = SuperGood::SolidusTaxJar::VERSION
-  spec.authors       = ["Jared Norman"]
-  spec.email         = ["jared@super.gd"]
+  spec.name = "super_good-solidus_taxjar"
+  spec.version = SuperGood::SolidusTaxjar::VERSION
+  spec.authors = ["Jared Norman"]
+  spec.email = ["jared@super.gd"]
 
-  spec.summary       = "Support for using TaxJar to handle tax calculations in Solidus"
-  spec.description   = spec.summary
-  spec.homepage      = "https://github.com/SuperGoodSoft/solidus_taxjar"
-  spec.license       = "MIT"
+  spec.summary = "Support for using TaxJar to handle tax calculations in Solidus"
+  spec.description = spec.summary
+  spec.homepage = "https://github.com/SuperGoodSoft/solidus_taxjar"
+  spec.license = 'BSD-3-Clause'
+
+  spec.required_ruby_version = Gem::Requirement.new('~> 2.5')
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
-    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  end
-  spec.bindir        = "exe"
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  files = Dir.chdir(__dir__) { `git ls-files -z`.split("\x0") }
+
+  spec.files = files.grep_v(%r{^(test|spec|features)/})
+  spec.test_files = files.grep(%r{^(test|spec|features)/})
+  spec.bindir = "exe"
+  spec.executables = files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
   spec.add_dependency "solidus_core", ">= 2.4.0"
   spec.add_dependency "solidus_support"
   spec.add_dependency "taxjar-ruby"
 
+  spec.add_development_dependency "solidus_dev_support"
   spec.add_development_dependency "bundler"
-  spec.add_development_dependency "database_cleaner"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "rspec-rails"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: super_good-solidus_taxjar
 version: !ruby/object:Gem::Version
-  version: 0.17.1
+  version: 0.18.1
 platform: ruby
 authors:
 - Jared Norman
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-05-28 00:00:00.000000000 Z
+date: 2021-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: solidus_core
@@ -53,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: solidus_dev_support
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -67,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: database_cleaner
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -163,12 +163,21 @@ files:
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
-- LICENSE.txt
+- LICENSE
+- PULL_REQUEST_TEMPLATE.md
 - README.md
 - Rakefile
 - bin/console
+- bin/rails
+- bin/rails-engine
+- bin/rails-sandbox
+- bin/rake
+- bin/sandbox
 - bin/setup
+- lib/super_good-solidus_taxjar.rb
+- lib/super_good/engine.rb
 - lib/super_good/solidus_taxjar.rb
+- lib/super_good/solidus_taxjar/addresses.rb
 - lib/super_good/solidus_taxjar/api.rb
 - lib/super_good/solidus_taxjar/api_params.rb
 - lib/super_good/solidus_taxjar/calculator_helper.rb
@@ -176,10 +185,18 @@ files:
 - lib/super_good/solidus_taxjar/tax_calculator.rb
 - lib/super_good/solidus_taxjar/tax_rate_calculator.rb
 - lib/super_good/solidus_taxjar/version.rb
+- spec/spec_helper.rb
+- spec/super_good/solidus_taxjar/addresses_spec.rb
+- spec/super_good/solidus_taxjar/api_params_spec.rb
+- spec/super_good/solidus_taxjar/api_spec.rb
+- spec/super_good/solidus_taxjar/discount_calculator_spec.rb
+- spec/super_good/solidus_taxjar/tax_calculator_spec.rb
+- spec/super_good/solidus_taxjar/tax_rate_calculator_spec.rb
+- spec/super_good/solidus_taxjar_spec.rb
 - super_good-solidus_taxjar.gemspec
 homepage: https://github.com/SuperGoodSoft/solidus_taxjar
 licenses:
-- MIT
+- BSD-3-Clause
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -187,17 +204,25 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: Support for using TaxJar to handle tax calculations in Solidus
-test_files: []
+test_files:
+- spec/spec_helper.rb
+- spec/super_good/solidus_taxjar/addresses_spec.rb
+- spec/super_good/solidus_taxjar/api_params_spec.rb
+- spec/super_good/solidus_taxjar/api_spec.rb
+- spec/super_good/solidus_taxjar/discount_calculator_spec.rb
+- spec/super_good/solidus_taxjar/tax_calculator_spec.rb
+- spec/super_good/solidus_taxjar/tax_rate_calculator_spec.rb
+- spec/super_good/solidus_taxjar_spec.rb

data/LICENSE.txt

@@ -1,21 +0,0 @@
-The MIT License (MIT)
-
-Copyright (c) 2018 Jared Norman
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in
-all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-THE SOFTWARE.