super_form 0.0.1 → 0.1.0

data/spec/lib/super_form/fieldable_spec.rb

@@ -0,0 +1,82 @@
+require 'spec_helper'
+require 'super_form/fieldable'
+require 'field/bare'
+
+describe SuperForm::Fieldable do
+  context 'when no fieldset is defined' do
+    it 'returns no fieldsets' do
+      expect(class_with_no_fields.fieldsets).to eq({})
+    end
+  end
+
+  context 'when fields and fieldsets are defined' do
+    let(:dummy) { class_with_fields }
+
+    it 'has the right number of fields' do
+      expect(dummy.fields.length).to eq 5
+    end
+
+    it 'has field values which are the same as the form attributes' do
+      dummy.name  = 'Thiago'
+      dummy.ball  = "Let's have it"
+      dummy.car   = "Let's drive it"
+      dummy.email = "findme@athome.com"
+      dummy.phone = '12345'
+
+      expect(dummy.field(:name).value).to eq dummy.name
+      expect(dummy.field(:ball).value).to eq dummy.ball
+      expect(dummy.field(:car).value).to eq dummy.car
+      expect(dummy.field(:email).value).to eq dummy.email
+      expect(dummy.field(:phone).value).to eq dummy.phone
+    end
+
+    it 'defines fieldsets which contain form fields' do
+      general = dummy.fieldset(:general)
+      expect(general.fields).to eq({
+        name: dummy.field(:name)
+      })
+
+      toys = dummy.fieldset(:toys)
+      expect(toys.fields).to eq ({
+        ball: dummy.field(:ball),
+        car:  dummy.field(:car)
+      })
+    end
+
+    it 'uses :default fieldset for fields defined outside a fieldset' do
+      default = dummy.fieldset(:default)
+      expect(default.fields).to eq ({
+        email: dummy.field(:email),
+        phone: dummy.field(:phone)
+      })
+    end
+  end
+end
+
+def class_with_fields(&block)
+  Class.new do
+    include SuperForm::Fieldable
+
+    attr_accessor :name, :ball, :car, :email, :phone
+
+    fieldset :general do
+      field :name, Field::Text, presence: true
+    end
+
+    fieldset :toys do
+      field :ball, Field::Bare
+      field :car,  Field::Text
+    end
+
+    field :email, Field::Text
+    field :phone, Field::Text, length: { minimum: 4 }
+
+    instance_eval(&block) if block_given?
+  end.new
+end
+
+def class_with_no_fields
+  Class.new do
+    include SuperForm::Fieldable
+  end
+end

data/spec/lib/super_form_spec.rb

@@ -1,98 +1,153 @@
-require 'spec_helper'
 require 'super_form'
-require 'active_model'
+require 'field/bare'
+require 'spec_helper'
 
-module Field
-  class Null < Base; end
-end
+describe SuperForm do
+  it 'includes the Fieldable module' do
+    form = Class.new { include SuperForm }
+    expect(form.ancestors).to include SuperForm::Fieldable
+  end
 
-class DummyForm
-  include SuperForm
-end
+  it 'runs the setup method when instantiated' do
+    form = Class.new do
+      include SuperForm
+      attr_reader :test_setup
 
-describe SuperForm do
-  before(:all) do
-    DummyForm.class_eval do
-      fieldset :general do
-        field :name, Field::Text, presence: true
+      setup { @test_setup = 'it worked' }
+    end
+
+    expect(form.new.test_setup).to eq('it worked')
+  end
+
+  it 'is never persisted' do
+    form = form_with_fields
+    form.name = 'Thiago'
+    form.save
+
+    expect(form.persisted?).to be_false
+    expect(form_with_no_fields.persisted?).to be_false
+  end
+
+  describe 'ActiveModel naming' do
+    context 'when the class name method returns nil' do
+      it 'relies on to_s to guess the model name' do
+        form = Class.new { include SuperForm }
+
+        expect(form).to receive(:name)
+        expect(form).to receive(:to_s)
+
+        form.model_name
       end
 
-      fieldset :toys do
-        field :ball, Field::Null
-        field :car,  Field::Text
+      it 'returns the correct model name' do
+        form = Class.new { include SuperForm }
+        form.stub(:to_s).and_return('InexistentForm')
+
+        expect(form.model_name.name).to eq 'Inexistent'
       end
     end
 
-    @dummy_form = DummyForm.new
-  end
+    context 'when the class name method returns the class name' do
+      it 'uses the name method to guess the model name' do
+        form = Class.new { include SuperForm }
+        form.stub(:name).and_return 'InexistentForm'
 
-  context 'when a field is defined at class level' do
-    before(:all) { @fields = DummyForm.fields }
-    
-    it 'stores the basic field objects at class level' do
-      expect(@fields.fetch(:name)).to be_instance_of Field::Text
-      expect(@fields.fetch(:ball)).to be_instance_of Field::Null
-      expect(@fields.fetch(:car)).to be_instance_of Field::Text
-    end
+        expect(form).to receive(:name)
 
-    it 'assigns the fieldset to the field' do
-      expect(@fields.fetch(:name).fieldset).to eq :general
-      expect(@fields.fetch(:ball).fieldset).to eq :toys
-      expect(@fields.fetch(:car).fieldset).to eq :toys
+        form.model_name
+      end
+
+      it 'returns the correct model name' do
+        form = Class.new { include SuperForm }
+        form.stub(:name).and_return('InexistentForm')
+
+        expect(form.model_name.name).to eq 'Inexistent'
+      end
     end
   end
 
-  context 'when a form object is created' do
-    before(:each) { @dummy_form = DummyForm.new }
+  context 'when fields and fieldsets are defined' do
+    let!(:dummy) { form_with_fields }
 
-    # this can get better, but for now it's ok
     it 'creates virtus attributes' do
-      expect(@dummy_form).to respond_to(:name)
-      expect(@dummy_form).to respond_to(:name=)
-      expect(@dummy_form).to respond_to(:ball)
-      expect(@dummy_form).to respond_to(:ball=)
-      expect(@dummy_form).to respond_to(:car)
-      expect(@dummy_form).to respond_to(:car=)
+      expect(dummy).to respond_to(:name)
+      expect(dummy).to respond_to(:name=)
+      expect(dummy).to respond_to(:ball)
+      expect(dummy).to respond_to(:ball=)
+      expect(dummy).to respond_to(:car)
+      expect(dummy).to respond_to(:car=)
+      expect(dummy).to respond_to(:email)
+      expect(dummy).to respond_to(:email=)
+      expect(dummy).to respond_to(:phone)
+      expect(dummy).to respond_to(:phone=)
     end
 
-    it 'assigns the fieldset id to the field' do
-      expect(@dummy_form.field(:name).fieldset).to eq :general
-      expect(@dummy_form.field(:ball).fieldset).to eq :toys
-      expect(@dummy_form.field(:car).fieldset).to eq :toys
+    it 'is ready for validation' do
+      expect(dummy).to_not be_valid
+      expect(dummy.errors[:name]).to eq ["can't be blank"]
+      expect(dummy.errors[:phone]).to eq ["is too short (minimum is 4 characters)"]
     end
 
-    it 'defines fieldsets containing the bundled fields' do
-      general = @dummy_form.fieldsets.fetch(:general)
+    it 'calls persisted! when a valid form is saved' do
+      dummy.name  = 'Dummy'
+      dummy.phone = '12345'
 
-      expect(general.first).to be_instance_of Field::Text
-      expect(general.first.name).to eq :name
+      expect(dummy).to receive(:persist!).once
+      dummy.save
+    end
+  end
 
-      toys = @dummy_form.fieldsets.fetch(:toys)
+  context 'when callbacks are defined' do
+    it 'triggers callbacks for save' do
+      dummy = form_with_fields do
+        before_save :callback_call
+        after_save :callback_call
+      end
 
-      expect(toys.first).to be_instance_of Field::Null
-      expect(toys.first.name).to eq :ball
+      dummy.name = 'Dummy'
+      dummy.phone = '12345'
 
-      expect(toys.last).to be_instance_of Field::Text
-      expect(toys.last.name).to eq :car
+      expect(dummy).to receive(:callback_call).twice
+      dummy.save
     end
 
-    it 'fieldsets fields are the same instance of fields' do
-      @dummy_form.fieldsets.each do |id, fields|
-        fields.each do |field|
-          expect(field).to eq @dummy_form.field(field.name)
-        end
+    it 'triggers callbacks for validation' do
+      dummy = form_with_fields do
+        before_validation :callback_call
+        after_validation :callback_call
       end
+
+      dummy.name = 'Dummy'
+      dummy.phone = '12345'
+
+      expect(dummy).to receive(:callback_call).twice
+      dummy.valid?
     end
+  end
+end
 
-    it 'is ready for validation' do
-      expect(@dummy_form).to_not be_valid
-      expect(@dummy_form.errors[:name]).to eq ["can't be blank"]
+def form_with_fields(&block)
+  Class.new do
+    include SuperForm
+
+    fieldset :general do
+      field :name, Field::Text, presence: true
     end
 
-    context 'when assigning a new attribute' do
-      it 'assigns the value of the attribute to the field' do
-        pending
-      end
+    fieldset :toys do
+      field :ball, Field::Bare
+      field :car,  Field::Text
     end
-  end
+
+    field :email, Field::Text
+    field :phone, Field::Text, length: { minimum: 4 }
+
+    instance_eval(&block) if block_given?
+  end.new
+end
+
+def form_with_no_fields
+  Class.new do
+    include SuperForm
+  end.new
 end

data/spec/lib/telephone_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+require 'telephone'
+
+describe Telephone do
+  it "returns true if valid" do
+    valid_numbers = ['8436429999', '(84) 1111-1111', '8498741122']
+
+    valid_numbers.each do |number|
+      telephone = Telephone.new(number)
+      expect(telephone).to be_valid
+    end
+  end
+
+  it "returns false if not valid" do
+    invalid_numbers = ['843649999', '843 aaa', 'aaa 1234 $%']
+
+    invalid_numbers.each do |number|
+      telephone = Telephone.new(number)
+      expect(telephone).to_not be_valid
+    end
+  end
+
+  it "returns a stripped number" do
+    telephone = Telephone.new('(84) 3642-9999')
+    expect(telephone.stripped).to eq('8436429999')
+  end
+
+  it "returns a formatted number" do
+    telephone = Telephone.new('84 3642-9999')
+    expect(telephone.formatted).to eq('(84) 3642-9999')
+  end
+end

data/spec/spec_helper.rb

@@ -1,17 +1,10 @@
-# This file was generated by the `rspec --init` command. Conventionally, all
-# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
-# Require this file using `require "spec_helper"` to ensure that it is only
-# loaded once.
-#
-# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+require 'pry'
+
 RSpec.configure do |config|
   config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
   config.order = 'random'
 end
+
+I18n.enforce_available_locales = false if defined?(I18n)

data/spec/support/presenter_name.rb

@@ -0,0 +1,28 @@
+shared_examples "presenter nameable" do
+  describe '.name' do
+    it 'returns a demodulized and underscored presenter name' do
+      presenter = Class.new(described_class) do
+        def self.name
+          'Presenter::Deep::IDontExist'
+        end
+      end
+
+      expect(presenter.__name__).to eq 'i_dont_exist'
+    end
+
+    it 'trims _presenter suffix' do
+      presenter = Class.new(described_class) do
+        def self.name
+          'Presenter::Deep::IDontExistPresenter'
+        end
+      end
+
+      expect(presenter.__name__).to eq 'i_dont_exist'
+    end
+
+    it 'raises an exception if presenter is anonymous' do
+      presenter = Class.new(described_class)
+      expect { presenter.__name__ }.to raise_error RuntimeError
+    end
+  end
+end

data/super_form.gemspec

@@ -24,6 +24,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '2.14.1'
   spec.add_development_dependency 'simplecov', '0.8.2'
   spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'pry', '0.9.12.6'
   spec.add_development_dependency 'capybara', '2.2.0'
   spec.add_development_dependency 'activemodel', '4.0.2'
   spec.add_development_dependency 'activesupport', '4.0.2'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: super_form
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Thiago A. Silva
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-09 00:00:00.000000000 Z
+date: 2014-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sqlite3
@@ -94,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.9.12.6
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.9.12.6
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
@@ -191,24 +205,53 @@ files:
 - lib/cnpj_validator.rb
 - lib/cpf_validator.rb
 - lib/field.rb
+- lib/field/bare.rb
 - lib/field/base.rb
 - lib/field/cnpj.rb
 - lib/field/cpf.rb
 - lib/field/email.rb
 - lib/field/error.rb
+- lib/field/float.rb
+- lib/field/form.rb
+- lib/field/form_array.rb
+- lib/field/form_proxy.rb
 - lib/field/password.rb
 - lib/field/person_type.rb
 - lib/field/telephone.rb
 - lib/field/text.rb
 - lib/person_type.rb
+- lib/presenter.rb
+- lib/presenter/cnpj.rb
+- lib/presenter/cpf.rb
+- lib/presenter/form.rb
+- lib/presenter/password.rb
+- lib/presenter/person_type.rb
+- lib/presenter/telephone.rb
 - lib/super_form.rb
+- lib/super_form/fieldable.rb
+- lib/super_form/fieldset.rb
 - lib/super_form/version.rb
 - lib/tasks/.keep
 - lib/telephone.rb
 - lib/telephone_validator.rb
 - lib/uniqueness_validator.rb
+- spec/lib/field/form_array.rb
+- spec/lib/field/form_array_spec.rb
+- spec/lib/field/form_spec.rb
+- spec/lib/field_spec.rb
+- spec/lib/person_type_spec.rb
+- spec/lib/presenter/cnpj_spec.rb
+- spec/lib/presenter/cpf_spec.rb
+- spec/lib/presenter/form_spec.rb
+- spec/lib/presenter/password_spec.rb
+- spec/lib/presenter/person_type_spec.rb
+- spec/lib/presenter/telephone_spec.rb
+- spec/lib/presenter_spec.rb
+- spec/lib/super_form/fieldable_spec.rb
 - spec/lib/super_form_spec.rb
+- spec/lib/telephone_spec.rb
 - spec/spec_helper.rb
+- spec/support/presenter_name.rb
 - super_form.gemspec
 homepage: http://github.com/thiagoa/super_form
 licenses:
@@ -235,6 +278,21 @@ signing_key:
 specification_version: 4
 summary: Object oriented forms for Rails
 test_files:
+- spec/lib/field/form_array.rb
+- spec/lib/field/form_array_spec.rb
+- spec/lib/field/form_spec.rb
+- spec/lib/field_spec.rb
+- spec/lib/person_type_spec.rb
+- spec/lib/presenter/cnpj_spec.rb
+- spec/lib/presenter/cpf_spec.rb
+- spec/lib/presenter/form_spec.rb
+- spec/lib/presenter/password_spec.rb
+- spec/lib/presenter/person_type_spec.rb
+- spec/lib/presenter/telephone_spec.rb
+- spec/lib/presenter_spec.rb
+- spec/lib/super_form/fieldable_spec.rb
 - spec/lib/super_form_spec.rb
+- spec/lib/telephone_spec.rb
 - spec/spec_helper.rb
+- spec/support/presenter_name.rb
 has_rdoc: