super_exception_notifier 3.0.16 → 3.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 --- 
 SHA1: 
-  metadata.gz: 1f8b0247e2462146eb4b943eb720ec55fcc0e6d4
-  data.tar.gz: 5d4c11443936fa2b8edeb83bdd053f0cc73dc87f
+  metadata.gz: 53acfe8d674c8785ece68fa6c6100d900cb36de7
+  data.tar.gz: 5a20baccf5fefd0ddc7b11a83be5a195e56e9e76
 SHA512: 
-  metadata.gz: f05ac1ad139780aff29112bb45bf7e0832a4e2246096555a0bb46df6d286d06769acf8b89a6b3373ddb3b7487536887b39cb439f70f65583e346f5593e93993b
-  data.tar.gz: b2e8ee968254fe472cdbea04a617d9790899d5a0dde2547727223f2df540da9773ed6a25cb588d9d83b715cadebadc90df56f72aa3bc6307ca632f2877c76191
+  metadata.gz: 6a6d8325445fb7f4d04be4f09aee510e641b917526ec2d678b5f4cbb01675a233285fb865912cf34ff66d40aed4cc3aed11ed3b9cdba9498518b9495d73ae2bf
+  data.tar.gz: 87ec579a8b51aefae4db68acfb9b15e1b2d32951c429cf87214905206152d36b87c68741e6902a5cfe831a77e3c0357434418aab9b5023233b4aa68aff980df0

data/CHANGELOG.txt

@@ -1,3 +1,8 @@
+2014-01-18 v3.1
+- Lots of refactoring, mostly in the test suite by Peter Boling
+- Now tested against Rails 2.3 and 2.2 by Peter Boling
+- Still 2 failing tests on Rails 2.1 and 2.0
+
 2014-01-18 v3.0.16
 - Fixed all the URLs in the Readme.
 

data/README.md

@@ -171,7 +171,8 @@ For example:
 ## References
 
 * [Source Code](http://github.com/pboling/exception_notification)
-* [A fork from the my original source on Google Code](https://github.com/vitaliel/super_exception_notifier)
+* [A popular fork/rewrite of this fork](https://github.com/bmpercy/wrangler)
+* [An old fork of my original source on Google Code](https://github.com/vitaliel/super_exception_notifier)
 * [The Original Source on Google Code](http://super-exception-notifier.googlecode.com/svn/trunk/super_exception_notifier/)
 * [Getting it to work on Stack Overflow & my response](http://stackoverflow.com/questions/1738017/getting-super-exception-notifier-to-work)
 * [Getting it to work on PasteBin](http://pastebin.com/pyHQjN84)

data/Rakefile

@@ -2,7 +2,6 @@
 require "bundler/gem_tasks"
 require 'rake'
 require 'rake/testtask'
-require 'rake/rdoctask'
 
 desc 'Default: run unit tests.'
 task :default => :test
@@ -14,6 +13,16 @@ Rake::TestTask.new do |t|
   t.verbose = true
 end
 
+namespace :test do
+  desc 'Test against all supported Rails versions'
+  task :all do
+    %w(2.0.x 2.1.x 2.2.x 2.3.x).each do |version|
+      sh "BUNDLE_GEMFILE='gemfiles/Gemfile.rails-#{version}' bundle --quiet"
+      sh "BUNDLE_GEMFILE='gemfiles/Gemfile.rails-#{version}' bundle exec rake test"
+    end
+  end
+end
+
 require 'reek/rake/task'
 Reek::Rake::Task.new do |t|
   t.fail_on_error = true
@@ -27,9 +36,12 @@ RoodiTask.new do |t|
   t.verbose = false
 end
 
+
 desc 'Generate documentation for exception_notifiable gem.'
 require File.expand_path('../lib/super_exception_notifier/version', __FILE__)
-Rake::RDocTask.new do |rdoc|
+require 'rdoc'
+require 'rdoc/task'
+RDoc::Task.new do |rdoc|
   rdoc.rdoc_dir = 'rdoc'
   rdoc.title    = "exception_notifiable #{SuperExceptionNotifier::VERSION}"
   rdoc.options << '--line-numbers' << '--inline-source'

data/lib/exception_notification/exception_notifiable.rb

@@ -10,14 +10,14 @@ module ExceptionNotification::ExceptionNotifiable
 
     # Sets up an alias chain to catch exceptions when Rails does
     #This is what makes it all work with Hoptoad or other exception catchers.
-#    base.send(:alias_method, :rescue_action_locally_without_sen_handler, :rescue_action_locally)
-#    base.send(:alias_method, :rescue_action_locally, :rescue_action_locally_with_sen_handler)
+    #base.send(:alias_method, :rescue_action_locally_without_sen_handler, :rescue_action_locally)
+    #base.send(:alias_method, :rescue_action_locally, :rescue_action_locally_with_sen_handler)
 
 #Alias method chaining doesn't work here because it would trigger a double render error.
     # Sets up an alias chain to catch exceptions when Rails does
     #This is what makes it all work with Hoptoad or other exception catchers.
-#    base.send(:alias_method, :rescue_action_in_public_without_exception_notifiable, :rescue_action_in_public)
-#    base.send(:alias_method, :rescue_action_in_public, :rescue_action_in_public_with_exception_notifiable)
+    #base.send(:alias_method, :rescue_action_in_public_without_exception_notifiable, :rescue_action_in_public)
+    #base.send(:alias_method, :rescue_action_in_public, :rescue_action_in_public_with_exception_notifiable)
 
     # Adds the following class attributes to the classes that include ExceptionNotifiable
     #  HTTP status codes and what their 'English' status message is
@@ -90,7 +90,7 @@ module ExceptionNotification::ExceptionNotifiable
     def environment_is_noisy?
       self.class.exception_notifiable_noisy_environments.include?(Rails.env)
     end
-  
+
     def notification_level_sends_email?
       self.class.exception_notifiable_notification_level.include?(:email)
     end
@@ -115,7 +115,8 @@ module ExceptionNotification::ExceptionNotifiable
     # Or when the error occurs somewhere without a subsequent render (eg. method calls in console)
     def rescue_with_handler(exception)
       to_return = super
-      if to_return
+      # Not sure how to do this. We aren't supposed to rely on the return value of the super handler.
+      #if to_return
         verbose = self.class.exception_notifiable_verbose && respond_to?(:logger) && !logger.nil?
         logger.info("[RESCUE STYLE] rescue_with_handler") if verbose
         data = get_exception_data
@@ -133,7 +134,7 @@ module ExceptionNotification::ExceptionNotifiable
         # Send Web Hook requests
         ExceptionNotification::HooksNotifier.deliver_exception_to_web_hooks(ExceptionNotification::Notifier.config, exception, self, request, data, the_blamed) if send_web_hooks
         pass_it_on(exception, ENV, verbose)
-      end
+      #end
       to_return
     end
 
@@ -141,6 +142,7 @@ module ExceptionNotification::ExceptionNotifiable
     # any custom processing that is defined with Rails 2's exception helpers.
     # When the action being executed is letting SEN handle the exception completely
     def rescue_action_in_public(exception)
+      logger.info "rescue_action_in_public"
       # If the error class is NOT listed in the rails_error_class hash then we get a generic 500 error:
       # OTW if the error class is listed, but has a blank code or the code is == '200' then we get a custom error layout rendered
       # OTW the error class is listed!
@@ -156,6 +158,7 @@ module ExceptionNotification::ExceptionNotifiable
     end
 
     def notify_and_render_error_template(status_cd, request, exception, file_path, verbose = false)
+      logger.info "notify_and_render_error_template"
       status = self.class.http_status_codes[status_cd] ? status_cd + " " + self.class.http_status_codes[status_cd] : status_cd
       data = get_exception_data
       #We only send email if it has been configured in environment

data/lib/exception_notification/helpful_hashes.rb

@@ -2,7 +2,7 @@
 #Released under the MIT license
 
 module ExceptionNotification::HelpfulHashes
-  unless defined?(SILENT_EXCEPTIONS)
+  SILENT_EXCEPTIONS = begin
     noiseless = []
     noiseless << ActiveRecord::RecordNotFound if defined?(ActiveRecord)
     if defined?(ActionController)
@@ -11,7 +11,7 @@ module ExceptionNotification::HelpfulHashes
       noiseless << ActionController::RoutingError
       noiseless << ActionController::MethodNotAllowed
     end
-    SILENT_EXCEPTIONS = noiseless
+    noiseless
   end
 
   # TODO: use ActionController::StatusCodes
@@ -27,7 +27,7 @@ module ExceptionNotification::HelpfulHashes
     "500" => "Internal Server Error",
     "501" => "Not Implemented",
     "503" => "Service Unavailable"
-  } unless defined?(HTTP_STATUS_CODES)
+  }
 
   def codes_for_error_classes
     #TODO: Format whitespace

data/lib/exception_notification/notifiable.rb

@@ -55,7 +55,7 @@ module ExceptionNotification::Notifiable
   private
 
   def environment_is_noisy?
-    self.notifiable_noisy_environments.include?(Rails.env)
+    self.class.notifiable_noisy_environments.include?(Rails.env) if defined?(Rails)
   end
 
   def notification_level_sends_email?

data/lib/exception_notification/notifiable_helper.rb

@@ -27,29 +27,29 @@ module ExceptionNotification::NotifiableHelper
   end
 
   def verbose_output(exception, status_cd, file_path, send_email, send_web_hooks, request = nil, the_blamed = nil, rejected_sections = nil)
-    logger.info("[EXCEPTION] #{exception}")
-    logger.info("[EXCEPTION CLASS] #{exception.class}")
-    logger.info("[EXCEPTION STATUS_CD] #{status_cd}")
-    logger.info("[ERROR LAYOUT] #{self.class.error_layout}") if self.class.respond_to?(:error_layout)
-    logger.info("[ERROR VIEW PATH] #{ExceptionNotification::Notifier.config[:view_path]}") if !ExceptionNotification::Notifier.nil? && !ExceptionNotification::Notifier.config[:view_path].nil?
-    logger.info("[ERROR FILE PATH] #{file_path.inspect}")
-    logger.info("[ERROR EMAIL] #{send_email ? "YES" : "NO"}")
-    logger.info("[ERROR WEB HOOKS] #{send_web_hooks ? "YES" : "NO"}")
-    logger.info("[THE BLAMED] #{the_blamed}") unless the_blamed.blank?
-    logger.info("[SECTIONS] #{ExceptionNotification::Notifier.sections_for_email(rejected_sections, request).inspect}")
+    puts("[EXCEPTION] #{exception}")
+    puts("[EXCEPTION CLASS] #{exception.class}")
+    puts("[EXCEPTION STATUS_CD] #{status_cd}")
+    puts("[ERROR LAYOUT] #{self.class.error_layout}") if self.class.respond_to?(:error_layout)
+    puts("[ERROR VIEW PATH] #{ExceptionNotification::Notifier.config[:view_path]}") if !ExceptionNotification::Notifier.nil? && !ExceptionNotification::Notifier.config[:view_path].nil?
+    puts("[ERROR FILE PATH] #{file_path.inspect}")
+    puts("[ERROR EMAIL] #{send_email ? "YES" : "NO"}")
+    puts("[ERROR WEB HOOKS] #{send_web_hooks ? "YES" : "NO"}")
+    puts("[THE BLAMED] #{the_blamed}") unless the_blamed.blank?
+    puts("[SECTIONS] #{ExceptionNotification::Notifier.sections_for_email(rejected_sections, request).inspect}")
     req = request ? " for request_uri=#{request.request_uri}" : ""
     logger.error("render_error(#{status_cd}, #{self.class.http_status_codes[status_cd]}) invoked#{req}") if self.class.respond_to?(:http_status_codes)
   end
 
   def perform_exception_notify_mailing(exception, data, request = nil, the_blamed = nil, verbose = false, rejected_sections = nil)
     if ExceptionNotification::Notifier.config[:exception_recipients].blank?
-      logger.info("[EMAIL NOTIFICATION] ExceptionNotification::Notifier.config[:exception_recipients] is blank, notification cancelled!") if verbose
+      puts("[EMAIL NOTIFICATION] ExceptionNotification::Notifier.config[:exception_recipients] is blank, notification cancelled!") if verbose
     else
       class_name = self.respond_to?(:controller_name) ? self.controller_name : self.to_s
       method_name = self.respond_to?(:action_name) ? self.action_name : get_method_name
       ExceptionNotification::Notifier.deliver_exception_notification(exception, class_name, method_name,
         request, data, the_blamed, rejected_sections)
-      logger.info("[EMAIL NOTIFICATION] Sent") if verbose
+      puts("[EMAIL NOTIFICATION] Sent") if verbose
     end
   end
 
@@ -65,7 +65,7 @@ module ExceptionNotification::NotifiableHelper
   def should_notify_on_exception?(exception, status_cd = nil, verbose = false)
     # don't notify (email or web hooks) on exceptions raised locally
     verbose && ExceptionNotification::Notifier.config[:skip_local_notification] && is_local? ?
-      logger.info("[NOTIFY LOCALLY] NO") :
+      puts("[NOTIFY LOCALLY] NO") :
       nil
     return false if ExceptionNotification::Notifier.config[:skip_local_notification] && is_local?
     # don't notify (email or web hooks) exceptions raised that match ExceptionNotifiable.notifiable_silent_exceptions

data/lib/super_exception_notifier/version.rb

@@ -1,5 +1,5 @@
 module SuperExceptionNotifier
 
-  VERSION = '3.0.16'
+  VERSION = '3.1.0'
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: super_exception_notifier
 version: !ruby/object:Gem::Version 
-  version: 3.0.16
+  version: 3.1.0
 platform: ruby
 authors: 
 - Peter Boling
@@ -46,7 +46,7 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        version: "2.3"
+        version: "2.0"
     - - <
       - !ruby/object:Gem::Version 
         version: "3"
@@ -69,10 +69,7 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        version: "0.8"
-    - - <
-      - !ruby/object:Gem::Version 
-        version: "0.9"
+        version: 10.1.1
   type: :development
   version_requirements: *id005
 - !ruby/object:Gem::Dependency