super_callbacks 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 22e2f43cddcb768271ec74009deb2829526bdd27
-  data.tar.gz: 701e41c8e839ab61ad2df10a4f2566ddf048aabc
+  metadata.gz: 281eed10edbb6eb455f6a91c229a6a7391a2ab65
+  data.tar.gz: ed6e915ce8778783ceeb9aa666622c7e36f7fdd4
 SHA512:
-  metadata.gz: 67f3d6b901dfece079d580f5379fbea181ebe9f03abe7f4a63fbcb6a71790f4c887852ac4c2e5fe8e17dfd6ac1c7f246b8ad8ae0eb82d54e16ed3b79551b8bcc
-  data.tar.gz: 33cb10f65c83656417940e2ec233081eab3108fdfcafe1c851a25d715f1c77dd235d721161399fd3e5437d44c21f15377d3321f789de2ac66116d52e7492191d
+  metadata.gz: 004497ddd9066a5c602f617024dc95b6993ffd455a8f153f28e760b0f4e4246c578781888c067885bf116065c16c088ce2f64cc133ad972f62c5b3e934cb99cc
+  data.tar.gz: 5d8c7b1d744307b9d9000f810cd3affb7089a4ce259035bef9e7e6e4505a6918cc038bf16166024b8873a3e42bb4a3ee200054c4a6543b17e1aa449123e6e0d6

data/README.md

@@ -1,6 +1,7 @@
 # SuperCallbacks
 
 [![Build Status](https://travis-ci.org/jrpolidario/super_callbacks.svg?branch=master)](https://travis-ci.org/jrpolidario/super_callbacks)
+[![Gem Version](https://badge.fury.io/rb/super_callbacks.svg)](https://badge.fury.io/rb/super_callbacks)
 
 * Allows `before` and `after` callbacks to any Class.
 * Supports both class and instance level callbacks
@@ -106,6 +107,7 @@ foo.bar
 ```
 
 *Notice above that you can also call another method instead of supplying a block.*
+
 *Above uses `before`, but works similarly with `after`*
 
 ### Example 3 (Multiple Callbacks)
@@ -142,6 +144,7 @@ foo.bar
 ```
 
 *Notice above multiple callbacks are supported, and that they are called in firt-come-first-served order.*
+
 *Above uses `before`, but works similarly with `after`*
 
 ### Example 4 (Setter Method Callbacks)
@@ -286,6 +289,7 @@ foo_2.bar
 ```
 
 *Notice above that foo_1 and foo_2 both call the class-level callbacks, while they have independent (not-shared) instance-level callbacks defined. Order of execution is class-level first then instance-level, of which defined callbacks are then in order of first-come-first-serve.*
+
 *Above uses `before`, but works similarly with `after`*
 
 ### Example 8 (Inherited Callbacks)
@@ -322,8 +326,42 @@ sub_foo.bar
 ```
 
 *Notice above `sub_foo` calls both `before` callbacks defined in `Foo` and `SubFoo`, because SubFoo inherits from Foo. Callbacks are called in order of ancestors descending; meaning it starts calling the top-level ancestor superclass callbacks, and then calling its subclass callbacks, until it reaches the instance's class callbacks*
+
 *Above uses `before`, but works similarly with `after`*
 
+### Example 9 (Requiring Method To Be Defined)
+
+```ruby
+class Foo
+  include SuperCallbacks
+
+  after! :bar do
+    puts 'after bar!'
+  end
+
+  def bar
+    puts 'bar!'
+  end
+end
+# => ArgumentError: `bar` is not or not yet defined for Foo
+
+class Foo
+  include SuperCallbacks
+
+  def bar
+    puts 'bar!'
+  end
+
+  after! :bar do
+    puts 'after bar!'
+  end
+end
+# => [NO ERRORS]
+```
+
+*From above, sometimes I noticed that I forgot to define a method! So the bang `!` version is just basically like `after` except that this raises an error if `method_name` is not defined or not yet defined (at the time `after!` is called). This works perfect with `attr_accesors` I normally put them at the top of the lines of a Class, and so I can now safely call `before!` or `after!` because I am sure that I already defined everything I needed to define. If I forgot something then, this `before!` would raise an error and alert me, and not silently failing. Helps debugging :)*
+
+*Above uses `after!`, but works similarly with `before!`*
 
 ## TODOs
 * when the need already arises, implement `around` (If you have ideas or want to help this part, please feel free to fork or send me a message! :)
@@ -344,7 +382,7 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Changelog
 
-* 1.0.2 (2019-08-12)
+* 1.0.3 (2019-08-12)
     * Cleaner code without explicitly calling `run_callbacks` anymore; done now because of ruby upgrade from 1.9 to 2.0+ which already supports `prepend`
     * Supported both class and instance level callbacks
     * Supported inherited callbacks

data/lib/super_callbacks.rb

@@ -4,6 +4,9 @@ module SuperCallbacks
   VALID_OPTION_KEYS = [:if].freeze
 
   def self.included(base)
+    # prevent re-including
+    return if base.ancestors.detect { |ancestor| ancestor.is_a? SuperCallbacks::Prepended }
+
     base.singleton_class.send :attr_accessor, *[:before_callbacks, :after_callbacks]
     base.send :attr_accessor, *[:before_callbacks, :after_callbacks]
     base.extend ClassMethods
@@ -39,14 +42,14 @@ module SuperCallbacks
   end
 
   module ClassAndInstanceMethods
-    def before!(method_name, *remaining_args)
+    def before!(method_name, *remaining_args, &callback_proc)
       raise ArgumentError, "`#{method_name}` is not or not yet defined for #{self}" unless method_defined? method_name
-      before(method_name, *remaining_args)
+      before(method_name, *remaining_args, &callback_proc)
     end
 
-    def after!(method_name, *remaining_args)
+    def after!(method_name, *remaining_args, &callback_proc)
       raise ArgumentError, "`#{method_name}` is not or not yet defined for #{self}" unless method_defined? method_name
-      before(method_name, *remaining_args)
+      after(method_name, *remaining_args, &callback_proc)
     end
 
     def before(method_name, callback_method_name = nil, options = {}, &callback_proc)

data/lib/super_callbacks/version.rb

@@ -1,3 +1,3 @@
 module SuperCallbacks
-  VERSION = '1.0.2'
+  VERSION = '1.0.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: super_callbacks
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Jules Roman B. Polidario
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-08-13 00:00:00.000000000 Z
+date: 2019-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler