sunstone 5.1.0.3 → 5.1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 36510647bb5cb8991c4133315ef746af7f2ad49b
-  data.tar.gz: 668776a98974ad2685c9bf82f054258fb462cd55
+  metadata.gz: d53af8c7411662e7621971b1c2a3f39f130ea8c3
+  data.tar.gz: 8a61637315c7faf35265b47b8334901340b41798
 SHA512:
-  metadata.gz: 26f5d6e7b9095a221b5c411b5b6d8f6b32a39a4629175f72750a19b23178684275385b26e76329b3b24af6e333f2566642ebb134be60be651e59ac15fa5e0811
-  data.tar.gz: 9d000ed9a6e7647edb76e846f3fee0e3d31d64fd0ced01779dee814759885328d5dcb9b0ed26909bc3471d0c29d314e61d5509bde015615a0623732930c79eca
+  metadata.gz: 690936bd2ba33aab551c98da50ea1871e29fdfa9207dd71c7bcd78050bfa56f219ad859c068ac33346833ffb44feb058bc2f41a46ab7c2e4f70b11c0f1449a62
+  data.tar.gz: 6e9f804cc2b2e75584e184b9791dc3f5b2d0d682c71cd5ef1c60cb4ffdf1af23b6607bf3f650be218acb87f0173dad53b2621fffa3aa9dac40f72fc51efc4663

data/ext/active_record/associations/collection_association.rb

@@ -9,6 +9,7 @@ module ActiveRecord
         if owner.new_record?
           replace_records(other_array, original_target)
         elsif owner.class.connection.is_a?(ActiveRecord::ConnectionAdapters::SunstoneAPIAdapter) && owner.instance_variable_defined?(:@updating) && owner.instance_variable_get(:@updating)
+          self.instance_variable_set(:@sunstone_changed, true)
           replace_common_records_in_memory(other_array, original_target)
 
           # Remove from target
@@ -71,7 +72,7 @@ module ActiveRecord
     # will fail and false will be returned.
     def update(attributes)
       @updating = :updating
-      $updating_model = self
+      Thread.current[:sunstone_updating_model] = self
       
       # The following transaction covers any possible database side-effects of the
       # attributes assignment. For example, setting the IDs of a child collection.
@@ -81,7 +82,7 @@ module ActiveRecord
       end
     ensure
       @updating = false
-      $updating_model = nil
+      Thread.current[:sunstone_updating_model] = nil
     end
     
   end

data/ext/active_record/attribute_methods.rb

@@ -16,7 +16,7 @@ module ActiveRecord
       if self.class.connection.is_a?(ActiveRecord::ConnectionAdapters::SunstoneAPIAdapter)
         self.class.reflect_on_all_associations.each do |reflection|
           if reflection.belongs_to?
-            if association(reflection.name).loaded? && association(reflection.name).target == $updating_model
+            if association(reflection.name).loaded? && association(reflection.name).target == Thread.current[:sunstone_updating_model]
               attrs.delete(arel_table[reflection.foreign_key])
             else
               add_attributes_for_belongs_to_association(reflection, attrs)
@@ -109,25 +109,25 @@ module ActiveRecord
       if reflection.is_a?(ActiveRecord::Reflection::HasAndBelongsToManyReflection)
         @_already_called[:"autosave_associated_records_for_#{self.class.name.downcase.pluralize}_#{reflection.name}"] = true
       end
-      
-      if association = association_instance_get(reflection.name)
-        autosave = reflection.options[:autosave]
 
-        attrs[Arel::Attributes::EmptyRelation.new(arel_table, reflection.name, true, true)] = [] if association.target.empty?
+      if association = association_instance_get(reflection.name)
+        if new_record? || (association.instance_variable_defined?(:@sunstone_changed) && association.instance_variable_get(:@sunstone_changed)) || reflection.options[:autosave] || association.target.any?(&:changed_for_autosave?) || association.target.any?(&:new_record?)
+          attrs[Arel::Attributes::EmptyRelation.new(arel_table, reflection.name, true, true)] = [] if association.target.empty?
         
-        association.target.each_with_index do |record, idx|
-          next if record.destroyed?
+          association.target.each_with_index do |record, idx|
+            next if record.destroyed?
 
-          if record.new_record?
-            record.send(:arel_attributes_with_values_for_create, record.attribute_names).each do |k, v|
-              attrs[Arel::Attributes::Relation.new(k, reflection.name, idx, true)] = v
-            end
-          else
-            record.send(:arel_attributes_with_values_for_update, record.attribute_names).each do |k, v|
-              attrs[Arel::Attributes::Relation.new(k, reflection.name, idx, true)] = v
+            if record.new_record?
+              record.send(:arel_attributes_with_values_for_create, record.send(:keys_for_partial_write) + [record.class.primary_key]).each do |k, v|
+                attrs[Arel::Attributes::Relation.new(k, reflection.name, idx, true)] = v
+              end
+            else
+              record.send(:arel_attributes_with_values_for_update, record.send(:keys_for_partial_write) + [record.class.primary_key]).each do |k, v|
+                attrs[Arel::Attributes::Relation.new(k, reflection.name, idx, true)] = v
+              end
             end
           end
-
+          association.instance_variable_set(:@sunstone_changed, false)
         end
 
         # reconstruct the scope now that we know the owner's id

data/ext/active_record/persistence.rb

@@ -16,7 +16,7 @@ module ActiveRecord
 
     def create_or_update(*args)
       @updating = new_record? ? :creating : :updating
-      $updating_model = self
+      Thread.current[:sunstone_updating_model] = self
 
       raise ReadOnlyRecord, "#{self.class} is marked as readonly" if readonly?
       result = new_record? ? _create_record : _update_record(*args)
@@ -55,7 +55,7 @@ module ActiveRecord
       raise ActiveRecord::RecordInvalid
     ensure
       @updating = false
-      $updating_model = nil
+      Thread.current[:sunstone_updating_model] = nil
     end
     
     # Creates a record with values matching those of the instance attributes

data/lib/arel/visitors/sunstone.rb

@@ -34,7 +34,7 @@ module Arel
         if !o.orders.empty?
           collector.order = o.orders.map { |x| visit(x, collector) }
         end
-
+        
         collector = maybe_visit o.limit, collector
         collector = maybe_visit o.offset, collector
         collector = maybe_visit o.eager_load, collector
@@ -635,11 +635,20 @@ module Arel
         end
       end
 
-      # def visit_Arel_Nodes_Matches o, collector
-      #   collector = visit o.left, collector
-      #   collector << " LIKE "
-      #   visit o.right, collector
-      # end
+      def visit_Arel_Nodes_Matches o, collector
+        key = visit(o.left, collector)
+        value = { like: visit(o.right, collector) }
+
+        if key.is_a?(Hash)
+          if o.left.is_a?(Arel::Attributes::Cast)
+            merge_to_bottom_hash(key, value)
+          else
+            add_to_bottom_of_hash(key, value)
+          end
+        else
+          { key => value }
+        end
+      end
       #
       # def visit_Arel_Nodes_DoesNotMatch o, collector
       #   collector = visit o.left, collector

data/lib/sunstone/version.rb

@@ -1,3 +1,3 @@
 module Sunstone
-  VERSION = '5.1.0.3'
+  VERSION = '5.1.0.4'
 end

data/test/active_record/associations/belongs_to_test.rb

@@ -0,0 +1,162 @@
+require 'test_helper'
+
+class ActiveRecord::Associations::BelongsToTest < ActiveSupport::TestCase
+
+  schema do
+    create_table "ships" do |t|
+      t.string   "name",                    limit: 255
+      t.integer  "fleet_id"
+    end
+
+    create_table "fleets" do |t|
+      t.string   "name",                    limit: 255
+    end
+  end
+
+  class Fleet < ActiveRecord::Base
+    has_many :ships
+  end
+
+  class Ship < ActiveRecord::Base
+    belongs_to :fleet
+  end
+  
+  # Save includes =============================================================
+
+  test '#save new record includes new belongs_to associations' do
+    ship = Ship.new(name: 'Definant', fleet: Fleet.new(name: 'Armada Duo'))
+    
+    req_stub = webmock(:post, '/ships', {include: :fleet}).with(
+      body: {
+        ship: { name: 'Definant', fleet_attributes: { name: 'Armada Duo' } }
+      }.to_json
+    ).to_return(
+      body: {
+        id: 2,
+        fleet_id: 3,
+        name: 'Definant 001',
+        fleet: { id: 3, name: 'Armada 2' }
+      }.to_json
+    )
+    
+    assert ship.save
+    assert_equal 2, ship.id
+    assert_equal 3, ship.fleet_id
+    assert_equal 3, ship.fleet.id
+    assert_equal 'Definant 001', ship.name
+    assert_equal 'Armada 2', ship.fleet.name
+    
+    assert_requested req_stub
+  end
+  
+  test '#save new record doesnt include persisted/unmodified belongs_to associations' do
+    webmock(:get, "/fleets", where: {id: 1}, limit: 1).to_return(
+      body: [{id: 1, name: 'Armada Original'}].to_json
+    )
+    
+    fleet = Fleet.find(1)
+    ship = Ship.new(name: 'Definant', fleet: fleet)
+    
+    req_stub = webmock(:post, '/ships').with(
+      body: {
+        ship: { name: 'Definant', fleet_id: 1 }
+      }.to_json
+    ).to_return(
+      body: {
+        id: 2,
+        fleet_id: 1,
+        name: 'Definant 001'
+      }.to_json
+    )
+    
+    assert ship.save
+    assert_equal 2, ship.id
+    assert_equal 1, ship.fleet_id
+    
+    assert_requested req_stub
+  end
+  
+  test '#save persisted record includes new belongs_to associations' do
+    webmock(:get, "/ships", where: {id: 1}, limit: 1).to_return(
+      body: [{id: 1, fleet_id: nil, name: 'Ship Uno'}].to_json
+    )
+
+    req_stub = webmock(:patch, '/ships/1', {include: :fleet}).with(
+      body: {
+        ship: { fleet_attributes: { name: 'Armada Duo' } }
+      }.to_json
+    ).to_return(
+      body: {
+        id: 1, fleet_id: 2, name: 'Ship Uno',
+        fleet: { id: 2, name: 'Armada Duo' }
+      }.to_json
+    )
+
+    ship = Ship.find(1)
+    ship.fleet = Fleet.new(name: 'Armada Duo')
+
+    ship.save
+    
+    assert_requested req_stub
+  end
+  
+  test '#save persisted record doesnt include persisted/unmodified belongs_to associations but updates belongs_to key' do
+    webmock(:get, "/ships", where: {id: 1}, limit: 1).to_return(
+      body: [{id: 1, fleet_id: nil, name: 'Ship Uno'}].to_json
+    )
+    webmock(:get, "/fleets", where: {id: 1}, limit: 1).to_return(
+      body: [{id: 1, name: 'Armada Original'}].to_json
+    )
+    
+    fleet = Fleet.find(1)
+    ship = Ship.find(1)
+    
+    req_stub = webmock(:patch, '/ships/1').with(
+      body: {
+        ship: { fleet_id: 1 }
+      }.to_json
+    ).to_return(
+      body: {
+        id: 1,
+        fleet_id: 1,
+        name: 'My Ship'
+      }.to_json
+    )
+    
+    ship.fleet = fleet
+    assert ship.save
+    assert_equal 1, ship.id
+    assert_equal 1, ship.fleet_id
+    assert_equal 'My Ship', ship.name
+    
+    assert_requested req_stub
+  end
+
+  test '#save persisted record doesnt include loaded belongs_to association' do
+    webmock(:get, "/ships", where: {id: 1}, limit: 1, include: [:fleet]).to_return(
+      body: [{id: 1, fleet_id: 1, name: 'Ship Uno', fleet: {id: 1, name: 'Armada Original'}}].to_json
+    )
+    
+    ship = Ship.eager_load(:fleet).find(1)
+    
+    req_stub = webmock(:patch, '/ships/1').with(
+      body: {
+        ship: { name: 'New NAME!!' }
+      }.to_json
+    ).to_return(
+      body: {
+        id: 1,
+        fleet_id: 1,
+        name: 'New NAME!!'
+      }.to_json
+    )
+
+
+    assert ship.association(:fleet).loaded?
+    ship.name = 'New NAME!!'
+    assert ship.save
+
+    assert_requested req_stub
+  end
+
+end

data/test/active_record/associations/has_and_belongs_to_many_test.rb

@@ -32,4 +32,94 @@ class ActiveRecord::Associations::HasAndBelongsToManyTest < ActiveSupport::TestC
     assert_equal [43], Ship.find(42).sailor_ids
   end
 
+  test '#update habtm relationships' do
+    webmock(:get, "/ships", where: {id: 1}, limit: 1).to_return(
+      body: [{id: 1, fleet_id: nil, name: 'Armada Uno'}].to_json
+    )
+    webmock(:get, "/sailors", where: {id: 1}, limit: 1).to_return(
+      body: [{id: 1, name: 'Captain'}].to_json
+    )
+    webmock(:get, "/sailors", where: {sailors_ships: {ship_id: {eq: 1}}}).to_return(
+      body: [].to_json
+    )
+    req_stub = webmock(:patch, '/ships/1').with(
+      body: {ship: {sailors_attributes: [{id: 1}]}}.to_json
+    ).to_return(
+      body: {id: 1, name: 'Armada Uno'}.to_json
+    )
+
+    ship = Ship.find(1)
+    assert ship.update(sailors: [Sailor.find(1)])
+    assert_requested req_stub
+  end
+  
+  test '#update clears habtm relationship' do
+    webmock(:get, "/ships", where: {id: 1}, limit: 1).to_return(
+      body: [{id: 1, fleet_id: nil, name: 'Armada Uno'}].to_json
+    )
+    webmock(:get, "/sailors", where: {id: 1}, limit: 1).to_return(
+      body: [{id: 1, name: 'Captain'}].to_json
+    )
+    webmock(:get, "/sailors", where: {sailors_ships: {ship_id: {eq: 1}}}).to_return(
+      body: [{id: 1, name: 'Captain'}].to_json
+    )
+    req_stub = webmock(:patch, '/ships/1').with(
+      body: {ship: {sailors_attributes: []}}.to_json
+    ).to_return(
+      body: {id: 1, name: 'Armada Uno'}.to_json
+    )
+
+    ship = Ship.find(1)
+    assert ship.update(sailors: [])
+    assert_requested req_stub
+  end
+  
+  test '#save persisted record doesnt include loaded habtm association' do
+    webmock(:get, "/ships", where: {id: 1}, limit: 1).to_return(
+      body: [{id: 1, name: 'Armada Uno'}].to_json
+    )
+    webmock(:get, "/sailors", where: {id: 1}, limit: 1).to_return(
+      body: [{id: 1, name: 'Captain'}].to_json
+    )
+    webmock(:get, "/sailors", where: {sailors_ships: {ship_id: {eq: 1}}}).to_return(
+      body: [{id: 1, name: 'Captain'}].to_json
+    )
+    
+    ship = Ship.find(1)
+    
+    
+    req_stub = webmock(:patch, '/ships/1').with(
+      body: {
+        ship: { name: 'New NAME!!' }
+      }.to_json
+    ).to_return(
+      body: {
+        id: 1,
+        name: 'New NAME!!'
+      }.to_json
+    )
+    
+    ship.sailors.load
+    assert ship.sailors.loaded?
+    ship.name = 'New NAME!!'
+    assert ship.save
+
+    assert_requested req_stub
+  end
+  
+  
+  test "#destroy with habtm relationship" do
+    webmock(:get, "/ships", where: {id: 1}, limit: 1).to_return(
+      body: [{id: 1, fleet_id: nil, name: 'Armada Uno'}].to_json
+    )
+    req_stub = webmock(:delete, '/ships/1').to_return(
+      status: 204
+    )
+
+    ship = Ship.find(1)
+    assert ship.destroy
+    assert_requested req_stub
+  end
+
+
 end

data/test/active_record/associations/has_many_test.rb

@@ -21,13 +21,15 @@ class ActiveRecord::Associations::HasManyTest < ActiveSupport::TestCase
     belongs_to :fleet
   end
   
+  # ID Setters ================================================================
+  
   test '#create with has_many_ids=' do
     webmock(:get, "/ships", where: {id: 2}).to_return(body: [{id: 2, fleet_id: nil, name: 'Duo'}].to_json)
     webmock(:post, "/fleets").with(
       body: {
         fleet: {
           name: 'Spanish Armada',
-          ships_attributes: [{id: 2, name: 'Duo'}]
+          ships_attributes: [{id: 2}]
         }
       }
     ).to_return(body: {id: 42, name: "Spanish Armada"}.to_json)
@@ -44,14 +46,52 @@ class ActiveRecord::Associations::HasManyTest < ActiveSupport::TestCase
     webmock(:patch, "/fleets/42").with(
       body: {
         fleet: {
-          ships_attributes: [{id: 2, name: 'Duo'}]
+          ships_attributes: [{id: 2}]
         }
     }).to_return(body: {id: 42, name: "Spanish Armada"}.to_json)
 
     Fleet.find(42).update(ship_ids: ["2"])
   end
+  
+  # Modifing relationship ====================================================
 
-  test '#save includes modified has_many associations' do
+  test '#save persisted records includes has_many associations when new record added' do
+    webmock(:get, '/fleets', where: {id: 1}, limit: 1, include: [:ships]).to_return({
+      body: [{
+        id: 1,
+        name: 'Armada Trio',
+        ships: [
+          {id: 2, fleet_id: 1, name: 'Definant'}
+        ]
+      }].to_json
+    })
+    
+    webmock(:get, '/ships', where: {id: 3}, limit: 1).to_return({
+      body: [{id: 3, fleet_id: nil, name: 'Enterprise'}].to_json
+    })
+
+    req_stub = webmock(:patch, '/fleets/1').with(
+      body: {
+        fleet: {
+          ships_attributes: [{ id: 2 }, {id: 3 }]
+        }
+      }.to_json
+    ).to_return(
+      body: {
+        id: 1,
+        name: 'Armada Trio',
+        ships: [{ id: 2, fleet_id: 1, name: 'Voyager' }]
+      }.to_json
+    )
+
+    # fleet.ships = [ship]
+    fleet = Fleet.eager_load(:ships).find(1)
+    fleet.update(ships: fleet.ships + [Ship.find(3)])
+
+    assert_requested req_stub
+  end
+
+  test '#save persisted records includes has_many associations when replaced with new record' do
     webmock(:get, '/fleets', where: {id: 1}, limit: 1, include: [:ships]).to_return({
       body: [{
         id: 1,
@@ -81,13 +121,93 @@ class ActiveRecord::Associations::HasManyTest < ActiveSupport::TestCase
     assert fleet.update(ships: [Ship.new(name: 'Voyager')])
     assert_equal 1, fleet.id
     assert_equal [3], fleet.ships.map(&:id)
-    # assert_equal 3, ship.fleet.id
-    # assert_equal 'Definant 001', ship.name
-    # assert_equal 'Armada 2', ship.fleet.name
 
     assert_requested req_stub
   end
   
+  test '#save persisted records includes has_many associations when updating record in relationship' do
+    webmock(:get, '/fleets', where: {id: 1}, limit: 1, include: [:ships]).to_return({
+      body: [{
+        id: 1,
+        name: 'Armada Trio',
+        ships: [
+          {id: 2, fleet_id: 1, name: 'Definant'}, {id: 3, fleet_id: 1, name: 'Enterprise'}
+        ]
+      }].to_json
+    })
+    
+    req_stub = webmock(:patch, '/fleets/1').with(
+      body: {
+        fleet: {
+          ships_attributes: [{ name: 'Voyager', id: 2 }, {id: 3}]
+        }
+      }.to_json
+    ).to_return(
+      body: {
+        id: 1,
+        name: 'Armada Trio',
+        ships: [{ id: 2, fleet_id: 1, name: 'Voyager' }, {id: 3, fleet_id: 1, name: 'Enterprise'}]
+      }.to_json
+    )
+
+    # fleet.ships = [ship]
+    fleet = Fleet.eager_load(:ships).find(1)
+    fleet.ships.first.name = 'Voyager'
+    fleet.save
+
+    assert_requested req_stub
+  end
+  
+  test '#save persisted records doesnt include any loaded has_many associations' do
+    webmock(:get, '/fleets', where: {id: 1}, limit: 1, include: [:ships]).to_return({
+      body: [{
+        id: 1,
+        name: 'Armada Trio',
+        ships: [
+          {id: 2, fleet_id: 1, name: 'Definant'}, {id: 3, fleet_id: 1, name: 'Enterprise'}
+        ]
+      }].to_json
+    })
+    
+    req_stub = webmock(:patch, '/fleets/1').with(
+      body: { fleet: { name: 'New NAME!!' } }.to_json
+    ).to_return(
+      body: {
+        id: 1,
+        name: 'New NAME!!'
+      }.to_json
+    )
+
+    # fleet.ships = [ship]
+    fleet = Fleet.eager_load(:ships).find(1)
+    assert fleet.ships.loaded?
+    fleet.name = 'New NAME!!'
+    fleet.save
+
+    assert_requested req_stub
+  end
+  
+  # Clearing the relationship =================================================
+
+  test '#update clears has_many relationship' do
+    webmock(:get, "/fleets", where: {id: 1}, limit: 1).to_return(
+      body: [{id: 1, name: 'Armada Uno'}].to_json
+    )
+    webmock(:get, "/ships", where: {fleet_id: 1}).to_return(
+      body: [{id: 1, name: 'Saucer Trio'}].to_json
+    )
+    req_stub = webmock(:patch, '/fleets/1').with(
+      body: {fleet: {ships_attributes: []}}.to_json
+    ).to_return(
+      body: {id: 1, name: 'Armada Uno'}.to_json
+    )
+
+    fleet = Fleet.find(1)
+    assert fleet.update(ships: [])
+    assert_requested req_stub
+  end
+
+  
   # test 'relation#delete_all' do
   #   webmock(:get, "/fleets", where: {id: 42}, limit: 1).to_return(body: [{id: 42, name: "Spanish Armada"}].to_json)
   #   Fleet.find(42).ships.delete_all

data/test/active_record/persistance_test.rb

@@ -84,7 +84,6 @@ class ActiveRecord::PersistanceTest < ActiveSupport::TestCase
     assert_equal 'Armada Duo', fleet.name
   end
 
-  
   test '#save attempts another request while in transaction' do
     webmock(:get, '/test_model_bs/schema').to_return(
       body: {
@@ -110,33 +109,6 @@ class ActiveRecord::PersistanceTest < ActiveSupport::TestCase
     end
   end
   
-  test '#save includes modified belongs_to associations' do
-    ship = Ship.new(name: 'Definant', fleet: Fleet.new(name: 'Armada Duo'))
-    
-    req_stub = webmock(:post, '/ships', {include: :fleet}).with(
-      body: {
-        ship: {
-          name: 'Definant', fleet_attributes: { name: 'Armada Duo' }
-        }
-      }.to_json
-    ).to_return(
-      body: {
-        id: 2,
-        fleet_id: 3,
-        name: 'Definant 001',
-        fleet: { id: 3, name: 'Armada 2' }
-      }.to_json
-    )
-    
-    assert ship.save
-    assert_equal 2, ship.id
-    assert_equal 3, ship.fleet_id
-    assert_equal 3, ship.fleet.id
-    assert_equal 'Definant 001', ship.name
-    assert_equal 'Armada 2', ship.fleet.name
-    
-    assert_requested req_stub
-  end
   
   
   test '#update clears belongs_to relationship' do
@@ -184,77 +156,4 @@ class ActiveRecord::PersistanceTest < ActiveSupport::TestCase
     assert_requested req_stub
   end
 
-  test '#update habtm relationships' do
-    webmock(:get, "/ships", where: {id: 1}, limit: 1).to_return(
-      body: [{id: 1, fleet_id: nil, name: 'Armada Uno'}].to_json
-    )
-    webmock(:get, "/sailors", where: {id: 1}, limit: 1).to_return(
-      body: [{id: 1, name: 'Captain'}].to_json
-    )
-    webmock(:get, "/sailors", where: {sailors_ships: {ship_id: {eq: 1}}}).to_return(
-      body: [].to_json
-    )
-    req_stub = webmock(:patch, '/ships/1').with(
-      body: {ship: {sailors_attributes: [{id: 1, name: "Captain"}]}}.to_json
-    ).to_return(
-      body: {id: 1, name: 'Armada Uno'}.to_json
-    )
-
-    ship = Ship.find(1)
-    assert ship.update(sailors: [Sailor.find(1)])
-    assert_requested req_stub
-  end
-  
-  test '#update clears habtm relationship' do
-    webmock(:get, "/ships", where: {id: 1}, limit: 1).to_return(
-      body: [{id: 1, fleet_id: nil, name: 'Armada Uno'}].to_json
-    )
-    webmock(:get, "/sailors", where: {id: 1}, limit: 1).to_return(
-      body: [{id: 1, name: 'Captain'}].to_json
-    )
-    webmock(:get, "/sailors", where: {sailors_ships: {ship_id: {eq: 1}}}).to_return(
-      body: [{id: 1, name: 'Captain'}].to_json
-    )
-    req_stub = webmock(:patch, '/ships/1').with(
-      body: {ship: {sailors_attributes: []}}.to_json
-    ).to_return(
-      body: {id: 1, name: 'Armada Uno'}.to_json
-    )
-
-    ship = Ship.find(1)
-    assert ship.update(sailors: [])
-    assert_requested req_stub
-  end
-
-  test '#update clears has_many relationship' do
-    webmock(:get, "/fleets", where: {id: 1}, limit: 1).to_return(
-      body: [{id: 1, name: 'Armada Uno'}].to_json
-    )
-    webmock(:get, "/ships", where: {fleet_id: 1}).to_return(
-      body: [{id: 1, name: 'Saucer Trio'}].to_json
-    )
-    req_stub = webmock(:patch, '/fleets/1').with(
-      body: {fleet: {ships_attributes: []}}.to_json
-    ).to_return(
-      body: {id: 1, name: 'Armada Uno'}.to_json
-    )
-
-    fleet = Fleet.find(1)
-    assert fleet.update(ships: [])
-    assert_requested req_stub
-  end
-  
-  test "#destroy with habtm relationship" do
-    webmock(:get, "/ships", where: {id: 1}, limit: 1).to_return(
-      body: [{id: 1, fleet_id: nil, name: 'Armada Uno'}].to_json
-    )
-    req_stub = webmock(:delete, '/ships/1').to_return(
-      status: 204
-    )
-
-    ship = Ship.find(1)
-    assert ship.destroy
-    assert_requested req_stub
-  end
-  
 end

data/test/active_record/query/limit_test.rb

@@ -0,0 +1,19 @@
+require 'test_helper'
+
+class ActiveRecord::LimitTest < ActiveSupport::TestCase
+  schema do
+    create_table "ships" do |t|
+      t.string   "name",                limit: 255
+    end
+  end
+
+  class Ship < ActiveRecord::Base
+  end
+    
+  test '::limit' do
+    webmock(:get, "/ships", {limit: 5000}).to_return(body: [{id: 42}].to_json)
+    assert_equal Ship.limit(5000).map(&:id), [42]
+  end
+
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sunstone
 version: !ruby/object:Gem::Version
-  version: 5.1.0.3
+  version: 5.1.0.4
 platform: ruby
 authors:
 - Jon Bracy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-08 00:00:00.000000000 Z
+date: 2017-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -286,6 +286,7 @@ files:
 - lib/sunstone/gis.rb
 - lib/sunstone/version.rb
 - sunstone.gemspec
+- test/active_record/associations/belongs_to_test.rb
 - test/active_record/associations/has_and_belongs_to_many_test.rb
 - test/active_record/associations/has_many_test.rb
 - test/active_record/eager_loading_test.rb
@@ -295,6 +296,7 @@ files:
 - test/active_record/query/count_test.rb
 - test/active_record/query/distinct_test.rb
 - test/active_record/query/find_test.rb
+- test/active_record/query/limit_test.rb
 - test/active_record/query/order_test.rb
 - test/active_record/query/where_test.rb
 - test/active_record/query_test.rb
@@ -324,11 +326,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: A library for interacting with REST APIs
 test_files:
+- test/active_record/associations/belongs_to_test.rb
 - test/active_record/associations/has_and_belongs_to_many_test.rb
 - test/active_record/associations/has_many_test.rb
 - test/active_record/eager_loading_test.rb
@@ -338,6 +341,7 @@ test_files:
 - test/active_record/query/count_test.rb
 - test/active_record/query/distinct_test.rb
 - test/active_record/query/find_test.rb
+- test/active_record/query/limit_test.rb
 - test/active_record/query/order_test.rb
 - test/active_record/query/where_test.rb
 - test/active_record/query_test.rb