sunspot_rails 2.2.7 → 2.5.0

data/spec/rails_app/app/controllers/application_controller.rb

@@ -0,0 +1,4 @@
+class ApplicationController < ActionController::Base
+  helper :all
+  protect_from_forgery
+end

data/spec/rails_app/app/controllers/posts_controller.rb

@@ -0,0 +1,16 @@
+class PostsController < ApplicationController
+  def create
+    PostWithAuto.create(permitted_params[:post])
+    head(:ok)
+  end
+
+  private
+
+  def permitted_params
+    if ::Rails::VERSION::MAJOR >= 4
+      params.permit! # ActionController::Parameters
+    else
+      params
+    end
+  end
+end

data/spec/{rails_template → rails_app}/app/models/author.rb

@@ -2,8 +2,6 @@ class Author < ActiveRecord::Base
   self.table_name  = :writers
   self.primary_key = :writer_id
 
-  attr_accessible :name
-
   searchable do
     string :name
   end

data/spec/{rails_template → rails_app}/app/models/blog.rb

@@ -2,8 +2,6 @@ class Blog < ActiveRecord::Base
   has_many :posts
   has_many :comments, :through => :posts
 
-  attr_accessible :name, :subdomain
-
   searchable :include => { :posts => :author } do
     string :subdomain
     text :name

data/spec/{rails_template → rails_app}/app/models/location.rb

@@ -1,3 +1,2 @@
 class Location < ActiveRecord::Base
-  attr_accessible :lat, :lng
 end

data/spec/{rails_template → rails_app}/app/models/post.rb

@@ -3,8 +3,6 @@ class Post < ActiveRecord::Base
   belongs_to :author
   has_many :comments
 
-  attr_accessible :title, :type, :location_id, :body, :blog
-
   searchable :auto_index => false, :auto_remove => false do
     string :title
     text :body, :more_like_this => true

data/spec/{rails_template → rails_app}/app/models/post_with_auto.rb

@@ -3,8 +3,6 @@ class PostWithAuto < ActiveRecord::Base
     'posts'
   end
 
-  attr_accessible :title, :type, :location_id, :body, :blog
-
   searchable :ignore_attribute_changes_of => [ :updated_at ] do
     string :title
     text :body, :more_like_this => true

data/spec/{rails_template → rails_app}/app/models/post_with_default_scope.rb

@@ -3,8 +3,6 @@ class PostWithDefaultScope < ActiveRecord::Base
     'posts'
   end
 
-  attr_accessible :title, :type, :location_id, :body, :blog
-
 	def self.default_scope
 		order(:title)
   end

data/spec/{rails_template → rails_app}/app/models/post_with_only_some_attributes_triggering_reindex.rb

@@ -3,8 +3,6 @@ class PostWithOnlySomeAttributesTriggeringReindex < ActiveRecord::Base
     'posts'
   end
 
-  attr_accessible :title, :type, :location_id, :body, :blog
-
   searchable :only_reindex_attribute_changes_of => [ :title, :body ] do
     string :title
     text :body, :more_like_this => true

data/spec/rails_app/config.ru

@@ -0,0 +1,4 @@
+# This file is used by Rack-based servers to start the application.
+
+require ::File.expand_path('../config/environment',  __FILE__)
+run RailsApp::Application

data/spec/rails_app/config/application.rb

@@ -0,0 +1,14 @@
+require File.expand_path('../boot', __FILE__)
+
+require 'rails/all'
+
+Bundler.require(:default, Rails.env) if defined?(Bundler)
+
+module RailsApp
+  class Application < Rails::Application
+    config.encoding = 'utf-8'
+
+    # Configure sensitive parameters which will be filtered from the log file.
+    config.filter_parameters += [:password]
+  end
+end

data/spec/rails_app/config/boot.rb

@@ -0,0 +1,6 @@
+require 'rubygems'
+
+# Set up gems listed in the Gemfile.
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
+
+require 'bundler/setup' if File.exists?(ENV['BUNDLE_GEMFILE'])

data/spec/rails_app/config/database.yml

@@ -0,0 +1,5 @@
+test:
+  adapter: sqlite3
+  database: ':memory:'
+  pool: 5
+  timeout: 5000

data/spec/rails_app/config/environment.rb

@@ -0,0 +1,5 @@
+# Load the rails application
+require File.expand_path('../application', __FILE__)
+
+# Initialize the rails application
+RailsApp::Application.initialize!

data/spec/rails_app/config/environments/test.rb

@@ -0,0 +1,41 @@
+RailsApp::Application.configure do
+  # Settings specified here will take precedence over those in config/application.rb
+
+  # The test environment is used exclusively to run your application's
+  # test suite.  You never need to work with it otherwise.  Remember that
+  # your test database is "scratch space" for the test suite and is wiped
+  # and recreated between test runs.  Don't rely on the data there!
+  config.cache_classes = true
+
+  # Eager load code on boot. This eager loads most of Rails and
+  # your application in memory, allowing both thread web servers
+  # and those relying on copy on write to perform better.
+  # Rake tasks automatically ignore this option for performance.
+  config.eager_load = true
+
+  # Show full error reports and disable caching
+  config.consider_all_requests_local       = true
+  config.action_controller.perform_caching = false
+
+  # Raise exceptions instead of rendering exception templates
+  config.action_dispatch.show_exceptions = false
+
+  # Disable request forgery protection in test environment
+  config.action_controller.allow_forgery_protection    = false
+
+  # Tell Action Mailer not to deliver emails to the real world.
+  # The :test delivery method accumulates sent emails in the
+  # ActionMailer::Base.deliveries array.
+  config.action_mailer.delivery_method = :test
+
+  # Use SQL instead of Active Record's schema dumper when creating the test database.
+  # This is necessary if your schema can't be completely dumped by the schema dumper,
+  # like if you have constraints or database-specific column types
+  # config.active_record.schema_format = :sql
+
+  # mute Rails 5.2 deprecation warning
+  config.active_record.sqlite3.represent_boolean_as_integer = true if config.active_record.sqlite3
+
+  # Print deprecation notices to the stderr
+  config.active_support.deprecation = :stderr
+end

data/spec/rails_app/config/initializers/secret_token.rb

@@ -0,0 +1 @@
+Rails.application.config.secret_key_base = '_secret_key_base_'

data/spec/rails_app/config/initializers/session_store.rb

@@ -0,0 +1,3 @@
+# Be sure to restart your server when you modify this file.
+
+Rails.application.config.session_store :cookie_store, :key => '_rails_app_session'

data/spec/{rails_template → rails_app}/config/sunspot.yml

@@ -2,6 +2,7 @@ test:
   solr:
     hostname: localhost
     port: 8983
+    update_format: <%= ENV.fetch('UPDATE_FORMAT', 'xml') %>
   auto_index_callback: after_save
   auto_remove_callback: after_destroy
 development:
@@ -22,6 +23,7 @@ config_test:
     bind_address: 127.0.0.1
     read_timeout: 2
     open_timeout: 0.5
+    update_format: json
     proxy: http://proxy.com:12345
   auto_commit_after_request: false
   auto_commit_after_delete_request: true

data/spec/rails_app/db/schema.rb

@@ -0,0 +1,26 @@
+ActiveRecord::Schema.define(version: 0) do
+  create_table :posts, force: :cascade do |t|
+    t.string :title
+    t.string :type
+    t.integer :location_id
+    t.text :body
+    t.references :blog
+    t.timestamps null: true
+  end
+
+  create_table :locations, force: :cascade do |t|
+    t.float :lat
+    t.float :lng
+  end
+
+  create_table :blogs, force: :cascade do |t|
+    t.string :name
+    t.string :subdomain
+    t.timestamps null: true
+  end
+
+  create_table :writers, force: :cascade, primary_key: :writer_id do |t|
+    t.string :name
+    t.timestamps null: true
+  end
+end

data/spec/rake_task_spec.rb

@@ -12,27 +12,27 @@ describe 'sunspot namespace rake task' do
       run_rake_task("sunspot:reindex", '', '', true)
 
       # This model should not be used by any other test and therefore should only be loaded by this test
-      Sunspot.searchable.collect(&:name).should include('RakeTaskAutoLoadTestModel')
+      expect(Sunspot.searchable.collect(&:name)).to include('RakeTaskAutoLoadTestModel')
     end
 
     it "should accept a space delimited list of models to reindex" do
-      Post.should_receive(:solr_reindex)
-      Author.should_receive(:solr_reindex)
-      Blog.should_not_receive(:solr_reindex)
+      expect(Post).to receive(:solr_reindex)
+      expect(Author).to receive(:solr_reindex)
+      expect(Blog).not_to receive(:solr_reindex)
 
       run_rake_task("sunspot:reindex", '', "Post Author", true)
     end
 
     it "should accept a plus delimited list of models to reindex" do
-      Post.should_receive(:solr_reindex)
-      Author.should_receive(:solr_reindex)
-      Blog.should_not_receive(:solr_reindex)
+      expect(Post).to receive(:solr_reindex)
+      expect(Author).to receive(:solr_reindex)
+      expect(Blog).not_to receive(:solr_reindex)
 
       run_rake_task("sunspot:reindex", '', "Post+Author", true)
     end
 
     it "should raise exception when all tables of sunspot models are empty" do
-      STDOUT.should_receive(:puts).with("You have no data in the database. Reindexing does nothing here.")
+      expect(STDOUT).to receive(:puts).with("You have no data in the database. Reindexing does nothing here.")
       empty_tables
       run_rake_task("sunspot:reindex")
     end

data/spec/request_lifecycle_spec.rb

@@ -15,47 +15,43 @@ describe PostsController, :type => :controller do
     Sunspot::Rails.configuration = nil
   end
 
-  unless respond_to?(:describes)
-    controller_name :posts  # RSpec 1
-  end
-
   it 'should automatically commit after each action if specified' do
     @configuration.user_configuration = { 'auto_commit_after_request' => true }
-    Sunspot.should_receive(:commit_if_dirty)
-    post :create, :post => { :title => 'Test 1' }
+    expect(Sunspot).to receive(:commit_if_dirty)
+    post :create, :params => { :post => { :title => 'Test 1' } }
   end
-  
+
   it 'should not commit, if configuration is set to false' do
     @configuration.user_configuration = { 'auto_commit_after_request' => false }
-    Sunspot.should_not_receive(:commit_if_dirty)
-    post :create, :post => { :title => 'Test 1' }
+    expect(Sunspot).not_to receive(:commit_if_dirty)
+    post :create, :params => { :post => { :title => 'Test 1' } }
   end
 
   it 'should commit if configuration is not specified' do
     @configuration.user_configuration = {}
-    Sunspot.should_receive(:commit_if_dirty)
-    post :create, :post => { :title => 'Test 1' }
+    expect(Sunspot).to receive(:commit_if_dirty)
+    post :create, :params => { :post => { :title => 'Test 1' } }
   end
-  
+
   ### auto_commit_if_delete_dirty
-  
+
   it 'should automatically commit after each delete if specified' do
     @configuration.user_configuration = { 'auto_commit_after_request' => false,
                                           'auto_commit_after_delete_request' => true }
-    Sunspot.should_receive(:commit_if_delete_dirty)
-    post :create, :post => { :title => 'Test 1' }
+    expect(Sunspot).to receive(:commit_if_delete_dirty)
+    post :create, :params => { :post => { :title => 'Test 1' } }
   end
-  
+
   it 'should not automatically commit on delete if configuration is set to false' do
     @configuration.user_configuration = { 'auto_commit_after_request' => false,
                                           'auto_commit_after_delete_request' => false }
-    Sunspot.should_not_receive(:commit_if_delete_dirty)
-    post :create, :post => { :title => 'Test 1' }
+    expect(Sunspot).not_to receive(:commit_if_delete_dirty)
+    post :create, :params => { :post => { :title => 'Test 1' } }
   end
 
   it 'should not automatically commit on delete if configuration is not specified' do
     @configuration.user_configuration = { 'auto_commit_after_request' => false }
-    Sunspot.should_not_receive(:commit_if_delete_dirty)
-    post :create, :post => { :title => 'Test 1' }
+    expect(Sunspot).not_to receive(:commit_if_delete_dirty)
+    post :create, :params => { :post => { :title => 'Test 1' } }
   end
-end
+end

data/spec/schema.rb

@@ -1,27 +1,26 @@
-ActiveRecord::Schema.define(:version => 0) do
-  create_table :posts, :force => true do |t|
+ActiveRecord::Schema.define(version: 0) do
+  create_table :posts, force: true do |t|
     t.string :title
     t.string :type
     t.integer :location_id
     t.text :body
     t.references :blog
-    t.timestamps
+    t.timestamps null: true
   end
 
-  create_table :locations, :force => true do |t|
+  create_table :locations, force: true do |t|
     t.float :lat
     t.float :lng
   end
 
-  create_table :blogs, :force => true do |t|
+  create_table :blogs, force: true do |t|
     t.string :name
     t.string :subdomain
-    t.timestamps
+    t.timestamps null: true
   end
 
-  create_table :writers, :force => true, :primary_key => :writer_id do |t|
+  create_table :writers, force: true, primary_key: :writer_id do |t|
     t.string :name
-    t.timestamps
+    t.timestamps null: true
   end
-
 end

data/spec/searchable_spec.rb

@@ -6,10 +6,10 @@ describe Sunspot::Rails::Searchable do
     	# Rspec runs tests in random order, causing this test to fail on occasion unless we ensure the models have loaded.
     	Author; Blog; Post;
 
-      Sunspot.searchable.should_not be_empty
-      Sunspot.searchable.should include(Author)
-      Sunspot.searchable.should include(Blog)
-      Sunspot.searchable.should include(Post)
+      expect(Sunspot.searchable).not_to be_empty
+      expect(Sunspot.searchable).to include(Author)
+      expect(Sunspot.searchable).to include(Blog)
+      expect(Sunspot.searchable).to include(Post)
     end
   end
 end

data/spec/server_spec.rb

@@ -4,28 +4,28 @@ describe Sunspot::Rails::Server do
   before :each do
     @server = Sunspot::Rails::Server.new
     @config = Sunspot::Rails::Configuration.new
-    @server.stub(:configuration){ @config }
+    allow(@server).to receive(:configuration){ @config }
     @solr_home = File.join(@config.solr_home)
   end
 
   it "sets the correct Solr home" do
-    @server.solr_home.should == @solr_home
+    expect(@server.solr_home).to eq(@solr_home)
   end
 
   it "sets the correct Solr PID path" do
-    @server.pid_path.should == File.join(@server.pid_dir, 'sunspot-solr-test.pid')
+    expect(@server.pid_path).to eq(File.join(@server.pid_dir, 'sunspot-solr-test.pid'))
   end
 
   it "sets the correct port" do
-    @server.port.should == 8983
+    expect(@server.port).to eq(8983)
   end
 
   it "sets the log level using configuration" do
-    @config.stub(:log_level){ 'WARNING' }
-    @server.log_level.should == "WARNING"
+    allow(@config).to receive(:log_level){ 'WARNING' }
+    expect(@server.log_level).to eq("WARNING")
   end
 
   it "sets the correct log file" do
-    @server.log_file.should == File.join(Rails.root, 'log', 'sunspot-solr-test.log')
+    expect(@server.log_file).to eq(File.join(Rails.root, 'log', 'sunspot-solr-test.log'))
   end
 end

data/spec/session_spec.rb

@@ -19,7 +19,7 @@ describe 'Sunspot::Rails session' do
 
     # There should be no items in the queue with the same object_id
     object_ids = sessions.map(&:object_id)
-    object_ids.uniq.should == object_ids
+    expect(object_ids.uniq).to eq(object_ids)
   end
 
   it 'should create a separate master/slave session if configured' do
@@ -31,7 +31,7 @@ describe 'Sunspot::Rails session' do
   context 'disabled' do
     before do
       Sunspot::Rails.reset
-      ::Rails.stub(:env).and_return("config_disabled_test")
+      allow(::Rails).to receive(:env).and_return("config_disabled_test")
     end
 
     after do
@@ -39,7 +39,7 @@ describe 'Sunspot::Rails session' do
     end
 
     it 'sets the session proxy as a stub' do
-      Sunspot::Rails.build_session.should be_a_kind_of(Sunspot::Rails::StubSessionProxy)
+      expect(Sunspot::Rails.build_session).to be_a_kind_of(Sunspot::Rails::StubSessionProxy)
     end
   end