summer_residents 0.0.2 → 0.0.3

data/test/functional/summer_residents/authentication_test.rb

@@ -137,7 +137,7 @@ module SummerResidents
     end
 
     test "destroy should redirect to login when not admin even when spouse of target user" do
-      when_spouse_target_user
+      when_spouse_of_target_user
       expect_redirect_to_login_when_destroying
     end
 

data/test/functional/summer_residents/families_controller_test.rb

@@ -18,6 +18,24 @@ module SummerResidents
       assert_response :success
     end
   
+    test "should get add_user_info" do
+      @family.destroy
+      get :add_user_info
+      assert_response :success
+      family = assigns(:family)
+      assert_template :new
+      assert_nil family.mother
+      assert family.father
+      assert_nil family.father.id
+      assert_equal users(:joe_user), family.father.user
+      assert_select 'input#adding_user_info[value="1"]', 1
+    end
+
+    test "add_user_info should redirect to show if family already exists" do
+      get :add_user_info
+      assert_redirected_to family_path(@family.id)
+    end
+
     test "should show family" do
       get :show, id: @family
       assert_response :success
@@ -46,6 +64,97 @@ module SummerResidents
       @mother_hash = { first_name: @mother.first_name, last_name: @mother.last_name, email: @mother.email }
     end
 
+    EMAIL_LINE_INTRO = "Before you can log into your account, you must set your password by following this link: http://#{Rails.application.config.action_mailer.default_url_options[:host]}/reset_password\\?uuid="
+
+    def verify_expected_email parent, email
+      assert_equal [parent.email], email.to
+      assert_email_contains /^#{EMAIL_LINE_INTRO}#{User.find_by_email(parent.email).password_recovery.reset_link}\.$/, email
+    end
+
+    def given_a_user_with_no_family_info
+      @user = users(:jose_user)
+      @controller.log_in_as @user
+    end
+
+    def when_creating_family_from_user adding_user_info=true
+      args = { mother: @mother_hash, father: { first_name: @father.first_name, last_name: @father.last_name, email: @user.email } }
+      args[:adding_user_info] = "1" if adding_user_info
+      post :create, args
+    end
+
+    def when_adding_family_info
+      assert_difference('Family.count') do
+        assert_difference('User.count') do
+          when_creating_family_from_user
+        end
+      end
+    end
+
+    def expect_the_correct_family
+      @fam = assigns(:family)
+      assert_equal 0, @fam.errors.count, @fam.errors.messages.inspect
+      father = @fam.father
+      assert father
+      assert father.user
+      mother = @fam.mother
+      assert mother
+      assert mother.user
+      [:first_name, :last_name].each { |attr|
+        assert_equal @father.__send__(attr), father.__send__(attr)
+        assert_equal @mother.__send__(attr), mother.__send__(attr)
+      }
+      assert_equal @mother.email, mother.email
+      assert_equal @user.email, father.email
+    end
+
+    def should_fail_to_create_family_from_user adding_user_info=true
+      assert_no_difference('Family.count') do
+        assert_no_difference('Resident.count') do
+          assert_no_difference('User.count') do
+            when_creating_family_from_user adding_user_info
+          end
+        end
+      end
+
+      assert_redirected_to @controller.login_path
+    end
+
+    test "should create family from existing user when family info was added and resident info already exists" do
+      given_a_user_with_no_family_info
+      assert_difference('Resident.count') do
+        expect_each_new_user_to_receive_email 1 do
+          when_adding_family_info
+        end
+      end
+      expect_the_correct_family
+      assert_redirected_to family_path(@fam.id)
+      verify_expected_email @mother, @email
+    end
+
+    test "should create family from existing user when family info was added and only login info exists" do
+      given_a_user_with_no_family_info
+      @user.resident.destroy
+      assert_difference('Resident.count', 2) do
+        expect_each_new_user_to_receive_email 1 do
+          when_adding_family_info
+        end
+      end
+      expect_the_correct_family
+      assert_redirected_to family_path(@fam.id)
+      verify_expected_email @mother, @email
+    end
+
+    test "should not allow creating family from existing user unless family info was added" do
+      given_a_user_with_no_family_info
+      should_fail_to_create_family_from_user false
+    end
+
+    test "should not allow creating family from existing user if not current_user" do
+      given_a_user_with_no_family_info
+      @controller.log_in_as users(:dad_user)
+      should_fail_to_create_family_from_user
+    end
+
     test "should create family" do
       assert_difference('Family.count') do
         assert_difference('Resident.count', 2) do
@@ -58,6 +167,32 @@ module SummerResidents
       assert_redirected_to families_path
     end
 
+    def expect_each_new_user_to_receive_email count, &block
+      assert_difference('ActionMailer::Base.deliveries.size', count) do
+        yield
+      end
+      if 2 == count
+        @mother_email, @father_email = ActionMailer::Base.deliveries.pop(2)
+        @father_email, @mother_email = [@mother_email, @father_email] if ([@father.email] == @mother_email.to)
+      elsif 1 == count
+        @email = ActionMailer::Base.deliveries.pop
+      end
+    end
+
+    def assert_email_contains regex, email
+      assert email.body =~ regex, "Mail body expected to match: #{regex}\nActual: <<<<<\n#{email.body}\n>>>>>"
+    end
+
+    test "when creating family, each parent shuld receive a password initializatin email" do
+      assert_difference('PasswordRecovery.count', 2) do
+        expect_each_new_user_to_receive_email 2 do
+          post :create, father: @father_hash, mother: @mother_hash
+        end
+      end
+      verify_expected_email @father, @father_email
+      verify_expected_email @mother, @mother_email
+    end
+
     def should_fail_to_create_family_from parents
       @family.destroy
       assert_no_difference('Family.count') do
@@ -92,10 +227,7 @@ module SummerResidents
 
     test "father's email is required" do
       should_fail_to_create_family_from mother: @mother_hash, father: { first_name: @father.first_name, last_name: @father.last_name }
-      there_should_be_errors 2
-      there_should_be_errors_on_column :"father-email", 2
-      should_fail_validation_because :"father-email", "can't be blank"
-      should_fail_validation_because :"father-email", "does not appear to be valid"
+      should_fail_validation_for_one_reason :"father-email", "can't be blank"
     end
 
     test "father's first name cannot be blank" do
@@ -110,10 +242,7 @@ module SummerResidents
 
     test "father's email cannot be blank" do
       should_fail_to_create_family_from mother: @mother_hash, father: { first_name: @father.first_name, last_name: @father.last_name, email: "" }
-      there_should_be_errors 2
-      there_should_be_errors_on_column :"father-email", 2
-      should_fail_validation_because :"father-email", "can't be blank"
-      should_fail_validation_because :"father-email", "does not appear to be valid"
+      should_fail_validation_for_one_reason :"father-email", "can't be blank"
     end
 
     test "father's email must be valid" do
@@ -133,10 +262,7 @@ module SummerResidents
 
     test "mother's email is required" do
       should_fail_to_create_family_from father: @father_hash, mother: { first_name: @mother.first_name, last_name: @mother.last_name }
-      there_should_be_errors 2
-      there_should_be_errors_on_column :"mother-email", 2
-      should_fail_validation_because :"mother-email", "can't be blank"
-      should_fail_validation_because :"mother-email", "does not appear to be valid"
+      should_fail_validation_for_one_reason :"mother-email", "can't be blank"
     end
 
     test "mother's first name cannot be blank" do
@@ -151,15 +277,47 @@ module SummerResidents
 
     test "mother's email cannot be blank" do
       should_fail_to_create_family_from father: @father_hash, mother: { first_name: @mother.first_name, last_name: @mother.last_name, email: "" }
-      there_should_be_errors 2
-      there_should_be_errors_on_column :"mother-email", 2
-      should_fail_validation_because :"mother-email", "can't be blank"
-      should_fail_validation_because :"mother-email", "does not appear to be valid"
+      should_fail_validation_for_one_reason :"mother-email", "can't be blank"
     end
 
     test "mother's email must be valid" do
       should_fail_to_create_family_from father: @father_hash, mother: { first_name: @mother.first_name, last_name: @mother.last_name, email: "123" }
       should_fail_validation_for_one_reason :"mother-email", "does not appear to be valid"
     end
+
+    def expect_only_one_resident_was_created
+      @fam = assigns(:family)
+      assert_equal 0, @fam.errors.count, @fam.errors.messages.inspect
+      assert @fam.id
+      father = @fam.father
+      assert father
+      assert father.id
+      assert father.user
+      mother = @fam.mother
+      assert_nil mother
+      [:first_name, :last_name].each { |attr|
+        assert_equal @father.__send__(attr), father.__send__(attr)
+      }
+      assert_equal @user.email, father.email
+    end
+
+    test "should create resident if user already exists and only one resident specified" do
+      given_a_user_with_no_family_info
+      @user.resident.destroy
+      @mother_hash.each { |k,v|
+        @mother_hash[k] = ""
+      }
+      assert_difference('Family.count') do
+        assert_difference('Resident.count') do
+          assert_no_difference('User.count') do
+            assert_no_difference('ActionMailer::Base.deliveries.size') do
+              when_creating_family_from_user
+            end
+          end
+        end
+      end
+      expect_only_one_resident_was_created
+      assert_redirected_to family_path(@fam.id)
+    end
   end
 end

data/test/functional/summer_residents/residents_controller_test.rb

@@ -25,7 +25,70 @@ module SummerResidents
       assert_response :success
       assert_template :edit
     end
+
+    test "edit should render show template when cancelling" do
+      get :edit, :id => @new_resident, format: :js, cancel: "1"
+      assert_response :success
+      assert_template :show
+    end
+
+    def log_in_as_single_parent
+      users(:joe_user).destroy
+      @user = users(:hadassah_user)
+      @user.admin = false
+      @user.save!
+      @controller.log_in_as @user
+    end
+
+    def when_creating_resident options
+      post :create, options.merge({format: :js })
+    end
+
+    def create_resident options
+      assert_difference('Resident.count') do
+        assert_difference('User.count') do
+          assert_difference('ActionMailer::Base.deliveries.size') do
+            when_creating_resident options
+          end
+        end
+      end
+    end
+
+    test "should get new" do
+      log_in_as_single_parent
+      get :new, format: :js, type: :Mother
+      assert_response :success
+      assert_template :edit
+    end
+
+    test "new should render show template when cancelling" do
+      log_in_as_single_parent
+      get :new, format: :js, cancel: "2", type: :Mother
+      assert_response :success
+      assert_template :show
+    end
   
+    test "should create resident as spouse of current_user" do
+      log_in_as_single_parent
+      create_resident :cell => @resident.cell, :first_name => @resident.first_name, :last_name => @resident.last_name, :email => @resident.email, :type => :Father
+      assert_response :success
+      assert_template :show
+      resident = assigns(:resident)
+      [:first_name, :last_name, :cell, :email].each { |e|
+        assert_equal @resident.__send__(e), resident.__send__(e)
+      }
+      assert resident.family.mother == @user.resident
+    end
+
+    test "create should fail and render errors if missing first_name" do
+      log_in_as_single_parent
+      when_creating_resident :cell => @resident.cell, :first_name => "", :last_name => @resident.last_name, :email => @resident.email, :type => :Father
+      expect_resident_was_not_updated
+      there_should_be_errors 1
+      there_should_be_errors_on_column :"first_name", 1
+      should_fail_validation_because :"first_name", "can't be blank"
+    end
+
     test "should update resident" do
       update_resident :cell => @resident.cell, :first_name => @resident.first_name, :last_name => @resident.last_name, :email => @resident.email, :type => :Father
       assert_response :success
@@ -56,9 +119,8 @@ module SummerResidents
     test "should not update resident if missing email" do
       update_resident :cell => @resident.cell, :first_name => @resident.first_name, :last_name => @resident.last_name, :type => :Father
       expect_resident_was_not_updated
-      there_should_be_errors 2
-      there_should_be_errors_on_column :email, 2
-      should_fail_validation_because :email, "does not appear to be valid"
+      there_should_be_errors 1
+      there_should_be_errors_on_column :email, 1
       should_fail_validation_because :email, "can't be blank"
     end
 
@@ -81,9 +143,8 @@ module SummerResidents
     test "should not update resident if email is blank" do
       update_resident :cell => @resident.cell, :first_name => @resident.first_name, :last_name => @resident.last_name, :email => "", :type => :Father
       expect_resident_was_not_updated
-      there_should_be_errors 2
-      there_should_be_errors_on_column :email, 2
-      should_fail_validation_because :email, "does not appear to be valid"
+      there_should_be_errors 1
+      there_should_be_errors_on_column :email, 1
       should_fail_validation_because :email, "can't be blank"
     end