sul_orcid_client 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c69ff816dc3d9337266431f30425887794ef50077d5e66efa667b47c337704b6
-  data.tar.gz: c3b186808e1c8fa4f1ebda219f9b23fc313dfea14e87eec7025f10609d96a221
+  metadata.gz: 8c0b1ede02c640634f62eeeaecdc164ba772b6892cab517a3d33b3a1e6a880b8
+  data.tar.gz: 1e16d0da5a41b5af16c7388f84cb4fcf6384d7987ae73f5327e8e61cdc077b3f
 SHA512:
-  metadata.gz: c87d4cef98681e21bd0f3cc170f90dd3a4160f3e6162e32d9d5eff9bafe320688aeb45305402b1b364f4b167dd16c4cc08f9afeedfadb993a6058fa44a1cbb79
-  data.tar.gz: c6034b1e4f487acadce12faa1c296206faa9fdc5bcde86bf981dfd050f4e825f927947ef24683417fbf22c7a84af28e46cf2fa71d3df953c1231f840bd19e1b3
+  metadata.gz: 6ec8a59ab3f5f8869d735eb56c04a5bf95eb4393fbd7441f3995d112e3dbb113ad532520d845406d8d2f44e1ef3675c660e566fc1794af725cd1c8f19f67bfb7
+  data.tar.gz: a200843b3089908ce16aae221972b002aa0d6f586f9463b069b44252deada3e93423cd4eafc0cfb77c0f169e74f746d6c48c312c84a467fa4b44a287704ab282

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    sul_orcid_client (0.6.0)
+    sul_orcid_client (0.7.0)
       activesupport (>= 4.2)
       cocina-models (~> 0.90)
       faraday
@@ -83,7 +83,7 @@ GEM
       activesupport (>= 3.0, < 9.0)
     equivalent-xml (0.6.0)
       nokogiri (>= 1.4.3)
-    faraday (2.13.1)
+    faraday (2.13.2)
       faraday-net_http (>= 2.0, < 3.5)
       json
       logger

data/lib/sul_orcid_client/contributor_mapper.rb

@@ -38,7 +38,6 @@ class SulOrcidClient
       }
     end
 
-    # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
     def name_from_structured_value(structured_value)
       forename = structured_value.find { |name_part| name_part.type == 'forename' }&.value
       surname = structured_value.find { |name_part| name_part.type == 'surname' }&.value
@@ -46,62 +45,22 @@ class SulOrcidClient
       if forename.present? || surname.present?
         [forename, surname].compact.join(' ')
       else
-        # take first value for the Stanford University organization. Do not map the department/institute suborganization for now.
-        structured_value.first&.value
+        structured_value.first.value
       end
     end
-    # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
-
-    IDENTIFIER_TYPES = %w[ORCID ROR].freeze
 
+    # find and map an ORCID from a contributor.identifier
     def map_orcid
-      if contributor.name.first&.structuredValue.present?
-        # there could be an identifier in the structuredValue if it has a suborganization
-        if contributor.name.first.structuredValue.first&.identifier.present?
-          orcid_from_structured_value
-        else
-          orcid_from_contributor
-        end
-      else
-        orcid_from_contributor
-      end
-    end
-
-    def identifier_from_structured_value(structured_value)
-      structured_value.identifier.find { |identifier| IDENTIFIER_TYPES.include?(identifier.type) }
-    end
-
-    # the identifier in the structuredValue has the uri in a different properties than a top-level contributor.identifier
-    def map_orcid_from_structured_value(identifier)
-      {
-        uri: identifier.uri || identifier.value,
-        path: URI(identifier.uri).path.split('/').last,
-        host: identifier.type == 'ORCID' ? 'orcid.org' : 'ror.org'
-      }
-    end
+      identifier = contributor.identifier.find { |check_identifier| check_identifier.type == 'ORCID' }
+      return unless identifier
 
-    def map_orcid_from_contributor(identifier)
       {
         uri: URI.join(identifier.source.uri, identifier.value).to_s,
         path: identifier.value,
-        host: identifier.type == 'ORCID' ? 'orcid.org' : 'ror.org'
+        host: 'orcid.org'
       }
     end
 
-    # find and map an orcid from a contributor.identifier
-    def orcid_from_contributor
-      identifier = contributor.identifier.find { |check_identifier| IDENTIFIER_TYPES.include?(check_identifier.type) }
-      return unless identifier
-
-      map_orcid_from_contributor(identifier)
-    end
-
-    # find and map an orcid from a contributor.structuredValue.identifier
-    def orcid_from_structured_value
-      identifier = identifier_from_structured_value(contributor.name.first.structuredValue.first)
-      map_orcid_from_structured_value(identifier)
-    end
-
     def map_attributes
       {
         'contributor-role': map_role

data/lib/sul_orcid_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class SulOrcidClient
-  VERSION = '0.6.0'
+  VERSION = '0.7.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sul_orcid_client
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Peter Mangiafico
 - Justin Littman
 bindir: exe
 cert_chain: []
-date: 2025-07-07 00:00:00.000000000 Z
+date: 2025-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport