sul_orcid_client 0.2.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 94e61c08976837c4f5fc946beca72656f4443258eace1a0c22c0d40884cb6e10
-  data.tar.gz: 8186d27f99e87462626a57aaa858abd33b8746615fde51148a2a9a3db76b67b1
+  metadata.gz: 57218fe5c199745f0479d48ffde6483d94ec7dac3f33d278bb37a796bcd5534a
+  data.tar.gz: 21824eef4efdb0c1c668483b1d4b1c4e42f7d8417db77c0ef85eb79d6cbe1fa6
 SHA512:
-  metadata.gz: 1a814db636b2df5ee2294fac3e1303b63d43a868ad4a044a93f9c27e7f7b300a8eeb00b596cc10d6eefa6ac10433a7ceb989c16fccb92b0f3c9f00ec986af979
-  data.tar.gz: eebc8350317753b68e6cd0d748f90710f4cf7bf50d716d97cadb7021faa1484884d5e6970c62a8b9da025ecee955539152a1908d6a2397273f89af9cc052d500
+  metadata.gz: 5623cd78ba366d9ddf1e33aa6eb858d787aca52deee5c569a7ae6fa1333e8f2134b39781aac6c47e772367ed4d51a4eea348ea728acb2ba4b8c64697d3041ff4
+  data.tar.gz: 64c1672225217bbd8b6cc7b962bea2549ef2432558902a396919778ede223fa78922b54dc73a7eee4087c5bada798c53fb4abe86e385afc35cf87199a989bf38

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    sul_orcid_client (0.2.0)
+    sul_orcid_client (0.3.1)
       activesupport (>= 4.2, < 8)
       cocina-models (~> 0.90)
       faraday
@@ -12,15 +12,16 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.6)
+    activesupport (7.0.7)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
-    addressable (2.8.4)
+    addressable (2.8.5)
       public_suffix (>= 2.0.2, < 6.0)
     ast (2.4.2)
     attr_extras (7.1.0)
+    base64 (0.1.1)
     byebug (11.1.3)
     cocina-models (0.90.0)
       activesupport
@@ -37,7 +38,7 @@ GEM
       super_diff
       thor
       zeitwerk (~> 2.1)
-    commonmarker (0.23.9)
+    commonmarker (0.23.10)
     concurrent-ruby (1.2.2)
     crack (0.4.5)
       rexml
@@ -45,7 +46,7 @@ GEM
       activesupport
     diff-lcs (1.5.0)
     docile (1.4.0)
-    dry-core (1.0.0)
+    dry-core (1.0.1)
       concurrent-ruby (~> 1.0)
       zeitwerk (~> 2.6)
     dry-inflector (1.0.0)
@@ -85,12 +86,12 @@ GEM
     jwt (2.7.1)
     language_server-protocol (3.17.0.3)
     lint_roller (1.1.0)
-    minitest (5.18.1)
+    minitest (5.19.0)
     multi_json (1.15.0)
     multi_xml (0.6.0)
-    nokogiri (1.15.3-x86_64-darwin)
+    nokogiri (1.15.4-x86_64-darwin)
       racc (~> 1.4)
-    nokogiri (1.15.3-x86_64-linux)
+    nokogiri (1.15.4-x86_64-linux)
       racc (~> 1.4)
     oauth2 (2.0.9)
       faraday (>= 0.17.3, < 3.0)
@@ -102,7 +103,7 @@ GEM
     openapi3_parser (0.9.2)
       commonmarker (~> 0.17)
     openapi_parser (0.15.0)
-    optimist (3.0.1)
+    optimist (3.1.0)
     parallel (1.23.0)
     parser (3.2.2.3)
       ast (~> 2.4.1)
@@ -115,7 +116,7 @@ GEM
     rainbow (3.1.1)
     rake (13.0.6)
     regexp_parser (2.8.1)
-    rexml (3.2.5)
+    rexml (3.2.6)
     rspec (3.12.0)
       rspec-core (~> 3.12.0)
       rspec-expectations (~> 3.12.0)
@@ -129,16 +130,18 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
     rspec-support (3.12.1)
-    rss (0.2.9)
+    rss (0.3.0)
       rexml
-    rubocop (1.52.1)
+    rubocop (1.56.1)
+      base64 (~> 0.1.1)
       json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
       parser (>= 3.2.2.3)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.28.0, < 2.0)
+      rubocop-ast (>= 1.28.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.29.0)
@@ -147,10 +150,10 @@ GEM
       rubocop (~> 1.41)
     rubocop-factory_bot (2.23.1)
       rubocop (~> 1.33)
-    rubocop-performance (1.18.0)
+    rubocop-performance (1.19.0)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rspec (2.22.0)
+    rubocop-rspec (2.23.2)
       rubocop (~> 1.33)
       rubocop-capybara (~> 2.17)
       rubocop-factory_bot (~> 2.22)
@@ -165,18 +168,18 @@ GEM
     snaky_hash (2.0.1)
       hashie
       version_gem (~> 1.1, >= 1.1.1)
-    standard (1.30.1)
+    standard (1.31.0)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.0)
-      rubocop (~> 1.52.0)
+      rubocop (~> 1.56.0)
       standard-custom (~> 1.0.0)
-      standard-performance (~> 1.1.0)
+      standard-performance (~> 1.2)
     standard-custom (1.0.2)
       lint_roller (~> 1.0)
       rubocop (~> 1.50)
-    standard-performance (1.1.1)
+    standard-performance (1.2.0)
       lint_roller (~> 1.1)
-      rubocop-performance (~> 1.18.0)
+      rubocop-performance (~> 1.19.0)
     super_diff (0.10.0)
       attr_extras (>= 6.2.4)
       diff-lcs
@@ -191,7 +194,7 @@ GEM
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
-    zeitwerk (2.6.8)
+    zeitwerk (2.6.11)
 
 PLATFORMS
   x86_64-darwin-22

data/README.md

@@ -29,8 +29,8 @@ require "sul_orcid_client"
 client = SulOrcidClient.configure(
   client_id: Settings.orcid.client_id,
   client_secret: Settings.orcid.client_secret,
-  base_url: Settings.orcid.base_url
-  base_public_url: Settings.orcid.base_public_url
+  base_url: Settings.orcid.base_url,
+  base_public_url: Settings.orcid.base_public_url,
   base_auth_url: Settings.orcid.base_auth_url
 )
 client.fetch_works(orcidid: 'https://sandbox.orcid.org/0000-0002-7262-6251')
@@ -46,8 +46,8 @@ to be sure configuration has already occurred, e.g.:
 SulOrcidClient.configure(
   client_id: Settings.orcid.client_id,
   client_secret: Settings.orcid.client_secret,
-  base_url: Settings.orcid.base_url
-  base_public_url: Settings.orcid.base_public_url
+  base_url: Settings.orcid.base_url,
+  base_public_url: Settings.orcid.base_public_url,
   base_auth_url: Settings.orcid.base_auth_url
 )
 

data/lib/sul_orcid_client/cocina_support.rb

@@ -0,0 +1,27 @@
+class SulOrcidClient
+  # Helper methods for working with Orcid in Cocina
+  class CocinaSupport
+    # @param [Cocina::Models::Contributor] contributor to check
+    # @return [Boolean] true unless the contributor has a citation status of false
+    def self.cited?(contributor)
+      contributor.note.none? { |note| note.type == "citation status" && note.value == "false" }
+    end
+
+    # @param [Cocina::Models::Contributor] contributor to check
+    # @return [String, nil] orcid id including host if present
+    def self.orcidid(contributor)
+      identifier = contributor.identifier.find { |identifier| identifier.type == "ORCID" }
+      return unless identifier
+
+      URI.join(identifier.source.uri, identifier.value).to_s
+    end
+
+    # @param [Cocina::Models::Description] description containing contributors to check
+    # @return [Array<String>] orcid ids including host if present
+    # Note that non-cited contributors are excluded.
+    def self.cited_orcidids(description)
+      cited_contributors = description.contributor.select { |contributor| cited?(contributor) }
+      cited_contributors.map { |contributor| orcidid(contributor) }.compact
+    end
+  end
+end

data/lib/sul_orcid_client/contributor_mapper.rb

@@ -12,7 +12,7 @@ class SulOrcidClient
     end
 
     def map
-      return unless cited?
+      return unless CocinaSupport.cited?(contributor)
 
       {
         "credit-name": map_credit_name,
@@ -25,10 +25,6 @@ class SulOrcidClient
 
     attr_reader :contributor
 
-    def cited?
-      contributor.note.none? { |note| note.type == "citation status" && note.value == "false" }
-    end
-
     def map_credit_name
       value = if contributor.name.first&.structuredValue.present?
         name_from_structured_value(contributor.name.first.structuredValue)
@@ -68,12 +64,12 @@ class SulOrcidClient
     end
 
     MARC_RELATOR_MAP = {
-      "aut" => "Author",
-      "cmp" => "Author",
-      "ctb" => "Author",
-      "cre" => "Author",
-      "edt" => "Editor",
-      "rth" => "Principal investigator"
+      "aut" => "author",
+      "cmp" => "author",
+      "ctb" => "author",
+      "cre" => "author",
+      "edt" => "editor",
+      "rth" => "principal-investigator"
     }
 
     def map_role

data/lib/sul_orcid_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class SulOrcidClient
-  VERSION = "0.2.0"
+  VERSION = "0.3.1"
 end

data/lib/sul_orcid_client.rb

@@ -136,6 +136,8 @@ class SulOrcidClient
       work.merge({"put-code" => put_code}).to_json,
       "Content-Type" => "application/vnd.orcid+json")
 
+    raise "ORCID.org API returned #{response.status} when updating #{put_code} for #{orcidid}. The author may have previously deleted this work from their ORCID profile." if response.status == 404
+
     raise "ORCID.org API returned #{response.status} when updating #{put_code} for #{orcidid}" unless response.status == 200
     true
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sul_orcid_client
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Peter Mangiafico
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-07-14 00:00:00.000000000 Z
+date: 2023-08-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -217,6 +217,7 @@ files:
 - README.md
 - Rakefile
 - lib/sul_orcid_client.rb
+- lib/sul_orcid_client/cocina_support.rb
 - lib/sul_orcid_client/contributor_mapper.rb
 - lib/sul_orcid_client/version.rb
 - lib/sul_orcid_client/work_mapper.rb
@@ -243,7 +244,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.14
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: Interface for interacting with the ORCID API.