suitcase 1.3.1 → 1.4.0

data/test/hotels/hotel_location_test.rb

@@ -0,0 +1,23 @@
+require "minitest_helper"
+
+describe Suitcase::Hotel::Location do
+  before :each do
+    @location = Suitcase::Hotel::Location.new({})
+  end
+  
+  [:destination_id, :province, :country, :country_code, :city, :type,
+  :active].each do |accessor|
+    it "has an accessor for #{accessor}" do
+      @location.must_respond_to(accessor)
+      @location.must_respond_to((accessor.to_s + "=").to_sym)
+    end
+  end
+
+  describe ".find" do
+    it "returns an Array of Locations" do
+      locations = Suitcase::Hotel::Location.find(destination_string: "Lond")
+      locations.must_be_kind_of(Array)
+      locations.first.must_be_kind_of(Suitcase::Hotel::Location)
+    end
+  end
+end

data/test/hotels/hotel_test.rb

@@ -0,0 +1,85 @@
+require "minitest_helper"
+
+describe Suitcase::Hotel do
+  before :each do
+    @hotel = Suitcase::Hotel.find(id: 123904)
+  end
+
+  [:id, :name, :address, :city, :amenities, :masked_amenities, :country_code,
+  :high_rate, :low_rate, :longitude, :latitude, :rating, :postal_code,
+  :images, :nightly_rate_total, :property_description, :number_of_floors,
+  :number_of_rooms, :deep_link, :tripadvisor_rating].each do |attribute|
+    it "has an attr_accessor for #{attribute}" do
+      @hotel.must_respond_to(attribute)
+      @hotel.must_respond_to((attribute.to_s + "=").to_sym)
+    end
+  end
+
+  describe ".find" do
+    it "returns a single Hotel if passed an ID" do
+      @hotel.must_be_kind_of(Suitcase::Hotel)
+    end
+
+    it "returns multiple Hotels if an ID is not passed in" do
+      hotels = Suitcase::Hotel.find(location: "London, UK")
+      hotels.must_be_kind_of(Array)
+      hotels.first.must_be_kind_of(Suitcase::Hotel)
+    end
+
+    it "returns multiple Hotels if multiple ID's are passed in" do
+      hotels = Suitcase::Hotel.find(ids: [123904, 191937, 220166])
+      hotels.must_be_kind_of(Array)
+      hotels.first.must_be_kind_of(Suitcase::Hotel)
+    end
+
+    it "returns an Array with a single Hotel if an Array with a single ID is passed in" do
+      hotels = Suitcase::Hotel.find(ids: [123904])
+      hotels.count.must_equal(1)
+      hotels.first.must_be_kind_of(Suitcase::Hotel)
+    end
+
+    it "sets a recovery attribute on the raised error when the location is not specific enough" do
+      begin
+        Suitcase::Hotel.find(location: "Mexico")
+      rescue Suitcase::EANException => e
+        e.recoverable?.must_equal(true) if e.type == :multiple_locations
+      end
+    end
+
+    it "sets the error type when the location is not specific enough" do
+      begin
+        Suitcase::Hotel.find(location: "Mexico")
+      rescue Suitcase::EANException => e
+        e.type.must_equal(:multiple_locations)
+      end
+    end
+  end
+
+  describe "#images" do
+    it "correctly gets the URLs of the images" do
+      images = @hotel.images
+      images.must_be_kind_of(Array)
+      images.map { |image| URI.parse(image.url) }
+    end
+  end
+
+  describe "#thumbnail_url" do
+    it "returns the first image's thumbnail URL" do
+      @hotel.thumbnail_url.must_equal @hotel.images.first.thumbnail_url
+    end
+  end
+
+  describe "#rooms" do
+    before do
+      @info = {
+        arrival: "1/1/2013",
+        departure: "1/8/2013"
+      }
+      @rooms = @hotel.rooms(@info)
+    end
+
+    it "returns an Array of available Rooms" do
+      @rooms.must_be_kind_of(Array)
+    end
+  end
+end

data/test/hotels/image_test.rb

@@ -0,0 +1,20 @@
+require "minitest_helper"
+
+describe Suitcase::Image do
+  before :each do
+    @image = Suitcase::Hotel.find(id: 123904).images.first
+  end
+  
+  [:url, :id, :caption, :height, :width, :thumbnail_url, :name].each do |meth|
+    it "has an accessor for #{meth}" do
+      @image.must_respond_to(meth)
+      @image.must_respond_to((meth.to_s + "=").to_sym)
+    end
+  end
+  
+  describe "#url" do
+    it "returns a valid URL" do
+      URI.parse(@image.url).must_be_kind_of(URI)
+    end
+  end
+end

data/test/hotels/payment_option_test.rb

@@ -0,0 +1,15 @@
+require "minitest_helper"
+
+describe Suitcase::PaymentOption do
+  before :each do
+    @info = { currency_code: "USD" }
+  end
+  
+  describe ".find" do
+    it "returns an Array of PaymentOption's" do
+      options = Suitcase::PaymentOption.find(@info)
+      options.must_be_kind_of(Array)
+      options.first.must_be_kind_of(Suitcase::PaymentOption)
+    end
+  end
+end

data/test/hotels/reservation_test.rb

@@ -0,0 +1,15 @@
+require "minitest_helper"
+
+describe Suitcase::Reservation do
+  before :each do
+    @reservation = Suitcase::Reservation.new({})
+  end
+  
+  it "has a reader for itinerary_id" do
+    @reservation.must_respond_to :itinerary_id
+  end
+  
+  it "has a reader for confirmation_numbers" do
+    @reservation.must_respond_to :confirmation_numbers
+  end
+end

data/test/hotels/room_test.rb

@@ -0,0 +1,45 @@
+require "minitest_helper"
+
+describe Suitcase::Room do
+  before :each do
+    @room = Suitcase::Hotel.find(id: 123904).rooms(arrival: "6/23/2012", departure: "6/30/2012").first
+  end
+
+  %w(arrival departure rate_code room_type_code supplier_type tax_rate
+  non_refundable occupancy quoted_occupancy min_guest_age total surcharge_total
+  average_base_rate average_base_rate average_rate max_nightly_rate
+  currency_code value_adds room_type_description price_breakdown total_price
+  average_nightly_rate promo rate_key hotel_id supplier_type bed_types
+  rooms).each do |attribute|
+    it "has an attr_accessor for #{attribute}" do
+      @room.must_respond_to attribute.to_sym
+      @room.must_respond_to (attribute + "=").to_sym
+    end
+  end
+
+  describe "#reserve!" do
+    before :each do
+      @info = { email: "walter.john.nelson@gmail.com",
+                first_name: "Walter",
+                last_name: "Nelson",
+                home_phone: "3831039402",
+                payment_option: Keys::SUITCASE_PAYMENT_OPTION, # Visa
+                credit_card_number: Keys::CREDIT_CARD_NUMBER_TESTING,
+                credit_card_verification_code: Keys::CREDIT_CARD_CVV_TESTING, # CVV
+                credit_card_expiration_date: Keys::CREDIT_CARD_EXPIRATION_DATE_TESTING,
+                address1: "travelnow", # for testing
+                address2: "Apt. 4A",
+                city: "Boston",
+                province: "MA",
+                country: "US",
+                postal_code: "02111" }
+      @room.rooms[0][:bed_type] = @room.bed_types[0]
+      @room.rooms[0][:smoking_preference] = "NS"
+    end
+
+    it "returns a Suitcase::Reservation" do
+      reservation = @room.reserve!(@info)
+      reservation.must_be_kind_of(Suitcase::Reservation)
+    end
+  end
+end

data/test/hotels/session_test.rb

@@ -0,0 +1,14 @@
+require "minitest_helper"
+
+describe Suitcase::Session do
+  before :each do
+    @session = Suitcase::Session.new
+  end
+  
+  [:id, :ip_address, :user_agent, :locale, :currency_code].each do |accessor|
+    it "has an accessor for #{accessor}" do
+      @session.must_respond_to(accessor)
+      @session.must_respond_to((accessor.to_s + "=").to_sym)
+    end
+  end
+end

data/{spec → test}/keys.rb

@@ -6,8 +6,10 @@
 # Or configure with a block:
 
 Suitcase.configure do |config|
-  config.hotel_api_key = "your_api_key_here"
-  config.hotel_cid = "your_cid_here"
+  config.hotel_api_key = "..."
+  config.hotel_cid = "..."
+  
+  config.hotwire_api_key = "..."
   # config.hotel_shared_secret = "none"
   # config.use_signature_auth = false
 end

data/test/minitest_helper.rb

@@ -0,0 +1,17 @@
+require "turn"
+require "minitest/spec"
+require "minitest/autorun"
+require "mocha"
+
+require "pry"
+
+$: << File.dirname(__FILE__) + "/../lib"
+$: << File.dirname(__FILE__)
+require "suitcase"
+require "keys"
+
+Turn.config do |config|
+  config.format = :pretty
+  # config.trace = true
+  config.natural = true
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: suitcase
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.4.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,10 +9,10 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-04-26 00:00:00.000000000 Z
+date: 2012-05-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
@@ -28,7 +28,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: mocha
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
@@ -44,7 +44,23 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: factory_girl
+  name: turn
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
@@ -141,20 +157,21 @@ files:
 - lib/suitcase/hotel/room.rb
 - lib/suitcase/session.rb
 - lib/suitcase/version.rb
-- spec/amenity_spec.rb
-- spec/car_rentals/car_rental_spec.rb
-- spec/hotels/caching_spec.rb
-- spec/hotels/helpers_spec.rb
-- spec/hotels/hotel_location_spec.rb
-- spec/hotels/hotels_spec.rb
-- spec/hotels/images_spec.rb
-- spec/hotels/payment_options_spec.rb
-- spec/hotels/reservation_spec.rb
-- spec/hotels/rooms_spec.rb
-- spec/hotels/sessions_spec.rb
-- spec/keys.rb
-- spec/spec_helper.rb
 - suitcase.gemspec
+- test/car_rentals/car_rental_test.rb
+- test/hotels/amenity_test.rb
+- test/hotels/caching_test.rb
+- test/hotels/ean_exception_test.rb
+- test/hotels/helpers_test.rb
+- test/hotels/hotel_location_test.rb
+- test/hotels/hotel_test.rb
+- test/hotels/image_test.rb
+- test/hotels/payment_option_test.rb
+- test/hotels/reservation_test.rb
+- test/hotels/room_test.rb
+- test/hotels/session_test.rb
+- test/keys.rb
+- test/minitest_helper.rb
 homepage: http://github.com/thoughtfusion/suitcase
 licenses: []
 post_install_message: 
@@ -180,17 +197,18 @@ signing_key:
 specification_version: 3
 summary: Locates available hotels and rental cars through Expedia and Hotwire
 test_files:
-- spec/amenity_spec.rb
-- spec/car_rentals/car_rental_spec.rb
-- spec/hotels/caching_spec.rb
-- spec/hotels/helpers_spec.rb
-- spec/hotels/hotel_location_spec.rb
-- spec/hotels/hotels_spec.rb
-- spec/hotels/images_spec.rb
-- spec/hotels/payment_options_spec.rb
-- spec/hotels/reservation_spec.rb
-- spec/hotels/rooms_spec.rb
-- spec/hotels/sessions_spec.rb
-- spec/keys.rb
-- spec/spec_helper.rb
+- test/car_rentals/car_rental_test.rb
+- test/hotels/amenity_test.rb
+- test/hotels/caching_test.rb
+- test/hotels/ean_exception_test.rb
+- test/hotels/helpers_test.rb
+- test/hotels/hotel_location_test.rb
+- test/hotels/hotel_test.rb
+- test/hotels/image_test.rb
+- test/hotels/payment_option_test.rb
+- test/hotels/reservation_test.rb
+- test/hotels/room_test.rb
+- test/hotels/session_test.rb
+- test/keys.rb
+- test/minitest_helper.rb
 has_rdoc: 

data/spec/amenity_spec.rb

@@ -1,25 +0,0 @@
-require 'spec_helper'
-
-module Suitcase
-  describe Amenity do
-    describe ".parse_mask" do
-      context "when provided bitmask is not nil or 0" do
-        it "returns an array of symbols representing given amenities" do
-          Amenity.parse_mask(5).should == [:business_services, :hot_tub]
-        end
-      end
-
-      context "when provided bitmask is 0" do
-        it "returns an empty array" do
-          Amenity.parse_mask(0).should == []
-        end
-      end
-
-      context "when provided bitmask is nil" do
-        it "returns nil" do
-          Amenity.parse_mask(nil).should == nil
-        end
-      end
-    end
-  end
-end

data/spec/car_rentals/car_rental_spec.rb

@@ -1,20 +0,0 @@
-require 'spec_helper'
-
-describe Suitcase::CarRental do
-  before :each do
-    @rentals = Suitcase::CarRental.find(destination: "Seattle", start_date: "07/04/2012", end_date: "07/11/2012", pickup_time: "07:30", dropoff_time: "07:30")
-  end
-
-  describe '.find' do 
-    it 'returns an Array of CarRentals' do
-      @rentals.class.should eq Array
-      @rentals.first.class.should eq Suitcase::CarRental
-    end
-  end
-
-  subject { @rentals.first }
-
-  [:seating, :type_name, :type_code, :possible_features, :possible_models].each do |method|
-    it { should respond_to method }
-  end
-end

data/spec/hotels/caching_spec.rb

@@ -1,32 +0,0 @@
-require 'spec_helper'
-
-describe Suitcase do
-  before :all do
-    Suitcase::Configuration.cache = {}
-  end
-
-  it "should cache all non-secure queries" do
-    hotel = Suitcase::Hotel.find(id: 123904)
-    Suitcase::Hotel.find(location: "Boston, US")
-    room = hotel.rooms(arrival: "6/23/2012", departure: "6/30/2012").first
-    Suitcase::PaymentOption.find currency_code: "USD"
-    room.rooms[0][:bed_type] = room.bed_types[0]
-    room.rooms[0][:smoking_preference] = "NS"
-    room.reserve!(Keys::VALID_RESERVATION_INFO) # We don't want to cache this
-    Suitcase::Configuration.cache.keys.count.should eq(4)
-  end
-
-  it "should retrieve from the cache if it's there" do
-    hotel = Suitcase::Hotel.find(id: 123904)
-    Suitcase::Hotel.find(location: "Boston, US")
-    hotel.rooms(arrival: "6/23/2012", departure: "6/30/2012")
-    Suitcase::PaymentOption.find currency_code: "USD"
-    lambda do
-      Net::HTTP.stub!(:get_response).and_return nil # disable access to the API
-      hotel = Suitcase::Hotel.find(id: 123904)
-      Suitcase::Hotel.find(location: "Boston, US")
-      hotel.rooms(arrival: "6/23/2012", departure: "6/30/2012")
-      Suitcase::PaymentOption.find currency_code: "USD"
-    end.should_not raise_error
-  end
-end

data/spec/hotels/helpers_spec.rb

@@ -1,40 +0,0 @@
-require 'spec_helper'
-
-describe Suitcase::Helpers do
-  before :each do
-    class Dummy; extend Suitcase::Helpers; end
-  end
-
-  describe "#url" do
-    it "should return a URI with the correct base URL" do
-      returned = Dummy.url(:method => "action", :params => {})
-      returned.should be_a(URI)
-      returned.host.should match(/api.ean.com/)
-    end
-
-    context "when using digital signature authentication" do
-      it "should add a 'sig' parameter" do
-        Suitcase::Configuration.stub(:use_signature_auth?) { true }
-        Dummy.stub(:generate_signature) { "test" }
-
-        returned = Dummy.url(:method => "action", :params => {})
-        returned.query.should match(/sig=test/)
-      end
-    end
-  end
-
-  it "#parse_response should raise an exception when passed an invalid URI" do
-    lambda do
-      Dummy.parse_response(URI.parse "http://google.com")
-    end.should raise_error
-  end
-
-  it "#generate_signature should return the encrypted api key, shared secret, and timestamp" do
-    Suitcase::Configuration.stub(:hotel_api_key) { "abc" }
-    Suitcase::Configuration.stub(:hotel_shared_secret) { "123" }
-    Time.stub(:now) { "10" }
-
-    returned = Dummy.generate_signature
-    returned.should == Digest::MD5.hexdigest("abc12310")
-  end
-end

data/spec/hotels/hotel_location_spec.rb

@@ -1,21 +0,0 @@
-require 'spec_helper'
-
-describe Suitcase::Hotel::Location do
-  describe '.find' do
-    it 'should return an array of Locations' do
-      locations = Suitcase::Hotel::Location.find(:destination_string => "Lond")
-      locations.should be_an(Array)
-      locations.first.should be_a(Suitcase::Hotel::Location)
-    end
-  end
-
-  before :all do
-    @location = Suitcase::Hotel::Location.new({})
-  end
-
-  subject { @location }
-
-  [:destination_id, :province, :country, :country_code, :city, :type, :active].each do |attribute|
-    it { should respond_to attribute }
-  end
-end

data/spec/hotels/hotels_spec.rb

@@ -1,77 +0,0 @@
-require 'spec_helper'
-
-describe Suitcase::Hotel do
-  before :all do
-    @hotel = Suitcase::Hotel.find(id: 123904)
-  end
-
-  describe "::find" do
-    it "should locate a single Hotel if an id argument is passed" do
-      @hotel.should be_a(Suitcase::Hotel)
-    end
-
-    it "should locate an Array of Hotels if an id argument is not passed" do
-      hotels = Suitcase::Hotel.find(location: "London, UK")
-      hotels.should be_an(Array)
-      hotels.first.should be_a(Suitcase::Hotel)
-    end
-
-    it "should locate an Array of Hotels if an ids argument is passed" do
-      hotels = Suitcase::Hotel.find(:ids => [123904, 191937, 220166])
-      hotels.should be_an(Array)
-      hotels.first.should be_a(Suitcase::Hotel)
-      hotels.count.should eq(3)
-    end
-
-    it "should locate an Array of Hotels if an ids argument is passed with a single id" do
-      hotels = Suitcase::Hotel.find(:ids => [123904])
-      hotels.should be_an(Array)
-      hotels.first.should be_a(Suitcase::Hotel)
-      hotels.count.should eq(1)
-    end
-  end
-
-  subject { @hotel }
-
-  it { should respond_to :id }
-  it { should respond_to :name }
-  it { should respond_to :address }
-  it { should respond_to :city }
-  it { should respond_to :amenities }
-  it { should respond_to :masked_amenities }
-  it { should respond_to :country_code }
-  it { should respond_to :high_rate }
-  it { should respond_to :low_rate }
-  it { should respond_to :longitude }
-  it { should respond_to :latitude }
-  it { should respond_to :rating }
-  it { should respond_to :postal_code }
-  it { should respond_to :images }
-  it { should respond_to :thumbnail_url }
-  it { should respond_to :nightly_rate_total }
-  it { should respond_to :property_description }
-  it { should respond_to :number_of_floors }
-  it { should respond_to :number_of_rooms }
-  it { should respond_to :deep_link }
-  it { should respond_to :tripadvisor_rating }
-
-  it "#images should return an Array of Suitcase::Image's" do
-    images = @hotel.images
-    images.should be_an(Array)
-    lambda do
-      images.map { |image| URI.parse image.url }
-    end.should_not raise_error
-  end
-
-  describe "#rooms" do
-    before :all do
-      @info = { arrival: "6/23/2012", departure: "6/30/2012" }
-    end
-
-    subject do
-      @hotel.rooms(@info)
-    end
-
-    it { should be_an(Array) }
-  end
-end

data/spec/hotels/images_spec.rb

@@ -1,23 +0,0 @@
-require 'spec_helper'
-
-describe Suitcase::Image do
-  before :all do
-    @image = Suitcase::Hotel.find(id: 123904).images.first
-  end
-
-  subject { @image }
-
-  it { should respond_to :url }
-  it { should respond_to :id }
-  it { should respond_to :caption }
-  it { should respond_to :height }
-  it { should respond_to :width }
-  it { should respond_to :thumbnail_url }
-  it { should respond_to :name } 
-
-  it "#url should return a valid URL" do
-    lambda do
-      URI.parse @image.url
-    end.should_not raise_error
-  end
-end

data/spec/hotels/payment_options_spec.rb

@@ -1,13 +0,0 @@
-require 'spec_helper'
-
-describe Suitcase::PaymentOption do
-  before :all do
-    @info = { currency_code: "USD" }
-  end
-
-  it "::find should return an Array of PaymentOptions" do
-    options = Suitcase::PaymentOption.find(@info)
-    options.should be_an(Array)
-    options.find_all { |opt| opt.class == Suitcase::PaymentOption }.count.should eq(options.count) # It should be an Array of PaymentOption's
-  end
-end

data/spec/hotels/reservation_spec.rb

@@ -1,11 +0,0 @@
-require 'spec_helper'
-
-describe Suitcase::Reservation do
-  before :all do
-    @reservation = Suitcase::Reservation.new({})
-  end
-
-  subject { @reservation }
-  it { should respond_to :itinerary_id }
-  it { should respond_to :confirmation_numbers }
-end