suggest_rb 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: b4767a25d85dccc93708b86da3fc1abaf21163f1
-  data.tar.gz: 9dac49839363b1aa5cea4c1905797d41a7d9ecf1
+SHA256:
+  metadata.gz: e61c1dd1cb882f09e1c11a1f7adfe9d123aa770a28e2578a2785025bc6ee1cbc
+  data.tar.gz: 5f3e5ed7bbaa495ba9844412c39fb47d6b686d8dec109a0aeedb4713c0f64f9f
 SHA512:
-  metadata.gz: 01fe386299c1c54e02833812316aa96097243eeef9460474bdbd28b8d4e1535d4db8ae961db7be8baa98a31ba649b6ddd04ebaf2e85e6dfbc04eae758ad1984f
-  data.tar.gz: 143bd64a2fee717bfdf443fa1f788014141112aef692ca7e9c5bf7befe64ccce04bab339c22cbdb19cd6f7a6e1c980bc0134f1aaa3191ff699d7d74ce982eefa
+  metadata.gz: 1037bab415285b2009496fb5b37e2c8b56593e5a62e5142b262fefa86978c94fedaef70b4f48ebc4fb9707a4dde5c5711843bd110a866d1c5a5e8ff523362568
+  data.tar.gz: 544907353e5c561b26edc69b20eecca87bc4070af9284cde736f37d3fa193068748b4a260dfbd0191c538cf4783c7be84134c2a6f01f8a3a3e80368ad965b633

data/lib/suggest/version.rb

@@ -1,3 +1,3 @@
 module Suggest
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/lib/suggest.rb

@@ -2,14 +2,34 @@ require "suggest/version"
 require "set"
 
 module Suggest
-  SUGGEST_MODS = Set.new([Array, Enumerable, String, Hash, Regexp, Integer])
-  UNSAFE = Set.new([Array.instance_method(:cycle)])
+  SUGGEST_MODS = Set.new([
+    Array,
+    Enumerable,
+    String,
+    Hash,
+    Regexp,
+    Integer,
+    Set
+  ])
+
+  UNSAFE_WITH_BLOCK = Set.new([
+    [Array, :cycle],
+    [Enumerable, :cycle]
+  ])
+
+  INCONSISTENT = Set.new([
+    [Array, :sample],
+    [Array, :shuffle],
+    [Array, :shuffle!]
+  ])
 
   module Mixin
     def what_returns?(expected, args: [], allow_mutation: false)
       block = Proc.new if block_given?
 
-      applicable_methods = self.methods.map(&method(:method)).select { |m| SUGGEST_MODS.include?(m.owner) }
+      applicable_methods = self.methods.map(&method(:method)).select do |m|
+        SUGGEST_MODS.include?(m.owner) && !INCONSISTENT.include?([m.owner, m.name])
+      end
 
       applicable_methods.select do |m|
         arity = m.arity
@@ -17,7 +37,7 @@ module Suggest
 
         post = clone
         if block
-          next if UNSAFE.include?(m.unbind)
+          next if UNSAFE_WITH_BLOCK.include?([m.owner, m.name])
           result = post.public_send(m.name, *args, &block) rescue next
         else
           result = post.public_send(m.name, *args) rescue next
@@ -33,7 +53,9 @@ module Suggest
       args = opts[:args] || []
       block = Proc.new if block_given?
 
-      applicable_methods = self.methods.map(&method(:method)).select { |m| SUGGEST_MODS.include?(m.owner) }
+      applicable_methods = self.methods.map(&method(:method)).select do |m|
+        SUGGEST_MODS.include?(m.owner) && !INCONSISTENT.include?([m.owner, m.name])
+      end
 
       applicable_methods.select do |m|
         arity = m.arity
@@ -41,7 +63,7 @@ module Suggest
 
         post = clone
         if block
-          next if UNSAFE.include?(m.unbind)
+          next if UNSAFE_WITH_BLOCK.include?([m.owner, m.name])
           result = post.public_send(m.name, *args, &block) rescue next
         else
           result = post.public_send(m.name, *args) rescue next

data/suggest.gemspec

@@ -21,7 +21,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.17"
+  spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "minitest", "~> 5.0"
   spec.add_development_dependency "minitest-tagz"

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: suggest_rb
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Josh Bodah
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-01-14 00:00:00.000000000 Z
+date: 2019-01-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.17'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.17'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -116,7 +116,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2.3
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: tells you which method does the thing you want to do