sufia 6.2.0 → 6.3.0

data/spec/views/generic_file/_browse_everything.html.erb_spec.rb

@@ -1,9 +1,9 @@
 require 'spec_helper'
 
-describe 'generic_files/_browse_everything.html.erb', :type => :view do
+describe 'generic_files/_browse_everything.html.erb', type: :view do
   it 'shows user timing warning' do
     render
     page = Capybara::Node::Simple.new(rendered)
-    expect(page).to have_selector('div.alert-success', text: /Please note that if you upload a large number of files/i , count: 1)
+    expect(page).to have_selector('div.alert-success', text: /Please note that if you upload a large number of files/i, count: 1)
   end
 end

data/spec/views/generic_file/_permission_form.html.erb_spec.rb

@@ -1,11 +1,11 @@
 require 'spec_helper'
 
-describe 'generic_files/_permission_form.html.erb', :type => :view do
-  let(:generic_file) {
+describe 'generic_files/_permission_form.html.erb', type: :view do
+  let(:generic_file) do
     stub_model(GenericFile, id: '123',
-        depositor: 'bob',
-        resource_type: ['Dataset'])
-  }
+                            depositor: 'bob',
+                            resource_type: ['Dataset'])
+  end
 
   let(:form) do
     form_for(generic_file, url: '/update') do |gf_form|
@@ -23,7 +23,7 @@ describe 'generic_files/_permission_form.html.erb', :type => :view do
   context "without additional users" do
     let(:permissions) { [] }
 
-    it "should draw the permissions form without error" do
+    it "draws the permissions form without error" do
       expect(rendered).to have_css("input#new_user_name_skel")
       expect(rendered).not_to have_css("button.remove_perm")
     end
@@ -33,13 +33,12 @@ describe 'generic_files/_permission_form.html.erb', :type => :view do
     let(:depositor_permission) { Hydra::AccessControls::Permission.new(id: '123', name: 'bob', type: 'person', access: 'edit') }
     let(:public_permission) { Hydra::AccessControls::Permission.new(id: '124', name: 'public', type: 'group', access: 'read') }
     let(:other_permission) { Hydra::AccessControls::Permission.new(id: '125', name: 'joe@example.com', type: 'person', access: 'edit') }
-    let(:permissions) { [ depositor_permission, public_permission, other_permission] }
+    let(:permissions) { [depositor_permission, public_permission, other_permission] }
 
-    it "should draw the permissions form without error" do
+    it "draws the permissions form without error" do
       expect(rendered).to have_css("input#new_user_name_skel")
       expect(rendered).to have_css("button.remove_perm", count: 1) # depositor and public should be filtered out
       expect(rendered).to have_css("button.remove_perm[data-index='2']")
     end
   end
-
 end

data/spec/views/generic_file/edit.html.erb_spec.rb

@@ -13,15 +13,15 @@ describe 'generic_files/edit.html.erb', :no_clean do
     let(:versions_graph) { double(all: [version1]) }
     let(:content) { double('content', mimeType: 'application/pdf') }
 
-    let(:generic_file) {
+    let(:generic_file) do
       stub_model(GenericFile, id: '123',
-        depositor: 'bob',
-        resource_type: ['Book', 'Dataset'])
-    }
+                              depositor: 'bob',
+                              resource_type: ['Book', 'Dataset'])
+    end
 
-    let(:form) {
+    let(:form) do
       Sufia::Forms::GenericFileEditForm.new(generic_file)
-    }
+    end
 
     before do
       allow(generic_file).to receive(:content).and_return(content)
@@ -36,7 +36,7 @@ describe 'generic_files/edit.html.erb', :no_clean do
       Capybara::Node::Simple.new(rendered)
     end
 
-    it "should only draw one resource_type multiselect" do
+    it "onlies draw one resource_type multiselect" do
       expect(page).to have_selector("select#generic_file_resource_type", count: 1)
     end
   end

data/spec/views/generic_file/show.html.erb_spec.rb

@@ -1,29 +1,29 @@
 require 'spec_helper'
 
-describe 'generic_files/show.html.erb', :type => :view do
-  let(:depositor) {
+describe 'generic_files/show.html.erb', type: :view do
+  let(:depositor) do
     stub_model(User,
-      user_key: 'bob',
-      twitter_handle: 'bot4lib')
-  }
+               user_key: 'bob',
+               twitter_handle: 'bot4lib')
+  end
 
-  let(:content){ double('content', versions: [], mimeType: 'application/pdf') }
+  let(:content) { double('content', versions: [], mimeType: 'application/pdf') }
 
   let(:generic_file) do
     stub_model(GenericFile, id: '123',
-      depositor: depositor.user_key,
-      audit_stat: 1,
-      title: ['My Title'],
-      description: ['Lorem ipsum lorem ipsum. http://my.link.com'],
-      tag: ['bacon', 'sausage', 'eggs'],
-      rights: ['http://example.org/rights/1'],
-      based_near: ['Seattle, WA, US'],
-      contributor: ['Tweedledee', 'Tweedledum'],
-      creator: ['Doe, John', 'Doe, Jane'],
-      date_created: ['1984-01-02'],
-      language: ['Quechua'],
-      publisher: ['Random Publishing, Inc.'],
-      subject: ['Biology', 'Physiology', 'Ethnography'])
+                            depositor: depositor.user_key,
+                            audit_stat: 1,
+                            title: ['My Title'],
+                            description: ['Lorem ipsum lorem ipsum. http://my.link.com'],
+                            tag: ['bacon', 'sausage', 'eggs'],
+                            rights: ['http://example.org/rights/1'],
+                            based_near: ['Seattle, WA, US'],
+                            contributor: ['Tweedledee', 'Tweedledum'],
+                            creator: ['Doe, John', 'Doe, Jane'],
+                            date_created: ['1984-01-02'],
+                            language: ['Quechua'],
+                            publisher: ['Random Publishing, Inc.'],
+                            subject: ['Biology', 'Physiology', 'Ethnography'])
   end
 
   let(:presenter) do
@@ -248,15 +248,15 @@ describe 'generic_files/show.html.erb', :type => :view do
 
     context "when the file is not featured in any collections" do
       let(:collections) { [] }
-      it "should display the empty message" do
+      it "displays the empty message" do
         expect(rendered).to have_text(t('sufia.file.collections_list.empty'))
       end
     end
 
     context "when the file is featured in collections" do
-      let(:collections) { [stub_model(Collection, title: 'collection1', id: '456') ] }
+      let(:collections) { [stub_model(Collection, title: 'collection1', id: '456')] }
 
-      it "should display the header and titles of collections it belongs to" do
+      it "displays the header and titles of collections it belongs to" do
         expect(rendered).to have_text(t('sufia.file.collections_list.heading'))
         expect(rendered).to have_text('collection1')
       end
@@ -267,9 +267,8 @@ describe 'generic_files/show.html.erb', :type => :view do
     before do
       render
     end
-    it "should display the visibility badge" do
-      expect(rendered).to include('<span class="label label-danger" title="'+t('sufia.visibility.private_title_attr')+'">'+t('sufia.visibility.private')+'</span></a>')
+    it "displays the visibility badge" do
+      expect(rendered).to include('<span class="label label-danger" title="' + t('sufia.visibility.private_title_attr') + '">' + t('sufia.visibility.private') + '</span></a>')
     end
   end
-
 end

data/spec/views/generic_file/stats.html.erb_spec.rb

@@ -1,32 +1,32 @@
 require 'spec_helper'
 
-describe 'generic_files/stats.html.erb', :type => :view do
+describe 'generic_files/stats.html.erb', type: :view do
   describe 'usage statistics' do
-    let(:generic_file) {
+    let(:generic_file) do
       stub_model(GenericFile, id: '123',
-        title: ['file1.txt'])
-    }
+                              title: ['file1.txt'])
+    end
 
-    let(:no_stats) {
+    let(:no_stats) do
       allow_message_expectations_on_nil
       allow(FileUsage).to receive(:new)
       stub_model(FileUsage,
-        created: Date.parse('2014-01-01'),
-        total_pageviews: 0,
-        total_downloads: 0,
-        to_flot: []
-      )
-    }
-
-    let(:stats) {
+                 created: Date.parse('2014-01-01'),
+                 total_pageviews: 0,
+                 total_downloads: 0,
+                 to_flot: []
+                )
+    end
+
+    let(:stats) do
       allow(FileUsage).to receive(:new)
       stub_model(FileUsage,
-        created: Date.parse('2014-01-01'),
-        total_pageviews: 9,
-        total_downloads: 4,
-        to_flot: [[1396422000000,2],[1396508400000,3],[1396594800000,4]]
-      )
-    }
+                 created: Date.parse('2014-01-01'),
+                 total_pageviews: 9,
+                 total_downloads: 4,
+                 to_flot: [[1_396_422_000_000, 2], [1_396_508_400_000, 3], [1_396_594_800_000, 4]]
+                )
+    end
 
     before do
       assign(:generic_file, generic_file)

data/spec/views/homepage/_announcement.html.erb_spec.rb

@@ -0,0 +1,51 @@
+require 'spec_helper'
+
+describe "homepage/_announcement.html.erb" do
+  let(:groups) { [] }
+  let(:ability) { instance_double("Ability") }
+  let(:announcement) { ContentBlock.new(name: ContentBlock::ANNOUNCEMENT, value: announcement_value) }
+
+  subject { rendered }
+
+  before do
+    assign(:announcement_text, announcement)
+    allow(controller).to receive(:current_ability).and_return(ability)
+    allow(ability).to receive(:can?).with(:update, ContentBlock).and_return(can_update_content_block)
+    render
+  end
+
+  context "when there is an announcement" do
+    let(:announcement_value) { "I have an announcement!" }
+
+    context "when the user can update content" do
+      let(:can_update_content_block) { true }
+
+      it { is_expected.to have_content announcement_value }
+      it { is_expected.to have_button("Edit") }
+    end
+
+    context "when the user can't update content" do
+      let(:can_update_content_block) { false }
+
+      it { is_expected.to have_content announcement_value }
+      it { is_expected.not_to have_button("Edit") }
+    end
+  end
+
+  context "when there is no announcement" do
+    let(:announcement_value) { "" }
+
+    context "when the user can update content" do
+      let(:can_update_content_block) { true }
+
+      it { is_expected.to have_selector "#announcement" }
+      it { is_expected.to have_button("Edit") }
+    end
+
+    context "when the user can't update content" do
+      let(:can_update_content_block) { false }
+
+      it { is_expected.not_to have_selector "#announcement" }
+    end
+  end
+end

data/spec/views/homepage/_featured_works.html.erb_spec.rb

@@ -7,10 +7,8 @@ describe "homepage/_featured_works.html.erb" do
 
   context "without featured works" do
     before { render }
-    it {
-      is_expected.to have_content 'No works have been featured'
-      is_expected.not_to have_selector('form')
-    }
+    it { is_expected.to have_content 'No works have been featured' }
+    it { is_expected.not_to have_selector('form') }
   end
 
   context "with featured works" do
@@ -20,10 +18,8 @@ describe "homepage/_featured_works.html.erb" do
       render
     end
 
-    it {
-      is_expected.not_to have_content 'No works have been featured'
-      is_expected.not_to have_selector('form')
-      is_expected.to have_selector('ol#featured_works')
-    }
+    it { is_expected.not_to have_content 'No works have been featured' }
+    it { is_expected.not_to have_selector('form') }
+    it { is_expected.to have_selector('ol#featured_works') }
   end
 end

data/spec/views/homepage/_home_header.html.erb_spec.rb

@@ -12,13 +12,13 @@ describe "homepage/_home_header.html.erb" do
     end
     context "when the user can view" do
       let(:can_view_share_work) { true }
-      it "should display" do
+      it "displays" do
         expect(rendered).to have_content t("sufia.share_button")
       end
     end
     context "when the user can't view" do
       let(:can_view_share_work) { false }
-      it "should not display" do
+      it "does not display" do
         expect(rendered).not_to have_content t("sufia.share_button")
       end
     end

data/spec/views/my/facet.html.erb_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 # Note: this is a direct copy of the corresponding test in Blacklight
 # with changes for "views/my" instead of "views/catalog"
 
-describe "my/facet.html.erb", :type => :view do
+describe "my/facet.html.erb", type: :view do
   let(:display_facet) { double }
   let(:blacklight_config) { Blacklight::Configuration.new }
   before do
@@ -15,19 +15,19 @@ describe "my/facet.html.erb", :type => :view do
     assign :display_facet, display_facet
   end
 
-  it "should have the facet title" do
+  it "has the facet title" do
     allow(view).to receive(:render_facet_limit)
     render
     expect(rendered).to have_selector "h3", text: "Facet title"
   end
 
-  it "should render facet pagination" do
+  it "renders facet pagination" do
     allow(view).to receive(:render_facet_limit)
     render
     expect(rendered).to have_content "pagination"
   end
 
-  it "should render the facet limit" do
+  it "renders the facet limit" do
     expect(view).to receive(:render_facet_limit).with(display_facet, layout: false)
     render
   end

data/spec/views/single_use_links/new_download.html.erb_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+describe 'single_use_links/new_download.html.erb' do
+  let(:user) { FactoryGirl.find_or_create(:jill) }
+  let(:file) do
+    GenericFile.create do |f|
+      f.add_file(File.open(fixture_path + '/world.png'), path: 'content', original_name: 'world.png')
+      f.label = 'world.png'
+      f.apply_depositor_metadata(user)
+    end
+  end
+
+  let(:hash) { "some-dummy-sha2-hash" }
+
+  before do
+    assign :asset, file
+    assign :link, Sufia::Engine.routes.url_helpers.download_single_use_link_path(hash)
+    render
+  end
+
+  it "has the download link" do
+    expect(rendered).to have_selector "a.download-link"
+  end
+
+  it "has turbolinks disabled in the download link" do
+    expect(rendered).to have_selector "a.download-link[data-no-turbolink]"
+  end
+end

data/spec/views/single_use_links_viewer/show.html.erb_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+
+describe 'single_use_links_viewer/show.html.erb' do
+  let(:user) { FactoryGirl.find_or_create(:jill) }
+  let(:file) do
+    GenericFile.create do |f|
+      f.add_file(File.open(fixture_path + '/world.png'), path: 'content', original_name: 'world.png')
+      f.label = 'world.png'
+      f.apply_depositor_metadata(user)
+    end
+  end
+
+  let(:hash) { "some-dummy-sha2-hash" }
+
+  before do
+    assign :asset, file
+    assign :download_link, Sufia::Engine.routes.url_helpers.download_single_use_link_path(hash)
+    assign :presenter, Sufia::GenericFilePresenter.new(file)
+    render
+  end
+
+  it "contains a download link" do
+    expect(rendered).to have_selector "a[href^='/single_use_link/download/']"
+  end
+
+  it "has turbolinks disabled in the download link" do
+    expect(rendered).to have_selector "a[data-no-turbolink][href^='/single_use_link/download/']"
+  end
+end

data/spec/views/users/_follower_modal.html.erb_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe 'users/_follower_modal.html.erb', :type => :view do
+describe 'users/_follower_modal.html.erb', type: :view do
   let(:frank) { FactoryGirl.create(:user, display_name: "Frank") }
   let(:page) { Capybara::Node::Simple.new(rendered) }
 
@@ -12,18 +12,17 @@ describe 'users/_follower_modal.html.erb', :type => :view do
   end
 
   context "when followers" do
-    let(:view_user) { }
-    let(:current_user) { }
-    let(:followers) { [frank]}
+    let(:view_user) {}
+    let(:current_user) {}
+    let(:followers) { [frank] }
 
     it "draws user list" do
       expect(page).to have_link "Frank", href: "/users/#{frank.to_param}"
     end
   end
 
-
   context "when no followers" do
-    let(:followers) { []}
+    let(:followers) { [] }
     let(:view_user) { frank }
 
     context "when logged in " do
@@ -45,11 +44,11 @@ describe 'users/_follower_modal.html.erb', :type => :view do
     end
 
     context "when not logged in" do
-      let(:current_user) { }
+      let(:current_user) {}
 
       it "indicates the lack of followers for this user" do
         expect(page).to have_text "No one is following this user."
       end
     end
   end
-end
+end