sufia 4.0.0.rc1 → 4.0.0.rc2

data/spec/actors/generic_file/actor_spec.rb

@@ -7,4 +7,21 @@ describe Sufia::GenericFile::Actor do
       expect { Sufia::GenericFile::Actor.virus_check(File.new(fixture_path + '/world.png')) }.to raise_error(Sufia::VirusFoundError)
     end
   end
+
+  describe "#featured_work" do
+    let(:user) { FactoryGirl.create(:user) }
+    let(:gf) { FactoryGirl.create(:generic_file, visibility: 'open') }
+    let(:actor) { Sufia::GenericFile::Actor.new(gf, user)}
+
+    before { FeaturedWork.create(generic_file_id: gf.noid) }
+
+    after { gf.destroy }
+
+    it "should be removed if document is not public" do
+      # Switch document from public to restricted
+      attributes = {'permissions'=>{'group' =>{'public' => '1', 'registered'=>'2'}}}
+      expect { actor.update_metadata(attributes, 'restricted') }.to change { FeaturedWork.count }.by(-1)
+    end
+  end
+
 end

data/spec/controllers/batch_controller_spec.rb

@@ -29,8 +29,8 @@ describe BatchController do
     end
     it "should not be editable" do
       ability = Ability.new(@user)
-      ability.can?(:edit, @file).should be_true
-      ability.can?(:edit, @file2).should be_false
+      expect(ability.can?(:edit, @file)).to be true
+      expect(ability.can?(:edit, @file2)).to be false
     end
     it "should enqueue a batch update job" do
       params = {'generic_file' => {'read_groups_string' => '', 'read_users_string' => 'archivist1, archivist2', 'tag' => ['']}, 'id' => @batch.pid, 'controller' => 'batch', 'action' => 'update'}

data/spec/controllers/batch_edits_controller_spec.rb

@@ -14,50 +14,55 @@ describe BatchEditsController do
 
   describe "edit" do
     before do
-      @one = GenericFile.new(creator: "Fred", language: 'en')#, resource_type: 'foo')
+      @one = GenericFile.new(creator: ["Fred"], language: ['en'])
       @one.apply_depositor_metadata('mjg36')
-      @two = GenericFile.new(creator: "Wilma", publisher: 'Rand McNally', language: 'en', resource_type: 'bar')
+      @two = GenericFile.new(creator: ["Wilma"], publisher: ['Rand McNally'], language: ['en'], resource_type: ['bar'])
       @two.apply_depositor_metadata('mjg36')
       @one.save!
       @two.save!
       controller.batch = [@one.pid, @two.pid]
-      controller.should_receive(:can?).with(:edit, @one.pid).and_return(true)
-      controller.should_receive(:can?).with(:edit, @two.pid).and_return(true)
+      expect(controller).to receive(:can?).with(:edit, @one.pid).and_return(true)
+      expect(controller).to receive(:can?).with(:edit, @two.pid).and_return(true)
     end
     it "should be successful" do
       get :edit
       response.should be_successful
       assigns[:terms].should == [:creator, :contributor, :description, :tag, :rights, :publisher,
                         :date_created, :subject, :language, :identifier, :based_near, :related_url]
-      assigns[:show_file].creator.should == ["Fred", "Wilma"]
-      assigns[:show_file].publisher.should == ["Rand McNally"]
-      assigns[:show_file].language.should == ["en"]
+      expect(assigns[:show_file].creator).to eq ["Fred", "Wilma"]
+      expect(assigns[:show_file].publisher).to eq ["Rand McNally"]
+      expect(assigns[:show_file].language).to eq ["en"]
     end
   end
 
   describe "update" do
     before do
-      @one = GenericFile.new(creator: "Fred", language: 'en')
+      @one = GenericFile.new(creator: ["Fred"], language: ['en'])
       @one.apply_depositor_metadata('mjg36')
-      @two = GenericFile.new(creator: "Wilma", publisher: 'Rand McNally', language: 'en')
+      @two = GenericFile.new(creator: ["Wilma"], publisher: ['Rand McNally'], language: ['en'])
       @two.apply_depositor_metadata('mjg36')
       @one.save!
       @two.save!
       controller.batch = [@one.pid, @two.pid]
-      controller.should_receive(:can?).with(:edit, @one.pid).and_return(true)
-      controller.should_receive(:can?).with(:edit, @two.pid).and_return(true)
+      expect(controller).to receive(:can?).with(:edit, @one.pid).and_return(true)
+      expect(controller).to receive(:can?).with(:edit, @two.pid).and_return(true)
     end
+    let(:mycontroller) { "my/files" }
     it "should be successful" do
-      put :update , update_type:"delete_all"
-      response.should be_redirect
-      expect {GenericFile.find(@one.id)}.to raise_error(ActiveFedora::ObjectNotFoundError)
-      expect {GenericFile.find(@two.id)}.to raise_error(ActiveFedora::ObjectNotFoundError)
+      put :update , update_type: "delete_all"
+      expect(response).to redirect_to(Sufia::Engine.routes.url_for(controller: "dashboard", only_path: true))
+      expect { GenericFile.find(@one.id) }.to raise_error(ActiveFedora::ObjectNotFoundError)
+      expect { GenericFile.find(@two.id) }.to raise_error(ActiveFedora::ObjectNotFoundError)
+    end
+    it "should redirect to the return controller" do
+      put :update , update_type: "delete_all", return_controller: mycontroller
+      expect(response).to redirect_to(Sufia::Engine.routes.url_for(controller: mycontroller, only_path: true))
     end
     it "should update the records" do
-      put :update , update_type:"update", "generic_file"=>{"subject"=>["zzz"]}
-      response.should be_redirect
-      GenericFile.find(@one.id).subject.should == ["zzz"]
-      GenericFile.find(@two.id).subject.should == ["zzz"]
+      put :update , update_type: "update", "generic_file"=>{"subject"=>["zzz"]}
+      expect(response).to be_redirect
+      expect(GenericFile.find(@one.id).subject).to eq ["zzz"]
+      expect(GenericFile.find(@two.id).subject).to eq ["zzz"]
     end
   end
 

data/spec/controllers/catalog_controller_spec.rb

@@ -12,24 +12,35 @@ describe CatalogController do
   describe "#index" do
     before (:all) do
       @user = FactoryGirl.find_or_create(:jill)
-      GenericFile.delete_all
-      @gf1 =  GenericFile.new(title:'Test Document PDF', filename:'test.pdf', tag:'rocks', read_groups:['public'])
-      @gf1.apply_depositor_metadata('mjg36')
-      @gf1.save
+      @gf1 = GenericFile.new(title: 'Test Document PDF', filename: 'test.pdf', tag: 'rocks', read_groups: ['public']).tap do |f|
+        f.apply_depositor_metadata('mjg36')
+        f.save
+      end
 
-      @gf2 =  GenericFile.new(title:'Test 2 Document', filename:'test2.doc', tag:'clouds', contributor:'Contrib1', read_groups:['public'])
-      @gf2.apply_depositor_metadata('mjg36')
-      @gf2.save
+      @gf2 = GenericFile.new(title: 'Test 2 Document', filename: 'test2.doc', tag: 'clouds', contributor: 'Contrib1', read_groups: ['public']).tap do |f|
+        f.apply_depositor_metadata('mjg36')
+        f.full_text.content = 'full_textfull_text'
+        f.save
+      end
 
-      @editable_file = GenericFile.new.tap do |gf|
-        gf.apply_depositor_metadata(@user.user_key)
-        gf.save!
+      @editable_file = GenericFile.new.tap do |f|
+        f.apply_depositor_metadata(@user.user_key)
+        f.save!
       end
     end
 
     after (:all) do
-      @gf1.delete
-      @gf2.delete
+      GenericFile.destroy_all
+    end
+
+    describe 'full-text search' do
+      it 'finds records' do
+        get :index, q: 'full_textfull_text'
+        expect(response).to be_success
+        expect(response).to render_template('catalog/index')
+        assigns(:document_list).count.should eql(1)
+        assigns(:document_list).map(&:id).should == [@gf2.id]
+      end
     end
 
     describe "term search" do

data/spec/controllers/collections_controller_spec.rb

@@ -38,33 +38,35 @@ describe CollectionsController do
       Collection.count.should == old_count+1
     end
     it "should create a Collection with files I can access" do
-      @asset1 = GenericFile.new(title: "First of the Assets")
+      @asset1 = GenericFile.new(title: ["First of the Assets"])
       @asset1.apply_depositor_metadata(user.user_key)
       @asset1.save
-      @asset2 = GenericFile.new(title: "Second of the Assets", depositor: user.user_key)
+      @asset2 = GenericFile.new(title: ["Second of the Assets"], depositor: user.user_key)
       @asset2.apply_depositor_metadata(user.user_key)
       @asset2.save
-      @asset3 = GenericFile.new(title: "Third of the Assets", depositor:'abc')
+      @asset3 = GenericFile.new(title: ["Third of the Assets"], depositor:'abc')
       @asset3.apply_depositor_metadata('abc')
       @asset3.save
       controller.should_receive(:has_access?).and_return(true)
       old_count = Collection.count
-      post :create, collection: {title: "My own Collection ", description: "The Description\r\n\r\nand more"}, batch_document_ids:[@asset1.id, @asset2.id, @asset3.id]
+      post :create, collection: { title: "My own Collection", description: "The Description\r\n\r\nand more" },
+        batch_document_ids: [@asset1.id, @asset2.id, @asset3.id]
       Collection.count.should == old_count+1
       collection = assigns(:collection)
       collection.members.should include (@asset1)
       collection.members.should include (@asset2)
-      collection.members.should_not include (@asset3)
+      collection.members.to_a.should_not include (@asset3) # .to_a to avoid a call to any? which doesn't exist in AF::HABTM
       @asset1.destroy
       @asset2.destroy
       @asset3.destroy
     end
 
     it "should add docs to collection if batch ids provided and add the collection id to the documents int he colledction" do
-      @asset1 = GenericFile.new(title: "First of the Assets")
+      @asset1 = GenericFile.new(title: ["First of the Assets"])
       @asset1.apply_depositor_metadata(user.user_key)
       @asset1.save
-      post :create, batch_document_ids: [@asset1.id], collection: {title: "My Secong Collection ", description: "The Description\r\n\r\nand more"}
+      post :create, batch_document_ids: [@asset1.id],
+        collection: { title: "My Secong Collection ", description: "The Description\r\n\r\nand more" }
       assigns[:collection].members.should == [@asset1]
       asset_results = ActiveFedora::SolrService.instance.conn.get "select", params:{fq:["id:\"#{@asset1.id}\""],fl:['id',Solrizer.solr_name(:collection)]}
       asset_results["response"]["numFound"].should == 1
@@ -78,16 +80,16 @@ describe CollectionsController do
 
   describe "#update" do
     before do
-      @collection = Collection.new(title: "Collection Title")
+      @collection = Collection.new(title: ["Collection Title"])
       @collection.apply_depositor_metadata(user.user_key)
       @collection.save
-      @asset1 = GenericFile.new(title: "First of the Assets")
+      @asset1 = GenericFile.new(title: ["First of the Assets"])
       @asset1.apply_depositor_metadata(user.user_key)
       @asset1.save
-      @asset2 = GenericFile.new(title: "Second of the Assets", depositor: user.user_key)
+      @asset2 = GenericFile.new(title: ["Second of the Assets"], depositor: user.user_key)
       @asset2.apply_depositor_metadata(user.user_key)
       @asset2.save
-      @asset3 = GenericFile.new(title: "Third of the Assets", depositor:'abc')
+      @asset3 = GenericFile.new(title: ["Third of the Assets"], depositor:'abc')
       @asset3.apply_depositor_metadata(user.user_key)
       @asset3.save
       sign_in user
@@ -100,7 +102,7 @@ describe CollectionsController do
     end
 
     it "should set collection on members" do
-      put :update, id: @collection.id, collection: {members:"add"}, batch_document_ids:[@asset3.pid,@asset1.pid, @asset2.pid]
+      put :update, id: @collection.id, collection: {members:"add"}, batch_document_ids: [@asset3.pid, @asset1.pid, @asset2.pid]
       response.should redirect_to Hydra::Collections::Engine.routes.url_helpers.collection_path(@collection.noid)
       assigns[:collection].members.map{|m| m.pid}.sort.should == [@asset2, @asset3, @asset1].map {|m| m.pid}.sort
       asset_results = ActiveFedora::SolrService.instance.conn.get "select", params:{fq:["id:\"#{@asset2.pid}\""],fl:['id',Solrizer.solr_name(:collection)]}
@@ -109,7 +111,7 @@ describe CollectionsController do
       doc["id"].should == @asset2.id
       afterupdate = GenericFile.find(@asset2.pid)
       doc[Solrizer.solr_name(:collection)].should == afterupdate.to_solr[Solrizer.solr_name(:collection)]
-      put :update, id: @collection.id, collection: {members:"remove"}, batch_document_ids:[@asset2]
+      put :update, id: @collection.id, collection: {members:"remove"}, batch_document_ids: [@asset2]
       asset_results = ActiveFedora::SolrService.instance.conn.get "select", params:{fq:["id:\"#{@asset2.pid}\""],fl:['id',Solrizer.solr_name(:collection)]}
       asset_results["response"]["numFound"].should == 1
       doc = asset_results["response"]["docs"].first
@@ -121,16 +123,16 @@ describe CollectionsController do
 
   describe "#show" do
     before do
-      @asset1 = GenericFile.new(title: "First of the Assets")
+      @asset1 = GenericFile.new(title: ["First of the Assets"])
       @asset1.apply_depositor_metadata(user.user_key)
       @asset1.save!
-      @asset2 = GenericFile.new(title: "Second of the Assets", depositor:user.user_key)
+      @asset2 = GenericFile.new(title: ["Second of the Assets"], depositor:user.user_key)
       @asset2.apply_depositor_metadata(user.user_key)
       @asset2.save!
-      @asset3 = GenericFile.new(title: "Third of the Assets", depositor:user.user_key)
+      @asset3 = GenericFile.new(title: ["Third of the Assets"], depositor:user.user_key)
       @asset3.apply_depositor_metadata(user.user_key)
       @asset3.save!
-      @asset4 = GenericFile.new(title: "Third of the Assets", depositor:user.user_key)
+      @asset4 = GenericFile.new(title: ["Third of the Assets"], depositor:user.user_key)
       @asset4.apply_depositor_metadata(user.user_key)
       @asset4.save!
       @collection = Collection.new

data/spec/controllers/dashboard_controller_spec.rb

@@ -32,34 +32,20 @@ describe DashboardController do
 
     it "gathers the user's notifications" do
       get :index
-      expect(assigns(:notifications)).to be_true
+      expect(assigns(:notifications)).to be_truthy
     end
 
     context "with activities" do
 
-      before :all do
-        @now = DateTime.now.to_i
-      end
-
+      let(:activity) { double }
       before do
-        allow_any_instance_of(User).to receive(:events).and_return(activities)
-      end
-
-      def activities
-        [
-          { action: 'so and so edited their profile', timestamp: @now },
-          { action: 'so and so uploaded a file', timestamp: (@now - 360 ) }
-        ]
+        allow(activity).to receive(:map).and_return(activity)
+        expect_any_instance_of(User).to receive(:get_all_user_activity).and_return(activity)
       end
 
       it "gathers the user's recent activity within the default amount of time" do
         get :index
-        expect(assigns(:activity)).to eq(activities.reverse)
-      end
-
-      it "gathers the user's recent activity within a given timestamp" do
-        get :index, { since: (@now - 60 ) }
-        expect(assigns(:activity)).to eq([activities.first])
+        expect(assigns(:activity)).to eq activity
       end
 
       it "returns results in JSON" do

data/spec/controllers/generic_files_controller_spec.rb

@@ -17,7 +17,10 @@ describe GenericFilesController do
     end
 
     after do
-      GenericFile.unstub(:new)
+      begin
+        GenericFile.unstub(:new)
+      rescue RSpec::Mocks::MockExpectationError => e
+      end
       Batch.find("sample:batch_id").delete rescue
       @mock.delete unless @mock.inner_object.class == ActiveFedora::UnsavedDigitalObject
     end
@@ -63,7 +66,7 @@ describe GenericFilesController do
       # This is confirming that the correct file was attached
       saved_file.label.should == 'world.png'
       saved_file.content.checksum.should == 'f794b23c0c6fe1083d0ca8b58261a078cd968967'
-      saved_file.content.dsChecksumValid.should be_true
+      expect(saved_file.content.dsChecksumValid).to be true
 
       # Confirming that date_uploaded and date_modified were set
       saved_file.date_uploaded.should == date_today
@@ -71,10 +74,8 @@ describe GenericFilesController do
     end
 
     it "should record what user created the first version of content" do
-      #GenericFile.any_instance.stub(:to_solr).and_return({})
       file = fixture_file_upload('/world.png','image/png')
-      xhr :post, :create, files: [file], Filename: "The world", terms_of_service: "1"
-
+      xhr :post, :create, files: [file], Filename: "The world", batch_id: "sample:batch_id", permission: {"group"=>{"public"=>"read"} }, terms_of_service: "1"
       saved_file = GenericFile.find('test:123')
       version = saved_file.content.latest_version
       version.versionID.should == "content.0"
@@ -86,9 +87,10 @@ describe GenericFilesController do
       file = fixture_file_upload('/world.png','image/png')
       controller.stub(:add_posted_blob_to_asset)
       xhr :post, :create, files: [file], Filename: "The world", batch_id: "sample:batch_id", permission: {"group"=>{"public"=>"read"} }, terms_of_service: "1"
+      GenericFile.unstub(:new)
       lambda {Batch.find("sample:batch_id")}.should raise_error(ActiveFedora::ObjectNotFoundError) # The controller shouldn't actually save the Batch, but it should write the batch id to the files.
-      b = Batch.create(pid: "sample:batch_id")
-      b.generic_files.first.pid.should == "test:123"
+      batch = Batch.create(pid: "sample:batch_id")
+      batch.generic_files.first.pid.should == "test:123"
     end
     it "should set the depositor id" do
       file = fixture_file_upload('/world.png','image/png')
@@ -123,15 +125,18 @@ describe GenericFilesController do
   describe "#create with browse-everything" do
     before do
       GenericFile.delete_all
-      @json_from_browse_everything = {"0"=>{"url"=>"https://dl.dropbox.com/fake/filepicker-demo.txt.txt", "expires"=>"2014-03-31T20:37:36.214Z", "file_name"=>"filepicker-demo.txt.txt"}, "1"=>{"url"=>"https://dl.dropbox.com/fake/Getting%20Started.pdf", "expires"=>"2014-03-31T20:37:36.731Z", "file_name"=>"Getting+Started.pdf"}}
+      @json_from_browse_everything = {"0"=>{"url"=>"https://dl.dropbox.com/fake/blah-blah.filepicker-demo.txt.txt", "expires"=>"2014-03-31T20:37:36.214Z", "file_name"=>"filepicker-demo.txt.txt"}, "1"=>{"url"=>"https://dl.dropbox.com/fake/blah-blah.Getting%20Started.pdf", "expires"=>"2014-03-31T20:37:36.731Z", "file_name"=>"Getting+Started.pdf"}}
     end
     it "should ingest files from provide URLs" do
       ImportUrlJob.should_receive(:new).twice {"ImportJob"}
       Sufia.queue.should_receive(:push).with("ImportJob").twice
-      lambda { post :create, selected_files: @json_from_browse_everything, batch_id: "sample:batch_id"}.should change(GenericFile, :count).by(2)
+      expect { post :create, selected_files: @json_from_browse_everything, batch_id: "sample:batch_id" }.to change(GenericFile, :count).by(2)
       created_files = GenericFile.all
-      ["https://dl.dropbox.com/fake/Getting%20Started.pdf", "https://dl.dropbox.com/fake/filepicker-demo.txt.txt"].each do |url|
-        created_files.map {|f| f.import_url}.should include(url)
+      ["https://dl.dropbox.com/fake/blah-blah.Getting%20Started.pdf", "https://dl.dropbox.com/fake/blah-blah.filepicker-demo.txt.txt"].each do |url|
+        expect(created_files.map {|f| f.import_url}).to include(url)
+      end
+      ["filepicker-demo.txt.txt","Getting+Started.pdf"].each do |filename|
+        expect(created_files.map {|f| f.label}).to include(filename)
       end
     end
   end
@@ -167,8 +172,8 @@ describe GenericFilesController do
         lambda { post :create, local_file: ["world.png", "image.jpg"], batch_id: "xw42n7934"}.should change(GenericFile, :count).by(2)
         response.should redirect_to Sufia::Engine.routes.url_helpers.batch_edit_path('xw42n7934')
         # These files should have been moved out of the upload directory
-        File.exist?("#{@mock_upload_directory}/image.jpg").should be_false
-        File.exist?("#{@mock_upload_directory}/world.png").should be_false
+        expect(File).not_to exist("#{@mock_upload_directory}/image.jpg")
+        expect(File).not_to exist("#{@mock_upload_directory}/world.png")
         # And into the storage directory
         files = GenericFile.find(Solrizer.solr_name("is_part_of",:symbol) => 'info:fedora/sufia:xw42n7934')
         files.first.label.should == 'world.png'
@@ -179,7 +184,7 @@ describe GenericFilesController do
         lambda { post :create, local_file: ["world.png"], batch_id: "xw42n7934"}.should change(GenericFile, :count).by(1)
         response.should redirect_to mock_url
         # These files should have been moved out of the upload directory
-        File.exist?("#{@mock_upload_directory}/world.png").should be_false
+        expect(File).not_to exist("#{@mock_upload_directory}/world.png")
         # And into the storage directory
         files = GenericFile.find(Solrizer.solr_name("is_part_of",:symbol) => 'info:fedora/sufia:xw42n7934')
         files.first.label.should == 'world.png'
@@ -188,9 +193,9 @@ describe GenericFilesController do
         lambda { post :create, local_file: ["world.png", "import"], batch_id: "xw42n7934"}.should change(GenericFile, :count).by(4)
         response.should redirect_to Sufia::Engine.routes.url_helpers.batch_edit_path('xw42n7934')
         # These files should have been moved out of the upload directory
-        File.exist?("#{@mock_upload_directory}/import/files/icons.zip").should be_false
-        File.exist?("#{@mock_upload_directory}/import/metadata/dublin_core_rdf_descMetadata.nt").should be_false
-        File.exist?("#{@mock_upload_directory}/world.png").should be_false
+        expect(File).not_to exist("#{@mock_upload_directory}/import/files/icons.zip")
+        expect(File).not_to exist("#{@mock_upload_directory}/import/metadata/dublin_core_rdf_descMetadata.nt")
+        expect(File).not_to exist("#{@mock_upload_directory}/world.png")
         # And into the storage directory
         files = GenericFile.find(Solrizer.solr_name("is_part_of",:symbol) => 'info:fedora/sufia:xw42n7934')
         files.first.label.should == 'world.png'
@@ -224,7 +229,7 @@ describe GenericFilesController do
       response.should be_success
       lambda { JSON.parse(response.body) }.should_not raise_error
       audit_results = JSON.parse(response.body).collect { |result| result["pass"] }
-      audit_results.reduce(true) { |sum, value| sum && value }.should be_true
+      expect(audit_results.reduce(true) { |sum, value| sum && value }).to be_truthy
     end
   end
 
@@ -250,6 +255,17 @@ describe GenericFilesController do
       Sufia.queue.should_receive(:push).with(s1).once
       delete :destroy, id: @generic_file.pid
     end
+
+    context "when the file is featured" do
+      before do
+        FeaturedWork.create(generic_file_id: @generic_file.pid)
+      end
+      it "should make the file not featured" do
+        expect(FeaturedWorkList.new.featured_works.map(&:generic_file_id)).to include(@generic_file.pid)
+        delete :destroy, id: @generic_file.pid
+        expect(FeaturedWorkList.new.featured_works.map(&:generic_file_id)).to_not include(@generic_file.pid)
+      end
+    end
   end
 
   describe 'stats' do
@@ -538,8 +554,7 @@ describe GenericFilesController do
         end
         it "should display failing audits" do
           sign_in @archivist
-          @ds = @file.datastreams.first
-          AuditJob.new(@file.pid, @ds[0], @ds[1].versionID).run
+          AuditJob.new(@file.pid, "RELS-EXT", @file.rels_ext.versionID).run
           get :show, id: "test5"
           assigns[:notify_number].should == 1
           @archivist.mailbox.inbox[0].messages[0].subject.should == "Failing Audit Run"

data/spec/controllers/homepage_controller_spec.rb

@@ -6,10 +6,10 @@ describe HomepageController do
   describe "#index" do
     before :all do
       GenericFile.delete_all
-      @gf1 = GenericFile.new(title:'Test Document PDF', filename:'test.pdf', tag:'rocks', read_groups:['public'])
+      @gf1 = GenericFile.new(title:['Test Document PDF'], filename:['test.pdf'], tag:['rocks'], read_groups:['public'])
       @gf1.apply_depositor_metadata('mjg36')
       @gf1.save
-      @gf2 = GenericFile.new(title:'Test 2 Document', filename:'test2.doc', tag:'clouds', contributor:'Contrib1', read_groups:['public'])
+      @gf2 = GenericFile.new(title:['Test 2 Document'], filename:['test2.doc'], tag:['clouds'], contributor:['Contrib1'], read_groups:['public'])
       @gf2.apply_depositor_metadata('mjg36')
       @gf2.save
     end
@@ -42,6 +42,29 @@ describe HomepageController do
       end
     end
 
+    context "with a document not created this second" do
+      before do
+        gf3 = GenericFile.new(title:['Test 3 Document'], read_groups:['public'])
+        gf3.apply_depositor_metadata('mjg36')
+        # stubbing to_solr so we know we have something that didn't create in the current second
+        old_to_solr = gf3.method(:to_solr)
+        allow(gf3).to receive(:to_solr) do
+          old_to_solr.call.merge(
+            Solrizer.solr_name('system_create', :stored_sortable, type: :date) => 1.day.ago.iso8601
+          )
+        end
+        gf3.save
+      end
+
+      it "should set recent documents in the right order" do
+        get :index
+        expect(response).to be_success
+        expect(assigns(:recent_documents).length).to be <= 4
+        create_times = assigns(:recent_documents).map{|d| d['system_create_dtsi']}
+        expect(create_times).to eq create_times.sort.reverse
+      end
+    end
+
     context "with featured works" do
       before do
         FeaturedWork.create!(generic_file_id: @gf1.id)