sufia 3.4.0 → 3.5.0

data/spec/models/generic_file/web_form_spec.rb

@@ -13,9 +13,10 @@ describe GenericFile do
   end
   describe "terms_for_display" do
     it "should return a list" do
-      subject.terms_for_display.should == [:part_of, :resource_type, :title, :creator, :contributor, :description, 
-        :tag, :rights, :publisher, :date_created, :date_uploaded, :date_modified, :subject, :language, :identifier, 
-        :based_near, :related_url]
+      expect(subject.terms_for_display).to eq([:resource_type, :title, 
+        :creator, :contributor, :description, :tag, :rights, :publisher,
+        :date_created, :date_uploaded, :date_modified, :subject, :language,
+        :identifier, :based_near, :related_url])
     end
   end
 

data/spec/models/generic_file_spec.rb

@@ -4,6 +4,7 @@ describe GenericFile do
   before do
     subject.apply_depositor_metadata('jcoyne')
     @file = subject #TODO remove this line someday (use subject instead)
+
   end
 
   describe '#to_s' do
@@ -1035,4 +1036,30 @@ describe GenericFile do
       end
     end
   end
+  describe "file content validation" do
+    before do
+      GenericFile.any_instance.stub(:create_derivatives)
+    end
+    context "when file contains a virus" do
+      let(:f) { File.new(fixture_path + '/small_file.txt') }
+      after(:each) do
+        subject.destroy if subject.persisted?
+      end
+      it "populates the errors hash during validation" do
+        allow(Sufia::GenericFile::Actions).to receive(:virus_check).and_raise(Sufia::VirusFoundError, "A virus was found in #{f.path}: EL CRAPO VIRUS")
+        subject.add_file(f, 'content', 'small_file.txt')
+        subject.save
+        subject.should_not be_persisted
+        subject.errors.messages.should == { content: ["A virus was found in #{f.path}: EL CRAPO VIRUS"] }
+      end
+      it "does not save a new version of a GenericFile" do
+        subject.add_file(f, 'content', 'small_file.txt')
+        subject.save
+        allow(Sufia::GenericFile::Actions).to receive(:virus_check).and_raise(Sufia::VirusFoundError)
+        subject.add_file(File.new(fixture_path + '/sufia_generic_stub.txt') , 'content', 'sufia_generic_stub.txt')
+        subject.save
+        subject.reload.content.content.should == "small\n"
+      end
+    end
+  end
 end

data/spec/routing/route_spec.rb

@@ -139,6 +139,21 @@ describe 'Routes' do
     end
   end
 
+  describe "Notifications" do
+    it "should have index" do
+      expect( get: '/notifications').to route_to(controller: 'mailbox', action: 'index')
+      expect(notifications_path).to eq '/notifications'
+    end
+    it "should allow deleting" do
+      expect( delete: '/notifications/123').to route_to(controller: 'mailbox', action: 'destroy', id: '123')
+      expect(notification_path(123)).to eq '/notifications/123'
+    end
+    it "should allow deleting all of them" do
+      expect( delete: '/notifications/delete_all').to route_to(controller: 'mailbox', action: 'delete_all')
+      expect(delete_all_notifications_path).to eq '/notifications/delete_all'
+    end
+  end
+
   describe "Contact Form" do
     it "should route to new" do
       { get: '/contact' }.should route_to(controller: 'contact_form', action: 'new')
@@ -149,26 +164,6 @@ describe 'Routes' do
     end
   end
 
-  describe "Queues" do
-  # TODO: figure out how to test mounted routes in Rails 3.2
-  #   before do
-  #     @routes = Resque::Server.routes
-  #     warden_mock = mock('warden')
-  #     warden_mock.stub(:user).returns(FactoryGirl.find_or_create(:archivist))
-  #     ActionDispatch::Request.any_instance.stub(:env).returns({'warden': warden_mock})
-  #   end
-
-    it "should route to queues if group is set properly" #do
-  #     User.any_instance.stub(:groups).returns(['umg/up.dlt.scholarsphere-admin'])
-  #     { get: '/admin/queues' }.should route_to('resque/server#index')
-  #   end
-
-    it "should *not* route to queues if group is not set properly" #do
-  #     User.any_instance.stub(:groups).returns(['something'])
-  #     { get: '/admin/queues' }.should_not route_to('resque/server#index')
-  #   end
-  end
-
   describe "Static Pages" do
     it "should route to about" do
       { get: '/about' }.should route_to(controller: 'static', action: 'about')

data/spec/spec_helper.rb

@@ -36,6 +36,20 @@ if $in_travis
   end
 end
 
+if defined?(ClamAV)
+  ClamAV.instance.loaddb
+else
+  class ClamAV
+    include Singleton
+    def scanfile(f)
+      0
+    end
+    def loaddb
+      nil
+    end
+  end
+end
+
 Resque.inline = Rails.env.test?
 
 FactoryGirl.definition_file_paths = [File.expand_path("../factories", __FILE__)]
@@ -65,10 +79,9 @@ RSpec.configure do |config|
   config.include EngineRoutes, :type => :controller
 end
 
-
 module FactoryGirl
   def self.find_or_create(handle, by=:email)
     tmpl = FactoryGirl.build(handle)
     tmpl.class.send("find_by_#{by}".to_sym, tmpl.send(by)) || FactoryGirl.create(handle)
   end
-end
+end

data/sufia-models/app/models/datastreams/fits_datastream.rb

@@ -70,7 +70,11 @@ class FitsDatastream < ActiveFedora::OmDatastream
         t.offset(:path=>"offset")
       }
       t.video {
-        # Not yet implemented in FITS
+        t.width(:path=>"imageWidth")
+        t.height(:path=>"imageHeight")
+        t.duration(:path=>"duration")
+        t.sample_rate(:path=>"sampleRate")
+        t.frame_rate(:path=>"frameRate")
       }
     }
     t.format_label(:proxy=>[:identification, :identity, :format_label])
@@ -98,7 +102,9 @@ class FitsDatastream < ActiveFedora::OmDatastream
     t.byte_order(:proxy=>[:metadata, :image, :byte_order])
     t.compression(:proxy=>[:metadata, :image, :compression])
     t.width(:proxy=>[:metadata, :image, :width])
+    t.video_width( :proxy=>[:metadata, :video, :width])
     t.height(:proxy=>[:metadata, :image, :height])
+    t.video_height(:proxy=>[:metadata, :video, :height])
     t.color_space(:proxy=>[:metadata, :image, :color_space])
     t.profile_name(:proxy=>[:metadata, :image, :profile_name])
     t.profile_version(:proxy=>[:metadata, :image, :profile_version])
@@ -115,11 +121,14 @@ class FitsDatastream < ActiveFedora::OmDatastream
     t.markup_basis(:proxy=>[:metadata, :text, :markup_basis])
     t.markup_language(:proxy=>[:metadata, :text, :markup_language])
     t.duration(:proxy=>[:metadata, :audio, :duration])
+    t.video_duration(:proxy=>[:metadata, :video, :duration])
     t.bit_depth(:proxy=>[:metadata, :audio, :bit_depth])
     t.sample_rate(:proxy=>[:metadata, :audio, :sample_rate])
+    t.video_sample_rate(:proxy=>[:metadata, :video, :sample_rate])
     t.channels(:proxy=>[:metadata, :audio, :channels])
     t.data_format(:proxy=>[:metadata, :audio, :data_format])
     t.offset(:proxy=>[:metadata, :audio, :offset])
+    t.frame_rate(:proxy=>[:metadata, :video, :frame_rate])
   end
 
   def self.xml_template

data/sufia-models/lib/generators/sufia/models/install_generator.rb

@@ -55,7 +55,7 @@ This generator makes the following changes to your application:
   def inject_sufia_user_behavior
     file_path = "app/models/#{model_name.underscore}.rb"
     if File.exists?(file_path)
-      inject_into_class file_path, model_name.classify do
+      inject_into_file file_path, after: /include Hydra\:\:User.*$/ do
         "# Connects this user object to Sufia behaviors. " +
           "\n include Sufia::User\n"
       end

data/sufia-models/lib/sufia/models/generic_file.rb

@@ -1,3 +1,4 @@
+require 'sufia/virus_found_error'
 module Sufia
   module GenericFile
     extend ActiveSupport::Concern
@@ -9,6 +10,7 @@ module Sufia
     autoload :Trophies, 'sufia/models/generic_file/trophies'
     autoload :Metadata, 'sufia/models/generic_file/metadata'
     autoload :Versions, 'sufia/models/generic_file/versions'
+    autoload :VirusCheck, 'sufia/models/generic_file/virus_check'
     include Sufia::ModelMethods
     include Sufia::Noid
     include Sufia::GenericFile::MimeTypes
@@ -22,6 +24,7 @@ module Sufia
     include Sufia::GenericFile::Trophies
     include Sufia::GenericFile::Metadata
     include Sufia::GenericFile::Versions
+    include Sufia::GenericFile::VirusCheck
 
     included do
       belongs_to :batch, :property => :is_part_of

data/sufia-models/lib/sufia/models/generic_file/actions.rb

@@ -2,7 +2,6 @@ module Sufia::GenericFile
   # Actions are decoupled from controller logic so that they may be called from a controller or a background job.
   module Actions
     def self.create_metadata(generic_file, user, batch_id)
-
       generic_file.apply_depositor_metadata(user)
       generic_file.date_uploaded = Date.today
       generic_file.date_modified = Date.today
@@ -16,7 +15,7 @@ module Sufia::GenericFile
       yield(generic_file) if block_given?
       generic_file.save!
     end
-    
+
     def self.create_content(generic_file, file, file_name, dsid, user)
       generic_file.add_file(file, dsid, file_name)
 
@@ -40,15 +39,13 @@ module Sufia::GenericFile
     end
 
     def self.virus_check(file)
-      if defined? ClamAV
-        stat = ClamAV.instance.scanfile(file.path)
-        logger.warn "Virus checking did not pass for #{file.inspect} status = #{stat}" unless stat == 0
-        stat
-      else
-        logger.warn "Virus checking disabled for #{file.inspect}"
-        0
+      path = file.is_a?(String) ? file : file.path
+      unless defined?(ClamAV)
+        logger.warn "Virus checking disabled, #{path} not checked"
+        return
       end
-    end 
-
+      scan_result = ClamAV.instance.scanfile(path)
+      raise Sufia::VirusFoundError.new("A virus was found in #{path}: #{scan_result}") unless scan_result == 0
+    end
   end
 end

data/sufia-models/lib/sufia/models/generic_file/characterization.rb

@@ -13,21 +13,36 @@ module Sufia
                                         :file_language, :word_count, :character_count,
                                         :paragraph_count, :line_count, :table_count,
                                         :graphics_count, :byte_order, :compression,
-                                        :width, :height, :color_space, :profile_name,
+                                        :color_space, :profile_name,
                                         :profile_version, :orientation, :color_map,
                                         :image_producer, :capture_device,
                                         :scanning_software, :exif_version,
                                         :gps_timestamp, :latitude, :longitude,
                                         :character_set, :markup_basis,
-                                        :markup_language, :duration, :bit_depth,
-                                        :sample_rate, :channels, :data_format, :offset, datastream: :characterization, multiple: true
+                                        :markup_language, :bit_depth,
+                                        :channels, :data_format, :offset, :frame_rate, datastream: :characterization, multiple: true
 
       end
 
+      def width
+        characterization.width.blank? ? characterization.video_width : characterization.width
+      end
+
+      def height
+        characterization.height.blank? ? characterization.video_height : characterization.height
+      end
+
+      def duration
+        characterization.duration.blank? ? characterization.video_duration : characterization.duration
+      end
+
+      def sample_rate
+        characterization.sample_rate.blank? ? characterization.video_sample_rate : characterization.sample_rate
+      end
+
       def characterize_if_changed
         content_changed = self.content.changed?
         yield
-        #logger.debug "DOING CHARACTERIZE ON #{self.pid}"
         Sufia.queue.push(CharacterizeJob.new(self.pid)) if content_changed
       end
 

data/sufia-models/lib/sufia/models/generic_file/virus_check.rb

@@ -0,0 +1,33 @@
+module Sufia
+  module GenericFile
+    module VirusCheck
+      extend ActiveSupport::Concern
+
+      included do
+        validate :detect_viruses
+      end
+
+      # Default behavior is to raise a validation error and halt the save if a virus is found
+      def detect_viruses
+        return unless content.changed?
+        path = if content.content.respond_to?(:path)
+                 content.content.path
+               else
+                 Tempfile.open('') do |t|
+                   t.binmode
+                   t.write(content.content)
+                   t.close
+                   t.path
+                 end
+               end
+        Sufia::GenericFile::Actions.virus_check(path)
+        true
+      rescue Sufia::VirusFoundError => virus
+        logger.warn(virus.message)
+        errors.add(:content, virus.message)
+        false
+      end
+
+    end
+  end
+end

data/sufia-models/lib/sufia/models/generic_file/web_form.rb

@@ -22,14 +22,13 @@ module Sufia
       end
 
       def terms_for_editing
-        terms_for_display -
-         [:part_of, :date_modified, :date_uploaded, :format] #, :resource_type]
+        terms_for_display - [:date_modified, :date_uploaded, :format]
       end
 
       def terms_for_display
         # 'type' is the RDF.type assertion, which is not present by default, but may be
         # provided in some RDF schemas
-        self.descMetadata.class.fields
+        self.descMetadata.class.fields - [:part_of]
       end
 
       def to_jq_upload

data/sufia-models/lib/sufia/models/jobs/import_url_job.rb

@@ -9,40 +9,38 @@ class ImportUrlJob < ActiveFedoraPidBasedJob
   end
 
   def run
-    f = Tempfile.new(self.pid)
-    f.binmode
-
-    # download file from url
-    uri = URI(generic_file.import_url)
-    http = Net::HTTP.new(uri.host, uri.port) 
-    http.use_ssl = uri.scheme == "https"  # enable SSL/TLS
-    http.verify_mode = OpenSSL::SSL::VERIFY_NONE
-
-    http.start do  
-      http.request_get(uri.request_uri) do |resp|
-        resp.read_body do |segment|
-          f.write(segment)
+    user = User.find_by_user_key(generic_file.depositor)
+
+    Tempfile.open(self.pid) do |f|
+      f.binmode
+
+      # download file from url
+      uri = URI(generic_file.import_url)
+      http = Net::HTTP.new(uri.host, uri.port)
+      http.use_ssl = uri.scheme == "https"  # enable SSL/TLS
+      http.verify_mode = OpenSSL::SSL::VERIFY_NONE
+
+      http.start do
+        http.request_get(uri.request_uri) do |resp|
+          resp.read_body do |segment|
+            f.write(segment)
+          end
         end
       end
-    end 
-    job_user = User.batchuser()
-    user = User.find_by_user_key(generic_file.depositor)
-    # check for virus
-    if Sufia::GenericFile::Actions.virus_check(f) != 0
-      message = "The file (#{File.basename(uri.path)}) was unable to be imported because it contained a virus."
-      job_user.send_message(user, message, 'File Import Error') 
-      return
+
+      f.rewind
+      # attach downloaded file to generic file stubbed out
+      Sufia::GenericFile::Actions.create_content(generic_file, f, File.basename(uri.path), 'content', user)
+      Sufia.queue.push(ContentDepositEventJob.new(generic_file.pid, generic_file.depositor))
+      # add message to user for downloaded file
+      message = "The file (#{File.basename(uri.path)}) was successfully imported."
+      job_user.send_message(user, message, 'File Import')
     end
+  rescue => error
+    job_user.send_message(user, error.message, 'File Import Error')
+  end
 
-    f.rewind
-    # attach downloaded file to generic file stubbed out
-    Sufia::GenericFile::Actions.create_content(generic_file, f, File.basename(uri.path), 'content', user)
-    # add message to user for downloaded file
-    message = "The file (#{File.basename(uri.path)}) was successfully imported." 
-    job_user.send_message(user, message, 'File Import') 
- 
-  ensure
-    f.close
-    f.unlink
+  def job_user
+    User.batchuser
   end
 end

data/sufia-models/lib/sufia/models/version.rb

@@ -1,5 +1,5 @@
 module Sufia
   module Models
-    VERSION = "3.4.0"
+    VERSION = "3.5.0"
   end
 end

data/sufia.gemspec

@@ -7,7 +7,7 @@ Gem::Specification.new do |gem|
   gem.email         = ["justin.coyne@yourmediashelf.com"]
   gem.description   = %q{Sufia is a Rails engine for creating a self-deposit institutional repository}
   gem.summary       = %q{Sufia was extracted from ScholarSphere developed by Penn State University}
-  gem.homepage      = ""
+  gem.homepage      = "http://github.com/projecthydra/sufia"
 
   gem.files         = `git ls-files`.split($\)
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }

data/tasks/sufia-dev.rake

@@ -26,7 +26,7 @@ end
 desc "Run specs"
 RSpec::Core::RakeTask.new(:rspec) do |t|
   t.pattern = '../**/*_spec.rb'
-  t.rspec_opts = ["--colour -I ../", '--backtrace']
+  t.rspec_opts = ["--colour -I ../", '--backtrace', '--profile 20']
 end
 
 desc "Load fixtures"
@@ -48,6 +48,7 @@ task :generate do
     puts "Updating gemfile"
 
     `echo "gem 'sufia', :path=>'../../../sufia'
+gem 'clamav'
 gem 'capybara'
 gem 'factory_girl_rails'
 gem 'kaminari', github: 'harai/kaminari', branch: 'route_prefix_prototype'" >> spec/internal/Gemfile`

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sufia
 version: !ruby/object:Gem::Version
-  version: 3.4.0
+  version: 3.5.0
 platform: ruby
 authors:
 - Justin Coyne
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-06 00:00:00.000000000 Z
+date: 2013-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sufia-models
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.4.0
+        version: 3.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.4.0
+        version: 3.5.0
 - !ruby/object:Gem::Dependency
   name: blacklight_advanced_search
   requirement: !ruby/object:Gem::Requirement
@@ -183,7 +183,6 @@ files:
 - app/assets/images/missing_original.png
 - app/assets/images/missing_thumb.png
 - app/assets/images/progressbar.gif
-- app/assets/images/rails.png
 - app/assets/images/site_images/bg_body.png
 - app/assets/images/site_images/bg_breadcrumbs.png
 - app/assets/images/site_images/bg_button1.png
@@ -204,8 +203,6 @@ files:
 - app/assets/images/site_images/icon_arrow_down.png
 - app/assets/images/site_images/icons_sprite.png
 - app/assets/images/site_images/logo_psuss_footer.png
-- app/assets/images/site_images/temp/guitar.jpg
-- app/assets/images/splashscreen.png
 - app/assets/images/ui-anim_basic_16x16.gif
 - app/assets/images/ui-bg_diagonals-thick_18_b81900_40x40.png
 - app/assets/images/ui-bg_diagonals-thick_20_666666_40x40.png
@@ -222,7 +219,6 @@ files:
 - app/assets/images/ui-icons_2e4f81_256x240.png
 - app/assets/images/ui-icons_ffd27a_256x240.png
 - app/assets/images/ui-icons_ffffff_256x240.png
-- app/assets/images/video-still.png
 - app/assets/javascripts/contact_form.js
 - app/assets/javascripts/sufia.js
 - app/assets/javascripts/sufia/batch_select_all.js
@@ -483,6 +479,7 @@ files:
 - lib/sufia/role_mapper.rb
 - lib/sufia/single_use_error.rb
 - lib/sufia/version.rb
+- lib/sufia/virus_found_error.rb
 - lib/tasks/fixtures.rake
 - public/.gitkeep
 - public/favicon.ico
@@ -532,6 +529,7 @@ files:
 - spec/fixtures/pdf_fits.xml
 - spec/fixtures/piano_note.wav
 - spec/fixtures/png_fits.xml
+- spec/fixtures/sample_mpeg4.mp4
 - spec/fixtures/small_file.txt
 - spec/fixtures/sufia/.gitignore
 - spec/fixtures/sufia/bg_header.jpg
@@ -665,6 +663,7 @@ files:
 - sufia-models/lib/sufia/models/generic_file/thumbnail.rb
 - sufia-models/lib/sufia/models/generic_file/trophies.rb
 - sufia-models/lib/sufia/models/generic_file/versions.rb
+- sufia-models/lib/sufia/models/generic_file/virus_check.rb
 - sufia-models/lib/sufia/models/generic_file/web_form.rb
 - sufia-models/lib/sufia/models/id_service.rb
 - sufia-models/lib/sufia/models/jobs/active_fedora_pid_based_job.rb
@@ -721,7 +720,7 @@ files:
 - vendor/assets/javascripts/swfobject.js
 - vendor/assets/javascripts/video.js
 - vendor/plugins/.gitkeep
-homepage: ''
+homepage: http://github.com/projecthydra/sufia
 licenses:
 - APACHE2
 metadata: {}
@@ -741,7 +740,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: Sufia was extracted from ScholarSphere developed by Penn State University
@@ -789,6 +788,7 @@ test_files:
 - spec/fixtures/pdf_fits.xml
 - spec/fixtures/piano_note.wav
 - spec/fixtures/png_fits.xml
+- spec/fixtures/sample_mpeg4.mp4
 - spec/fixtures/small_file.txt
 - spec/fixtures/sufia/.gitignore
 - spec/fixtures/sufia/bg_header.jpg