sufia 2.0.1 → 3.0.0

data/spec/factories/users.rb

@@ -1,17 +1,3 @@
-# Copyright © 2012 The Pennsylvania State University
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
 FactoryGirl.define do
   factory :user, :class => User do |u|
     email 'jilluser@example.com'
@@ -23,6 +9,11 @@ FactoryGirl.define do
     password 'password'
   end
 
+  factory :user_with_fixtures, :class => User do |u|
+    email 'archivist2@example.com'
+    password 'password'
+  end
+
   factory :curator, :class => User do |u|
     email 'curator1@example.com'
     password 'password'

data/spec/features/browse_dashboard_files.rb

@@ -0,0 +1,21 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe "Browse Dashboard files" do
+
+  before do
+    sign_in :user_with_fixtures
+  end
+
+  it "should show me some files (from the fixtures)" do
+    click_link "dashboard"
+    click_link "more Keywords"
+    click_link "keyf"
+    page.should have_content "Test mp3"
+  end
+
+  it "should allow me to edit files (from the fixtures)" do
+    click_link "dashboard"
+    click_link "Edit File"
+    page.should have_content "Edit Test mp3"
+  end
+end

data/spec/features/browse_files.rb

@@ -0,0 +1,31 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe "Browse files" do
+
+  describe "when not logged in" do
+    it "should let us browse some of the fixtures" do
+      visit '/'
+      click_link "more Keywords"
+      click_link "test"
+      # TODO this used to be 1 - 4 of 4, but now we get 5. WTF?
+      # It looks to me like sufia:sufia1, sufia:test3,  sufia:test4,  sufia:test5, sufia:test6 all should match
+      page.should have_content "1 - 5 of 5"
+      click_link "Test Document PDF"
+      page.should have_content "Download"
+      page.should_not have_content "Edit"
+    end
+
+  end
+
+  describe "when logged in" do
+    before do
+      sign_in :user
+    end
+    it "should let us browse some of the fixtures and see the edit link"do
+      click_link "more Keywords"
+      click_link "test"
+      click_link "Test Document PDF"
+      page.should_not have_content "Edit"
+    end
+  end
+end

data/spec/features/contact_form.rb

@@ -0,0 +1,99 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe "Sending an email via the contact form" do
+
+  before do
+    sign_in :user_with_fixtures
+  end
+
+  it "should send mail" do
+    ContactForm.any_instance.stub(:deliver).and_return(true)
+    visit '/'
+    click_link "Contact"
+    page.should have_content "Contact Form"
+    fill_in "contact_form_name", with: "Test McPherson" 
+    fill_in "contact_form_email", with: "archivist1@example.com"
+    fill_in "contact_form_message", with: "I am contacting you regarding ScholarSphere."
+    fill_in "contact_form_subject", with: "My Subject is Cool"
+    select "Depositing content", from: "contact_form_category"
+    click_button "Send"
+    page.should have_content "Thank you"
+    # this step allows the delivery to go back to normal
+    ContactForm.any_instance.unstub(:deliver)
+  end
+
+  it "should give an error when I don't provide a contact type" do
+    visit '/'
+    click_link "Contact"
+    page.should have_content "Contact Form"
+    fill_in "contact_form_name", with: "Test McPherson" 
+    fill_in "contact_form_email", with: "archivist1@example.com"
+    fill_in "contact_form_message", with: "I am contacting you regarding ScholarSphere."
+    fill_in "contact_form_subject", with: "My Subject is Cool"
+    click_button "Send"
+    page.should have_content "Sorry, this message was not sent successfully"
+  end
+
+  it "should give an error when I don't provide a valid email" do
+    visit '/'
+    click_link "Contact"
+    page.should have_content "Contact Form"
+    fill_in "contact_form_name", with: "Test McPherson" 
+    fill_in "contact_form_email", with: "archivist1"
+    fill_in "contact_form_message", with: "I am contacting you regarding ScholarSphere."
+    fill_in "contact_form_subject", with: "My Subject is Cool"
+    select "Depositing content", from: "contact_form_category"
+    click_button "Send"
+    page.should have_content "Sorry, this message was not sent successfully"
+  end
+
+  it "should give an error when I don't provide a name" do
+    visit '/'
+    click_link "Contact"
+    page.should have_content "Contact Form"
+    fill_in "contact_form_email", with: "archivist1@example.com"
+    fill_in "contact_form_message", with: "I am contacting you regarding ScholarSphere."
+    fill_in "contact_form_subject", with: "My Subject is Cool"
+    select "Depositing content", from: "contact_form_category"
+    click_button "Send"
+    page.should have_content "Sorry, this message was not delivered"
+  end
+
+  it "should give an error when I don't provide a subject" do
+    visit '/'
+    click_link "Contact"
+    page.should have_content "Contact Form"
+    fill_in "contact_form_name", with: "Test McPherson" 
+    fill_in "contact_form_email", with: "archivist1@example.com"
+    fill_in "contact_form_message", with: "I am contacting you regarding ScholarSphere."
+    select "Depositing content", from: "contact_form_category"
+    click_button "Send"
+    page.should have_content "Sorry, this message was not sent successfully"
+  end
+
+  it "should give an error when I don't provide a message" do
+    visit '/'
+    click_link "Contact"
+    page.should have_content "Contact Form"
+    fill_in "contact_form_name", with: "Test McPherson" 
+    fill_in "contact_form_email", with: "archivist1@example.com"
+    fill_in "contact_form_subject", with: "My Subject is Cool"
+    select "Depositing content", from: "contact_form_category"
+    click_button "Send"
+    page.should have_content "Sorry, this message was not sent successfully"
+  end
+
+  it "should give an error when I provide an invalid captcha" do
+    visit '/'
+    click_link "Contact"
+    page.should have_content "Contact Form"
+    fill_in "contact_form_contact_method", with: "My name is" 
+    fill_in "contact_form_name", with: "Test McPherson" 
+    fill_in "contact_form_email", with: "archivist1@example.com"
+    fill_in "contact_form_subject", with: "My Subject is Cool"
+    fill_in "contact_form_message", with: "I am contacting you regarding ScholarSphere."
+    select "Depositing content", from: "contact_form_category"
+    click_button "Send"
+    page.should have_content "Sorry, this message was not delivered"
+  end
+end

data/spec/features/display_dashboard.rb

@@ -0,0 +1,46 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe "Display Dashboard files" do
+
+  before do
+    sign_in :user
+  end
+
+  it "should display the dashboard and have search" do
+    click_link 'dashboard'
+    fill_in "dashboard_search", with: "dash search"
+    click_button "dashboard_submit"
+    page.should have_content "Dashboard"
+    page.should have_content "You searched for: dash search"
+    find_field("search-field-header").value.should be_nil
+  end
+
+  it "should display the dashboard and want to upload files" do
+    click_link 'dashboard'
+    click_link 'Upload File(s)'
+    page.should have_content "Upload"
+  end
+
+  it "should display the dashboard and want to upload files" do
+    click_link 'dashboard'
+    click_link 'Upload File(s)'
+    page.should have_content "Upload"
+  end
+
+  it "should display the dashboard and want to search the whole system" do
+    fill_in "search-field-header", with: "system search"
+    click_button "search-submit-header"
+    page.should have_content "You searched for: system search"
+    page.should_not have_content "Dashboard"
+    find_field("search-field-header").value.should match(/system search/)
+  end
+
+  # @culerity
+  # Scenario: I have files on my dashboard I should see icons 
+  #   #Given I load sufia fixtures
+  #   And I am logged in as "archivist1@example.com"
+  #   And I follow "dashboard"
+  #   Then I should see "Test Document Text"
+  #   When I follow the link within "a[href='/files/test3'].itemtrash"
+  #   Then I should see "The file has been deleted"
+end

data/spec/features/ingest_upload_files.rb

@@ -0,0 +1,24 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe "Uploading files via web form" do
+
+  before do
+    sign_in :user
+  end
+
+  it "should have an ingest screen" do
+    click_link "upload"
+    page.should have_content "Select files"
+    page.should have_content "Start upload"
+    page.should have_content "Cancel upload"
+    page.should have_xpath '//input[@type="file"]'
+  end
+
+  it "should require checking the terms of service" do
+    click_link "upload"
+    attach_file("files[]", "spec/fixtures/image.jp2")
+    attach_file("files[]", "spec/fixtures/jp2_fits.xml")
+    click_button 'Start upload'
+    page.should have_content "You must accept the terms of service!"
+  end
+end

data/spec/features/users_spec.rb

@@ -0,0 +1,25 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe "User Profile" do
+
+  before do
+    # FactoryGirl.create(:user)
+    # FactoryGirl.create(:archivist)
+    # FactoryGirl.create(:curator)
+    sign_in :curator
+  end
+
+  it "should be displayed" do
+    click_link "curator1@example.com"
+    page.should have_content "Edit Your Profile"
+  end
+
+  it "should be editable" do
+    click_link "curator1@example.com"
+    click_link "Edit Your Profile"
+    fill_in 'user_twitter_handle', with: 'curatorOfData'
+    click_button 'Save Profile'
+    page.should have_content "Your profile has been updated"
+    page.should have_content "curatorOfData"
+  end
+end

data/spec/helpers/generic_file_helper_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe GenericFileHelper do
   it "draws add button" do
@@ -12,8 +12,15 @@ describe GenericFileHelper do
   end
 
   it "draws help_icon" do
-    helper.help_icon(:tag).should == 
-      "<a href=\"#\" data-content=\"Words or phrases you select to describe what the file is about. These are used to search for content. &lt;em&gt;This is a required field&lt;/em&gt;.\" data-original-title=\"Keyword\" id=\"generic_file_tag_help\" rel=\"popover\"><i class=\"icon-question-sign icon-large\"></i></a>"
+    str = String.new(helper.help_icon(:tag))
+    doc = Nokogiri::HTML(str)
+    a = doc.xpath('//a').first
+    
+    a.attr('data-content').should == "Words or phrases you select to describe what the file is about. These are used to search for content. <em>This is a required field</em>."
+    a.attr('data-original-title').should == "Keyword"
+    a.attr('id').should == "generic_file_tag_help"
+    i = a.children.first
+    i.attr('class').should == 'icon-question-sign icon-large'
   end
 
 end

data/spec/helpers/sufia_helper_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe SufiaHelper do
   describe "link_to_profile" do

data/spec/lib/sufia/id_service_spec.rb

@@ -1,18 +1,4 @@
-# Copyright © 2012 The Pennsylvania State University
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-require 'spec_helper'
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Sufia::IdService do
   describe "mint" do

data/spec/models/audit_job_spec.rb

@@ -1,18 +1,4 @@
-# Copyright © 2012 The Pennsylvania State University
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-require 'spec_helper'
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe AuditJob do
   before do

data/spec/models/batch_spec.rb

@@ -1,18 +1,4 @@
-# Copyright © 2012 The Pennsylvania State University
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-require 'spec_helper'
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe Batch do
   before(:all) do

data/spec/models/batch_update_job_spec.rb

@@ -1,19 +1,6 @@
 # encoding: UTF-8
-# Copyright © 2012 The Pennsylvania State University
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
 
-require 'spec_helper'
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe BatchUpdateJob do
   before do
@@ -47,10 +34,10 @@ describe BatchUpdateJob do
     it "should log a content update event" do
       User.any_instance.should_receive(:can?).with(:edit, @file).and_return(true)
       User.any_instance.should_receive(:can?).with(:edit, @file2).and_return(true)
-      s1 = stub('one')
+      s1 = double('one')
       ContentUpdateEventJob.should_receive(:new).with(@file.pid, @user.user_key).and_return(s1)
       Sufia.queue.should_receive(:push).with(s1).once
-      s2 = stub('two')
+      s2 = double('two')
       ContentUpdateEventJob.should_receive(:new).with(@file2.pid, @user.user_key).and_return(s2)
       Sufia.queue.should_receive(:push).with(s2).once
       params = {'generic_file' => {'read_groups_string' => '', 'read_users_string' => 'archivist1, archivist2', 'tag' => ['']}, 'id' => @batch.pid, 'controller' => 'batch', 'action' => 'update'}.with_indifferent_access

data/spec/models/characterize_job_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe CharacterizeJob do
   before do
@@ -20,7 +20,7 @@ describe CharacterizeJob do
       @generic_file.save!
     end
     it "should create a transcode job" do
-      job = stub("stub video job")
+      job = double("stub video job")
       if $in_travis
         @generic_file.stub(:video?).and_return(true)
         GenericFile.should_receive(:find).with(@generic_file.id).and_return(@generic_file)
@@ -42,7 +42,7 @@ describe CharacterizeJob do
       @generic_file.save!
     end
     it "should create a transcode job" do
-      job = stub("stub audio job")
+      job = double("stub audio job")
       if $in_travis
         @generic_file.stub(:audio?).and_return(true)
         GenericFile.should_receive(:find).with(@generic_file.id).and_return(@generic_file)
@@ -61,7 +61,7 @@ describe CharacterizeJob do
     end
     it "should create a transcode job. (we'd like ogg too)" do
       # TODO just copy the 'content' datastream to the mp3 datastream if it's an mp3, and then transcode to ogg
-      job = stub("stub audio job")
+      job = double("stub audio job")
       if $in_travis
         @generic_file.stub(:audio?).and_return(true)
         GenericFile.should_receive(:find).with(@generic_file.id).and_return(@generic_file)